| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
refactored it so that there is a clear object responsible for dragging
and the controller now controls it all.
There is some common code between TabOverviewDragController and
DraggedTabController. I will try and share some code between these two
later.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
header, the public key, the signature, and the zip.
Review URL: http://codereview.chromium.org/118490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
just don't get the sad tab page.
If the renderer dies before it sends a ViewHostMsg_RenderViewReady message,
we never get the TAB_CONTENTS_CONNECTED, which in turn means that
TAB_CONTENTS_DISCONNECTED doesn't fire. If TAB_CONTENTS_DISCONNECTED
doesn't fire, we never initialize sad_tab_ in tab_contents_view_gtk.cc and
crash the browser process.
I found this crash on the crash server:
http://crash/reportdetail?
reportid=fb3a7bc60c67eb1e&product=Chrome_Linux&version=3.0.183.1&date=&signa
ture=TabContentsViewGtk::Invalidate()-534CC7
BUG=13715
Review URL: http://codereview.chromium.org/119395
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I haven't been able to reproduce the crash, but I'm pretty sure
this is the problem.
I think this involves closing the browser while we're in the
middle of a cross-process or interstitial page tab transition.
TEST=none
BUG=http://crbug.com/11493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Press ctrl+q and chrome should quit
Patch by Jacob Mandelson <jacob@mandelson.org> via
http://codereview.chromium.org/119393
Review URL: http://codereview.chromium.org/118522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118506
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
work because the friend declarations depended on the exact name of the tests,
which I changed when I marked them disabled.
Review URL: http://codereview.chromium.org/119426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13733
Review URL: http://codereview.chromium.org/118507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
"svn: Inconsistent line ending style"...
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
clicking a file link.
BUG=13552
TEST=Clicking a file link in the download manager should open the file.
Review URL: http://codereview.chromium.org/119398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118502
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
previous checkin will be picked up.
TBR=aa
Review URL: http://codereview.chromium.org/118503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=11823
TEST=--load-extension test/data/extensions/samples/bookmarks
TEST=unit_tests.exe --gtest_filter=ExtensionAPIClientTest.*
Review URL: http://codereview.chromium.org/118209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We optimize mouse-mouve event handling by ignoring two mouse-move events in a row
which works in most cases except that when we animate tab-closing on windows we
send a duplicate mouse-move event on purpose to highlight the button. Unfortunately
our optimization kicks in.
Fixed by reseting the flag to optimize this before sending the extra mouse-move.
BUG=8838
Review URL: http://codereview.chromium.org/118454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13494
Review URL: http://codereview.chromium.org/118494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=4655
Review URL: http://codereview.chromium.org/119415
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/119411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that removed the following strings:
IDS_OPTIONS_CLEAR_DATA_INFO
IDS_OPTIONS_CLEAR_DATA_GROUP_NAME
IDS_OPTIONS_IMPORT_DATA_INFO
IDS_OPTIONS_IMPORT_DATA_GROUP_NAME
These strings are in use internally,
by the personalization module.
Review URL: http://codereview.chromium.org/119402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Eliminates browser_views.lib as a distinct target due to circular
dependencies.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118492
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Open the task manager. Close it. Open again and close. Browser should not crash.
http://crbug.com/13361
Review URL: http://codereview.chromium.org/119299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We'd like to run EV cert verification in cert verifier's context, but
EV cert verification is expensive and it is only relevant to main frame.
So, pass the LOAD_VERIFY_EV_CERT flag when the resource is main frame
to request EV cert verification.
BUG=10911
TEST=none
Review URL: http://codereview.chromium.org/118373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13215
TBR=jeremy
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Make the download progress pie chart fill up CW even in the RTL UI.
2. Make the filename be at the right end instead of being in the middle of the download status in the RTL UI.
BUG=13215,13216 (http://crbug.com/13215, http://crbug.com/13216)
TEST=1. Launch Chrome with --lang=he or --lang=ar.
2. Download a large file (like chrome mini-installer or Firefox) and go to the download tab (pressing Ctrl-J would work)
3. The progress pie-chart should be filled up clockwise.
4. The filename should be to the right of the download status ('5 kB of 7.2 MB - 4 mins left' in Hebrew or Arabic) instead of being put in the middle of the status string.
Review URL: http://codereview.chromium.org/119318
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/118421
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
transitional//en'><html><head><META HTTP-EQUIV='Refresh' CONTENT='0;URL=http://www.orkut.com'></head><body>You are being redirected <a href='http://www.orkut.com'>http://www.orkut.com</a>.</body></html>
Review URL: http://codereview.chromium.org/118418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on the page after closing the find bar. This happens because
gtk_entry_set_text triggers a "changed" event in gtk. This
doesn't happen in on the windows side.
BUG=13344
Review URL: http://codereview.chromium.org/118457
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* split up extension_shelf into a model and a view (easier to port)
* ExtensionHost now owns ExtensionView rather than vice versa
* dragging reorders extensions on the shelf
* moved ExtensionView* into browser_tests (currently not working)
BUG=12123
TEST=browser_tests.exe --gtest_filter=ExtensionShelfModel* (browser_tests.exe is currently broken)
Review URL: http://codereview.chromium.org/119290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contexts rather than frames.
Also change the way we call through to javascript, to avoid a v8::Compile.
This is so we don't skew the histogram stats on our script cache.
BUG=?
TEST=none
Review URL: http://codereview.chromium.org/119369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I've kept the old style in there now too since we have --disable-omnibox2 for a short while so QA can compare if necessary.
http://crbug.com/13647
TEST=suggestion completions should be bolded in the omnibox2 dropdown. the first "Search Google For" item should now read "<query> - Search Google" (or whatever your default search engine is).
Review URL: http://codereview.chromium.org/119341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enhance SimpleMenuModel::Delegate interface to support additional options required by the above.
Make MenuHostWindow process WM_MENUCOMMAND and WM_MENUSELECT - the first so we can determine which index was selected, the second so we can track highlight changes within a menu.
Convert Tab's context menu back to the windows native menu. This will make my life easier when I upgrade chrome_menu.cc to the new API if only the bookmarks menus/context menus are using it.
BUG=none
TEST=page, app menus again, context menu for tabs. open a bunch of tabs, open this page: http://bengoodger.dreamhosters.com/software/chrome/cxmenutest.html, close that tab then right click on the menu quickly. should not crash!
Review URL: http://codereview.chromium.org/118426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This version is from Google and has already stripped all non related code except for the MAPS_DEBUG flag. I manually removed all the debugging code related to MAPS_DEBUG.
TEST=New tab page, history, downloads and all other pages using HTML content should still work.
BUG=None
Review URL: http://codereview.chromium.org/119384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you enter a search term and delete it, the Find box UI flag gets set as inactive and the box stops moving when the browser resizes. This fixes that.
BUG=13570
TEST=Open Find, press 'e', press Backspace, resize the window. The Find box should move.
Review URL: http://codereview.chromium.org/119383
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Split chrome_dll_version.rc generation into its own target.
* perf_tests.exe: add missing modules:
browser/safe_browsing/database_perftest.cc,
browser/safe_browsing/filter_false_positive_perftest.cc,
common/json_value_serializer_perftest.cc.
* interactive_ui_tests.exe:
add dependency on installer_util_strings;
add dependency on new chrome_dll_version target;
add missing browser/debugger/devtools_sanity_unittest.cc module;
add missing resources.
* Cleanup: alphabetize sources in test_support_common.
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/119373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119376
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119379
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119378
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of SkBitmaps.
Add command line flag "--thumbnail-store" to enable
using the ThumbnailStore facility instead of the current
ThumbnailDatabase.
Original review: http://codereview.chromium.org/118409
Patch by Meelap Shah
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nib file changes:
- Set the min browser window size to 400x250.
BUG=http://crbug.com/11844
BUG=http://crbug.com/13015
BUG=http://crbug.com/13017
TEST=Verify that windows have a minimum size. Verify that (with a
single monitor) windows cannot be resized into the dock area, unless
their lower right corner started in the dock area. Verify that
windows can be resized across multiple monitors.
Review URL: http://codereview.chromium.org/118439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not set so you could ask for a printout of page 0-5 in a 5 page document.
This caused an empty page to be printed before the others.
BUG=none
TEST=Try to enter illegal page number in the page number dialog.
Review URL: http://codereview.chromium.org/118446
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of providing a separate check to validate bookmarks while loading, we could assume invalid bookmarks are invalid, hence we don't break the loading sequence. We keep looping since another bookmark might be valid.
If the JSON syntax is broken, it will exit gracefully because the parser can't parse the file. This patch is only good for people who are editing their bookmarks directly and missing a item in the bookmark node.
BUG=10709 (http://crbug.com/10709)
TEST=Deleted any line from the Bookmarks file within the bookmark children node. Loaded up Chromium and it loaded the error free bookmarks.
Review URL: http://codereview.chromium.org/118351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17960 0039d316-1c4b-4281-b951-d872f2087c98
|