summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Make interstitial_page.cc compile on Posix.jhawkins@chromium.org2009-02-187-29/+32
| | | | | | Review URL: http://codereview.chromium.org/21467 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9971 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up toolbar layout code. I originally did this while looking into ↵pkasting@chromium.org2009-02-181-74/+50
| | | | | | | | bookmark bubble positioning issues. Review URL: http://codereview.chromium.org/20467 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9969 0039d316-1c4b-4281-b951-d872f2087c98
* Add the referrer value to the new NavigationEntry.paulg@google.com2009-02-181-0/+1
| | | | | | Review URL: http://codereview.chromium.org/21464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9968 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes drag of images from new tab page. We need to pass in the mimesky@google.com2009-02-181-4/+6
| | | | | | | | | | | | | type, otherwise webkit isn't able to get the mime type and we try and drag an image with a bogus name. BUG=none TEST=drag a thumbnail from the new tab to explorer. You should end up with a file named foo.png. Review URL: http://codereview.chromium.org/21435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9967 0039d316-1c4b-4281-b951-d872f2087c98
* The DOM Automation controller object uses the RenderView instance as the ↵ananta@chromium.org2009-02-184-18/+83
| | | | | | | | | | | | | | | | | | | | message sender, i.e. to send replies to javascript requests issued by the browser. The DOM automation controller object is bound to the frame in the WindowObjectcleared code path.The current implementation maintains the message sender object as a static pointer, which causes a crash if the RenderView instance goes out of scope. This can be reproduced with a page which causes a popup window to show up and close. If we attempt to use the Dom Automation controller instance bound to the original Renderview, which is still valid, we crash. The fix is to maintain the message sender as a member variable. The lifetime of the Dom Automation controller instance depends on the RenderView lifetime anyway as it is a member variable. This mimics the other CppBindings like the external host bindings, etc. Added an automation test to test this case. I verified that the test crashes without this fix. This fixes bug http://code.google.com/p/chromium/issues/detail?id=3941 Bug=3941 Review URL: http://codereview.chromium.org/21441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9963 0039d316-1c4b-4281-b951-d872f2087c98
* Trivially port more unittests in chrome/phajdan.jr@chromium.org2009-02-181-4/+0
| | | | | | | | | | | | Added to the build: common/resource_dispatcher_unittest.cc renderer/net/render_dns_master_unittest.cc renderer/render_view_unittest.cc renderer/render_widget_unittest.cc Review URL: http://codereview.chromium.org/21461 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9961 0039d316-1c4b-4281-b951-d872f2087c98
* Dictionary-related Linux porting.phajdan.jr@chromium.org2009-02-185-21/+18
| | | | | | | | | | - build convert_dict tool - compile & pass hunspell tests - misc gcc cleanups Review URL: http://codereview.chromium.org/20462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9960 0039d316-1c4b-4281-b951-d872f2087c98
* Build break. In revision 9958, I hadn't intented to commit this change.maruel@chromium.org2009-02-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/20466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9959 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the amount of included header files. Vast change like in "Oh God! ↵maruel@chromium.org2009-02-1853-225/+273
| | | | | | | | This revision changes half of the source files!". Review URL: http://codereview.chromium.org/20378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9958 0039d316-1c4b-4281-b951-d872f2087c98
* Add locale_settings.grd to the build. This generatestc@google.com2009-02-1891-351/+296
| | | | | | | | | | | | a locale_settings.h file that we use on all platforms. However, the rc generation isn't correct yet, so for now, use the existing locale_settings_*.rc files. Also go ahead and generate the en-US locale pak on linux. Review URL: http://codereview.chromium.org/20447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9956 0039d316-1c4b-4281-b951-d872f2087c98
* fix linux build, add stub functions to browser window gtktc@google.com2009-02-182-0/+11
| | | | | | | Review URL: http://codereview.chromium.org/21463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9955 0039d316-1c4b-4281-b951-d872f2087c98
* Stub more Mac functions to fix another build breakpkasting@chromium.org2009-02-182-0/+11
| | | | | | | TBR=pinkerton Review URL: http://codereview.chromium.org/20463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9954 0039d316-1c4b-4281-b951-d872f2087c98
* Solved 2 bugs which caused Chrome to maximize itself whendouble clicking, ↵idanan@chromium.org2009-02-1811-42/+72
| | | | | | | | either on the new tab button, on the closetab button or on a single tab.BUG=2827BUG=3787The problem comes from the Windows event sequence upon adouble-click (simplified here):1 - hit-test2 - mouse-down4 - mouse-up/click5 - hit-test6 - mouse down7 - mouse up/double-clickThe 1st hit-test is always performed correctly, returningclient for tabs and non-client for the tab-strip (background).The 2nd hit test is not performed correctly to avoid crashesin Chromebot from events being processed while tabs are animating.Since we have no record of these crashes, Ben prefers we keepthis special-case, even though we are responding incorrectlyto the windows hit-test. So, when the tabs are animating wereturn a HTNOWHERE hit which the caller translates into anHTCAPTION hit. This even though a tab-control (new-tab/close-tab)may have been hit.The problem is that having returned HTCAPTION to Windows defaultmessage handling, we get a NON-CLIENT double-click event insteadof a standard one.To keep the behavior of the second hit-test AND prevent theChrome window from maximizing, this change simply declaresthe non-client double-click as handled when the tabs areanimating.Another trick we pulled in the hit-test is to return HTCAPTIONwhen a single tab is present. This allows the entire window to be dragged but causes the context menu to be wrong and the windowto maximize when double clicking on the single tab.The solution here is to correct return a client hit for a singletab and, upon handling a client single-click, delegate to thenon-client single-click default handler. Review URL: http://codereview.chromium.org/21268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9953 0039d316-1c4b-4281-b951-d872f2087c98
* Preliminary fullscreen mode support.pkasting@chromium.org2009-02-1811-39/+174
| | | | | | | | | There is no UI for this (yet), just F11 to toggle in and out. BUG=534 Review URL: http://codereview.chromium.org/20423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9950 0039d316-1c4b-4281-b951-d872f2087c98
* bump for 165 dev cyclemal@chromium.org2009-02-181-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9949 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9944.yurys@google.com2009-02-1822-928/+2
| | | | | | | This change broke ui, interactive and Vista Perf tests. I felt like reverting. Review URL: http://codereview.chromium.org/24020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9947 0039d316-1c4b-4281-b951-d872f2087c98
* Create communication channel between developer tools UI implemented in JS ↵yurys@google.com2009-02-1822-2/+928
| | | | | | | | | | | | | and residing in a process different from inspected page renderer process. There is no direct IPC channel between the two processes so all messages are routed through browser process. On the side of inspected page there is ToolsAgent existing in all renderers so that we can start inspecting the page at any moment by talking to this object. On the side of developer tools renderer there is ToolsClient which is created only for RenderView that host developer tools UI. This change is a slightly modified version of http://codereview.chromium.org/20221/show Review URL: http://codereview.chromium.org/20430 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9944 0039d316-1c4b-4281-b951-d872f2087c98
* Add IPC messages to send data between inspected page and developer tools.yurys@google.com2009-02-181-0/+30
| | | | | | | | | | | | Although there is no sematic changes I'd like to commit render_messages_internal.h changes in its own CL since trying to combine this change with other(even unrelated) changes lead to mysterious test failures on linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/2878 http://build.chromium.org/buildbot/try-server/builders/linux/builds/2877 http://build.chromium.org/buildbot/try-server/builders/linux/builds/2876 Review URL: http://codereview.chromium.org/21451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9943 0039d316-1c4b-4281-b951-d872f2087c98
* Translation update.mal@chromium.org2009-02-1898-321/+533
| | | | | | | | | | | Update all .xtb files with current translations from the translation console. BUG= None TBR= tony TEST= Find 49 friends who each speak a different language ...nevermind. Review URL: http://codereview.chromium.org/20451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9940 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build. I ranjam@chromium.org2009-02-181-0/+2
| | | | | | | | | tools\xcodebodge\xcodebodge.py -p chrome\chrome.xcodeproj -t browser add_source chrome\common\child_process_info.cc and now the trybot builds. Review URL: http://codereview.chromium.org/21444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9937 0039d316-1c4b-4281-b951-d872f2087c98
* Fix release build breakjam@chromium.org2009-02-181-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9936 0039d316-1c4b-4281-b951-d872f2087c98
* Take out common functionality from PluginProcessHost and move it to ↵jam@chromium.org2009-02-1814-256/+364
| | | | | | | | ChildProcessHost. Review URL: http://codereview.chromium.org/21443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9935 0039d316-1c4b-4281-b951-d872f2087c98
* Get something in chrome/plugin/ compiling to make Scons happy.thestig@chromium.org2009-02-182-2/+5
| | | | | | Review URL: http://codereview.chromium.org/20449 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9934 0039d316-1c4b-4281-b951-d872f2087c98
* Don't pass out pointers that belong to other processes.tommi@chromium.org2009-02-181-7/+13
| | | | | | Review URL: http://codereview.chromium.org/20385 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9931 0039d316-1c4b-4281-b951-d872f2087c98
* Display the current URL and connect the entry widget to OpenURLFromTab().erg@google.com2009-02-183-8/+40
| | | | | | | | | This currently crashes when trying to load a new URL. (It looks like some housekeeping isn't being done in RenderWidgetHostViewGtk, the underlying widget isn't attached to any GTK window...) Review URL: http://codereview.chromium.org/21438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9930 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use relative path for net/url_request/url_request_test_job.thestig@chromium.org2009-02-181-2/+2
| | | | | | Review URL: http://codereview.chromium.org/20443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9927 0039d316-1c4b-4281-b951-d872f2087c98
* Follow-up rename to my previous commit.evan@chromium.org2009-02-182-1/+1
| | | | | | | | | process_singleton.cc can just become process_singleton_win.cc since it's all Windows-specific. Review URL: http://codereview.chromium.org/20442 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9926 0039d316-1c4b-4281-b951-d872f2087c98
* HtmlDialogs had focus problems.jcampan@chromium.org2009-02-1818-16/+30
| | | | | | | | | | | | | | | | | | They would not be focused when shown and tab traversal was not working. This was caused by several issues: - HWNDView was not focusing its HWND when focused through the View::RequestFocus() method (it would rely on the default view behavior which is to focus the root view HWND), so it would not be focused by default. - DOMView (parent of HtmlDialogView) was not focusable so would not get the focus when pressing tab. - DOMView was not eating tab keys events (by returning false in View::CanProcessTabKeyEvents()), so the render view would not get the tab key press messages (for focus traversal in the render view). Note: most of the file changes in this CL are just the consequence of changing the constness of the WindowDelegate::GetInitiallyFocusedView method. BUG=6859 TEST=Open a web page, from the page menu, select the "Create application shortcut..." menu. In the dialog, press the TAB key, focus should alternate between the different fields Review URL: http://codereview.chromium.org/21439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9925 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple functions missed in r9921 during conflict resolution.thestig@chromium.org2009-02-181-0/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9924 0039d316-1c4b-4281-b951-d872f2087c98
* Rename MessageWindow to ProcessSingleton in anticipation of more refactoring.evan@chromium.org2009-02-186-40/+43
| | | | | | | Review URL: http://codereview.chromium.org/20437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9923 0039d316-1c4b-4281-b951-d872f2087c98
* step 1 on getting strings in linux: create a locale_settings.grdtc@google.com2009-02-183-3/+285
| | | | | | | | | | | | | | | | | | based on locale_settings_en-US.rc. We don't use this anywhere yet, just putting things in place. - Fix preprocessor defines in grit vcproj files (needs to be defined everywhere) and update grit_localized_resources.rules to pass the preprocessor define to grit. - Add generated .h files to chrome_strings.vcproj so people can ctrl+alt+a open them. - Update GRIT so it knows how to substitute [GRITLANGCODE] in strings to the locale value. Review URL: http://codereview.chromium.org/20440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9922 0039d316-1c4b-4281-b951-d872f2087c98
* Add more scaffolding to make shared linking work.thestig@chromium.org2009-02-182-5/+63
| | | | | | Review URL: http://codereview.chromium.org/21429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9921 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes PrefServiceUITest file deletion code in favor of DieFileDie,sky@google.com2009-02-181-10/+1
| | | | | | | | | | | which I suspect is causing purify ui test flakeyness. BUG=6557 TEST=none Review URL: http://codereview.chromium.org/20439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9920 0039d316-1c4b-4281-b951-d872f2087c98
* Make gears_integration.cc compile on Posix. Change the GearsCreateShortcut ↵jhawkins@chromium.org2009-02-179-22/+32
| | | | | | | | callback to use GearsShortCutData2. Review URL: http://codereview.chromium.org/20412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9918 0039d316-1c4b-4281-b951-d872f2087c98
* Check the file handle for NULL before using it to write. Under somebrettw@chromium.org2009-02-171-20/+15
| | | | | | | | | | | | | circumstances this might be NULL if we opened the file after initialization and it failed. In this case, we should just silently fail rather than throwing an invalid parameter exception. I'm not 100% sure this will fix the bug below, I did this by inspection. BUG=7566 Review URL: http://codereview.chromium.org/21425 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9917 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher in GetDefaultSearchEngineName() in first run bubble.cpu@google.com2009-02-173-12/+17
| | | | | | | | | | | | - It seems that BrowserList::GetLastActive() is returning null, probably it takes longer now for the browser to become active. - But rather than guessing the profile, get it from the guts of the location bar. - crasher is ranked #34 by Laforge BUG=6211 Review URL: http://codereview.chromium.org/20381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9916 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak of the renderer thread objects in single process mode.brettw@chromium.org2009-02-171-3/+8
| | | | | | | BUG=6538 Review URL: http://codereview.chromium.org/21432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9915 0039d316-1c4b-4281-b951-d872f2087c98
* Add importer/firefox_profile_lock_posix.cc to the build.thestig@chromium.org2009-02-171-0/+1
| | | | | | Review URL: http://codereview.chromium.org/21427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9914 0039d316-1c4b-4281-b951-d872f2087c98
* Persist info about subresources on pages for DNS pre-resolutionjar@chromium.org2009-02-1712-15/+398
| | | | | | | | | | | | | | | | | | | | | The DNS pre-resolution system already "learns" what domains are commonly needed when rendering sub-resources of a page at a given domain. This patch saves (some of) the information learned into a persistent pref, and restores it on startup. For now, I put in a wimpy pruning of the list each time I save, so that the list will not grow endlessly from session to session. I probably need a better pruning algorithm, such as one that prunes after a given amount of time, rather than only during shutdown. For now, this should get a lot of nice results, and provide slightly larger than needed lists to users that have long lived sessions, which is similar to the current performance, where I didn't persist any info, and only pruned (actually discarded) all learned info at shutdown. r=mbelshe Review URL: http://codereview.chromium.org/21374 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9912 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up theme images and chrome resource data on linux.tc@google.com2009-02-174-78/+87
| | | | | | | | | | Go ahead and convert our toolbar buttons to using the theme data pack file. Review URL: http://codereview.chromium.org/20433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9911 0039d316-1c4b-4281-b951-d872f2087c98
* Update copyright dates to reflect the fact that it's 2009.jhaas@chromium.org2009-02-172-2/+2
| | | | | | Review URL: http://codereview.chromium.org/20432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9910 0039d316-1c4b-4281-b951-d872f2087c98
* Do two TODOs related to --load-extension:aa@chromium.org2009-02-1716-22/+46
| | | | | | | | | | | * Stop watching extension dirs for user script changes. * Stop supporting unversioned extension dirs. Also a few minor related cleanups. Review URL: http://codereview.chromium.org/20390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9909 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContentsDelegate from scaffolding. Remove a large chunk of ifdef'd ↵pinkerton@chromium.org2009-02-175-113/+27
| | | | | | | | code from browser.cc to go along with it as well as enabling more functionality. Review URL: http://codereview.chromium.org/21424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9908 0039d316-1c4b-4281-b951-d872f2087c98
* Changes new tab page to not make a link for recently closedsky@google.com2009-02-171-3/+4
| | | | | | | | | | | | windows. It was rather bogus that we were doing this before as there is nothing for the window to link to. BUG=5836 TEST=see bug Review URL: http://codereview.chromium.org/21426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9907 0039d316-1c4b-4281-b951-d872f2087c98
* Create chrome_resources.scons, chrome_strings.scons and theme_dll.sconstc@google.com2009-02-177-222/+89
| | | | | | | | | | | | | | | | which mirror the vcproj files used by Windows. Add the linux specific code to generate .pak files that we use for resources on linux. This doesn't include the necessary changes to build the theme default.dll on windows, but the windows scons build is already really broken so punting for now. Review URL: http://codereview.chromium.org/21371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9906 0039d316-1c4b-4281-b951-d872f2087c98
* Significantly rework coordinate handling for the Cocoa views. Fixes tons of ↵avi@chromium.org2009-02-179-55/+81
| | | | | | | | redraw and scrolling issues. Review URL: http://codereview.chromium.org/20435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9905 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard focus mostly works on Linux.evan@chromium.org2009-02-173-7/+28
| | | | | | | | | | | I added more TODOs than I removed, but they're now for more subtle cases: - the web page didn't handle a keystroke and our accelerators should; - you tab off the end of the list of tabbable things on the page. Review URL: http://codereview.chromium.org/21428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9903 0039d316-1c4b-4281-b951-d872f2087c98
* Default to using the current tab when opening a url until we hook up more ↵pinkerton@chromium.org2009-02-171-1/+1
| | | | | | | | advanced gestures. Returning to create a new tab is just wrong. Review URL: http://codereview.chromium.org/20434 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9902 0039d316-1c4b-4281-b951-d872f2087c98
* Change the encoding for tapuz.co.il to UTF-8 from windows-1255 and update ↵jungshik@google.com2009-02-171-2/+2
| | | | | | | | | | | | | the version to 20. BUG=7271 TEST=Start Chrome in Hebrew Windows or with cmdline switch "--country=IL --lang=he" and set the default search engine to tapuz (it's in Hebrew) and type a keyword in the omnibox and select search with 'tapuz'. Search result should come up with multiple hits. Review URL: http://codereview.chromium.org/20315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9901 0039d316-1c4b-4281-b951-d872f2087c98
* Registering the AutoFill manager because someone added it to the build ↵avi@chromium.org2009-02-171-2/+2
| | | | | | | | without registering its prefs. Review URL: http://codereview.chromium.org/20431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9899 0039d316-1c4b-4281-b951-d872f2087c98