summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* disabling a ui test while I investigate its failureestade@chromium.org2009-05-051-1/+1
| | | | | | | | tbr=thestig Review URL: http://codereview.chromium.org/113006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15348 0039d316-1c4b-4281-b951-d872f2087c98
* Handle mouse back and forward buttons for page navigation.jhawkins@chromium.org2009-05-051-0/+16
| | | | | | | BUG=11439 Review URL: http://codereview.chromium.org/108038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15340 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing assignment in chrome_mini_installer.thestig@chromium.org2009-05-051-1/+1
| | | | | | | TBR=tony Review URL: http://codereview.chromium.org/109048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15339 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing assignment in helper_unittest.thestig@chromium.org2009-05-051-1/+1
| | | | | | TBR=tony git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15336 0039d316-1c4b-4281-b951-d872f2087c98
* Linux download shelf: remove download items when the associated download is ↵estade@chromium.org2009-05-054-17/+74
| | | | | | | | | | | removed. BUG=11381 TEST=in opt mode: download something, go to downloads tab, clear all, go back to tab with downloaded item. The shelf should be gone. Review URL: http://codereview.chromium.org/100366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15335 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the no-longer used TabButtonGtk class.jhawkins@chromium.org2009-05-054-203/+0
| | | | | | Review URL: http://codereview.chromium.org/108035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15334 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side to handle changing CreateWebWorker to createWorker.darin@chromium.org2009-05-052-2/+2
| | | | | | | | R=jam Review URL: http://codereview.chromium.org/109028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15333 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Don't allow onunload handlers to hang a renderer forever.agl@chromium.org2009-05-054-0/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | (Reland of r15025 which was reverted in r15095. |exit| has been changed to |_exit| to save running the onexit handlers while another thread is still in V8 code.) On POSIX one can install an unload handler which loops forever and leave behind a renderer process which eats 100% CPU forever. This is because the terminate signals (ViewMsg_ShouldClose and the error from the IPC channel) are routed to the main message loop but never processes (because that message loop is stuck in V8). One could make the browser SIGKILL the renderers, but that leaves open a large window where a browser failure (or a user, manually terminating the browser because "it's stuck") will leave behind a process eating all the CPU. On Windows we don't have this issue because all the processes are in a job so when the parent dies, all the children are killed too. http://codereview.chromium.org/100222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15332 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Linux tabs as widgets. This moves tab input handling into the ↵jhawkins@chromium.org2009-05-0511-744/+980
| | | | | | | | correct object. This change also adds an initial DraggedTabControllerGtk. Review URL: http://codereview.chromium.org/99371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15330 0039d316-1c4b-4281-b951-d872f2087c98
* Adding first run bypass command line flag.robertshield@google.com2009-05-053-1/+11
| | | | | | | This allows the browser to start up without ever showing the first run UI, regardless of whether the First Run sentinel file is present. Quite useful for automated testing ;-) Review URL: http://codereview.chromium.org/99344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15329 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for 10.6jeremy@chromium.org2009-05-052-5/+37
| | | | | | | | | | | | | * Workaround for rdar://6857649 - NSGradient fails when using LAB Colorspace * Update sandbox config file for 10.6 BUG=11265 TEST=Open Chrome on 10.6, it should have tabs and the tab title should reflect the title of the page that's currently loaded. Review URL: http://codereview.chromium.org/109032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15328 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors HWNDView into two classes for reuse on GTK.sky@chromium.org2009-05-056-174/+278
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/108025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15327 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the creator URL for popups up to the browser. We don't yet use this ↵pkasting@chromium.org2009-05-0514-22/+40
| | | | | | | | | for anything; it will be used for whitelisting popups by hostname. BUG=11440 Review URL: http://codereview.chromium.org/105004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15326 0039d316-1c4b-4281-b951-d872f2087c98
* Remove uses of deprecated version of PathService::Get() in the installer.thestig@chromium.org2009-05-0513-142/+152
| | | | | | Review URL: http://codereview.chromium.org/109033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15325 0039d316-1c4b-4281-b951-d872f2087c98
* Move the shared JS and CSS out of the HTML files and into separate files.arv@chromium.org2009-05-055-112/+77
| | | | | | Review URL: http://codereview.chromium.org/99151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15323 0039d316-1c4b-4281-b951-d872f2087c98
* The bookmark bar app menu item should have a checkbox displayed next to it ↵jhawkins@chromium.org2009-05-051-1/+1
| | | | | | | | when it's selected. Review URL: http://codereview.chromium.org/109036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15322 0039d316-1c4b-4281-b951-d872f2087c98
* Convert autocomplete to use a custom matrix and button cell.shess@chromium.org2009-05-053-130/+226
| | | | | | | | | | | | | | | On the user-visible side this change enables mouse hover (the item under the mouse is highlighted), and lays out the text omnibox v2 style. Only hover really needed the control change, but I have another change queued up to style the popup text. It uses different colors and shades, and really looked horrible with the NSTableView highlighting. [Which is why this part of the CL is coming first.] TEST=Omnibox popup works and shows highlighting under the mouse in addition to the keyboard-selected item. Review URL: http://codereview.chromium.org/99310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15321 0039d316-1c4b-4281-b951-d872f2087c98
* Set infobar text to black (overriding system default color).estade@chromium.org2009-05-051-0/+5
| | | | | | | | Since we set the background color, we can't go letting the theme choose the text color unless we want to potentially end up with white on yellow. Review URL: http://codereview.chromium.org/108034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15320 0039d316-1c4b-4281-b951-d872f2087c98
* Center the download progress meter behind the icon.arv@chromium.org2009-05-051-4/+4
| | | | | | | | | | | | I moved the image down 2px as well as adjusted the margins. I tried keeping the image at 0px but it looks better when moved down slightlty :-) http://crbug.com/10057 Review URL: http://codereview.chromium.org/99286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15319 0039d316-1c4b-4281-b951-d872f2087c98
* Landing the CL from Yusukes.jcampan@chromium.org2009-05-053-0/+18
| | | | | | | | | See http://codereview.chromium.org/99311 TBR=yusukes Review URL: http://codereview.chromium.org/109030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15317 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=11200rafaelw@chromium.org2009-05-0516-332/+331
| | | | | | | | R=aa Review URL: http://codereview.chromium.org/110001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15310 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r15294 that causes crash spike in chromebot.huanr@chromium.org2009-05-052-26/+6
| | | | | | Review URL: http://codereview.chromium.org/108023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15305 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak that happen on some video fileshclam@chromium.org2009-05-051-8/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The memory leak was introduced by BufferedDataSource, the cause of the leak: 1. Some video files have read patterns that BufferedResourceLoader cannot provide data buffer with, thus a large amount of BufferedResourceLoader is created and destroyed. 2. In the destruction of BufferedResourceLoader, it cancels the resource request and immediately deletes the ResourceLoaderBridge. 3. The request canceled in the renderer process isn't cancalled immediately in the browser process, at the mean time browser process still sends shared memory buffers to the renderer process. 4. When these shared memory buffers arrived at the renderer process, the ResourceLoaderBridge associated with the requst has already been destroyed, ResourceDispatcher can't find the associated ResourceLoaderBridge and simply delete the message. But the IPC message is not POD, it contains the handle to shared memory that should be closed. 5. End result is a lot of memory are shared to the renderer process but they are not closed. Solutions: 1. Delete ResourceLoaderBridge only at OnCompletedResponse. Delete ResourceLoaderBridge at OnCompletedResponse, it is guranteed that no more shared memory buffer will arrive after this point, so it's safe to delete ResourceLoaderBridge. The downside is the lifetime of BufferedResourceLoader is prolonged until OnCompletedResponse is received, which may never is received in case of timeout for certain protocol.. 2. Inside ResourceDispatcer, close the handles to shared memory even if ResourceLoaderBridge is not found. I'm going for route 1. The problem I mentioned in 2 also sounds like a bug in ResourceDispatcher, will talk to erickay or eroman to find a solution. Review URL: http://codereview.chromium.org/100302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15304 0039d316-1c4b-4281-b951-d872f2087c98
* Makes closed window icon appear on right side when rtl.sky@chromium.org2009-05-051-0/+4
| | | | | | | | | BUG=11463 TEST=see bug Review URL: http://codereview.chromium.org/108019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15300 0039d316-1c4b-4281-b951-d872f2087c98
* Close browser window synchronously during UI testhuanr@chromium.org2009-05-052-6/+26
| | | | | | | | | | tear down. This is an effor to reduce random failure due to browser crash with multiple window open during shutdown. Review URL: http://codereview.chromium.org/100363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15294 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: localize window title, append inspected tab url there.pfeldman@chromium.org2009-05-0510-12/+53
| | | | | | Review URL: http://codereview.chromium.org/109014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15292 0039d316-1c4b-4281-b951-d872f2087c98
* Don't start the throbber when loading javascript URLs. This fixes abrettw@chromium.org2009-05-052-5/+13
| | | | | | | | | | | | | | | | | regression from my "start the throbber sooner" patch that made JS URLs keep throbbing forever. This patch just adds a check to see if the URL is JS, and doesn't synthesize the load start message. It seems kind of like a hcak, but I think it's the right thing. As I argued in the last patch (the comment for the block I modified here), we really need the throbbing status to be synchronous. This means we need to basically duplicate the logic for when WebKit will do the throbber in this function. BUG=11422 Review URL: http://codereview.chromium.org/105009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15280 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r15278. More unexpected test failures :(darin@chromium.org2009-05-052-2/+32
| | | | | | | | TBR=mpcomplete Review URL: http://codereview.chromium.org/108005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15279 0039d316-1c4b-4281-b951-d872f2087c98
* Re-do r15244: Fix crash in ~TestWebViewDelegate caused bydarin@chromium.org2009-05-052-32/+2
| | | | | | | | | | | | | | | | | | shell_ being null. Moved the RevokeDragDrop call to the TestShell destructor instead. Eliminate webkit/glue/webhistoryitem* in favor of adding a NavigateBackForwardSoon method WebViewDelegate. This moves all of the hacky details of how we intercept "history.{back, forward,go}" into the webkit layer. My eventual plan is to teach WebCore how to make this not hacky. BUG=11423 R=mpcomplete Review URL: http://codereview.chromium.org/108004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15278 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage - file movedben@chromium.org2009-05-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15276 0039d316-1c4b-4281-b951-d872f2087c98
* Move *Animation to app/ben@chromium.org2009-05-0535-778/+41
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15275 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the ClipboardService class and header... it is nothing but a ↵ben@chromium.org2009-05-0516-78/+49
| | | | | | | | | | shell around base::Clipboard now. http://crbug.com/11387 Review URL: http://codereview.chromium.org/105011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15274 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_vector.h and stl_util-inl.h to base/ben@chromium.org2009-05-0564-590/+80
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/107001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15272 0039d316-1c4b-4281-b951-d872f2087c98
* implemented API style/convention changes, including:rafaelw@chromium.org2009-05-0511-297/+725
| | | | | | | | | | | | | | | | | | | | | | | | -tabs.update() -tabs.move() -tabs.remove() -tabs.update() -tabs.create() -tabs.get() -all tab events, except onUpdated implemented -tabs.getSelected() -tabs.getAllInWindow() -windows.getCurrent() -windows.getFocused() -windows.getAll(populate) -windows.onFocusedChanged() -ExtensionBrowserEventRouter now uses BrowserList::Observer Review URL: http://codereview.chromium.org/100345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15271 0039d316-1c4b-4281-b951-d872f2087c98
* FindBarView::UpdateForResult is not a good place to finnur@chromium.org2009-05-059-1/+23
| | | | | | | | | | | | | | | | | beep if nothing was found on the page. The reason is that it is gets called when you switch from one tab to the other. I've added a function to FindBar that the controller can call and each platform can implement whatever sound they want to use. BUG=10823 TEST=Open google.com, search for z0, it should beep (no matches). Open new tab, switch back to the old tab and it should not beep. Review URL: http://codereview.chromium.org/99372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15269 0039d316-1c4b-4281-b951-d872f2087c98
* racy builds meant I didn't see this one... build bustage fix via dependency ↵ben@chromium.org2009-05-051-0/+1
| | | | | | update git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15267 0039d316-1c4b-4281-b951-d872f2087c98
* Bustage fix - forgot to merge this over onto my windows machine from my ↵ben@chromium.org2009-05-051-0/+7
| | | | | | | | | | linux box. Make sure we include gtk as a dependency on Linux. Review URL: http://codereview.chromium.org/105006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15266 0039d316-1c4b-4281-b951-d872f2087c98
* Adds toplevel app/ directory and moves ResourceBundle into it.ben@chromium.org2009-05-05133-1063/+200
| | | | | | | | | | | No changes to resource bundle yet, just the move to keep this CL as compact as possible. Adds new vcproj and gyp file for app dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15264 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for handling files containing URLs with a samplingpaulg@google.com2009-05-051-17/+51
| | | | | | | | | weight. Also print out a few more statistics like the number of URLs examined and the number of host + path pairs looked up. Review URL: http://codereview.chromium.org/105005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15263 0039d316-1c4b-4281-b951-d872f2087c98
* Constrain the gtk menu popup to the bounds of the current monitor.jhawkins@chromium.org2009-05-051-4/+9
| | | | | | Review URL: http://codereview.chromium.org/106001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15262 0039d316-1c4b-4281-b951-d872f2087c98
* Add a RENDERER_PROCESS_CLOSED notification that gets sent when we close thempcomplete@google.com2009-05-055-15/+21
| | | | | | | | | | RenderProcessHost's process_. This is similar to RENDER_PROCESS_TERMINATED, but the latter is not always sent since the process could get reused. It also takes the place of RENDERER_PROCESS_CRASHED, where this one contains a boolean Details indicating whether the process crashed (true) or just exited (false). Review URL: http://codereview.chromium.org/100277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15261 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up full-page zoom menu items and fix that zoomed controls don't draw.thakis@chromium.org2009-05-052-3/+65
| | | | | | | | | BUG=crbug.com/11325 TEST=Open a page with controls, zoom in or out and check that they scale nicely. Also, check that the "mouse down" and "clicked" states appear correctly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15259 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: enable omni box ui test and automation proxy ui test.estade@chromium.org2009-05-0512-36/+49
| | | | | | | | Enable a lot of (already essentially working) automation code along the way. Review URL: http://codereview.chromium.org/100278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15258 0039d316-1c4b-4281-b951-d872f2087c98
* Port the folder selector portion of the BookmarkEditor to GTK.erg@google.com2009-05-0510-97/+773
| | | | | | | | | | | | | | | Mirrors the BookmarkEditorView method, where the contents of BookmarkModel are copied to a temporary model so changes can be discarded if the user hits Cancel. In the GTK version, we copy not into another BookmarkModel, but into a GtkTreeStore, which serves as a model to the GtkTreeView on screen. Also ports the unit tests. http://crbug.com/11250 Review URL: http://codereview.chromium.org/99361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15257 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: show the correct cursor when the render view regains focus.estade@chromium.org2009-05-051-1/+2
| | | | | | | | BUG=11407 Review URL: http://codereview.chromium.org/105002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15256 0039d316-1c4b-4281-b951-d872f2087c98
* Highlight the next find result when the return key is pressed in the Linux ↵jhawkins@chromium.org2009-05-052-31/+34
| | | | | | | | find bar. Review URL: http://codereview.chromium.org/99376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15255 0039d316-1c4b-4281-b951-d872f2087c98
* Various trivial clean-up bits:pkasting@chromium.org2009-05-052-8/+4
| | | | | | | | | | * Fix an 80-column issue * Remove an unused param * Remove an unnecessary setter * Fix a variable capitalization style violation Review URL: http://codereview.chromium.org/100361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15254 0039d316-1c4b-4281-b951-d872f2087c98
* Several minor visual fixes to toolstrips:aa@chromium.org2009-05-046-47/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Layout toolstrips on the left of the bookmark bar so that something always obviously happens when you install one. This is in response to some feedback I've gotten demoing toolstrips for various people. * Open the NTP on install if the bookmarkbar isn't visible. Again, I'm trying to make something happen when you install an extension. This won't be the permanent behavior but it seems like doing nothing if you have your bookmark bar detached is likely to confuse people. * Fix a bug where we kept trying to resize the toolstrip back to the width it had when it was first made visible. * Fix a bug where we didn't always repaint the bookmarkbar after the toolstrip preferred width changed. This also seems to fix the issue where the buildbot sample shows up overlayed on top of tab contents, though I didn't mean to fix that with this CL. Review URL: http://codereview.chromium.org/100310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15249 0039d316-1c4b-4281-b951-d872f2087c98
* Specify all the outputs of theme_resources.grd-- it outputstc@google.com2009-05-041-1/+36
| | | | | | | | | | | | | | an extra .h and .cc file. This means I have to split it into it's own action since the other grd files don't create this output. This fixes a dependency in the make build. Review URL: http://codereview.chromium.org/99362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15248 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 9812: Remove current RSS code in favor of new more generalizedfinnur@chromium.org2009-05-0421-286/+5
| | | | | | | | | | | | PageAction code that serves the same purpose (and more). BUG=9812 TEST=No test needed, this shouldn't result in any noticable difference since the RSS parsing was disabled. Review URL: http://codereview.chromium.org/100356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15247 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 22:00:53 +0000