summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fix a leak in HistoryProfileTest.TypicalProfileVersion.erikkay@google.com2008-08-251-8/+9
| | | | | | | | sqlite3_close returns SQLITE_BUSY if there are any outstanding statements. Since the SQLStatement object hadn't been destroyed, finalize hadn't been called, so the close failed and a lot of sqlite stuff leaked. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1321 0039d316-1c4b-4281-b951-d872f2087c98
* Add some new tests for NavigationController for navigations that come in ↵brettw@google.com2008-08-252-13/+224
| | | | | | when various navigations are pending. This doesn't actually change any behavior. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1314 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete project so it doesn't confuse new developerspinkerton@google.com2008-08-251-649/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1313 0039d316-1c4b-4281-b951-d872f2087c98
* We can link with secur32.lib and call the SSPI functions directly.wtc@google.com2008-08-251-0/+1
| | | | | | | | | Add secur32.dll to chrome.dll.deps as a new dependency of chrome.dll. R=maruel BUG=1272567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1310 0039d316-1c4b-4281-b951-d872f2087c98
* Make PlatformThread::SetName operate only on the current thread.deanm@google.com2008-08-254-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1306 0039d316-1c4b-4281-b951-d872f2087c98
* SCons build: Add app\client_util.cc. Handle rename ofsgk@google.com2008-08-252-1/+2
| | | | | | | app\theme\google_theme_resources.rc to app\theme\distribution_resources.rc. TBR: rahulk git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1301 0039d316-1c4b-4281-b951-d872f2087c98
* roll back r1297 for nowbeng@google.com2008-08-242-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1298 0039d316-1c4b-4281-b951-d872f2087c98
* Fix task manager crash by releasing the delegate's scoped_ptr back to the ↵beng@google.com2008-08-242-1/+1
| | | | | | | | window when the window is destroyed, not when the window delegate is destroyed, since some use cases recycle the delegate. B=1333829 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1297 0039d316-1c4b-4281-b951-d872f2087c98
* fix release bustage.beng@google.com2008-08-241-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1296 0039d316-1c4b-4281-b951-d872f2087c98
* fix release bustage.beng@google.com2008-08-241-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1295 0039d316-1c4b-4281-b951-d872f2087c98
* fix release bustage.beng@google.com2008-08-241-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1294 0039d316-1c4b-4281-b951-d872f2087c98
* Make the window icon the app icon by default for popups and app windows ↵beng@google.com2008-08-243-10/+22
| | | | | | | | | | unless the page specifies a favicon. This ensures that we don't show the default favicon for the window icon. (This is only appropriate for tab icons). Also make sure popup windows opened from app windows are themselves app windows (and don't show the URL bar) B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1293 0039d316-1c4b-4281-b951-d872f2087c98
* Makes our tables (task manager, keywords ...) not flicker whensky@google.com2008-08-242-5/+38
| | | | | | | | | | | resizing by doing nothing when we get erase background. BUG=804753 TEST=make sure you don't get any painting artifacts in the task manager and keyword editor. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1292 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bogus typedef for HistoryService's empty callback. This turnedsky@google.com2008-08-243-3/+3
| | | | | | | | | | up as an UMR. I'm surprised this didn't produce a compiler error. BUG=1338601 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1291 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241292-37183/+6090
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Try to remove the flakyness in the test by adding a Sleep.nsylvain@google.com2008-08-231-0/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1282 0039d316-1c4b-4281-b951-d872f2087c98
* Update DEPS files for new changes to app.brettw@google.com2008-08-231-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1279 0039d316-1c4b-4281-b951-d872f2087c98
* Adds capabilities for IPC messages of type long, for the primary purpose of ↵klink@google.com2008-08-221-0/+14
| | | | | | accessibility related communication. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1263 0039d316-1c4b-4281-b951-d872f2087c98
* Move distribution specific theme images:rahulk@google.com2008-08-2224-35/+60
| | | | | | | | | | | | | - Google Chrome images are in internal repository now and get checked out into app\theme\google_chrome so delete them from app\theme - Add Chromium images to app\theme\Chromium - Modify html inlining script to pick up images from different places depending on environment variable (for now the default is google chrome which will change to chromium). - Moving icon file to private repository as well so delete it from public repository. In its place add chromium icon. - chromium\product_logo.png is a not actually a logo but just the blue icon in the same size as google_chrome\product_logo.png. This file makes about:version and new tab page look prettier (imo). BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1249 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome.exe read version from Software\Chromium instead of Google Update ↵rahulk@google.com2008-08-226-197/+279
| | | | | | | | | | | | | | keys when running Chromium. With this change now we can build a Chromium release that gets installed under Application Data\Chromium and actually runs. - Added a new file that has common functions used by google update client and chromium - Did some minor cleanup based on readability guidelines (alphabatical order etc). - We seem to be trying to avoid std::wstring at some places but are using it at other places. In future we should be just able to use std::wstring and get rid of StringCchDup. BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1243 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome strings.tc@google.com2008-08-224-5/+5
| | | | | | TBR=mal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1231 0039d316-1c4b-4281-b951-d872f2087c98
* Add google_theme_resources.rc to SCons build.sgk@google.com2008-08-221-1/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1228 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor thread naming in the DNS slaves.deanm@google.com2008-08-223-18/+10
| | | | | | BUG=1337196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1219 0039d316-1c4b-4281-b951-d872f2087c98
* The FINAL strings for Beta!mal@google.com2008-08-223-7/+17
| | | | | | | | (Confirmed with rharris) TBR= tc@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1210 0039d316-1c4b-4281-b951-d872f2087c98
* Preclude large UMA uploads (but ensure histograms and crash data are sent)jar@google.com2008-08-222-5/+48
| | | | | | | | bug=1338039 r=petersont,evanm git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1203 0039d316-1c4b-4281-b951-d872f2087c98
* Had the logic for detecting ifdef DEBUG wrong.mbelshe@google.com2008-08-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1188 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeClientImpl::windowRect() to return the currenterg@google.com2008-08-213-7/+6
| | | | | | | | | | window's rect. Previously, it was combining the window origin with the size of the renderer; not the size of the window. BUG=1186573 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1184 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes up the autocomplete providers to correctly update starredsky@google.com2008-08-217-85/+41
| | | | | | | | | | | state. I broke this in order to land my last mongo patch. HistoryContentsProvider is still lacking in one area. BUG=1256202 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1181 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing file to fix the buildjoshia@google.com2008-08-211-2/+2
| | | | | | | TBR=nsylvain git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1179 0039d316-1c4b-4281-b951-d872f2087c98
* Code review changes. Incorporated all the suggestions from previous review. joshia@google.com2008-08-2115-111/+110
| | | | | | | | | | | | | One item not changed yet is to rename 'receiver' in ForwardMessageToExternalHost. The idea is to invoke receiver("message") at the other end. So for example if the args to ForwardMessageToExternalHost("hello", "world") then we will invoke a script hello("world") on the other side. 'receiver' doesn't really describe the first argument here so if there is a better suggestion, I would be happy to change it :) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1176 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak on shutdown in the navigation controller. The pending entry was notbrettw@google.com2008-08-211-0/+2
| | | | | | getting deleted. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1173 0039d316-1c4b-4281-b951-d872f2087c98
* Unrollback r1158.rahulk@google.com2008-08-218-55/+92
| | | | | | | BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1170 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability to disable breakpad while running the ui tests.maruel@google.com2008-08-213-0/+12
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1169 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 1158 as it is breaking ui_testsrahulk@google.com2008-08-219-93/+56
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1165 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in BookmarkBarNode. I wasn't resetting a load handlesky@google.com2008-08-211-5/+5
| | | | | | | | | | | | | | resulting in the possibility of trying to cancel a bogus load handle. I'm TBRing this one as I just introduced this and its easy to hit a DCHECK now. BUG=1256202 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1163 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome strings.tc@google.com2008-08-212-517/+517
| | | | | | TBR=mal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1161 0039d316-1c4b-4281-b951-d872f2087c98
* disable test to make build greenrahulk@google.com2008-08-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1160 0039d316-1c4b-4281-b951-d872f2087c98
* Do not display "Google" in titlebar of Chromium builds. rahulk@google.com2008-08-218-55/+92
| | | | | | | | - Create a new resource file that will contain Google Chrome specific resources. Ideally this new resource file should not be in the Chromium project at all but there doesnt seem to be any way to do conditional includes in vcproj files. So we ifdef its contents. - Make distributor logo optional. If we do not find it, we do not try to paint/layout logo. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1158 0039d316-1c4b-4281-b951-d872f2087c98
* Makes resize of custom frame window a bit smoother. I tried a wholesky@google.com2008-08-211-1/+14
| | | | | | | | | | | | | | | | | slew of variations, and this is the best I could get. From nc calc size we now return WVR_REDRAW, which indicates we need to redraw the frame. Without this I believe windows was copying some bits around for us resulting in the jitter. Additionally in OnNCPaint we do nothing if the root view's size isn't the same as the window's size. This is done as during resizes we get a WM_NCPAINT *before* a WM_SIZE. We also get a WM_NCPAINT after the WM_SIZE, so that it's ok to ignore the first one. BUG=1293978 TEST=make sure sizing of task manager/keyword editor doesn't break. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1157 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmarks out of history into its own file (JSON).sky@google.com2008-08-2157-2414/+1216
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Interesting points: . Migration was a bit atypical. Here is the approach I took: . If the URL db contains bookmarks it writes the bookmarks to a temporary file. . When the bookmark bar model is loaded it assumes bookmarks are stored in a file. If the bookmarks file doesn't exist it then attempts to load from history, after waiting for history to finish processing tasks. . I've broken having the omnibox query for starred only. This patch was already too ginormous for me to contemplate this too. I'll return to it after I land this. . Similarly the history page isn't searching for starred titles now. As we discussed with Glen, that is probably fine for now. . I've converted NOTIFY_STARRED_FAVICON_CHANGED to NOTIFY_FAVICON_CHANGED and it is notified ANY time a favicon changes. I'm mildly concerned about the extra notifications, but without having history know about starred it's the best I can do for now. . Autocomplete (specifically URLDatabase::AutocompleteForPrefix) previously sorted by starred. It can no longer do this. I don't think I can get this functionality back:( Luckily it only mattered if you had a starred and non-starred URL with the same type count that matched a query. Probably pretty rare. What's left: . Fix up HistoryContentsProvider to query for starred entries titles. . Clean up the delete all case. I basically just made it compile; it can be greatly simplified. . Rename BookmarkBarModel to BookmarksModel. BUG=1256202 TEST=this is a huge change to bookmarks. Thanfully it's pretty well covered by tests, none-the-less make sure you exercise bookmarks pretty heavily to make sure nothing is busted. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1153 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustagedarin@google.com2008-08-211-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1148 0039d316-1c4b-4281-b951-d872f2087c98
* Fix release build bustage.darin@google.com2008-08-211-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1147 0039d316-1c4b-4281-b951-d872f2087c98
* Port the Thread class properly to Mac and Linux. This involved portingdarin@google.com2008-08-214-4/+5
| | | | | | | | | | | | PlatformThread and creating an API on PlatformThread to create a native thread and later join with it. I also made a few other tweaks to PlatformThread, such as eliminating the Current() method which appears to be unused. The operator==() is also unused, so I killed it as well. I made a few other miscellaneous cleanups and adjustments. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1146 0039d316-1c4b-4281-b951-d872f2087c98
* As Brett pointed it out, We normally use 8-bit for encoding names since ↵jnd@google.com2008-08-2132-118/+123
| | | | | | they're always ASCII. Plus, wstrings will also be 32-bit characters on Linux and Mac, which is expensive. So I make this CL by using std::string instead of std::wstring every time you have an encoding name. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1144 0039d316-1c4b-4281-b951-d872f2087c98
* Track removal of browser\navigation_controller_base.cc.sgk@google.com2008-08-211-1/+0
| | | | | | TBR: brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1142 0039d316-1c4b-4281-b951-d872f2087c98
* Fix one bug in the URL list.mbelshe@google.com2008-08-211-2/+7
| | | | | | | Add timeout to NavigateToURL in case there are timeouts. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1140 0039d316-1c4b-4281-b951-d872f2087c98
* Kill NavigationControllerBase. I merged the two into NavigationController.brettw@google.com2008-08-215-710/+536
| | | | | | | | | This fixes a leak of NavigationEntry's by using the spiffy linked ptr. I had to add a const to linked_ptr for the comparisons to work. BUG=1319484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1137 0039d316-1c4b-4281-b951-d872f2087c98
* Don't compile installer_util_strings.rc as a separate .res,sgk@google.com2008-08-201-10/+5
| | | | | | | it's getting #included by the other .rc files that need it. (While here, refactor the way the libs are configured for consistency.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1128 0039d316-1c4b-4281-b951-d872f2087c98
* TrackedObjects assumes you can use a "TLS slot" of -1 to indicate ↵evanm@google.com2008-08-206-23/+25
| | | | | | uninitialized. This isn't true for the pthread_key_t type, which is unsigned on Linux and reportedly a struct on Macs. This change modifies the Slot type to be a struct containing an "initialized" flag. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1122 0039d316-1c4b-4281-b951-d872f2087c98
* Revert a fix where I mistakenly assumed that numbers coming into erg@google.com2008-08-203-10/+8
| | | | | | | | | | | | Browser::MoveContents() were content sizes instead of window sizes; this broke a unit test and is incorrect. Reopening the other bug; it seems like webkit is getting totally wrong numbers when asking for a window's size. BUG=1334628, git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1121 0039d316-1c4b-4281-b951-d872f2087c98