| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
failing at revision 12317.
Review URL: http://codereview.chromium.org/49012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
be something that breaks our build.
TBR=aa
Review URL: http://codereview.chromium.org/52029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NULL check the wrapper since this can be called when we're not in a view hierarchy.
TBR=jcampan
Review URL: http://codereview.chromium.org/42539
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
messages to the extension process is supported.
Review URL: http://codereview.chromium.org/48090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Replace with renamed NativeButton2, Checkbox2, RadioButton2.
Review URL: http://codereview.chromium.org/50083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following are implemented:
* Keyboard shortcuts for next/prev/close tab.
* Tab layout and rendering.
The following need to be implemented:
* Mouse input handling.
* Animations.
* TabGtk, TabRendererGtk.
* Dragging.
* Fix a NOTREACHED in navigation_controller.cc.
Review URL: http://codereview.chromium.org/42457
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=6468
Review URL: http://codereview.chromium.org/46076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gfx::GetCleanStringFromUrl() got implemented for Mac at some point (I
suspect when fonts landed), so now all of this code should be
portable.
There is a slight difference in how ElideUrl() works, due to font
metric differences, but that should not be relevant to this code.
Review URL: http://codereview.chromium.org/42513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
in PluginThread::CleanUp.
BUG=8980
Review URL: http://codereview.chromium.org/50075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42519
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetRequestContextForMedia() in ProfileImpl and OffTheRecordProfileImpl
now respect --disk-cache-dir. Since the snippet for getting the path
from --disk-cache-dir is very short, it's not necessary to keep it in
a separate method so I duplicated the snippet and used it in both
classes.
Review URL: http://codereview.chromium.org/42517
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=9082
Since I forwarded CreateOffTheRecordForMedia to
CreateOriginalForMedia, it triggers a DCHECK. Since the
implementation of off the record media cache is not going to be
implemented soon, I duplicated the implementation of
CreateOriginalForMedia.
Review URL: http://codereview.chromium.org/42467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42489
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/52017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/52015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- enable following ui tests on Linux:
history_uitest.cc
inspector_controller_uitest.cc
browser/history/redirect_uitest.cc
browser/locale_tests_uitest.cc
browser/sanity_uitest.cc
- move information about Linux-specific splash page
to more generic location and enable more logic
about start page on Linux
- maintainability cleanups (DISABLED_ instead of #if 0)
- misc GCC-related cleanups
Review URL: http://codereview.chromium.org/49006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/47002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/52009
Review URL: http://codereview.chromium.org/42503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42501
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/52009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window and remote debugger connected over TCP(apavlov is working on it). To allow DevToolsManager coordinate both types of devtools uniformly their API is extracted into DevToolsClientHost interface.
Fix purify errors in DevToolsManager unit tests.
BUG=9150
Review URL: http://codereview.chromium.org/50009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
initializing values into Extension, outputting values to the extension_ui, and appropriate unit test changes
Review URL: http://codereview.chromium.org/42480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is also meant to exercise the field trial infrastructure.
r=mbelshe
Review URL: http://codereview.chromium.org/50084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Rolling forward deps on gyp to get 'copies' support.
This time handled wow_helper.
Review URL: http://codereview.chromium.org/42355
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
DownloadRequestManagerTest, URLFetcher*Test, TimeFormat, RenderWidgetTest
Review URL: http://codereview.chromium.org/50081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
for now.
Review URL: http://codereview.chromium.org/50092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
in the purify unit test.
Review URL: http://codereview.chromium.org/45021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/45012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At one point we changed the Clear Browsing Data dialog to remember
the values of the combobox and the checkboxes between runs. Like
with the Options dialog, changes you make take effect immediately
and as such having a Cancel button is misleading. Therefore, I am
proposing we rename it to Close.
BUG=6474
TEST=Open Clear Browsing Data dialog. The button should now say
Close.
Review URL: http://codereview.chromium.org/45019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test for extension user script load and inject.
This add a test that a user script actually gets injected into
pages and runs. Before we only had unit tests for the various
classes and weren't testing the system end-to-end.
Review URL: http://codereview.chromium.org/51003
Patch from Steve Krulewitz <skrulx@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- future crash reporter will use this key
BUG=1459941
Review URL: http://codereview.chromium.org/42407
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
implementation.
Review URL: http://codereview.chromium.org/45016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
copied from the old radio button.
Review URL: http://codereview.chromium.org/50080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/50047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42469
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add Linux settings to target_defaults in common.gypi so
gyp-generated SConscript files no longer depend on
build/SConscript.main or the Hammer infrastructure.
* Copy the FilterOut() function from Hammer to the chromium_builders.py
Tool module.
* Add a ChromiumLoadableModule() builder to chromium_builders.py.
* Add dependencies on the 'views' library to the chrome link (target 'app').
* Add missing views/*/*_unittest.cc modules to the 'unit_tests' target.
Exclude all but the one that builds on Linux from the non-Windows builds.
* Crib a list of chrome/views files to exclude from the Linux build
from the old SCons configuration.
* Add a new build/linux/system.gyp file with new 'settings' targets
to encapsulate the pkg-config checks for gtk+-2.0, nss and pangoft2.
* Add depenedencies in the other targets on the new gtk, nss and
pangoft2 'settings' targets from build/linux/system.gyp.
* Add a pkg_config_wrapper.py script that keeps gyp happy by
simply exiting 0 if the package isn't found.
* DEPS roll for latest gyp changes to support the above.
Review URL: http://codereview.chromium.org/42340
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
its originating page.
BUG=5630
Review URL: http://codereview.chromium.org/50067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
deletes that suggestion from the DB.
BUG=6176
TEST=Bring up the autofill popup in a form. Select an item and press the Del key. The item should be removed from the popup and should not show on subsequent autofill popups.
Review URL: http://codereview.chromium.org/42258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This DCHECK occurs when we click Allow on the "This webpage is trying to download multiple files" dialog.
When...
DownloadRequestDialogDelegate
... and ...
DownloadRequestDialogDelegateWin
... were created, both classes by accident contained a host_ member.
This causes a DCHECK in...
DownloadRequestDialogDelegateWin::DeleteDelegate()
... because the host_ in the child class is never initialized. I
believe the intent is to check the host_ of the parent class, so
I deleted the definition of host from xxxDelegateWin.
Review URL: http://codereview.chromium.org/50072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/50073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
--bookmark-menu.
BUG=3206
TEST=Turn on the bookmark menu via --bookmark-menu and make sure it
works. Also make sure I didn't break anything on the bookmark bar.
Review URL: http://codereview.chromium.org/42460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This consolidates the shutdown path. We used to have two paths depending
of whether the user hit the X on the window manager or used wrench -> exit.
Now both do the same thing: call BrowserWindowGtk::Close().
Review URL: http://codereview.chromium.org/42372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- less things #ifdef-ed
- replaced Windows-specific functions with portable equivalents
Review URL: http://codereview.chromium.org/50059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- enable one more point of logging
- enable decoding of automation messages in log output
Review URL: http://codereview.chromium.org/50058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
this so easy.
Review URL: http://codereview.chromium.org/42438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12210 0039d316-1c4b-4281-b951-d872f2087c98
|