| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
its corresponding object has been removed via the "Clear
browsing data" command.
BUG=1270230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Used libxml rather than scanf/the wrapper class XmlReader.
More data from the response are recorded to be used later to control the transmissions.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=beng
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
WebCore/Configurations/Version.xcconfig and generate a header file that allows us to keep our user agent info up to date.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The new dialog command fires up a dialog (chosen randomly) and exercises it.
BUG=None
TEST=Run the automated_ui_test
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
commits, even if their NavigationEntries aren't adjacent to the current entry.
Also makes NavigationController::Destroy compatible with NavigationControllerTest, which adds more tab types than TAB_CONTENTS_NUM_TYPES. Also re-enables the SwitchTypes tests and adds another to prevent regression of this bug.
BUG=1296773
TEST=NavigationControllerTest.SwitchTypesCleanup
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
new tab button) or an address is opened from the address bar in a new tab (by pressing Alt+Enter), the opener is remembered briefly, allowing quick lookup in a new tab without disrupting the z-order experience.
Full explanation in bug:
B=1266404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've hidden this frame behind a command line switch (--magic_browzR) so as not to destabilize the main browser UI any further. Note that running with this switch is likely buggy, incomplete, crashy, etc.
In order to make this work without disrupting a lot of existing code, I've had to make another BrowserView class (temporary) - BrowserView2. This also has to be a BrowserWindow implementor since that's the interface Browser uses to communicate with the UI.
BrowserView2 and OpaqueNonClientView are the major new files in this CL, but BrowserView2 is pretty similar to BrowserView. OpaqueNonClientView is the view that renders the titlebar/borders/etc. It's layout/painting routines are a bit simpler than XPFrame's!
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
suffixes when linking with the libraries we build, replacing the lists of explicitly-suffixed "source files" with library base names in the environment LIBS variables. This requires having ChromeStaticLibrary() install .lib files in a $BUILD_TYPE/Libs directory, and adding that directory to $LIBPATH.
R=evanm,bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
1) Remove ConstrainedWindow::GenerateInitialBounds(), which is old and crufty and no longer relevant now that there are no unsuppressed, constrained popup windows.
2) Move the browser side positioning logic into Browser::BuildPopupWindow().
3) Fix the window.open() handler so that when we aren't given top=/left= coordinates, we don't set the window origin (allowing the browser to do something more intelligent).
BUG=1290758
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
input source files to the $LIBS variable.
TBR: bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
everywhere into the base Windows environment.
TBR: evanm,bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR: evanm,bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It hasn't relanded, yet, so I thought I'd put it back before it slips through the cracks.
Original Description (r65, creis):
Makes the process model heuristic for generated searches only apply in --process-per-site, since it isn't relevant otherwise. (This matters now that process-per-site-instance is the default.)
BUG=1256259
TEST=Visit a non-Google page, then run a search from the location bar. The tab should switch renderer processes.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Browser_dll will follow. At this point, plugin.dll and renderer.dll are roughly 35% smaller than browser.dll and chrome.dll
BUG=1211534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the renderer due to the plugin instance getting destroyed
in the context of the ShowModalHTMLDialog request. The fix
is to convert the WebPluginDelegateProxy object in a DeleteLater and to set its channel to NULL in the destructor. This ensures that the reply to the message can be sent out successfully.
Bug=1303133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR= tc@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
testing.
TBR=sky
BUG=1291438,1291559,1291598,1293274,1295631,1295636,1298147,1305160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
1. Remove all the is_closing_browser plumbing. WebContents/TabContents/RenderViewHost/etc really shouldn't (and don't!) need to know anything about whether we're closing the browser or not.
2. Refactor the handling of beforeunload/unload state in browser.cc. I think this makes it considerably easier to reason about the correctness of it.
3. Added a couple TODOs for future cleanups that would have made this change a bit too large.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Also conveniently fixes accessibility test 'failures' introduced by the last distributor logo change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
disappears in maximized view to avoid taking away from the tab strip.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Our code is not well prepared to handle this case.
BUG=1286612
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
debug output functionality at the same time.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This really should be using our GridLayout, but GridLayout had trouble both handling our row-spanned images, and cropping the image correctly when the column got too small (it center-cropped it). In the interests of not adding complication for Beta, I just modified the existing code.
BUG=1304459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add base\object{,_watcher}.cc.
* Add chrome\browser\bookmark_{codec,storage}.cc.
* Add chrome\views\frame\browser_window_factory.cc.
* Split of app\main.cc into app\chrome_{dll,exe}_main.cc, with added CPPDEFINES for {BROWSER,RENDERER,PLUGIN}_DLL.
* Move $CSCRIPT, $PLATFORMSDK* and $VISUAL_STUDIO variables to the win32-specific construction environment.
* Remove unnecessary comments.
TBR: bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tc
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
simulating drags, rather than ChromeViews events. Sending ChromeViews events directly to the RootView means that capture isn't set up properly and some state relating to dragging isn't saved on the frame.
B=1303306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://chrome-reviews.prom.corp.google.com/996
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
to the right of the tab whose context menu was used.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whenever the RenderView is told that a provisional load has started for the main frame.
The DCHECK(params->referrer == params->redirects[0]) was firing because:
a) page A was loaded, triggered WillPerformClientRedirect
b) after the provisional load started for the destination page of A's client redirect, but before this load was committed, the browser makes a Navigation request for page B.
c) When page B's load is committed, the RenderView's completed_client_redirect_src_ was still set, resulting in a CLIENT_REDIRECT transition type and forwarding the src value through params->referrer -- but params->redirects was now completely unrelated. Kaboom.
This fix should be general enough to handle cases (that are relatively likely in the wild) where WebKit legitimately cancels the redirect, instead of just the browser doing so. Note we can't depend on dispatchDidCancelClientRedirect because we get that callback on both completion and cancellation of a client redirect.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on a specific project.
Remove C++ style ; in python script.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
needing this. This ensures that users in countries where the Google base URL is not "google.com" will see the appropriate keyword for their local country (and can trigger it for tab-to-search, etc.).
BUG=1301290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
file. These files aren't being built or used yet (though a test case
exists that is ifdef'd out).
BUG=1256202
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserToolbarView and StatusBubble into it.
Also restructures the creation of the Frame. This is significant! The Browser now constructs a frame via a new static BrowserWindow::CreateBrowserWindow method (see browser_window_factory.cc). Recall the diagram in the architectural overview doc - the BrowserView object is the one that implements the interface that the Browser object uses to communicate with the UI. The Browser object communicates to the BrowserView directly through this interface, but not directly to the frame.
What actually happens right now in CreateBrowserWindow is that an XP/VistaFrame is constructed, but this is _not_ the object returned to the Browser, rather when the XP/VistaFrame is init'ed, it constructs a BrowserView that also implements BrowserWindow. This is the object that's returned to the Browser.
Since both BrowserView and XP/VistaFrame implement BrowserWindow, I am now able to gradually migrate functionality from the frames to BrowserView. During this process BrowserWindow functions not handled yet by BrowserView will be forwarded to the appropriate frame.
Modifies the Accessibility UI tests to account for this extra level of indirection (should only be temporary while I'm moving things around).
This does actually pass the UI tests.
See the whiteboard in my office for a diagram. This is a bit confusing right now since there's so much going on. Sadly the only way to get where we need to go incrementally is to make a mess on the way.
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
migrating from Window to DialogClientView, I neglected to insert the check into this function to see if the dialog had already been accepted by the user before trying to abort.
B=1304032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the same number when run several times consecutively.
BUG=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chrome.dll due to interdependencies. This will be fixed later.
The new dlls are not built by default.
BUG=1211534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
identified to their owning project.
Add #ifdef to make the ChromeMain function exclude parts depending on the
relevancy of the dll generated.
BUG=1211534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
notification_service.h.
TBR=maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
set, and replaces it with a lock. Rename confusing GotAuth test and set method to was WasAuthHandled, which will optionally marked as handled.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- Forgot to fix one main() function.
TBR=nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Previously this job was done by the CRT's atexit() which runs later than we want and under the loader lock.
- Had to modify most main() functions for the testing executables so we don't trigger leak detectors.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
competing can-be-default choices with the same host and path. Previously we would end up picking the least commonly used engine in this case.
BUG=1303406
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
real-world servers return responses like this and there's no obvious reason to disallow it, even though technically it violates the JSON spec.
BUG=1295216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
avoid race conditions with tab closing now that it's async.
BUG=1303289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216 0039d316-1c4b-4281-b951-d872f2087c98
|