| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: http://codereview.chromium.org/19717
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19711
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19697
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
kSetupExe constants to the executable path.
Review URL: http://codereview.chromium.org/19493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1609821
Review URL: http://codereview.chromium.org/19694
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Wrong titlebar height
* Titlebars not handling custom font size properly
* Drawing errors in maximized mode
* One-pixel overlap glitch on bottom corners of client edges
* Borders not handling custom border sizes correctly
* Unnecessarily small top resize area (unlike in the main window, there's no competition here between resizing and window dragging in the same small strip)
* Wrong icon sizing (only a problem in theory, no one uses this code ATM)
These files are now very much like simplified versions of the opaque_non_client_view.cc code (which was the goal); eventually all these should be refactorable.
BUG=5054
Review URL: http://codereview.chromium.org/19484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19692
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://clients4.google.com/firefox/metrics/collect,
which has a certificate that matches the host name.
Remove the net::LOAD_IGNORE_CERT_COMMON_NAME_INVALID
load flag.
R=evanm
BUG=b/876021
Review URL: http://codereview.chromium.org/19450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a proof of concept I converted
FindInPageControllerTest.FindInPageFrames over to this.
See the description in InProcessBrowserTest for how it all works.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19644
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
formatting changes, i.e. CRLF, space at end of line.
Review URL: http://codereview.chromium.org/19486
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=evanm
Review URL: http://codereview.chromium.org/19482
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is mostly making sure we have all the symbols we need.
Review URL: http://codereview.chromium.org/19683
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The first run import will trigger the eula again : this requires changes in browser_main.cc
so the master prefs are not processed again by the importer process
- The launch of setup.exe to show the eula was using a path that only works on developer builds
this requires relocating a constant from setup_constants to util_constants
BUG=1468838
Review URL: http://codereview.chromium.org/19680
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changes in OpaqueNonClientView in preparation for fixing similar problems in them, and then refactoring everyone to a common base implementation.
This change should have no visible effect; it merely adds functions, reorganizes code, renames variables, and modifies spacing/style to match OpaqueNonClientView as closely as possible. The subsequent set of functional changes should thus hopefully be easier to review, as should the eventual refactoring changes.
This does away with some useless code since both these views are used for windows which always have titles, and, in ConstrainedWindowNonClientView's case, never have icons. (Technically, DefaultNonClientView never has an icon right now either, but there's some commented-out code in the bookmark manager that speaks of having one one day.)
Review URL: http://codereview.chromium.org/19684
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
--install-extensionChanged manifest filename to end in .json.Updated authoring script to include sha256 hash of zip file.
Review URL: http://codereview.chromium.org/18477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
about issues I discovered in this process.
Review URL: http://codereview.chromium.org/19677
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the UI, just had to manually edit the file.
Review URL: http://codereview.chromium.org/19480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
also removed support for window frame sizes with unequal widths vs. heights; Windows' UI doesn't actually let you do this and it was making the code more complex than it needed to be.
Review URL: http://codereview.chromium.org/19477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageLoop. I'm going to need this when running ui tests in
process. In this case I'll pass in the IO thread.
I'll change all callers to use the new method, but before doing that
wanted to make sure you're ok with it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pointer. Based on the crash dump, the crash occurs in the windows message filter hook, used for tracking whether the plugin enters a modal loop. The global plugin instance pointer gets reset to NULL in the windowed plugin wndproc and HandleEvent. If these events occur in nested order, then it is quite possible for the plugin instance pointer to get set to NULL incorrectly.
Added a check for whether this pointer is NULL in the message filter hook along with a NOTREACHED statement.
We maintain a local global stack to ensure that the plugin instance pointer gets set/reset correctly.
The bug is http://code.google.com/p/chromium/issues/detail?id=6703
The other issue being fixed is to set the modal_loop_pump_messages_event coming in from the plugin
in WebPluginDelegateProxy correctly. This caused the plugin to not receive events when it enters a modal loop like a context menu.
Bug=6703
Review URL: http://codereview.chromium.org/19444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Turns out we need to broadcast the NOTIFY_USER_SCRIPTS_LOADED message even if
there are no scripts. I just removed the DCHECK that expects scripts.
Review URL: http://codereview.chromium.org/19475
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit into unit_tests.
There was also a problem with simple_clipboard_impl.cc which should only be
compiled into test_shell.
I can't remove mock_webkit_glue.cc until I verify that the mac build doesn't
need it anymore.
Review URL: http://codereview.chromium.org/19474
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19473
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19669
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
already).
Review URL: http://codereview.chromium.org/19653
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19671
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
code that runs it.
Review URL: http://codereview.chromium.org/19666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
more sense anyway) so I'll be able to use it in custom_frame_window.cc.
Also eliminate an unnecessarily-repeated set of resource IDs from the opaque nonclient view, and move a comment to match what I ended up doing (but haven't yet sent up for review) in other places. Seems I couldn't make up my mind on that one.
Review URL: http://codereview.chromium.org/19458
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Disconnect the "browser controlled printing" and always delegate the control flow to the renderer.
Simplify the tests by not using a message loop anymore.
Followup changes will remove more parts that are not needed anymore.
Review URL: http://codereview.chromium.org/19460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
avoid possible crash.
Review URL: http://codereview.chromium.org/19451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=7191
Review URL: http://codereview.chromium.org/19665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
UI by plumbing through a delegate notification. This will also fix metrics for
the "focus the URL bar" command.
This also includes some OCD URL-formatting changes to the DOM UI that I noticed.
Review URL: http://codereview.chromium.org/19455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
studio projects for creating snapshots.
Apply change http://codereview.chromium.org/19635 to chrome and webkit solution files.
Review URL: http://codereview.chromium.org/19659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Collected in setup.exe passed to chrome via return code
- Depends on an updated oem.html and JS code by Glen
BUG=1468838
Review URL: http://codereview.chromium.org/19649
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=aa
Review URL: http://codereview.chromium.org/19654
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
also cleans up the internal plugin handling some more.
Review URL: http://codereview.chromium.org/19443
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
web page to the desktop.
We receive information about the image from WebKit in the
render which includes the image URL, MIME type and a guess
as to what the file name is. If the filename is empty, we
synthesize a file name based on the URL. In all cases, we
set the file extension to the MIME type that was detected
by WebKit.
This change is the Chromium portion of image dragging. The
WebKit portion has been committed as:
http://trac.webkit.org/changeset/40294
BUG=6481 (http://crbug.com/6481)
Review URL: http://codereview.chromium.org/19417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr
Review URL: http://codereview.chromium.org/19652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
message if we don't have any scripts.
Review URL: http://codereview.chromium.org/19441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=7144
Review URL: http://codereview.chromium.org/19642
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
constants, oops.
Also some tiny reorderings and similar nonfunctional changes in order to make this class closer to its sibling NonClientView subclasses, so I can eventually refactor them all more easily.
Review URL: http://codereview.chromium.org/19447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This will re-land http://codereview.chromium.org/18390
BUG=5325
Review URL: http://codereview.chromium.org/19004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8847 0039d316-1c4b-4281-b951-d872f2087c98
|