| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jcampan
Review URL: http://codereview.chromium.org/18634
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This was not noticed since this code only builds if
CHROME_PERSONALIZATION is defined.
Review URL: http://codereview.chromium.org/18618
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
windows open. Can now create new browser windows.
Review URL: http://codereview.chromium.org/18458
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Revert "Build fix: release builds seemed to break"
Review URL: http://codereview.chromium.org/18460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an adopted CL from Evan. Original:
http://codereview.chromium.org/14504
(see original for review comments etc)
Review URL: http://codereview.chromium.org/16814
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jcampan
Review URL: http://codereview.chromium.org/18621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
disable SecondLaunch. This looks command line related.
tbr=evan
Review URL: http://codereview.chromium.org/18617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Add missing .h files in chrome_dll.vcproj.
Review URL: http://codereview.chromium.org/18605
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
scaffolding. Adds browser window controller and shim from NSWindow to BrowserWindow.
Review URL: http://codereview.chromium.org/18368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Detect logs that are unacceptable to the server, and don't
retransmit them (it won't help to send them again).
bug= 1505736
r=huanr,evanm
Review URL: http://codereview.chromium.org/18444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/18442
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ben
Review URL: http://codereview.chromium.org/18441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the constructor to the Init() function().
The virtual call in the constructor of the base class doesn't
get dispatched to the child class since we haven't started to
construct it yet. Instead, defer the call until after we've
finished creating the object.
Review URL: http://codereview.chromium.org/18601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
appropriate classes.
Review URL: http://codereview.chromium.org/18335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the new tab page, then press back in the interstitial.
The crasher would happen because the navigation controller collects (destroys) the previous tab contents when a navigation is initiated. In this case, when navigating back (by just discarding the non committed entries), it would not be expect that the tab contents would be NULL.
It seems we do not need to collect the unused tab contents on NavigateToPendingEntry() since we are collecting any unused TabContents in NavigationController::RendererDidNavigate().
BUG=6408
TEST=From the new page, enter the URL to a malware site (ex: http://ianfette.org), press Back (or close the tab), there should be no crash.
Review URL: http://codereview.chromium.org/18433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
matches Windows pixel-for-pixel except where we adjust things slightly in restored mode to look better with our frame shape, and in occasional cases where our scaling differs slightly, mainly because the Windows icon caching makes it almost impossible to tell what the "correct" Windows behavior actually is.
This depends on my oustanding "fix scaled icon problems" change.
BUG=5054
Review URL: http://codereview.chromium.org/18396
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
automatically scale the throbber and favicon to whatever size the View itself is. Notably, this does NOT change tab_renderer.cc, which _also_ draws favicons -- the former is used by app windows and the latter by standard tabs. Argh! I'm not going to bother unifying these for now even though it'd be nice, since we never scale up our tabs, just our app titlebars.
BUG=5054
Review URL: http://codereview.chromium.org/18392
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
current process's command line.
One explicit goal of this change is to *not* deal with the string/wstring issues at the API on POSIX; the functions are the same as before, which means they remain as broken as before. (I did try to fix the internals, though, so migrating the callers is now possible by adding platform-appropriate hooks.)
Review URL: http://codereview.chromium.org/18248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
file names in the download page.
BUG=6335 (crbug.com/6335 - "Download location ignored")
Review URL: http://codereview.chromium.org/18388
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pinkerton
Review URL: http://codereview.chromium.org/18386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/18384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18415
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
porting).
TEST=make sure back/forward buttons still enable/disable correctly depending on the length of the back/forward navigation list.
Review URL: http://codereview.chromium.org/18343
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18324
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
this seemed to be due to rolling forward the browser window change.
TBR=ben
Review URL: http://codereview.chromium.org/18429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
wasn't getting included before a defined(OS_WIN) check.
Review URL: http://codereview.chromium.org/18414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It appears that some logs get "stuck" trying to be sent,
so I've changed a number of DLOG() calls to LOG() calls.
I also added a bit of info to the LOG() calls, and made
minor edits.
bug=1505736
r=evanm
Review URL: http://codereview.chromium.org/18354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add missing mock_render_process_host.*.
Remove focus_manager_unittest.cc duplicate entry in unit_tests.vcproj.
Review URL: http://codereview.chromium.org/18411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Solution files changes are:
- Glue now depends on WebCore_prebuild (and not WebCore).
- WebCore depends on WebCore_prebuild.
(Reapply R8295 with the path to version.xcconfig fixed)
Review URL: http://codereview.chromium.org/18416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Solution files changes are:
- Glue now depends on WebCore_prebuild (and not WebCore).
- WebCore depends on WebCore_prebuild.
Review URL: http://codereview.chromium.org/18357
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
during the unit test which is annoying.
Review URL: http://codereview.chromium.org/18356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r8245.
TBR=ben
Review URL: http://codereview.chromium.org/18410
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16612
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
simplify the splitting work/resource work afterward.
Didn't change the actually list of included source files.
Review URL: http://codereview.chromium.org/18366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This will make it diffitult to remove the tab contents type system and to port,
so I'm sadly removing it.
Review URL: http://codereview.chromium.org/18408
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17606
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were two problems here:
a) We were adding an extra line number for the function
wrapper, but the wrapper didn't include a newline.
b) WebKit actually expects these to be one-based, not
zero-based.
So we were ending up two off.
Review URL: http://codereview.chromium.org/18199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Some files were moved and include path needed to be updated.
There are still link problems, but this gets us closer.
Review URL: http://codereview.chromium.org/18169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8264 0039d316-1c4b-4281-b951-d872f2087c98
|