summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* GTK: fix link button double free.estade@chromium.org2009-11-181-48/+28
| | | | | | | | | | | | | | | If set_normal_color was called while native_markup == normal_markup, then the string could be double freed. To fix this problem and prevent similar future mistakes, I made native_markup stdup normal_markup instead of just copying the pointer (the optimization wasn't worth the trickiness). Also, I cleaned up destruction logic. BUG=27855 TEST=tried every flavor of chrome link button: - classic theme - non classic theme - gtk theme - gtk theme system theme that has non-default link text color property Review URL: http://codereview.chromium.org/400009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32358 0039d316-1c4b-4281-b951-d872f2087c98
* DISABLING all new unpacker tests. XP try bots are failing.cira@chromium.org2009-11-182-12/+12
| | | | | | | | TBR=tony@chromium.org Review URL: http://codereview.chromium.org/399076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32357 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bug 27191 from known_crashes.txt it should be fixed nowjamesr@chromium.org2009-11-181-2/+0
| | | | | | Review URL: http://codereview.chromium.org/408007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32356 0039d316-1c4b-4281-b951-d872f2087c98
* Change two |-autorelease|ed objects to scoped_nsobject<>.rsesek@chromium.org2009-11-181-7/+6
| | | | | | | | | | | See http://codereview.chromium.org/380010/diff/1/2. BUG=27149 TEST=Style Review URL: http://codereview.chromium.org/405019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32350 0039d316-1c4b-4281-b951-d872f2087c98
* Moving gradient button cell over to cocoatest.dmaclach@chromium.org2009-11-181-14/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/404029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32348 0039d316-1c4b-4281-b951-d872f2087c98
* Parse messages.json in ExtensionUnpacker (like we do for manifest) and pass ↵cira@chromium.org2009-11-1841-97/+719
| | | | | | | | | | | | | them to sandboxed_extension_unpacker. Added unittest files for unpacker and sandboxed unpacker. TEST=Try loading any of the unpacker samples added in this CL. They should either pass, or show error and fail. BUG=27362 Review URL: http://codereview.chromium.org/390019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32345 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate the extra separator when there are no bookmarks in the bookmarks bar.mrossetti@chromium.org2009-11-182-3/+27
| | | | | | | | | BUG=27795 TEST=Start with a fresh Chrome or else remove all bookmarks. Bring up the Bookmarks menu. Observe that there is a single separator above the Other Bookmarks menu item. Add a bookmark to the bar. Bring up the Bookmarks menu. Observe that there is now a new bookmark item followed by a new separator. Remove the new bookmark and repeat the observation noting that both the bookmark and the separator have been removed. Review URL: http://codereview.chromium.org/403013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32344 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: add Extensions to the Main Menu and to the Wrench Menu.viettrungluu@chromium.org2009-11-186-113/+925
| | | | | | | | | | | | | Changes to MainMenu.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS_MAC", tag: IDC_MANAGE_EXTENSIONS, sends: -commandDispatch: to First Responder) to Main Menu -> Window, immediately below Downloads. Changes to Toolbar.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS", others as above) to Wrench Menu, immediately below Downloads. Enable Extensions menu item when no browser window is open. BUG=25423 TEST=Make sure Extensions menu items in Main Menu -> Window and in the Wrench Menu work. Also make sure the former works when no browser window is open. Review URL: http://codereview.chromium.org/399072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32342 0039d316-1c4b-4281-b951-d872f2087c98
* Drag and drop of buttons/folders from bar to bar.jrg@chromium.org2009-11-1810-31/+414
| | | | | | | | | | | | | | | | Does not include DnD to/from menus. No animations of drop destination yet. BUG=http://crbug.com/17608 TEST=Do some draggin and droppin. Confirm click still works on the marks and folders. Confirm "other bookmarks" canNOT be moved. Confirm NTP / detached bar also works for DnD. Review URL: http://codereview.chromium.org/395031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32341 0039d316-1c4b-4281-b951-d872f2087c98
* Move bookmark bar bridge unittest over to CocoaTest.dmaclach@chromium.org2009-11-181-2/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/407002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32339 0039d316-1c4b-4281-b951-d872f2087c98
* Add various tests for chrome.tabs/windows.kkania@chromium.org2009-11-186-120/+373
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/355029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32336 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes several focus issue with popup in the extensions' browser actions:jcampan@chromium.org2009-11-185-2/+41
| | | | | | | | | | | | | | | | - when opening a browser action popup, it gets the focus. - tab traversal now works in the popup - pressing esc closes the popup (if the keyboard event is not processed by the page) BUG=22654, 28087, 28086 TEST=Create an extension with a browser extension that shows a popup. Make the popup so that it has a textfield (that gets focused when the popup show) and a button. Install the extension. Open the popup, the textfield should have focus. Press tab, the focus should go to the button. Press Esc, the popup should be closed. Review URL: http://codereview.chromium.org/402036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32335 0039d316-1c4b-4281-b951-d872f2087c98
* Add an option to tree_view for whether to show lines from the root nodeian@chromium.org2009-11-181-1/+2
| | | | | | | | | | | | | to children nodes (sets TVS_LINESATROOT). Set this to false by default (maintaining existing behaviour by default), except for cookies_view where we set it to true. BUG=27657 TEST=open cookies dialog, make sure the origins have a + box next to them, and that expanding these also expands the cookies folder beneath them. Review URL: http://codereview.chromium.org/399030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32334 0039d316-1c4b-4281-b951-d872f2087c98
* Add memory commit charge reporting to the page_cycler tests.sgk@google.com2009-11-181-0/+13
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/401015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32332 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my last...jorlow@chromium.org2009-11-184-38/+68
| | | | | | Review URL: http://codereview.chromium.org/402049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32320 0039d316-1c4b-4281-b951-d872f2087c98
* Make the WebKitThread object start the WebKit thread on construction (not ↵jorlow@chromium.org2009-11-184-68/+38
| | | | | | | | | | | | | | | lazily). NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing. TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread. TEST=The WebKit thread gets spun up early in the initialization process. BUG=24144 Review URL: http://codereview.chromium.org/405007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32319 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 251.0 to 252.0chrome-bot@google.com2009-11-181-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32318 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run TabRestoreUITest.* under ThreadSanitizertimurrrr@chromium.org2009-11-181-0/+3
| | | | | | | | BUG=28115 TBR=dank Review URL: http://codereview.chromium.org/405015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32316 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Make sure the suid sandbox is owned by root.thestig@chromium.org2009-11-181-1/+2
| | | | | | | | | | If chrome-sandbox is mode 4755 but not owned by root, Chrome doesn't start up. We should abort instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/372008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32314 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add more manual Profiles tab tests.mnaganov@chromium.org2009-11-184-0/+179
| | | | | | Review URL: http://codereview.chromium.org/404002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32313 0039d316-1c4b-4281-b951-d872f2087c98
* Hold histograms in static variables instead of allocating heap.ukai@chromium.org2009-11-182-112/+94
| | | | | | | | | | | | | | | | | If instance variables holding pointers to Histograms, it would cause crash bug when the instance is torn down and the metrics services use and recording of their contents. The current "standard" patten for using Histograms includes making sure that the Histogram instances are not destroyed prematurely, held in static variables. BUG=28096 TEST=none Review URL: http://codereview.chromium.org/404022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32311 0039d316-1c4b-4281-b951-d872f2087c98
* A fix for Issue 18994.hbono@chromium.org2009-11-181-7/+29
| | | | | | | | | | | | | | This change retrieves the number of slots available for custom JumpList items to calculate the items for "Most Visited" items and for "Recently Closed" items. As written in the MSDN doc, Windows 7 changes the number of JumpList slots at run time and it truncates the items from the bottom (i.e. "Recently Closed" items) if we add more items than available ones. To fix this issue, this change assigned 60% of available JumpList slots to the "Most Visited" category and 40% to the "Recently Closed" category, respectively. (If there are not so many "Recently Closed" Items, this change increases the number of "Most Visited" items.) Also, this change sets the AppID since <http://codereview.chromium.org/385120> changes it. BUG=18994 TEST=Open a JumpList and see there are two or more "Recently Closed" items in it. Review URL: http://codereview.chromium.org/399031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32308 0039d316-1c4b-4281-b951-d872f2087c98
* Make extension popups shrink when their contents shrink.aa@chromium.org2009-11-182-5/+5
| | | | | | | | | BUG=26471 TEST=Load news example extension, see resizing goodness. Review URL: http://codereview.chromium.org/400028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32305 0039d316-1c4b-4281-b951-d872f2087c98
* Remove tabs introduced by r31197.mark@chromium.org2009-11-181-22/+22
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/402045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32304 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for BookmarkManager Test Crash test.oshima@chromium.org2009-11-181-0/+10
| | | | | | | | | | | | | | | * Test was failing because the key events were sent even after the window has been destroyed. * Make sure browser window is closed before the end of test. Test fails in BookmarkBarView without this. I think this requires a fix on browser side. Filed a bug 28046. BUG=None Test=run browser_tests --gtest_filter=*Bookmark* Review URL: http://codereview.chromium.org/397034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32286 0039d316-1c4b-4281-b951-d872f2087c98
* Fix find bar scrolling with the page after switching back to tab.simonrad@chromium.org2009-11-181-8/+7
| | | | | | | | | | | | We need to do a BrowserView::Layout() (which updates things like the bookmarks bar and the find bar) both in between the TabContents detach/attach AND after the final attach. This way, we toggle the bookmarks bar at the right time, but we still end up setting the find bar properly. R=beng BUG=27960 TEST=Navigate to a page where you can see the vertical scroll bar. Press Ctrl+F to open the find bar. Switch to another tab and then back to the original tab. Scroll down/up the page. The find bar should stay in place, not scroll with the page or disappear. Review URL: http://codereview.chromium.org/397036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32284 0039d316-1c4b-4281-b951-d872f2087c98
* Hide seccomp sandbox calls from non-x86 machinesjoel@chromium.org2009-11-181-0/+7
| | | | | | | | | | | | The seccomp sandbox is not built on ARM as it contains x86 specific code. However, there are a pair of calls to seccomp sandbox functions in the zygote initialisation, this hides those calls behind the ARCH_CPU_X86_FAMILY define. Without this the ARM build does not link. Review URL: http://codereview.chromium.org/402009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32278 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when activating a select element inside a pageaa@chromium.org2009-11-183-12/+69
| | | | | | | | | | | | | | | | action popup. With this change, select elements still don't work correctly with page actions: when you try to use them, the page action popup disappears. However, at least now, it doesn't crash. BUG=27576 TEST=Install extension in related bug. Navigate to any site and click page action. Browser should not crash. Review URL: http://codereview.chromium.org/399032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32277 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to BookmarkBubble.xib.dmaclach@chromium.org2009-11-182-764/+41
| | | | | | | | | | | | Removed explicitly set first responder that was causing autocalculate not to work. Changes to Preferences.xib Turned on the autorecalculate flag. BUG=27781 TEST=repro steps in bug Review URL: http://codereview.chromium.org/402041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32274 0039d316-1c4b-4281-b951-d872f2087c98
* Update Chromium menu button images.derat@chromium.org2009-11-182-0/+0
| | | | | | Review URL: http://codereview.chromium.org/402038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32272 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow content scripts to execute on file:// urls.finnur@chromium.org2009-11-1833-209/+230
| | | | | | | | | | | | This requires a command line flag for the page cycler tests, since those load file:// urls. BUG=27877 TEST=Bunch of tests affected. Review URL: http://codereview.chromium.org/402029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32271 0039d316-1c4b-4281-b951-d872f2087c98
* Only request full-screen once per plugin windowstuartmorgan@chromium.org2009-11-181-1/+5
| | | | | | | | | BUG=28019 TEST=Make Silverlight full screen on the Mac, then shrink it back to in-page mode; the dock should re-appear. Review URL: http://codereview.chromium.org/402028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32270 0039d316-1c4b-4281-b951-d872f2087c98
* Interpose one more Carbon function for Window disposingstuartmorgan@chromium.org2009-11-181-0/+10
| | | | | | | | | BUG=27820 TEST=Focus should return to browser window in test case from bug. Review URL: http://codereview.chromium.org/402037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32269 0039d316-1c4b-4281-b951-d872f2087c98
* Replace hard-coded media_format() methods with Google Mock methods declared ↵scherkus@chromium.org2009-11-181-3/+16
| | | | | | | | | | | | | | | | in mock_filters.h. Updated unit tests accordingly. Patch by Dominic Jodoin <dominic.jodoin@gmail.com> BUG=21040 TEST=Run the media_unittests and AudioRendererImplTest test suite in unit_tests. Ensure there is no Google Mock failures and that all tests are passing. Review URL: http://codereview.chromium.org/404016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32267 0039d316-1c4b-4281-b951-d872f2087c98
* Launch processes asynchronously so as not to block the UI thread. For now, ↵jam@chromium.org2009-11-1818-332/+486
| | | | | | | | | renderer only, I'll take care of plugin/worker/utility processes in a followup change. (relanding 32203) BUG=6844 Review URL: http://codereview.chromium.org/397031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32264 0039d316-1c4b-4281-b951-d872f2087c98
* Stop top-crasher regression by disabling WebSocketExperimentRunnerjar@chromium.org2009-11-181-0/+4
| | | | | | | | | | | | | | There was a race to destroy histograms held by an instance within WebSocketExperimentRunner, and this was causing the crash when histograms were being recorded at shutdown. See bug 28096 for re-enabling this feature. BUG=27856 r=wtc,ukai Review URL: http://codereview.chromium.org/404017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32263 0039d316-1c4b-4281-b951-d872f2087c98
* Use an explicit boolean has_new_first_party_for_cookies insteadwtc@chromium.org2009-11-189-9/+27
| | | | | | | | | | | | of an empty, invalid URL to indicate whether the first party for cookies URL needs changing when following a redirect. R=eroman BUG=25133 TEST=none Review URL: http://codereview.chromium.org/405011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32260 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser tests for the BLOCK_THIRD_PARTY_COOKIES policywtc@chromium.org2009-11-182-0/+88
| | | | | | | | | | | | to verify we allow first-party cookies in the regular and redirected cases. R=abarth,eroman BUG=25133 TEST=new browser tests are added Review URL: http://codereview.chromium.org/401009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32257 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes up TabStripControllerTests so that they work with CocoaTest.dmaclach@chromium.org2009-11-182-25/+44
| | | | | | | | | | | | Enhances BrowserTestHelper so that you can create and close the browser window. BUG=none TEST=none Review URL: http://codereview.chromium.org/402035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32253 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for parent window closing behind the bookmark bubble.dmaclach@chromium.org2009-11-185-142/+146
| | | | | | | | | BUG=27752 TEST=none Review URL: http://codereview.chromium.org/397006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32251 0039d316-1c4b-4281-b951-d872f2087c98
* Move TaskManagerMacUnitTest over to Cocoatest.dmaclach@chromium.org2009-11-181-5/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/404010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32246 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up check so that it reads correctly when it fails.dmaclach@chromium.org2009-11-181-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/399047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32245 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crashing bug around ApplicationCacheDispatcherHost::Initialize in the ↵michaeln@google.com2009-11-181-4/+8
| | | | | | | | | | | mac port. TEST=existing tests BUG=26754 Review URL: http://codereview.chromium.org/402025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32243 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the refcount on InternalGetCommandRequest stays non-zero through ↵jamesr@chromium.org2009-11-181-1/+1
| | | | | | | | | | | | | | | a PostTask The problem was that BaseSessionService::ScheduleGetLastSessionCommands() was posting a task with a InternalGetCommandsRequest* request parameter by calling NewRunnableMethod(.., &SessionBackend::ReadLastSessionCommands, request). SessnionBackend::ReadLastSessionCommands takes one parameter of type scoped_refptr<InternalGetCommandsRequest>. However, NewRunnableMethod was matching the template because an InternalGetCommandsRequest* is implicitly convertable to a scoped_refptr<InternalGetCommandsRequest> but it was not actually creating the scoped_refptr<> (and thus bumping the refcount) until the task was dispatched. By this time the refcount on the InternalGetCommandsRequest had already dropped to zero, leading to memory corruption. This fixes the problem by passing a scoped_refptr<...> in to NewRunnableMethod() to ensure that it is copied and that the refcount stays up. TEST=covered by TabRestoreUITest.RestoreIntoSameWindow - caused very intermittend failures locally BUG=none Review URL: http://codereview.chromium.org/404012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32240 0039d316-1c4b-4281-b951-d872f2087c98
* Add a string to be used in new extension promo message.mirandac@chromium.org2009-11-181-1/+4
| | | | | | | | BUG= none TEST= none Review URL: http://codereview.chromium.org/403007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32239 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32203,32204,32205 - Launch processes asynchronously so as not to ↵jam@chromium.org2009-11-1816-482/+330
| | | | | | | | | | | block the UI thread. For now, renderer only, I'll take care of plugin/worker/utility processes in a followup change. BUG=6844 Review URL: http://codereview.chromium.org/397002 Review URL: http://codereview.chromium.org/402033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32238 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32176 - Tweaks and fixes for NTP extension promo.mirandac@chromium.org2009-11-187-37/+24
| | | | | | | | | | | | | Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing. BUG= 27814, 25258, 27815 TEST= see various bugs. Review URL: http://codereview.chromium.org/385135 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/399051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32237 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK when trying to remove multiple engines from the Manage Search ↵pkasting@chromium.org2009-11-171-1/+1
| | | | | | | | | Engines dialog. Original patch by Thiago Farina (see http://codereview.chromium.org/401013 ), r=me. BUG=5227 TEST=Select multiple engines and hit "Remove" in a debug build; should not checkfail. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32223 0039d316-1c4b-4281-b951-d872f2087c98
* Fix checkfailure caused by stupidity.pkasting@chromium.org2009-11-171-1/+1
| | | | | | | | BUG=23400 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32221 0039d316-1c4b-4281-b951-d872f2087c98
* I've moved toolbar_controller_unittest over to CocoaTest which should be ↵dmaclach@chromium.org2009-11-171-23/+19
| | | | | | | | | | | | | better about cleaning things up properly. Let's see if this fixes the world. BUG=27920 TEST=none Review URL: http://codereview.chromium.org/399041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32218 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-10 21:48:28 +0000