| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=3224
Caveats:
* Did not update TabNavigation yet. Hence session restore will continue to load the tabs with empty referrer.
* Did not plumb referrer into incognito url open. (Not sure what the right thing to do is here with respect to privacy vs compatibility.)
* Did not plumb referrer throughout the automation controller. No functional impact here, but it makes the code inconsistent with the non-automation version.
Review URL: http://codereview.chromium.org/8186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
asynchronous, so we can greatly simplify the code.
Refactor BuildBloomFilter() to smaller worker functions.
Review URL: http://codereview.chromium.org/8605
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8631
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a redirect loop. We could easily use this for other errors too
if there are URLs to the help center.
BUG=http://crbug.com/2445
Review URL: http://codereview.chromium.org/8174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7995
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Revert keyword dialog to being unsorted by default, which is appropriate for users looking at search engines -- users looking for keywords can always click the column header to sort things.
BUG=3219,1358883
Review URL: http://codereview.chromium.org/8802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG = 1447656
BUG = 1391110
Review URL: http://codereview.chromium.org/8171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I have a separate change list coming to support predictive DNS resolutions,
so I pulled out a pile of mechanical changes (with no semantic changes
intendend).
r=mbelshe
Review URL: http://codereview.chromium.org/8624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
changes:Renamed ContentSection to WebContentSection to reflect changes that have already been made to the UI (prior to this change list).Renamed GeneralSection to PrivacySectionMoved various checkboxes that appear in other categories in the "Under the hood"-tab to appear under the new PrivacySection.Moved the checkbox "Use a suggestion service" from Edit Search Engines to the PrivacySection, since we don't want it in two different places. - If you check the "Use Suggest" but have a provider that doesn't support it, it will just not perform Suggest queries.The mock I was following has the Learn More link right after the text blurb, but this version has the link below the text. We need to figure out what we want to do here.
Review URL: http://codereview.chromium.org/7985
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderView does not set the value for sub frames.
As a result, we ended up resetting to NULL by updating it for any frame.
This CL should go in for both trunk and 0.3.154.x branch.
BUG=2929
TEST=Open http://fund.eastmoney.com in a tab, switch to another tab and then switch back. Encoding menu should be enabled
which tab you're in.
Review URL: http://codereview.chromium.org/8206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
states caused the window border not to be shown.
Review URL: http://codereview.chromium.org/4044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=998
Review URL: http://codereview.chromium.org/8080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
it tests.
Review URL: http://codereview.chromium.org/8176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add 'midl' Tool module.
* Filter out the default OS_WINDOWS= definition from the Hammer
modules, which messes up our build.
* Fix the $PLATFORMSDK_VISTA definition.
* Remove the current directory from the 'base' Alias (avoid cycles).
* Remove by-hand addition of .lib, .pdb and .ilk files to the target
list when build shared libraries (multiple places).
* Comment out a post-action Touch() of the themes/default resource.
(Thanks to bradnelson for many of the above individual fixes.)
Review URL: http://codereview.chromium.org/8207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(Checking in for external contributer Arthur Lussos <developer0420@gmail.com>, who is already listed in AUTHORS)
Reviewed at http://codereview.chromium.org/7946
Review URL: http://codereview.chromium.org/7993
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
called after the deserializer has been popped. This now happens in the listener thread, so post a task to the IPC thread to do it.
Review URL: http://codereview.chromium.org/8175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There doesn't appear to be a WebKit PLATFORM macro for LINUX and, since we're
in the middle of a merge, adding one isn't a great idea either. So I'm using
__linux__ here. Also, several the stubs were very temporary and since stubbing
them required getting their headers to work as well I just aliased them away.
Review URL: http://codereview.chromium.org/8131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/8170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
default browser.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
SafeBrowsingDatabaseBloom, via a command line flag(--new-safe-browsing).
Review URL: http://codereview.chromium.org/6807
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to need for the bookmark manager. Specifically:
. NativeController now delegates OnContextMenu to the
ContextMenuController.
. TableView allows a NULL model.
. TableView::SetColumns was buggy.
. Added a method that TableView invokes after painting.
. Added methods to TreeView for getting various state information.
BUG=674
TEST=make sure the various places in the UI we uses trees and table
work fine: cookies table, passwords table, task manager, bookmark
editor, search engines.
Review URL: http://codereview.chromium.org/8145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll just turn it on for google.com to start with, since I think google
is the only server supporting this experimental protocol. This doesn't
catch all the google usages, as search in Europe/Asia etc. may use a
different server, but this should get some baseline tip-o-tree usage.
After a week or two (without problems), I'll open it up by default for
all sites on the net.
r=openvcdiff
Review URL: http://codereview.chromium.org/8154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
implementation by pumping messages on its own. This fixes the problem of windowless plugins not painting on right click, and generally makes this class almost ported, other than using a generic version of events/locks.Through this change I've also cleaned up the class and hopefully made it more understandable.
Review URL: http://codereview.chromium.org/8001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- chrome/common/chrome_paths.cc
- chrome/common/logging_chrome.cc
Add these to libcommon along with:
- chrome/common/notification_registrar.cc
Patch by Paweł Hajdan jr <phajdan.jr@gmail.com>
http://codereview.chromium.org/8059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1015,1156722
Review URL: http://codereview.chromium.org/7907
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
as it looks like some users get NULL when they ask for bitmap resource.
BUG=1432071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
launch).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- to match new version
Review URL: http://codereview.chromium.org/8141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The AffReader::AddAffix() function does not reencode a "stripping prefix (or
suffix)" field of a PFX (or SFX) line.
Unfortunately, this function creates corrupted prefix (and suffix) rules for
some dictionaries whose encoding is not UTF-8 (e.g. Russian, Polish, etc.)
because a "stripping prefix (or suffix)" field isn't only a length of a prefix
(or suffix) but also it is a string to be replaced.
To solve this problem, this change branch checks the third token of an PFX (and
SFX) line represents a "stripping characters" field or a "cross product" field,
and reencode them only if the third token represents a suffix or a prefix.
Needless to say, we also have to re-create bdics and push them to our download
server to solve this issue. :)
BUG=1428
Review URL: http://codereview.chromium.org/3183
Review URL: http://codereview.chromium.org/3183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=2712
Review URL: http://codereview.chromium.org/8140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I'm TBRing this one.
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/7965
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/7930
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
class that I can use in the bookmark manager.
BUG=674
TEST=make sure drag and drop on the bookmark bar still works,
especially when moving folders around.
Review URL: http://codereview.chromium.org/8115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
translation console.
TBR=mal
Review URL: http://codereview.chromium.org/7957
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This first needs http://codereview.chromium.org/6492
(porting base/process_util).
BUG=2333
Review URL: http://codereview.chromium.org/6268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tabs displaying Loading/Untitled in Chrome. We should display the page URL
if the title of the page is blank.
Fix on these lines.
R=beng
Review URL: http://codereview.chromium.org/7905
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on the first load of a page
in a tab.
BUG=2929
TEST=Launch Chrome, go to www.google.com and make sure that the encoding menu is enabled.
Review URL: http://codereview.chromium.org/7894
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
not actually going to need FillLayout, but I'm fixing the bug in case
someone else bumps into it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a version number. This makes it easier for translators to
handle both cases.
BUG=2656
Review URL: http://codereview.chromium.org/7900
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with the enabled parameter, when it should be !enabled.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkTableModel, which will be used to show one of the following:
the children of a folder, recently bookmarked or the results of a
search. And the tree model implementation that shows the folders.
BUG=674
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/8063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
resulting from API changes.
NOTE: I'll probably submit this with a slightly later
V8; I'm still waiting for the try-finally issue to
be resolved.
Review URL: http://codereview.chromium.org/7913
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3811 0039d316-1c4b-4281-b951-d872f2087c98
|