| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This error occurs when build with GYP_DEFINES="chromeos=0 touchui=1".
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7266001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We recently added a UTF8 encoded 'official build' localized string to the About dialog, but elsewhere in the file that string is treated as containing ASCII. This causes garbage to be displayed in ie. Russian locale.
This affects Chromium builds only, since this is not done for Google Chrome builds.
BUG=87370
TEST=Open Chromium in Russian locale. No garbage should been seen in the dialog (see screenshot in bug).
Review URL: http://codereview.chromium.org/7274001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=87666
TEST=Relaunch following the steps in r90371 using a debug build. The relaunch
should succeed. You shouldn't get a message like
[42074:263:11981638314257:FATAL:sandbox_init_wrapper_mac.cc(68)] Check
failed: false.
Review URL: http://codereview.chromium.org/7273029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
all boilerplate helpers, unittests, and python server updates.
BUG=15548
TEST=None. All sync unit and integration test should still run and pass.
Review URL: http://codereview.chromium.org/7150023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
including refactoring MockTimeProvider out of media/.
BUG=None
TEST=No visible changes. Ensure that changed unittests all pass.
Review URL: http://codereview.chromium.org/7232023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7274019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
at the beginning of each sentence.
BUG=None
TEST=Manually opened keyboard and tried typing several sentences.
Review URL: http://codereview.chromium.org/7277007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=84601
TEST=no change
Review URL: http://codereview.chromium.org/7253019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=87614
TBR=rogerta
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/7277040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:16118
TEST=open "about://flags", no "multi-profiles" flag presented.
Review URL: http://codereview.chromium.org/7276033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves the OnBeforeSendHeaders signal from net_http_transaction.cc and net_cache_transaction.cc to url_request_http_job.cc. We do this for several reasons:
- deep in the http stack one URL Request can be split into several http requests
(with different byte ranges).
- We do not want to expose this implementation detail to extension authors.
- It is not sufficient to submit only the first OnBeforeSendHeaders event to
the extension: If the extension modifies the headers, this modification should
apply to all http requests.
- from an architectural perspective we do not want to go too deep in order to
allow changing the network stack implementation without being limited by the
published Extension API (needs to be backwards compatible)
BUG=60101
TEST=no
Review URL: http://codereview.chromium.org/7039010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the second Chromium patch needed to support media streams
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication. The first patch is here http://codereview.chromium.org/7192007/.
The patch contain types needed in both the render and browser process and MediaStreamDispatcher that is used for sending request from the render process to the browser process for granting a webpage access to audio input and video capture devices.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7184010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:15923
TEST=manual
Review URL: http://codereview.chromium.org/7249007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
'kContentSettingsPatterns' against BUG=87695
Review URL: http://codereview.chromium.org/7274014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=altimofeev@chromium.org
BUG=chromium-os:16313
TEST=Open chrome://settings/changePicture and verify that images are aligned perfectly.
Review URL: http://codereview.chromium.org/7230026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added framework "wait" methods and preliminary hello world tests for PP.
- Added logging of javascript console messages.
- Fixed some header ifdef guards (found in presubmit checks).
R=thestig@chromium.org,dtseng@chromium.org
BUG=82437
TEST=browser_tests --gtest_filter=*PrintPreviewWebUI*Test.*
Review URL: http://codereview.chromium.org/7013013
TBR=scr@chromium.org
Review URL: http://codereview.chromium.org/7276028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=82437
TBR=thestig@chromium.org
TEST=browser_tests
Review URL: http://codereview.chromium.org/7276024
TBR=scr@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7239023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a couple issues with the Extension.Permissions_*Cancel histograms. First, the histogram now distinguishs between installations explicitly canceled by the user and installations aborted for other reasons. The aborted installations are now recorded in Extension.Permissions_*Abort histograms. Second, this fixes an issue that caused cancelations of the uninstall prompt to be recorded in the Extension.Permissions_ReEnableCancel enum.
BUG=none
TEST=about:histograms/Extensions
Review URL: http://codereview.chromium.org/7274007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To detect 3 country code number and 10 phone number combination, added the matching pattern in phone field.
BUG=76331
TEST=Run 13_register_supershuttle.com.html
Review URL: http://codereview.chromium.org/7239019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To show tooltip text in <select> when title attribute is specified, call
|EnsureToolTip()| when popup window initialization.
BUG=12721
TEST=1, Make html file in BUG=12721. 2, Make sure tooptip is shown.
Review URL: http://codereview.chromium.org/7263010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=82437
TBR=thestig@chromium.org
TEST=browser_tests
Review URL: http://codereview.chromium.org/7276024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are from Cole.
BUG=chromium-os:13963
TEST=manual: used this in another change
Review URL: http://codereview.chromium.org/7275013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=86958
TEST=none for now
Review URL: http://codereview.chromium.org/7187023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=87642
Review URL: http://codereview.chromium.org/7272016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=87124
TEST=PrerenderHistoryTest.GetAsValue
Review URL: http://codereview.chromium.org/7253009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL enables multi-tab selection on Linux (shift+click, ctrl+click and context menu commands). Dragging multiple tabs in not implemented yet (probably on a follow up CL).
BUG=30572
TEST=NONE
Review URL: http://codereview.chromium.org/6933037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
All of this code hasn't been used in over a year and has been replaced by VideoDecodeAccelerator and it's corresponding OpenMAX implementation OmxVideoDecodeAccelerator.
BUG=none
TEST=the world still compiles
Review URL: http://codereview.chromium.org/7066071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
password can be deleted. (Instead of some random other password!)
BUG=87221
TEST=deleteting passwords when the password list is filtered (searched) works correctly
Review URL: http://codereview.chromium.org/7274015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changed to make FindBarView resizable width-wise.
BUG=None
TEST=Open a narrow popup and open the FindBar (command-F). Verify FindBar fits within the window. Resize the width of the window. Verify FindBar width adjusts accordingly.
Review URL: http://codereview.chromium.org/7253027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The test first pause the video and play it again. Then, it seek to some point in the video. This script will make sure event happens correctly.
Review URL: http://codereview.chromium.org/7230029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The message notifying user about empty file name was created. The comment in mock_chrome.js was updated with up-to-date filenames.
Nonempty file name notification + comment fix
BUG=chromium-os:16059
TEST=Try to create the file with empty filename field. The error message should be displayed.
Review URL: http://codereview.chromium.org/7253023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added framework "wait" methods and preliminary hello world tests for PP.
- Added logging of javascript console messages.
- Fixed some header ifdef guards (found in presubmit checks).
R=thestig@chromium.org,dtseng@chromium.org
BUG=82437
TEST=browser_tests --gtest_filter=*PrintPreviewWebUI*Test.*
Review URL: http://codereview.chromium.org/7013013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui/gtk/omnibox directory.
- Rename AutocompletePopupViewGtk to OmniboxPopupViewGtk.
- Move autocomplete_popup_view_gtk.* to omnibox_popup_view_gtk.*
BUG=80186
TEST=None
R=pkasting@chromium.org,evan@chromium.org
Review URL: http://codereview.chromium.org/7264012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=76442
TEST=Embedding an object with the new mime type; print preview continues to work.
Review URL: http://codereview.chromium.org/7239012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/7244002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
forks a NaCl helper.
This patch can launch earth_c.html with and without the SUID sandbox. It is enabled with the environment variable NACL_NEW_ZYGOTE.
BUG=nativeclient:480
TEST=nativeclient in-browser tests on Linux, ChromeOS
Review URL: http://codereview.chromium.org/6995121
TBR=bradchen@google.com
Review URL: http://codereview.chromium.org/7274011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch can launch earth_c.html with and without the SUID sandbox. It is enabled with the environment variable NACL_NEW_ZYGOTE.
BUG=nativeclient:480
TEST=nativeclient in-browser tests on Linux, ChromeOS
Review URL: http://codereview.chromium.org/6995121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of mixed content on the web.
These can be removed after a dev channel or two.
Review URL: http://codereview.chromium.org/7261015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issue is that the InfoBarController gets deallocated when the animation
finishes running. But, the second click event can be delievered either before or
after that happens, meaning that sometimes a zombie can be messaged. Use the
performSelector:withObject:afterDelay: hack-and-slash to "work around" this.
BUG=87201
TEST=Enter a string of a known hostname (like crash) and get "Did you mean http://crash?" on the search results page. Double click the link quickly and don't crash. Try multiple times for safety.
Review URL: http://codereview.chromium.org/7277008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=87550
TEST=See example script in the bug. Run it and it works.
Review URL: http://codereview.chromium.org/7273010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Coverity CID=13545,13546,12901,12826,13536,12445
BUG=
TEST=
Review URL: http://codereview.chromium.org/7222020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
installs and user-level installs.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7260011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
themePatternPhase when there is no tab strip.
BUG=86120
TEST=Open a find bar in a popup. Resize popup height. Verifiy find bar does not flash.
Review URL: http://codereview.chromium.org/7245010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=fischman@chromium.org
Review URL: http://codereview.chromium.org/7275010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support multi-valued profiles, hey!
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7262017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
available.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7262016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7243011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clear |old_print_pages_params_| before creating a print preview tab.
BUG=none
TEST=Open a webpage. Press Ctrl+P to display a preview tab. Once the preview tab is loaded, close the preview tab. Press Ctrl+P again on Initiator tab. A new preview tab is created and the associated preview data is displayed to the user.
Review URL: http://codereview.chromium.org/7273007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90663 0039d316-1c4b-4281-b951-d872f2087c98
|