summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Remove throttling code from the Browser process and implement throttling in ↵erg@google.com2008-10-1713-25/+185
| | | | | | | | | | | | | the Renderer. The previous way of doing throttling was just calling CloseContents() on a window to reject it. But since the Browser is notified about a window opening asynchronously, by the time the CloseContents() sends a message back to the Renderer, a bunch more windows have been opened, leading to memory exhaustion. Instead, make all RenderViews created from a parent RenderView share a counter and start refusing to create RenderViews if too many RV have been created. Every RenderView (except for the first one) is assumed to be an unrequested popup, until notified by the Browser process by either a ViewMsg_DisassociateFromPopupCount message (this RenderView is a new top level page) or a ViewMsg_DisassociatePopup message (this RenderView is a requested popup and therefore shouldn't count against the count.) BUG=3382, 2632 Review URL: http://codereview.chromium.org/7388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3568 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem where "text/xml" responses get buffered past 512 bytes, causing ↵ericroman@google.com2008-10-171-0/+1
| | | | | | | | | | the response to be truncated. BUG=3521 Review URL: http://codereview.chromium.org/7610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3567 0039d316-1c4b-4281-b951-d872f2087c98
* Make ChromeThreadTest and TextDatabaseTest inherit from PlatformTest formark@chromium.org2008-10-173-6/+24
| | | | | | | autorelease pool management on the Mac. Review URL: http://codereview.chromium.org/7640 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3563 0039d316-1c4b-4281-b951-d872f2087c98
* more bustage fixesben@chromium.org2008-10-171-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3557 0039d316-1c4b-4281-b951-d872f2087c98
* more bustage fixesben@chromium.org2008-10-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3556 0039d316-1c4b-4281-b951-d872f2087c98
* fix release bustage :-(ben@chromium.org2008-10-171-1/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3555 0039d316-1c4b-4281-b951-d872f2087c98
* attempt at fixing release bustageben@chromium.org2008-10-171-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3554 0039d316-1c4b-4281-b951-d872f2087c98
* Convert SchedulePaint and a few other methods to use gfx types.ben@chromium.org2008-10-1724-114/+90
| | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3550 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some code I accidentally left in which is causing asserts and crashes.brettw@google.com2008-10-171-6/+0
| | | | | | | | | | | close_on_deactivate_ was getting set to true which was deleting the object, causing us to crash later. The code that originally set this externally is still there, so this restores the old behavior. TEST=Press tab on any page, it shouldn't assert or crash. Review URL: http://codereview.chromium.org/7631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3549 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a potential crasher in SpellChecker Add to dictionary feature.sidchat@google.com2008-10-171-1/+2
| | | | | | | Issue=3039 Review URL: http://codereview.chromium.org/7484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3546 0039d316-1c4b-4281-b951-d872f2087c98
* testing something elseben@chromium.org2008-10-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3544 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the anti-carpet bombing dialog. More specifically a newsky@google.com2008-10-1725-204/+1378
| | | | | | | | | | | | | | | | | EventHandler now exists between the buffered event handler and download event handler. This new event handler asks the DownloadRequestManager whether the download is allowed. This may prompt the user and then the download continues or is canceled. The DownloadRequestManager receives the request on the IO thread, forwards to the UI thread, makes the decision, then notifies back on the IO thread. BUG=3422 TEST=make sure you don't see any problems downloading content. Review URL: http://codereview.chromium.org/7479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3543 0039d316-1c4b-4281-b951-d872f2087c98
* Add processing for a master profile json file on first run. Allows:cpu@google.com2008-10-175-18/+137
| | | | | | | | | - set home page / show home button - show bookmarks bar Review URL: http://codereview.chromium.org/7369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3542 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 3470, where the download tab would show the temporary name for ↵jcampan@chromium.org2008-10-175-25/+70
| | | | | | | | | | | | dangerous downloads (see download_tab_view.cc). Also fixes bug 3471, where if the same file is downloaded again while the first one is not finished, they would get the same name. For dangerous downloads, we now uniquify the path on download start (so the UI shows a file name most likely to be the final name), and on download complete (so if there 2 simultaneous downloads of the same file the last one does not overwrite the first). BUG=3470, 3471 TEST=see bugs Review URL: http://codereview.chromium.org/7395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3536 0039d316-1c4b-4281-b951-d872f2087c98
* Add some trace statements in an attempt to find the reason why a Find test ↵finnur@google.com2008-10-171-0/+23
| | | | | | | | is flaky. This will be removed once I get a run that hangs again. Review URL: http://codereview.chromium.org/7626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3534 0039d316-1c4b-4281-b951-d872f2087c98
* testing a theory...ben@chromium.org2008-10-171-2/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3533 0039d316-1c4b-4281-b951-d872f2087c98
* Removes expiring of recently closed tabs from new tab page. Also makessky@google.com2008-10-172-34/+5
| | | | | | | | | | | it so that if you restore a tab we remove from the tab restore service (this is what control-shift-t does too). BUG=2598 TEST=make sure closed tabs still show up on the new tab page. Review URL: http://codereview.chromium.org/4016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3529 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where a shelf or infobar would not be closed correctly when closing ↵glen@google.com2008-10-174-16/+21
| | | | | | | | | | | | | | a tab. The issue was because ShelfVisibilityChangedImpl is called twice, once with a null current_tab for the closing tab (via TabClosingAt), and once on selection of the new tab (via TabSelectedAt) - the first call nulls the shelves without doing a Layout, the nulled shelves then don't show up in the second call, so Layout is never called. http://crbug.com/2069 BUG=2069 Review URL: http://codereview.chromium.org/7155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3528 0039d316-1c4b-4281-b951-d872f2087c98
* Separate out most view creation from WebContents. This adds a new ↵brettw@google.com2008-10-1721-205/+363
| | | | | | | | sub-delegate to RenderViewHostDelegate which is implemented by WebContentsView. I did a lot of plumbing and moving around as a result. Review URL: http://codereview.chromium.org/6608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3527 0039d316-1c4b-4281-b951-d872f2087c98
* Removes an unneeded override.sky@google.com2008-10-172-7/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3526 0039d316-1c4b-4281-b951-d872f2087c98
* Run GRIT on all platforms.tc@google.com2008-10-171-26/+28
| | | | | | | | | | | | | * RCFLAGS may not exist in SCons environment. Use empty list if absent. * Accumulate generated files in grit_files and run RES on win32 only. Patch by Seo Sanghyeon <sanxiyn@gmail.com> originally from http://codereview.chromium.org/7247/show Review URL: http://codereview.chromium.org/7614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3517 0039d316-1c4b-4281-b951-d872f2087c98
* Start compiling a bunch of *Chromium.cpp files in our port ontc@google.com2008-10-171-1/+1
| | | | | | | | | linux. More will come once we stop using PLATFORM_GTK_. Review URL: http://codereview.chromium.org/7606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3513 0039d316-1c4b-4281-b951-d872f2087c98
* The translation lead requested that this sentence be a singletc@google.com2008-10-174-28/+43
| | | | | | | | | string, otherwise it will likely be grammatically incorrect. This is a hack until http://crbug.com/3295 is implemented. Review URL: http://codereview.chromium.org/7396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3512 0039d316-1c4b-4281-b951-d872f2087c98
* Fix interactive UI tests. ViewEventTestBase's View was using a layout ↵ben@chromium.org2008-10-171-1/+5
| | | | | | | | | manager incompatible with a non-RootView, causing coordinates to get screwed up. TBR=sky Review URL: http://codereview.chromium.org/7471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3507 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for a possible assertion caused by r3407.hbono@chromium.org2008-10-171-1/+2
| | | | | | | | When a user opens a "Fonts and Languages" dialog (through [Options] -> [Change Font and Language Settings]) and presses its "OK" button without changing anything, the debug build of Chromium raises an assert exception because the LanguagePageView::SaveChanges() function reads the value of an initialized member variable |LanguagePageView::spellcheck_language_index_selected_|. To prevent this possible assertion, this change initializes the member variable |LanguagePageView::spellcheck_language_index_selected_| to -1 in the constructor of the LanguagePageView class. Review URL: http://codereview.chromium.org/7387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3506 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing file from r3496.aa@google.com2008-10-171-0/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3499 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a bit of Greasemonkey support hidden behind the --enable-greasemonkey ↵aa@google.com2008-10-1616-18/+374
| | | | | | | | | | | | | flag. Implementation follows the pattern of the visited links system. Things still to be done: - stop using a hardcoded script directory - watch script directory and update shared memory when necessary - move file io to background thread - support for @include patterns -- now, all scripts are applied to all pages Review URL: http://codereview.chromium.org/7254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3496 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-16362-3531/+3402
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Fix weird NC painting in classic mode by removing an apparently unnecessary ↵ben@chromium.org2008-10-161-4/+1
| | | | | | | | | window style. http://crbug.com/3264 Review URL: http://codereview.chromium.org/7442 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3494 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing build: GetViewContainer changed name from under me. :)finnur@google.com2008-10-161-2/+2
| | | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/7464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in downloading files (issue 3423).finnur@google.com2008-10-161-0/+9
| | | | | | | | | | | | | | | | | | | | | | | I was finally able to reproduce a problem where we would crash when clicking Save on the Download Tab (it would also crash during animation of the items on the download shelf after switching away from the tab downloading). The reason for the crash is that if the controls on the download shelf have not been laid out once (before switching to a tab that doesn't have a download shelf), then we'll crash inside NativeControlContainer ctor when it tries to ValidateNativeControl() (it walks up the parent hierarchy trying to find the ViewContainer and ends up dereferencing a NULL pointer). This was reviewed by jcampan as http://codereview.chromium.org/7446 I had to recreate the changelist before submitting (long story). Review URL: http://codereview.chromium.org/7604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3492 0039d316-1c4b-4281-b951-d872f2087c98
* fix the scons build that broke when the hunspell dictionarytc@google.com2008-10-161-1/+1
| | | | | | | | | | | was renamed TBR=sidchat Review URL: http://codereview.chromium.org/7399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3487 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more shared_event that I missed last timeagl@chromium.org2008-10-165-5/+0
| | | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/7397 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3485 0039d316-1c4b-4281-b951-d872f2087c98
* When a mixed-content resource was loaded, we would apply the mixed-content ↵jcampan@chromium.org2008-10-162-5/+4
| | | | | | | | | | | | | | | state to the active entry, which would be the pending entry if there is one. That caused a problem in cases where a bad resource is loading and we are initiating a navigation from the browser (and therefore creating a pending entry). More details: In the GoodFrame test, the top-frame is HTTPS and we load an HTTP frame with an image. As soon as the bad frame has loaded, we navigate back (creating a pending entry). In rare cases, the notification for the mixed-content image of the HTTP frame would happen after the back action, mistakingly setting the mixed-content state on the pending entry. BUG=2742 TEST=Run the SSL UI tests 1000 times. Review URL: http://codereview.chromium.org/7440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3480 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at fixing image corruption on drag and drop.tc@google.com2008-10-162-3/+3
| | | | | | | | Fix a unittest that needs to specify the size when reading char* data. Review URL: http://codereview.chromium.org/7441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3478 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable SpellCheck tests by adding en-US-1-1.bdic to copy rule in hunspell ↵sidchat@google.com2008-10-163-3/+3
| | | | | | | | project and also add the new dictionary, en-US-1-1.bdic, in the hunspell dictionary directory. Review URL: http://codereview.chromium.org/7394 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3476 0039d316-1c4b-4281-b951-d872f2087c98
* fix unittestben@chromium.org2008-10-161-2/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3475 0039d316-1c4b-4281-b951-d872f2087c98
* Disable spellCheck tests temporarily. A new version of dictionary has been ↵sidchat@google.com2008-10-161-2/+2
| | | | | | | | updated for automatic download and use. However, buildbot cannot download anything. So, have to update the dictionary manually - otherwise, all the tests will fail. Review URL: http://codereview.chromium.org/7392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3472 0039d316-1c4b-4281-b951-d872f2087c98
* Make View::SetBounds take a const gfx::Rect& instead of a const CRect&ben@chromium.org2008-10-1697-572/+288
| | | | | | | | | | Make View::DidChangeBounds call Layout by default, eliminating this function from most places. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3471 0039d316-1c4b-4281-b951-d872f2087c98
* Return without doing anything instead of dereferencing junk in unexpected cases.mark@chromium.org2008-10-161-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3470 0039d316-1c4b-4281-b951-d872f2087c98
* Update SpellChecker to download the latest version of the bdic dictionary files.sidchat@google.com2008-10-162-3/+46
| | | | | | Review URL: http://codereview.chromium.org/6474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3468 0039d316-1c4b-4281-b951-d872f2087c98
* Updating dependencies for the following projects to fix build errors.ananta@chromium.org2008-10-161-0/+6
| | | | | | | | | | | | 1. startup tests. 2. Reliability tests. 3. Interactive UI tests. TBR=tony Review URL: http://codereview.chromium.org/7389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3466 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a bug where we were truncating the last byte of images"tc@google.com2008-10-161-1/+1
| | | | | | | | | | | due to purify regression TBR=sky Review URL: http://codereview.chromium.org/7437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3465 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the following changes to the bookmark bar context menu:sky@google.com2008-10-166-93/+91
| | | | | | | | | | | | . Nukes the open menu item. . Adds open incognito and for folders open all incognito. BUG=144 TEST=Fully test the context menu of bookmark folders/urls. Review URL: http://codereview.chromium.org/7357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3464 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser\interstitial_page.cc to the SCons build.sgk@google.com2008-10-161-1/+2
| | | | | | | Move render_widget_host_hwnd.cc to render_widget_host_win.cc. Review URL: http://codereview.chromium.org/7336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3463 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully the last of the failures. Updating the deps for ananta@chromium.org2008-10-161-0/+2
| | | | | | | | | | automated_ui_tests. TBR=darin Review URL: http://codereview.chromium.org/7386 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3460 0039d316-1c4b-4281-b951-d872f2087c98
* Updating the deps for startup test and reliability test.ananta@chromium.org2008-10-161-0/+4
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/7435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3459 0039d316-1c4b-4281-b951-d872f2087c98
* Update dependencies of the memory_test project to fix build error.ananta@chromium.org2008-10-161-0/+618
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/7434 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3458 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://code.google.com/p/chromium/issues/detail?id=146&,ananta@chromium.org2008-10-1611-93/+363
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | which was an issue with navigation attempts initiated by Flash not working correctly in Chrome. The plugin would initiate a navigation in response to a user click. This would eventually result in a call to a script on the page, which would query the history in a timer, and would end up resetting the selected URL to the original URL as the history length would not be updated as yet. The reason being the following:- 1. A Frame navigation is initiated by the renderer in response to the user click. 2. This is sent as an async message to the browser UI thread. 3. When the navigation in the browser completes we update the history info in render view asynchronously. The fix is to attempt to update the history count when we receive notifications from webkit. These include notifications for items being added to the history, navigations based on history (like history.back/forward/goto, etc). These counts continue to be updated as before from the browser as well. Added UI tests to test these cases. Bug=146 R=jam Review URL: http://codereview.chromium.org/7412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3457 0039d316-1c4b-4281-b951-d872f2087c98
* Change the prefix for unconfirmed, potentially dangerous downloads mal@chromium.org2008-10-161-1/+1
| | | | | | | | | | | | | | | | | from: dangerous_download_%d to: unconfirmed %d We want to avoid alarming names in the UI. I'm open to better suggestions for the prefix. R= jcampan@chromium.org, brian@chromium.org Review URL: http://codereview.chromium.org/7107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3455 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-05 19:56:29 +0000