| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we have a proper fix (r37722), we should revert this short term hack
(which didn't work in the end anyway).
BUG=33416
TEST=none
Review URL: http://codereview.chromium.org/562015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Watch for window minizing and app hiding so we know when pages aren't visible for reasons other than being in background tabs. Manually hide plugins in non-visible windows, as a temporary workaround for bug 34266.
BUG=30838
TEST=Minimize a window or hide the application while a Flash or Quicktime movie is playing; CPU usage should be the same as if it were in a background tab.
Review URL: http://codereview.chromium.org/563010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/11246
TEST=See http://codereview.chromium.org/556106
Review URL: http://codereview.chromium.org/552250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/561011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/553172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We'd crash at startup if a window manager that supports
EWMH had been replaced during the current X session by
one that didn't, leaving behind a property on the root
window referring to an old window.
BUG=23860
TEST=checked that the old code crashes at startup and the new code doesn't after replacing openbox with xmonad
Review URL: http://codereview.chromium.org/568002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/32703
TEST=when hiding cursor (Flash 10.1), cursor hides (but doesn't stay hidden; that's a different bug)
Review URL: http://codereview.chromium.org/560003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/548227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=knorton
Review URL: http://codereview.chromium.org/560014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Original review: http://codereview.chromium.org/564006
TBR=knorton
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whitelist.
Notably, this removes the UI entirely for Mac and Linux. We need to rebuild it.
This also guts the old system's testing, since most of it disappeared or changed radically. We should test the new stuff. I will file a followup bug for that.
There are various tiny edge cases, like if you click the address bar icon really quickly, sometimes you'll get popups without any title yet, which makes them leave gaps in the bubble that appears. We can fix that sort of thing. The critical bit I tried to ensure was that we never try to open a dead popup or use a dead TabContents, no matter what.
BUG=33314
TEST=Go visit some sites with popups and play with things
Review URL: http://codereview.chromium.org/562013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
info as well.
Original patch by Zelidrag Hornung, r=me, tweaked.
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/563007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change fixes a couple of problems needed for using a Hungarian dictionary in Chrome.
1. Use TrimWhitespace() in TrimLine()
Sorry, this is caused by my mistake that used TrimWhiteSpaceUTF8() without checking it deeply.
2. Replace morphing rules with compound rules.
it seems existing Hungarian dictionaries use (language-specific) morphing rules to handle words that have both prefixes and suffixes, e.g. "legjobb" (best). It is better to replace such (language-dependent) morphing rules with (language-independent) compound rules to avoid language-specific issues. (As far as I tested, this change fixes many quality problems caused by Hungarian compounds.)
This change also adds simple tests for our dictionary converter.
BUG=15558
TEST=unit_test --gtest_filter=ConvertDictTest*
Review URL: http://codereview.chromium.org/553087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a different language.
We are keeping the text nodes and their original text around. If another translate request arrives, we translate directly based on the text nodes and text stored.
The text nodes and original text chunks are deleted when a navigation to a new page occurs.
BUG=None
TEST=Visit a page in a foreign language. Have it translated.
On the resulting infobar, change the target language.
Make sure the page is translated correctly to the new
selected language.
Review URL: http://codereview.chromium.org/567014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Where there is no bookmark, an instruction will be displayed in the bookmark bar, which should be shrinkable when resizing the browser window.
Review URL: http://codereview.chromium.org/552211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is because the English locale 'en-US' would not match the English
language code 'en' and we would default to the 1st language, Afrikaan.
BUG=None
TEST=Test that translate when Chrome is configured in English (US and UK),
Spanish, Portuguese (Brazil and Portugal) does translate to the
language Chrome is configured to be in.
TBR=kuan
Review URL: http://codereview.chromium.org/563005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- in the process, modify to use indexes into vector of languages to communicate between infobars and delegates
BUG=31297
TEST=verify that language names in translate infobars' language buttons, dropdown lists and options are properly localized.
Review URL: http://codereview.chromium.org/566012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is somewhat tricky. setup.exe is executed by SYSTEM and
as such we cannot run the experiment. So what we do is that
if there is an interactive user logged in at the moment of
chrome upgrade we re-launch setup in her context, from then
on things proceed as in the previous case.
Other enhancements
- New experiment codes TKxx and TLxx (99% and 1% as usual)
- New experiment group TK40 and TL40 : An active user
BUG=32474
TEST=see bug
Review URL: http://codereview.chromium.org/557077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Make sure the content exception dialog (options->under the
hood->content settings->exceptions (for all tabs)) and editor work
correctly. Specifically try adding/removing and make sure they persist
correctly.
Review URL: http://codereview.chromium.org/564007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
destroyed.
BUG=none
TEST=run browser_tests, look for Gtk-CRITICAL errors.
Review URL: http://codereview.chromium.org/562009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/553161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2 of the comented out ones crash and need investigation.
The rest have output that are too big for a cookie. It's a low-priority todo to find a better solution for these since there's a decent amount of coverage provided by the tests that do run and the runs in test shell.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/548174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/551225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32384: IME within search box doesn't accept text properly
TEST=See the bug report.
Review URL: http://codereview.chromium.org/560006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Part of a larger patch to use clang to warning-check our code.
Review URL: http://codereview.chromium.org/561008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will help in diagnosing the "slow resolving host" bugs.
Users can now click an "Enable tracing" button on "chrome://net-internals/hostresolver".
This logs detailed information on the DNS requests flowing through the browser (when they were received, when they were posted to the thread pool, when they started running on the worker thread, etc...).
BUG=12754
Review URL: http://codereview.chromium.org/556094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, do a better job of making sure we don't write useless default values to disk, and we force the in-memory copy of the default prefs to never say "DEFAULT" even if a caller provides that to SetDefaultContentSetting().
BUG=32719
TEST=unittests
Review URL: http://codereview.chromium.org/562003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33907
TEST=see bug
Review URL: http://codereview.chromium.org/565005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/557088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
flakiness dashboard this hasn't failed since the day I checked
in the fix (Jan 26th).
BUG=http://crbug.com/16447
TEST=None (making a change to a test)
Review URL: http://codereview.chromium.org/565006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Make sure that when migrating away from the old pref the old pref gets erased.
* Make sure the unittest is testing all the countries in the data file.
* Make sure we explicitly handle or don't handle all the countries the unittest tests.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/565003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
would be.
BUG=none
TEST=Open advanced prefs in a Chromium build, note no big gaps.
Review URL: http://codereview.chromium.org/556096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/561003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
kNoError, commandBufferEntries -> commandBufferSize.
Added NPDevice3DContextError enumeration.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/558054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Add the extension and try dragging items around.
Review URL: http://codereview.chromium.org/553178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure we always remove it before showing a new "before translate" infobar.
BUG=34076
TEST=See bug.
Review URL: http://codereview.chromium.org/552258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=In the new bookmark manager. Right click near the lower right corner. The context menu should be shown above and to the left of the mouse.
Review URL: http://codereview.chromium.org/554139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=All current tests pass
BUG=31078
Review URL: http://codereview.chromium.org/554130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the new notification:
- Update plugin clip rect when it's not in a visible tab.
- Update plugin idle event rate when it's not in a visible tab.
- Switch the unfocus-on-tab-switch event to be based on the this new notification, instead of a browser-level broadcast.
Related changes:
- Stop sending redundant focus events to plugins.
- Send window activation to Carbon event plugins too, not just Cocoa.
- Now that plugins are getting window and tab de-focus events directly, remove the older hack to force all plugins to lose focus any window or tab loses focus.
BUG=29371, 32229, 30838
TEST=Flash should still only register keystrokes when it is in the active window+tab. Plugins in background tabs should use less CPU.
Review URL: http://codereview.chromium.org/548224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/552228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33890
TEST=none (see steps to repro in bug report)
Review URL: http://codereview.chromium.org/557085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: Change "Focus Ring" from "Default" to "None" on both scroll view and contained table view.
This does not address the ring around the first column when tabbing through.
BUG=33699
TEST=Click row in table in task manager. The table should not have a focus ring.
Review URL: http://codereview.chromium.org/559004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=33026
TEST=none
Review URL: http://codereview.chromium.org/558051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NavicationControllerTest, TaskManagerTest and BackFwdMenuModelTest.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/557063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When sorting by a column that is shared by resources in a group (e.g. process id or CPU, but not network), make sure those rows are grouped.
Also get rid of the confusing grid lines. I think we want separators between groups, but getting them to draw properly without introducing huge complexity to the code is hard.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/555177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Given a list such as
00000222223333
and an index i into that list, find the first occurrence of the value of list[i]. The current code just does a plain search. The new code does a reverse search starting at i.
The reason I am bothering to optimize this is because it is used in TaskManagerGtk::CompareImpl, pending my other cl.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33471
TEST=alt+f, alt+e
Review URL: http://codereview.chromium.org/551214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Original patch by Philippe Beaudoin (see http://codereview.chromium.org/554143 ), r=me, tweaked.
BUG=33460
TEST=Write goog in the omnibox, drag around, while pressing the left mouse button hit ESC. The selection should return to the first entry and not move as you continue to drag.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37724 0039d316-1c4b-4281-b951-d872f2087c98
|