summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Add "Show all downloads" link to download shelf.thakis@chromium.org2009-06-193-6/+341
| | | | | | | | | | | BUG=14665 TEST=Download something, check that "show all downloads" text is on shelf, click it, check that the downloads tab opens. Review URL: http://codereview.chromium.org/132073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18831 0039d316-1c4b-4281-b951-d872f2087c98
* Use correct calling convention for intercepted callcpu@google.com2009-06-191-2/+4
| | | | | | | | | | | - Thanks to zhu.she.pi@gmail.com for finding the bug BUG=14631 TEST=no test Review URL: http://codereview.chromium.org/131066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18827 0039d316-1c4b-4281-b951-d872f2087c98
* Add merging algorithm for keychain and metadata db PasswordForms, and unit ↵stuartmorgan@chromium.org2009-06-193-0/+440
| | | | | | | | | | | | tests for it. Not used quite yet, since the metadata database still needs to be integrated into PasswordStoreMac. BUG=none TEST=none Review URL: http://codereview.chromium.org/131076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18825 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak when we bail out early because of the wrong bpp.jhawkins@chromium.org2009-06-191-1/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/131118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18823 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error.pinkerton@chromium.org2009-06-191-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18822 0039d316-1c4b-4281-b951-d872f2087c98
* Make escape close the prefs window.pinkerton@chromium.org2009-06-191-0/+7
| | | | | | | | BUG=none TEST=fields in the middle of being editing should not save the value. Review URL: http://codereview.chromium.org/131113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18821 0039d316-1c4b-4281-b951-d872f2087c98
* Add a temporary command-line switch --auto-ssl-client-auth forwtc@chromium.org2009-06-194-4/+34
| | | | | | | | | | | | | | | | | automatically selecting a client certificate when an SSL server requests client authentication. This switch will be removed when we implement client certificate selection UI. Also fix some cpplint.py nits. R=jcampan BUG=http://crbug.com/318 TEST=none Review URL: http://codereview.chromium.org/131090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18819 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Enable 'Inspect element' on chromeui content while in debug mode.pfeldman@chromium.org2009-06-191-1/+6
| | | | | | Review URL: http://codereview.chromium.org/132071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18817 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make import warning dialog modal.kuchhal@chromium.org2009-06-194-3/+14
| | | | | | | | | | | | Make ImporterHost aware of the current parent window and use that as parent for the warning dialog. BUG=13481 TEST=Start Firefox, try to import profile in Chrome and make sure the warning dialog is modal. Review URL: http://codereview.chromium.org/131080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18816 0039d316-1c4b-4281-b951-d872f2087c98
* Add Print Selection support to Chrome. This change is fairly involved since ↵sverrir@google.com2009-06-1919-127/+160
| | | | | | | | | | | | | | | | this means that the printing is done async instead of the fully synchronous mode the normal full page printing is. This means we create an in memory copy of the selected text for printing. This is the next step to move to fully async printing with print frame support. This change also removes the print on demand functionality that was no longer used. BUG=http://crbug.com/1682 TEST=The print dialog on Windows now contains an option to print selection only. Test that with various pages and various selections. Review URL: http://codereview.chromium.org/125082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18815 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the mode we pull events in, so we don't fire off timers and ↵avi@google.com2009-06-191-3/+5
| | | | | | | | | | | notifications. BUG=http://crbug.com/14609 TEST=No immediate test; see that the specified crash in the bug report stops happening. Review URL: http://codereview.chromium.org/132070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18814 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'theme_dll' as a dependency of 'chrome_dll'.sgk@google.com2009-06-191-3/+1
| | | | | | | | | gyp DEPS roll so loadable_module targets ignore import libraries. BUG=none TEST=none Review URL: http://codereview.chromium.org/131109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18813 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the redness on the new Google Chrome continuous builder by notnsylvain@chromium.org2009-06-191-1/+3
| | | | | | | | running the mini_installer_tests that need to access the previous installers, since they are not accessible from this buildbot. Review URL: http://codereview.chromium.org/131070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18812 0039d316-1c4b-4281-b951-d872f2087c98
* Display an infobar alert when extension process crashes.phajdan.jr@chromium.org2009-06-199-32/+190
| | | | | | | | | | | | Also correctly handle crashes in task manager. The infobar allows user to restart the extension process. TEST=Install buildbot extension, see its content in the shelf. Open task manager, kill extension process. Click "restart" in the infobar that should appear. The extension content in the shelf should re-appear after the crash. http://crbug.com/14111 Review URL: http://codereview.chromium.org/126289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18809 0039d316-1c4b-4281-b951-d872f2087c98
* Implement restoring closed tab menu item. Reworked cross-platform code to ↵pinkerton@chromium.org2009-06-1910-80/+181
| | | | | | | | | | handle the case of restoring when there are no browsers open by making window restore re-use a given browser if it has no tabs. Removed unit test that assumes it can pass a NULL Browser. Wrote a new UI test to cover the same area, but it's disabled until another bug is fixed, and I didn't want to hold up landing this feature. Added key shortcut for "open window in incognito mode". BUG=13758 TEST=restoring closed tabs with visible windows and with no windows remaining open. Review URL: http://codereview.chromium.org/125257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18806 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary devtool_sanity_unittest.cc entries from 'unit_tests'.sgk@chromium.org2009-06-191-4/+0
| | | | | | | | BUG=14639 TEST=none Review URL: http://codereview.chromium.org/132067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18804 0039d316-1c4b-4281-b951-d872f2087c98
* Don't grant unnecessary handle privileges in OpenProcessHandle.phajdan.jr@chromium.org2009-06-193-4/+4
| | | | | | | | | This patch makes it harder for process handles with more privileges to leak to untrusted places. Review URL: http://codereview.chromium.org/125260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18802 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a valgrind error related to Zygote's CommandLine usage.craig.schlenter@chromium.org2009-06-193-5/+12
| | | | | | | | Also touch up some include guards and a comment. Review URL: http://codereview.chromium.org/131054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18801 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: New window appears to the left/up if the taskbar is on left/top.yuzo@chromium.org2009-06-193-8/+25
| | | | | | | | | | | | | | | | | Currently, the Windows taskbar (put differently, work area) is not considered in getting the last window bounds (while it is for the saved window bounds). This causes new windows (CTRL-N) appear to the left/up of the existing window instead of right/down, if the taskbar is on left or top. TESTED=gcl try, manually TEST=Place the taskbar on left or top of the screen and create new Chrome windows by CTRL-N and observe. BUG=14131 Review URL: http://codereview.chromium.org/125179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18795 0039d316-1c4b-4281-b951-d872f2087c98
* When we upgrade, discard all uploadable stats, including old logsjar@chromium.org2009-06-191-0/+8
| | | | | | | | | | | | | | We already discard all stability info when we do an upgrade to a new version, as there is less concern about stats from old versions. This change just adds the list of "old logs" (gathered in previous sessions, presumably with an old version) to the list of data that is discarded. BUG=14657 r=evanm Review URL: http://codereview.chromium.org/131089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18794 0039d316-1c4b-4281-b951-d872f2087c98
* This is a fix for a memory leak.jcampan@chromium.org2009-06-192-2/+4
| | | | | | | | | | AutocompletePopupWin would be leaked when the browser view is closed. BUG=None TEST=Make sure Chrome can be opened/closed without crasher. Review URL: http://codereview.chromium.org/132050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18791 0039d316-1c4b-4281-b951-d872f2087c98
* Change URL back to the previous one if the typed URL causes file download.yuzo@chromium.org2009-06-191-0/+7
| | | | | | | | | | | | | | | | | | This is the successor to http://codereview.chromium.org/115704 TESTED=manually TEST=Type any URL that causes download, e.g., ftp://ftp.vim.org/pub/vim/pc/gvim72.zip into the omnibox. Without this change the URL remains there. With this change, the URL is changed back to the original one. BUG=1904 Review URL: http://codereview.chromium.org/126266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18790 0039d316-1c4b-4281-b951-d872f2087c98
* Convert unit_tests.exe, with additional dependency on ffmpegsgk@google.com2009-06-191-2/+13
| | | | | | | | | | | | | | | (for dependencies on avcode-52.lib et al.). Adds additional system libraries (urlmon.lib and winmm.lib). Disables (excludes from the build) four modules with build or runtime errors: browser/debugger/devtools_sanity_unittest.cc browser/extensions/extensions_service_unittest.cc browser/password_manager/login_database_unittest.cc common/extensions/extension_unittest.cc BUG=none TEST=none Review URL: http://codereview.chromium.org/126180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18789 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher from the field seems to indicate that the page render widget host ↵jcampan@chromium.org2009-06-191-1/+2
| | | | | | | | | | view win can get the focus after the TabContents delegate has been NULLed. BUG=http://crbug.com/14599 TEST=Exercise closing tabs with on-unload handlers. Review URL: http://codereview.chromium.org/132052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18788 0039d316-1c4b-4281-b951-d872f2087c98
* Implement window open disposition for (some) navigation buttons.estade@chromium.org2009-06-196-5/+92
| | | | | | | | | | still need to do similar for link buttons and such. BUG=14518 Review URL: http://codereview.chromium.org/131071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18786 0039d316-1c4b-4281-b951-d872f2087c98
* Don't treat underscores as mnemonics in the bookmark bar.estade@chromium.org2009-06-191-2/+21
| | | | | | | | | BUG=14438 TEST=see bug Review URL: http://codereview.chromium.org/132049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18785 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18765 to try to repair perf regressionjar@chromium.org2009-06-1919-206/+97
| | | | | | | TBR=mpcomplete Review URL: http://codereview.chromium.org/131093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18784 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18730 in attempt to repair Linux UI build bustage.jar@chromium.org2009-06-192-47/+9
| | | | | | | tbr=tc Review URL: http://codereview.chromium.org/132055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18782 0039d316-1c4b-4281-b951-d872f2087c98
* Render the dragged tab contents when detaching a tab from the tabstrip in gtk.jhawkins@chromium.org2009-06-195-19/+174
| | | | | | | | BUG=none TEST=Drag a tab out of the tabstrip. If the WM has compositing enabled, the dragged tab contents should be translucent; otherwise, the contents should be opaque. Review URL: http://codereview.chromium.org/131042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18780 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Load icons with gdk instead of using PNGDecoder.estade@chromium.org2009-06-192-30/+30
| | | | | | | | BUG=14487 Review URL: http://codereview.chromium.org/131058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18779 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up BrowserWindowGtk constructor.estade@chromium.org2009-06-192-93/+104
| | | | | | Review URL: http://codereview.chromium.org/131062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18778 0039d316-1c4b-4281-b951-d872f2087c98
* Linux crash fix.kuchhal@chromium.org2009-06-192-9/+29
| | | | | | | | | | | | If no browser profile is found from which we can import, disable the import button. This was not problem on Windows since we always had IE. BUG=14489 TEST=Rename your Firefox profile dir (~/.mozilla/firefox) and make sure that the import button is disabled on the import dialog box. Review URL: http://codereview.chromium.org/131075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18777 0039d316-1c4b-4281-b951-d872f2087c98
* Handle middle click on gtk tab close button.mattm@chromium.org2009-06-192-0/+19
| | | | | | | | | BUG=14636 TEST=middle click on tab close button, left click on tab close button Review URL: http://codereview.chromium.org/131072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18776 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in LocationBarView when accessing TabContents.finnur@chromium.org2009-06-192-21/+20
| | | | | | | | | | | | | The LocationBarView asks its delegate (the ToolbarView) for a pointer to TabContents. The problem is, the ToolbarView is keeping an internal pointer to TabContents, and that pointer is not getting cleared when the last tab goes away. This can lead to shutdown crashes, which is what I think is happening in the crash in bug 14601. This is a speculative fix because we can't reproduce, but according to the dis-assembly we access a corrupt STL struct through a non-null TabContents pointer, which makes sense if the TabContents pointer is not getting cleared (or if the STL struct is being modified through multiple threads, which I have verified it is not). BUG=14601 TEST=Cannot reproduce, we'll have to watch the crash reports as they come in to see if the crash is fixed. Review URL: http://codereview.chromium.org/132043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18775 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where the window would not be shaped properly whentc@google.com2009-06-181-0/+1
| | | | | | | | | | | | | | dragging a new tab out. It would sometimes not be shaped properly when opening a new window. The code to update the window frame looks to see if the window is maximized. state_ contains information as to whether or not we're maximized, but it wasn't set yet resulting in a UMR. Review URL: http://codereview.chromium.org/131079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18773 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tab strip paint regression for tabs other than the first tab.tc@google.com2009-06-181-1/+1
| | | | | | | | | | X is already offset when we call SetBounds, so we only need to handle y offset. Review URL: http://codereview.chromium.org/131073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18767 0039d316-1c4b-4281-b951-d872f2087c98
* First draft of web resource service; fetches data from a JSON feed mirandac@chromium.org2009-06-1824-6/+770
| | | | | | | | | | and stores it in user prefs, where it can be used by the new tab page. BUG = http://crbug.com/13363 Review URL: http://codereview.chromium.org/125052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18766 0039d316-1c4b-4281-b951-d872f2087c98
* Send port-closed notification when a frame with ports unloads.mpcomplete@google.com2009-06-1819-97/+206
| | | | | | | | | | | | | Also add onLoad and onUnload chrome Event to our bindings, so we can add listeners to these events without needing a DOM. These don't hook into the window "unload" event, so we no longer prevent Chrome's sudden termination of tabs on shutdown. BUG=12686 TEST=no Review URL: http://codereview.chromium.org/125280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18765 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a max worker count of 16 per tab and 64 total. Any workers ↵jam@chromium.org2009-06-1812-62/+272
| | | | | | | | created after that are queued. Review URL: http://codereview.chromium.org/125242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18763 0039d316-1c4b-4281-b951-d872f2087c98
* Make the tabstrip transparent (doesn't paint a background) bytc@google.com2009-06-184-31/+8
| | | | | | | | | | | | | | turning the window off for the gtk_fixed that represents the tabstrip. For some reason, this caused the tabs to render relative to the top of the window, so adjust the tab painting via the event area offset. BUG=13789 Review URL: http://codereview.chromium.org/131069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18762 0039d316-1c4b-4281-b951-d872f2087c98
* Adds SendMessage to TransitionTypes.sky@chromium.org2009-06-182-0/+30
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/131052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18761 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.thakis@chromium.org2009-06-181-992/+0
| | | | | | | tbr=pinkerton git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18759 0039d316-1c4b-4281-b951-d872f2087c98
* Initial download shelf on OS X.thakis@chromium.org2009-06-1819-46/+1948
| | | | | | | | | | | | | | | | | | | This has lots of missing stuff (e.g. a custom download item view that shows download progress, the popup is the same for in-progress and completed downloads, no animation, everything looks ugly, the info bubble overlaps the shelf when it's visible, no "open download manager page" link, etc), but the basic functionality is hooked up: The shelf appears when files are downloaded, and something ugly is added to the shelf for each download. The popup's "Reveral in Finder" even works. The shelf is per-window as it should be. BUG=12500 TEST=Download something and check the shelf appears. Click the close button and make sure it disappears again. Review URL: http://codereview.chromium.org/93129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18757 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r18743, the rest of it.avi@google.com2009-06-183-0/+202
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18756 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r18743.avi@google.com2009-06-183-28/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18755 0039d316-1c4b-4281-b951-d872f2087c98
* Enable SDCH on mac/linuxjar@chromium.org2009-06-181-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Although it compiles in all builds etc., someone left the enabling code ifdef'ed in browser main. This should enable SDCH on mac/linux. To test, visit a site that supports SDCH (twice... the first time you'll get the dictionary in the background), and then do a view-cache: in front of the resulting URL, and check to see that you're getting Content-Encoding: sdch,gzip If it is not sdch encoded, then with some tiny (1%) probability, you're in a control group of a current experiment... and you can try starting your browser again... and doing another two visits. To better track the issue if you think you are in the control group, you can also visit about:histograms and you should see that a dictionary was downloaded, and then either some content was decoded, with timings in Sdch3.Experiment_Decode or was not run in SDCH and was timed in Sdch3.Experiment_Holdback. BUG=14516 r=willchan,pinkerton Review URL: http://codereview.chromium.org/131025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18753 0039d316-1c4b-4281-b951-d872f2087c98
* Import bookmarks to bookmark bar if user has not bookmarked anything yet.kuchhal@chromium.org2009-06-187-41/+52
| | | | | | | | BUG=9000 Review URL: http://codereview.chromium.org/131004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18751 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a comment I meant to update in the last change.tc@google.com2009-06-181-1/+1
| | | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/131063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18750 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an uninitialized variable that valgrind complains about.stuartmorgan@chromium.org2009-06-181-2/+4
| | | | | | | | BUG=none TEST=Tab dragging on the Mac should still work. Review URL: http://codereview.chromium.org/131055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18749 0039d316-1c4b-4281-b951-d872f2087c98
* Paint the custom frame border and round the corners.tc@google.com2009-06-183-15/+104
| | | | | | | | | | | | We apply the theme background color to the window and use a NineBox to draw the theme images around the border. BUG=13430 Review URL: http://codereview.chromium.org/131049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18748 0039d316-1c4b-4281-b951-d872f2087c98