summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fix a memory leak in Add to dictionary code.sidchat@google.com2008-09-182-0/+6
| | | | | | Review URL: http://codereview.chromium.org/3148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2379 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an old leak in tab_strip_model_unittest which had recently contributed ↵erikkay@google.com2008-09-182-59/+7
| | | | | | | | to a new leak showing up. The leak was caused by not cleaning up after ReplaceTabContents. Review URL: http://codereview.chromium.org/2954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2374 0039d316-1c4b-4281-b951-d872f2087c98
* Use libevent, second try. Changes this time:dkegel@google.com2008-09-181-0/+1
| | | | | | | | | - remove bogus include of base/completion_callback.h - add DEPS rules to allow including third_party/libevent Review URL: http://codereview.chromium.org/2964 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2371 0039d316-1c4b-4281-b951-d872f2087c98
* Make uninstall slightly less prone to chrome.exe crashes by changing default ↵kuchhal@chromium.org2008-09-183-45/+26
| | | | | | | | | | to uninstall confirmation. BUG=1215 Review URL: http://codereview.chromium.org/3128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2370 0039d316-1c4b-4281-b951-d872f2087c98
* NULL check the return value during navigation to prevent a crash.brettw@google.com2008-09-181-0/+2
| | | | | | | BUG=1384003 Review URL: http://codereview.chromium.org/2966 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2366 0039d316-1c4b-4281-b951-d872f2087c98
* Submit Issue 2965 patch by vega.james@gmail.com (jamessan)mmoss@google.com2008-09-181-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2362 0039d316-1c4b-4281-b951-d872f2087c98
* Enable safe browsing tests exercising VerifyMAC. Reorder libraries to match ↵deanm@chromium.org2008-09-183-14/+5
| | | | | | | | | the dependency order required on Posix. Patch from Pawel Hajdan Jr. Review URL: http://codereview.chromium.org/3143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2361 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in r2358.deanm@chromium.org2008-09-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2360 0039d316-1c4b-4281-b951-d872f2087c98
* Add cross platform base::SysInfo::AmountOfPhysicalMemoryMB to replace the ↵deanm@chromium.org2008-09-185-18/+6
| | | | | | | | | Windows only env_util::GetPhysicalMemoryMB. From Seo Sanghyeon. Review URL: http://codereview.chromium.org/2962 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2358 0039d316-1c4b-4281-b951-d872f2087c98
* Add some padding between the right edge of the new tab button and the left ↵ben@chromium.org2008-09-181-2/+7
| | | | | | | | | | edge of the window controls. http://crbug.com/2451 Review URL: http://codereview.chromium.org/3130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2355 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure window controls in maximized browser windows can be hit-tested as ↵ben@chromium.org2008-09-181-2/+8
| | | | | | | | | | the appropriate HTCLOSE HTMINBUTTON etc types. Buggy code would previously prevent this from happening by detecting the entire area to the right of the tabstrip as being part of the caption. http://crbug.com/2449 Review URL: http://codereview.chromium.org/2955 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2354 0039d316-1c4b-4281-b951-d872f2087c98
* Fix painting of the title bar when the window is maximized and then deactivated.ben@chromium.org2008-09-181-1/+1
| | | | | | | | http://crbug.com/2456 Review URL: http://codereview.chromium.org/2953 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2350 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make tcp_client_socket_unittest pass on Linux."evanm@google.com2008-09-181-1/+0
| | | | | | | This reverts commit d63170654d935f5a8ff6517bfacb60893f186a6b. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2347 0039d316-1c4b-4281-b951-d872f2087c98
* Make tcp_client_socket_unittest pass on Linux.dkegel@google.com2008-09-181-0/+1
| | | | | | | | | | Requires another changeset that puts libevent in third_party; I'll upload that next. This is not the final word; it makes too many syscalls per read. But it's a start. Review URL: http://codereview.chromium.org/3202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2346 0039d316-1c4b-4281-b951-d872f2087c98
* Disable part of the Importer unit test because it failsnsylvain@chromium.org2008-09-181-0/+6
| | | | | | | | | | on windows sp3 (clean machine). See bug 2466. Review URL: http://codereview.chromium.org/3127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2344 0039d316-1c4b-4281-b951-d872f2087c98
* filter out a couple of tests which seem to be causing a lot of purify crasheserikkay@google.com2008-09-181-1/+6
| | | | | | | | | BUG=http://code.google.com/p/chromium/issues/detail?id=2468 TBR=pamg Review URL: http://codereview.chromium.org/2952 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2343 0039d316-1c4b-4281-b951-d872f2087c98
* Fix GDI leak in Window object (leak of HICONs)ben@chromium.org2008-09-171-4/+12
| | | | | | | | http://crbug.com/2322 Review URL: http://codereview.chromium.org/3120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2341 0039d316-1c4b-4281-b951-d872f2087c98
* =fix stretched logokuchhal@chromium.org2008-09-171-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2338 0039d316-1c4b-4281-b951-d872f2087c98
* Rename legacy methods that were in CamelCase to unix_hacker.erg@google.com2008-09-1796-1664/+1631
| | | | | | | | | Required going through and modifying some of the code to solve name clashes. Review URL: http://codereview.chromium.org/2945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2337 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for issue 2362: On-demand update hang with "Checking for update..."finnur@google.com2008-09-171-1/+3
| | | | | | | | | We have been restructuring the message loop code lately and the MessageLoop on the file thread is not dispatching messages as it was before. I have changed the file thread to start with type MessageLoop::TYPE_IO, which pumps messages in such a way that Google Update can communicate back to us. I'm not sure what the best way to test this is but I ran the UI tests and the unit tests and they all pass. Review URL: http://codereview.chromium.org/2918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2334 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in the view unit tests.ben@chromium.org2008-09-171-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2328 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Add to dictionary unit tests temporarily. It is flaky.sidchat@google.com2008-09-171-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2327 0039d316-1c4b-4281-b951-d872f2087c98
* Don't set any cookies as a result of the Google URL Tracker update check. ↵pkasting@chromium.org2008-09-171-1/+5
| | | | | | | | | This way, if users clear their cookies and restart, they won't have to wonder why a Google cookie has suddenly mysteriously appeared. BUG=1204 Review URL: http://codereview.chromium.org/2937 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2323 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for "Add to dictionary" in the context menu.sidchat@google.com2008-09-1718-925/+1239
| | | | | | Review URL: http://codereview.chromium.org/2446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2322 0039d316-1c4b-4281-b951-d872f2087c98
* Add gears.dll to Chrome installer. Also uninstall gears.msi if new installer ↵kuchhal@chromium.org2008-09-172-0/+20
| | | | | | | | succeeds. Review URL: http://codereview.chromium.org/2938 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2320 0039d316-1c4b-4281-b951-d872f2087c98
* Include chrome SConscript.unit_tests in Linux build.tc@google.com2008-09-177-223/+262
| | | | | | | | | | | | BUG=2335 Original patch by phajdan.jr@gmail.com in http://codereview.chromium.org/2891 R=mark,sgk Review URL: http://codereview.chromium.org/2939 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2319 0039d316-1c4b-4281-b951-d872f2087c98
* Second try to make the theme dll no-executable.nsylvain@chromium.org2008-09-171-1/+1
| | | | | | | Hopefully this flag wont cause a performance regression. Review URL: http://codereview.chromium.org/3109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2318 0039d316-1c4b-4281-b951-d872f2087c98
* Include chrome/browser/SConscript in Linux build.tc@google.com2008-09-1711-264/+298
| | | | | | | | | | | | | | | In dns_host_info.cc there was probably a bug (hardcoded 1 instead of length. BUG=2333 R=mark,sgk Original patch by phajdan.jr@gmail.com at: http://codereview.chromium.org/2890 Review URL: http://codereview.chromium.org/3108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2317 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the provisional load commit notification since it duplicates the nav ↵brettw@google.com2008-09-176-61/+60
| | | | | | | | | | | entry committed notification. I had to add some more stuff to the nav entry committed structure which now looks suspiciously like the provisional load details structure. I'll see how I can improve this in a future pass. I used the new NotificationRegistrar to automatically unregister for notifications in the SSL manager, which reduces some code. Review URL: http://codereview.chromium.org/3095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2313 0039d316-1c4b-4281-b951-d872f2087c98
* Adds logging to file_util::WriteFile to figure out why writingsky@google.com2008-09-173-115/+1
| | | | | | | | | | | | | bookmarks is failing for some people. As a result of this I moved some code from common/win_util to base/win_util so that file_util_win could call it. The only changes to this code are formatting. BUG=none TEST=none Review URL: http://codereview.chromium.org/2931 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2312 0039d316-1c4b-4281-b951-d872f2087c98
* Some initial work on compiling chrome/common/ on Linux.deanm@chromium.org2008-09-1710-159/+162
| | | | | | | | | Patch from Pawel Hajdan Jr. BUG=2410 Review URL: http://codereview.chromium.org/2929 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2311 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up session restore so that it correctly deals with thesky@google.com2008-09-177-40/+232
| | | | | | | | | | | | navigation controller removing entries from the front of its list. BUG=1324021 TEST=covered by unit tests, but make sure you don't see problems with session restore. Review URL: http://codereview.chromium.org/2906 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2310 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a referenced file that doesn't exist.maruel@google.com2008-09-171-4/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2308 0039d316-1c4b-4281-b951-d872f2087c98
* Add a missing include and match a constant type better. From phajdan.jr.deanm@chromium.org2008-09-171-1/+4
| | | | | | Review URL: http://codereview.chromium.org/2922 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2300 0039d316-1c4b-4281-b951-d872f2087c98
* Don't load the font for the window title if we're not going to be painting a ↵beng@google.com2008-09-178-154/+76
| | | | | | | | | | text title bar... ie. don't load the font for the title bar for the main browser window since we won't use it - it's only used for app windows. http://crbug.com/2369 Review URL: http://codereview.chromium.org/2919 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2299 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land this fix from earlier. Since I was making the tab icon view ↵beng@google.com2008-09-173-21/+29
| | | | | | | | | | | optional, I needed to adjust the accessibility tests so that they use the right index. Don't initialize the TabIconView if we don't need to. It's expensive to create. http://crbug/2369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2298 0039d316-1c4b-4281-b951-d872f2087c98
* According to reports in the field, some XP machines have a registry flag ↵finnur@google.com2008-09-171-0/+1
| | | | | | | | | | that says "Disable UAC". Possibly, this is governed by a policy setting on corporate networks. In any case, this causes the About box to think we can't perform on-demand updates. We should never block on-demand updates on XP. Review URL: http://codereview.chromium.org/2901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2297 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back this fix until I can figure out why it;s crashing the ui testsbeng@google.com2008-09-172-28/+20
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2295 0039d316-1c4b-4281-b951-d872f2087c98
* Don't initialize the TabIconView if we don't need to. It's expensive to create.beng@google.com2008-09-172-20/+28
| | | | | | | | http://crbug.com/2369 Review URL: http://codereview.chromium.org/2917 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2294 0039d316-1c4b-4281-b951-d872f2087c98
* Revert this earlier fix since it didn't do any good.beng@google.com2008-09-172-33/+28
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2292 0039d316-1c4b-4281-b951-d872f2087c98
* Always block the request for a sub-resource with anwtc@google.com2008-09-161-14/+5
| | | | | | | | | | SSL certificate error. R=abarth,jcampan BUG=2316 Review URL: http://codereview.chromium.org/3091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2291 0039d316-1c4b-4281-b951-d872f2087c98
* Adds logging of loading/saving bookmarks to help me diagnose why somesky@google.com2008-09-163-0/+19
| | | | | | | | | | | folks are having problems. BUG=none TEST=none Review URL: http://codereview.chromium.org/2914 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2290 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bookmark bubble bug. If you changed the title, then clicked editsky@google.com2008-09-161-0/+3
| | | | | | | | | | | | the title would revert. BUG=1353834 TEST=Create a bookmark, on the bubble type in a new name, click edit and make sure the editor that pops up has the name you just typed in. Review URL: http://codereview.chromium.org/3093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2289 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://code.google.com/p/chromium/issues/detail?id=2321, which ↵iyengar@google.com2008-09-161-2/+4
| | | | | | | | | | | | | | | | was an issue with Adobe reader retaining an open handle to the chrome application folder causing issues with subsequent installs. This was because we did not specify the current directory in the ShellExecute call. This resulted in the chrome application folder becoming the current directory and hence the issue. Bug=2321 Review URL: http://codereview.chromium.org/3092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2287 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to reduce startup regression by deferring load of inactive window ↵beng@google.com2008-09-162-28/+33
| | | | | | | | | | bitmaps until they're actually needed. http://crbug.com/2369 Review URL: http://codereview.chromium.org/2907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2285 0039d316-1c4b-4281-b951-d872f2087c98
* Move gears.dll location to the versioned directory (alongside chrome.dll). Wempcomplete@google.com2008-09-161-3/+12
| | | | | | | fall back to searching the original plugins/gears/gears.dll for existing users. Review URL: http://codereview.chromium.org/2904 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2282 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of the alternate nav url fetcher from the navigation controller.brettw@google.com2008-09-164-40/+27
| | | | | | | | | | | | This changes the memory model around a bit, and it's not the most clear thing ever, not that it was before. The alternate URL fetcher is now responsible for deleting itself in most cases. BUG=2370 (Assertion when using the alternate URL tracker twice in a row) BUG=1324500 (Move the AlternateNavURLFetcher logic out of NavigationController) Review URL: http://codereview.chromium.org/2905 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2279 0039d316-1c4b-4281-b951-d872f2087c98
* Added code for personalization to the new frame classjhaas@chromium.org2008-09-162-1/+48
| | | | | | Review URL: http://codereview.chromium.org/3074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2278 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an explicit call from the NavigationController to the alternate URLbrettw@google.com2008-09-166-54/+177
| | | | | | | | | | | fetcher since there is already a notification that does this. I created a class that will automatically unregister for notifications when it goes out of scope and used it here. I think it will be useful for most consumers of notifications. Review URL: http://codereview.chromium.org/2895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2276 0039d316-1c4b-4281-b951-d872f2087c98
* Create a copy of the test directory before using it.mbelshe@google.com2008-09-161-10/+52
| | | | | | | | | The memory test alters the data, so not doing this causes the next run to be altered. Review URL: http://codereview.chromium.org/2861 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2275 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 19:49:09 +0000