| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
TBR=thakis
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1575029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(this is to avoid triggering a DCHECK on geolocation_host_content_settings_map).
Note: the bug will be fully fixed after we roll webkit to:
http://trac.webkit.org/changeset/57335
BUG=40660
TEST=GeolocationPermissionContextTests.InvalidURL
Review URL: http://codereview.chromium.org/1632006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
finding the form field in FindFormWithFormControlElement.
BUG=41013
TEST=none
Review URL: http://codereview.chromium.org/1527025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40818
TEST=NameFieldTest.FirstMiddleLast2
Review URL: http://codereview.chromium.org/1612013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Make the list items a single row.
2. Make the title of the bookmark a link
3. Make the blue bar at the top slightly higher
4. Fix indentation bug of the tree.
5. Fix hover effect for performance.
6. Use default lnf for text inputs when renaming/editing items
7. Reorder context menu items ot better match the organize menu.
8. Don't show the path in search and recent.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1643001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
postConsoleMessageToWorkerObject()
Patch contributed by caseq@chromium.org
BUG=https://bugs.webkit.org/show_bug.cgi?id=37155
TEST=none
Review URL: http://codereview.chromium.org/1528029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stop using SetInputMethodActivated cros API and use the generic API, SetImeConfig, instead. This fix greatly reduces total number of ibus_config_set_value() calls.
I'm still not 100% certain, but this change might fix crosbug.com/2471, "Fails to activate an input method occasionally." ibus-daemon seems to ignore too frequent ibus_config_set_value("general", "preload_engines", ...) calls.
BUG=crosbug.com/2471
TEST=see the bug
Review URL: http://codereview.chromium.org/1596021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to be synced.
Fix a bug where sites can be added to allow and deny lists multiple times.
BUG=none
TEST=Open two browsers with separate profiles. Request permission for notifications on a site on one. Check that the permissions are the same on the other browser.
Review URL: http://codereview.chromium.org/1578023
TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/1607012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a bug where sites can be added to allow and deny lists multiple times.
BUG=none
TEST=Open two browsers with separate profiles. Request permission for notifications on a site on one. Check that the permissions are the same on the other browser.
Review URL: http://codereview.chromium.org/1578023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
compiz. It can cause a really weird bug in the version of compiz in Ubuntu 8.04, which we still want to support.
BUG=19291
TEST=drag a window partially offscreen when using compiz in 8.04, then click in the title bar - it will not disappear or move
Review URL: http://codereview.chromium.org/1564024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/1523019.
BUG=crosbug.com/2403
TEST=ran browser_tests.
Review URL: http://codereview.chromium.org/1519030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ran browser_tests on the linux_chromeos try bot.
Review URL: http://codereview.chromium.org/1566036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
flaky on Windows.
BUG=41124
TEST=slightly greener Windows browser_tests
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/1634008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run a branded Google Chrome (without any command-line flags); check about:plugins to make sure it picks up the internal Flash. Run it with --disable-internal-flash; check about:plugins to make sure it doesn't pick up the internal Flash.
Review URL: http://codereview.chromium.org/1564025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/1623007/
BUG= 41077
TEST= none
Review URL: http://codereview.chromium.org/1517031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40803
TEST=run browser & use geolocation.
Review URL: http://codereview.chromium.org/1604023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
subsequent URLs are opened in the new window instead of the original window. This change hinges on having URL opening code return the browser into which the URL was opened so that subsequent openings may now into which browser to do so.
BUG=39901
TEST=Bring up context menu on a folder with two or more bookmarks and select "Open All in Incognito Window". Insure that all of the URLs are opened in the newly created, topmost window. Verify that no new tabs were created in the original window. Perform this same test using "Open All in New Window".
Review URL: http://codereview.chromium.org/1634004
TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/1520032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are opened in the new window instead of the original window. This change hinges on having URL opening code return the browser into which the URL was opened so that subsequent openings may now into which browser to do so.
BUG=39901
TEST=Bring up context menu on a folder with two or more bookmarks and select "Open All in Incognito Window". Insure that all of the URLs are opened in the newly created, top-most window. Verify that no new tabs were created in the original window. Perform this same test using "Open All in New Window".
Review URL: http://codereview.chromium.org/1634004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41027
TEST=None
TBR=erikkay
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40750
TEST=see bug
Review URL: http://codereview.chromium.org/1542025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37365
Review URL: http://codereview.chromium.org/1611019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No big deal, but no need to preserve the misspelling for all time.
BUG= None
TEST= None needed. No code change.
TBR= chocobo
Review URL: http://codereview.chromium.org/1508029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome://plugins/.
We need it for Flash, and we can't link directly.
BUG=none
TEST=later
Review URL: http://codereview.chromium.org/1642001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40448
TEST=copy image into gimp from sandboxed chrome. also, gtk_clipboard_dump shows image data on clipboard
Review URL: http://codereview.chromium.org/1517029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I finished my other bugs so I had some more time to look at this. We were hiding the wrong widget.
BUG=40483
TEST=TTS box doesn't have so much blank space on the left
Review URL: http://codereview.chromium.org/1568029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40022
TEST=Make sure the top left and right eges of the toolbar are rounded.
Review URL: http://codereview.chromium.org/1606021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40505
TEST=existing test under valgrind.
Review URL: http://codereview.chromium.org/1589028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Turns out queuing up a million of these is a bad bad thing.
BUG=40970
TEST=See test in bug.
Review URL: http://codereview.chromium.org/1568027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't show search item until we do a search. Leave the item there unless the user explicitly clears the search.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1619010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds menu item "Edit->AutoFill Form" and keyboard shortcut cmd-shift-a to
fill form on page with default address and/or credit card information.
Nib change: add "AutoFill Form" menu item under Edit, with command id 40024.
BUG=39491
TEST=Open browser window with autofillable form, invoke menu item with mouse or
cmd-shift-a. Expect: form fills.
Review URL: http://codereview.chromium.org/1622020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/1606021
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=feldstein
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
requests.
BUG=None
TEST=Open bookmarks manager. The tree should show the expand icons all the time (given that there are nested folders).
Review URL: http://codereview.chromium.org/1639001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This depends on http://codereview.chromium.org/1610011/show
BUG=37802
TEST=Open the bookmark manager. It should now show favicons.
Review URL: http://codereview.chromium.org/1574021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An extension needs to add chrome://favicon/ to its permission to able to load
favicon images.
WebKit changes: https://bugs.webkit.org/show_bug.cgi?id=37228
BUG=37802
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.*
Review URL: http://codereview.chromium.org/1610011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't fix the TTS padding, unfortunately I have more pressing mstone5 bugs to attend to for now (and fixing that padding doesn't look trivial).
BUG=40843
TEST=visual --- text in omnibox and popup should align; images should align as well.
Review URL: http://codereview.chromium.org/1576031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40848
TEST=none
Review URL: http://codereview.chromium.org/1530027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29148
TEST=prints documents greater than one page (to real printers)
Review URL: http://codereview.chromium.org/1520014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1622019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Nib change: in each nib, added a checkbox with the correct title and bindings to the file owner of enabled<=>canAlterDefault and value<=>isDefault
BUG=http://crbug.com/38263
TEST=as in bug
Review URL: http://codereview.chromium.org/1527022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installed (but not loaded).
Refactored theme handling code in ExtensionInstallerUI.
BUG=40847
TEST=manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44134
Review URL: http://codereview.chromium.org/1625007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40950
Review URL: http://codereview.chromium.org/1634006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces the various resources used for omnibox icons with PDF images.
The use of copies is because the field is flipped while the popup is
unflipped (and the icons get flipped to match).
BUG=37865
TEST=Icons don't look suck, look awesome when scale factor is changed under Quartz Debug.
Review URL: http://codereview.chromium.org/1629010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=40995
Review URL: http://codereview.chromium.org/1527024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pressed (ctrl-shift-a).
BUG=39491
TEST=none
Review URL: http://codereview.chromium.org/1521020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
notifications don't shrink caused a regression when the notification is of minimal size (like the one from html5rocks.com), since this is the same as the pre-show size.
BUG=40817
TEST=see bug
Review URL: http://codereview.chromium.org/1558031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of r42674).
BUG=none
TEST=Run (branded, official) Google Chrome build with --enable-internal-flash; EULA "dialog" tab should no longer be shown, and our Flash should be enabled (check about:plugins). Without --enable-internal-flash, it should still not appear in about:plugins.
Review URL: http://codereview.chromium.org/1527023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44147 0039d316-1c4b-4281-b951-d872f2087c98
|