summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Trivial: Change STL-container-is-empty check from "size() > 0" to "!empty()".pkasting@chromium.org2010-04-121-1/+1
| | | | | | | | | TBR=thakis BUG=none TEST=none Review URL: http://codereview.chromium.org/1575029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44259 0039d316-1c4b-4281-b951-d872f2087c98
* Deny geolocation access for invalid URL in geolocation_permission_context.bulach@chromium.org2010-04-122-0/+20
| | | | | | | | | | | | | | (this is to avoid triggering a DCHECK on geolocation_host_content_settings_map). Note: the bug will be fully fixed after we roll webkit to: http://trac.webkit.org/changeset/57335 BUG=40660 TEST=GeolocationPermissionContextTests.InvalidURL Review URL: http://codereview.chromium.org/1632006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44256 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/1631006dhg@chromium.org2010-04-123-52/+74
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44255 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Use FormManager::WebFormControlElementToFormField directly instead ofjhawkins@chromium.org2010-04-121-13/+4
| | | | | | | | | | | finding the form field in FindFormWithFormControlElement. BUG=41013 TEST=none Review URL: http://codereview.chromium.org/1527025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44251 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Add another variation of a middle name field for heuristics.jhawkins@chromium.org2010-04-122-1/+37
| | | | | | | | | BUG=40818 TEST=NameFieldTest.FirstMiddleLast2 Review URL: http://codereview.chromium.org/1612013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44250 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager UI fixesarv@chromium.org2010-04-126-120/+74
| | | | | | | | | | | | | | | | | | 1. Make the list items a single row. 2. Make the title of the bookmark a link 3. Make the blue bar at the top slightly higher 4. Fix indentation bug of the tree. 5. Fix hover effect for performance. 6. Use default lnf for text inputs when renaming/editing items 7. Reorder context menu items ot better match the organize menu. 8. Don't show the path in search and recent. BUG=None TEST=None Review URL: http://codereview.chromium.org/1643001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44249 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete MessageDestination parameter from ↵mnaganov@chromium.org2010-04-124-9/+13
| | | | | | | | | | | | postConsoleMessageToWorkerObject() Patch contributed by caseq@chromium.org BUG=https://bugs.webkit.org/show_bug.cgi?id=37155 TEST=none Review URL: http://codereview.chromium.org/1528029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44245 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify Preferences::SetPreloadEngines() function.yusukes@google.com2010-04-124-54/+27
| | | | | | | | | | | | | Stop using SetInputMethodActivated cros API and use the generic API, SetImeConfig, instead. This fix greatly reduces total number of ibus_config_set_value() calls. I'm still not 100% certain, but this change might fix crosbug.com/2471, "Fails to activate an input method occasionally." ibus-daemon seems to ignore too frequent ibus_config_set_value("general", "preload_engines", ...) calls. BUG=crosbug.com/2471 TEST=see the bug Review URL: http://codereview.chromium.org/1596021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44241 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44234 - Add notifications to allow desktop notification permissions ↵zork@chromium.org2010-04-125-152/+29
| | | | | | | | | | | | | | | | to be synced. Fix a bug where sites can be added to allow and deny lists multiple times. BUG=none TEST=Open two browsers with separate profiles. Request permission for notifications on a site on one. Check that the permissions are the same on the other browser. Review URL: http://codereview.chromium.org/1578023 TBR=zork@chromium.org Review URL: http://codereview.chromium.org/1607012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44235 0039d316-1c4b-4281-b951-d872f2087c98
* Add notifications to allow desktop notification permissions to be synced.zork@chromium.org2010-04-125-29/+152
| | | | | | | | | | | Fix a bug where sites can be added to allow and deny lists multiple times. BUG=none TEST=Open two browsers with separate profiles. Request permission for notifications on a site on one. Check that the permissions are the same on the other browser. Review URL: http://codereview.chromium.org/1578023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44234 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: suppress calling gdk_window_raise() on titlebar click when running ↵mdm@chromium.org2010-04-122-2/+16
| | | | | | | | | | compiz. It can cause a really weird bug in the version of compiz in Ubuntu 8.04, which we still want to support. BUG=19291 TEST=drag a window partially offscreen when using compiz in 8.04, then click in the title bar - it will not disappear or move Review URL: http://codereview.chromium.org/1564024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44233 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the obsolete function, RemoveDummyInputMethod.yusukes@google.com2010-04-121-22/+1
| | | | | | | | | | | Depends on http://codereview.chromium.org/1523019. BUG=crosbug.com/2403 TEST=ran browser_tests. Review URL: http://codereview.chromium.org/1519030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44232 0039d316-1c4b-4281-b951-d872f2087c98
* Retry of r44072, which is partially reverted by r44077.yusukes@google.com2010-04-122-4/+2
| | | | | | | | | BUG=none TEST=ran browser_tests on the linux_chromeos try bot. Review URL: http://codereview.chromium.org/1566036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44230 0039d316-1c4b-4281-b951-d872f2087c98
* Mark FindInPageControllerTest.FindMovesWhenObscuring (browser_tests) as ↵viettrungluu@chromium.org2010-04-121-0/+3
| | | | | | | | | | | | flaky on Windows. BUG=41124 TEST=slightly greener Windows browser_tests TBR=finnur@chromium.org Review URL: http://codereview.chromium.org/1634008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44226 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on internal Flash Player by default.viettrungluu@chromium.org2010-04-123-9/+8
| | | | | | | | | BUG=none TEST=Run a branded Google Chrome (without any command-line flags); check about:plugins to make sure it picks up the internal Flash. Run it with --disable-internal-flash; check about:plugins to make sure it doesn't pick up the internal Flash. Review URL: http://codereview.chromium.org/1564025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44223 0039d316-1c4b-4281-b951-d872f2087c98
* Commit fix for import from dbelenko.mirandac@chromium.org2010-04-111-17/+28
| | | | | | | | | | See http://codereview.chromium.org/1623007/ BUG= 41077 TEST= none Review URL: http://codereview.chromium.org/1517031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44217 0039d316-1c4b-4281-b951-d872f2087c98
* Work-around for DBus crash due to timers firing on the wrong thread.joth@chromium.org2010-04-111-0/+14
| | | | | | | | | BUG=40803 TEST=run browser & use geolocation. Review URL: http://codereview.chromium.org/1604023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44216 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 375.0 to 376.0chrome-release@google.com2010-04-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44208 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44201 - Once the initial URL is opened in a new window, insure that ↵mrossetti@chromium.org2010-04-117-46/+42
| | | | | | | | | | | | | | subsequent URLs are opened in the new window instead of the original window. This change hinges on having URL opening code return the browser into which the URL was opened so that subsequent openings may now into which browser to do so. BUG=39901 TEST=Bring up context menu on a folder with two or more bookmarks and select "Open All in Incognito Window". Insure that all of the URLs are opened in the newly created, topmost window. Verify that no new tabs were created in the original window. Perform this same test using "Open All in New Window". Review URL: http://codereview.chromium.org/1634004 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/1520032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44202 0039d316-1c4b-4281-b951-d872f2087c98
* Once the initial URL is opened in a new window, insure that subsequent URLs ↵mrossetti@chromium.org2010-04-117-42/+46
| | | | | | | | | | | are opened in the new window instead of the original window. This change hinges on having URL opening code return the browser into which the URL was opened so that subsequent openings may now into which browser to do so. BUG=39901 TEST=Bring up context menu on a folder with two or more bookmarks and select "Open All in Incognito Window". Insure that all of the URLs are opened in the newly created, top-most window. Verify that no new tabs were created in the original window. Perform this same test using "Open All in New Window". Review URL: http://codereview.chromium.org/1634004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44201 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 374.0 to 375.0chrome-release@google.com2010-04-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44190 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionApiTest.FavIconPermission on Linuxarv@chromium.org2010-04-101-0/+5
| | | | | | | | | BUG=41027 TEST=None TBR=erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44187 0039d316-1c4b-4281-b951-d872f2087c98
* Geo exceptions: Disable "Remove" button if no row is selected.thakis@chromium.org2010-04-101-1/+1
| | | | | | | | | BUG=40750 TEST=see bug Review URL: http://codereview.chromium.org/1542025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44186 0039d316-1c4b-4281-b951-d872f2087c98
* Delay the nudge when syncing only preferences.skrul@chromium.org2010-04-101-1/+12
| | | | | | | | BUG=37365 Review URL: http://codereview.chromium.org/1611019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44182 0039d316-1c4b-4281-b951-d872f2087c98
* Change MIUTE to MINUTE in 4 string descriptions.mal@google.com2010-04-101-4/+4
| | | | | | | | | | | No big deal, but no need to preserve the misspelling for all time. BUG= None TEST= None needed. No code change. TBR= chocobo Review URL: http://codereview.chromium.org/1508029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44181 0039d316-1c4b-4281-b951-d872f2087c98
* Make a JavaScript hook to open a new window to about:terms from ↵viettrungluu@chromium.org2010-04-102-4/+36
| | | | | | | | | | | | | chrome://plugins/. We need it for Flash, and we can't link directly. BUG=none TEST=later Review URL: http://codereview.chromium.org/1642001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44180 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: open shared memory in browser rather than renderer (like on mac).estade@chromium.org2010-04-104-8/+15
| | | | | | | | | BUG=40448 TEST=copy image into gimp from sandboxed chrome. also, gtk_clipboard_dump shows image data on clipboard Review URL: http://codereview.chromium.org/1517029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44179 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: fix TTS padding.estade@chromium.org2010-04-102-18/+21
| | | | | | | | | | | I finished my other bugs so I had some more time to look at this. We were hiding the wrong widget. BUG=40483 TEST=TTS box doesn't have so much blank space on the left Review URL: http://codereview.chromium.org/1568029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44178 0039d316-1c4b-4281-b951-d872f2087c98
* Round the top left and right edges of the toolbar.glen@chromium.org2010-04-105-18/+108
| | | | | | | | | BUG=40022 TEST=Make sure the top left and right eges of the toolbar are rounded. Review URL: http://codereview.chromium.org/1606021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44177 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory error writing to a deleted URLFetcher instance.eroman@chromium.org2010-04-102-3/+10
| | | | | | | | BUG=40505 TEST=existing test under valgrind. Review URL: http://codereview.chromium.org/1589028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44175 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Do not schedule more than one delayed call to setNeedsDisplayInRect. ↵rohitrao@chromium.org2010-04-102-6/+30
| | | | | | | | | | Turns out queuing up a million of these is a bad bad thing. BUG=40970 TEST=See test in bug. Review URL: http://codereview.chromium.org/1568027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44174 0039d316-1c4b-4281-b951-d872f2087c98
* Only show search item when there is a searchfeldstein@chromium.org2010-04-101-2/+8
| | | | | | | | | | | Don't show search item until we do a search. Leave the item there unless the user explicitly clears the search. BUG=none TEST=none Review URL: http://codereview.chromium.org/1619010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44173 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill cmd-shift-a keyboard shortcut on Mac.dhollowa@chromium.org2010-04-101-2/+54
| | | | | | | | | | | | | | | Adds menu item "Edit->AutoFill Form" and keyboard shortcut cmd-shift-a to fill form on page with default address and/or credit card information. Nib change: add "AutoFill Form" menu item under Edit, with command id 40024. BUG=39491 TEST=Open browser window with autofillable form, invoke menu item with mouse or cmd-shift-a. Expect: form fills. Review URL: http://codereview.chromium.org/1622020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44172 0039d316-1c4b-4281-b951-d872f2087c98
* Images only checkin for try server goodness.glen@chromium.org2010-04-104-0/+0
| | | | | | | | | | See http://codereview.chromium.org/1606021 BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44171 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build breakage after r44169arv@chromium.org2010-04-101-1/+0
| | | | | | | | | BUG=None TEST=None TBR=feldstein git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44170 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager - Change the tree expand icon behavior to match Brian's ↵arv@chromium.org2010-04-102-58/+15
| | | | | | | | | | | | requests. BUG=None TEST=Open bookmarks manager. The tree should show the expand icons all the time (given that there are nested folders). Review URL: http://codereview.chromium.org/1639001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44169 0039d316-1c4b-4281-b951-d872f2087c98
* Add favicons to the bookmark manager.arv@chromium.org2010-04-103-6/+4
| | | | | | | | | | | This depends on http://codereview.chromium.org/1610011/show BUG=37802 TEST=Open the bookmark manager. It should now show favicons. Review URL: http://codereview.chromium.org/1574021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44168 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extensions to access chrome://favicon/.arv@chromium.org2010-04-1014-11/+104
| | | | | | | | | | | | | | | An extension needs to add chrome://favicon/ to its permission to able to load favicon images. WebKit changes: https://bugs.webkit.org/show_bug.cgi?id=37228 BUG=37802 TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.* Review URL: http://codereview.chromium.org/1610011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44167 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: fix padding of autocomplete popup.estade@chromium.org2010-04-101-2/+2
| | | | | | | | | | | This doesn't fix the TTS padding, unfortunately I have more pressing mstone5 bugs to attend to for now (and fixing that padding doesn't look trivial). BUG=40843 TEST=visual --- text in omnibox and popup should align; images should align as well. Review URL: http://codereview.chromium.org/1576031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44163 0039d316-1c4b-4281-b951-d872f2087c98
* loosen origin requirements for apps for nowerikkay@chromium.org2010-04-101-5/+5
| | | | | | | | | BUG=40848 TEST=none Review URL: http://codereview.chromium.org/1530027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44162 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix printing somewhat.estade@chromium.org2010-04-101-26/+7
| | | | | | | | | BUG=29148 TEST=prints documents greater than one page (to real printers) Review URL: http://codereview.chromium.org/1520014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44161 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Final (late) grd string changes.jhawkins@chromium.org2010-04-093-4/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1622019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44159 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Use as default" checkboxes to the autofill dialogs on the Mac.avi@chromium.org2010-04-0910-41/+539
| | | | | | | | | | | Nib change: in each nib, added a checkbox with the correct title and bindings to the file owner of enabled<=>canAlterDefault and value<=>isDefault BUG=http://crbug.com/38263 TEST=as in bug Review URL: http://codereview.chromium.org/1527022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44158 0039d316-1c4b-4281-b951-d872f2087c98
* Show Infobar on new synced theme even if the theme was alreadyakalin@chromium.org2010-04-093-38/+69
| | | | | | | | | | | | | | | installed (but not loaded). Refactored theme handling code in ExtensionInstallerUI. BUG=40847 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44134 Review URL: http://codereview.chromium.org/1625007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44157 0039d316-1c4b-4281-b951-d872f2087c98
* At some UMA counters to log when various failures happen.skrul@chromium.org2010-04-096-14/+36
| | | | | | | | BUG=40950 Review URL: http://codereview.chromium.org/1634006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44156 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] PDF icons for omnibox.shess@chromium.org2010-04-0916-16/+6921
| | | | | | | | | | | | | Replaces the various resources used for omnibox icons with PDF images. The use of copies is because the field is flipped while the popup is unflipped (and the icons get flipped to match). BUG=37865 TEST=Icons don't look suck, look awesome when scale factor is changed under Quartz Debug. Review URL: http://codereview.chromium.org/1629010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44152 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling WorkerTest.WorkerWebSocketLayoutTests on Linux bots only.dumi@chromium.org2010-04-091-1/+5
| | | | | | | | | | TEST=none BUG=40995 Review URL: http://codereview.chromium.org/1527024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44151 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Fill the default profile when the AutoFill accelerator combo is ↵jhawkins@chromium.org2010-04-0920-34/+267
| | | | | | | | | | | pressed (ctrl-shift-a). BUG=39491 TEST=none Review URL: http://codereview.chromium.org/1521020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44149 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure small notifications get shown. Previous change to make sure ↵johnnyg@chromium.org2010-04-091-3/+6
| | | | | | | | | | | notifications don't shrink caused a regression when the notification is of minimal size (like the one from html5rocks.com), since this is the same as the pre-show size. BUG=40817 TEST=see bug Review URL: http://codereview.chromium.org/1558031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44148 0039d316-1c4b-4281-b951-d872f2087c98
* No longer display EULA when internal Flash enabled (revert r42783 and most ↵viettrungluu@chromium.org2010-04-0912-339/+0
| | | | | | | | | | | of r42674). BUG=none TEST=Run (branded, official) Google Chrome build with --enable-internal-flash; EULA "dialog" tab should no longer be shown, and our Flash should be enabled (check about:plugins). Without --enable-internal-flash, it should still not appear in about:plugins. Review URL: http://codereview.chromium.org/1527023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44147 0039d316-1c4b-4281-b951-d872f2087c98