summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Change "dll" to "plugin" where appropriate.avi@google.com2009-01-0613-110/+113
| | | | | | Review URL: http://codereview.chromium.org/16543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7617 0039d316-1c4b-4281-b951-d872f2087c98
* Applying patch for Mohamed Mansour (reviewed by pkasting): ↵finnur@google.com2009-01-066-16/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/16246 CRASH at Tab::OnMouseReleased Some strange thing is happening that it crashes for view::HitTest, it can never ENTER that function. It seems that the tab is being destroyed and as pkasting stated on IRC: "Part of this may be because our retarded Views designs can't distinguish which buttons are being held versus clicked in these sorts of cases (I filed a bug on this about a year and a half ago, internally)" When a tab has ended dragging (EndDrag), if something was being dragged and you end it, it actually cleans the TabDelegate and assigns its value to 'freed memory' which is 0xfeeefeee. Therefore it crashes while dragging, because the object no longer exists. I couldn't do if (delegate_) cause that always returns true since delegate has 0xfeeefeee. So I just changed the return type from void to bool for underlying EndDragImpl and pumped it to tab.cc. That way, we can know if a tab is destroyed or not. BUG=5819 (http://crbug.com/5819) TEST=Dragging tabs around, closing while dragging, and closing tabs. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7615 0039d316-1c4b-4281-b951-d872f2087c98
* Butcher some files to make ui_tests run 0 tests on Linux.evanm@google.com2009-01-064-30/+137
| | | | | | | Review URL: http://codereview.chromium.org/16545 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7613 0039d316-1c4b-4281-b951-d872f2087c98
* Bump for 157 dev cyclemal@chromium.org2009-01-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7610 0039d316-1c4b-4281-b951-d872f2087c98
* Make browser_uitest more Purify friendly.paulg@google.com2009-01-061-13/+16
| | | | | | Review URL: http://codereview.chromium.org/16544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7605 0039d316-1c4b-4281-b951-d872f2087c98
* clean up safe browsing pref registration by following thetc@google.com2009-01-063-5/+5
| | | | | | | | naming convention of other Local State register prefs methods. Review URL: http://codereview.chromium.org/17207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7600 0039d316-1c4b-4281-b951-d872f2087c98
* (Correctly) acquire real-time UMA stats for aggregationjar@google.com2009-01-064-20/+46
| | | | | | | | | | | | | | | Properly nest XML so existing back-end code can grok the data. Include plugin crash stats as well. Correct bug where default time for interlog transmission is set (in case the server does not provide a value). bug=1564631 r=evanm,hunar Review URL: http://codereview.chromium.org/17068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7599 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in the RenderView tests. We were responsible for deleting the ↵brettw@chromium.org2009-01-062-6/+7
| | | | | | | | | reply deserializer for sync messages, which wasn't happening for all cases. BUG=6037 Review URL: http://codereview.chromium.org/17206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7597 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a dummy ui_tests executable to chrome.xcodeproj. This doesn't currentlymark@chromium.org2009-01-061-1/+269
| | | | | | | run any tests. Review URL: http://codereview.chromium.org/17205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7596 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent files saved via the "Save as..." page menu item fromtc@google.com2009-01-066-13/+101
| | | | | | | | | | | | | | | | | being named maliciously. This is mainly copying some code from the download manager because it seems like a pretty large task to refactor the save-as code right now. Here's a demo page: http://ponderer.org/tests/title-with-.exe.html Clean up the naming convention of register prefs for the safe browsing service to make it more like the other register methods. Review URL: http://codereview.chromium.org/16523 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7595 0039d316-1c4b-4281-b951-d872f2087c98
* Build file change for enabling dynamic font support. This is a follow-up to ↵jungshik@google.com2009-01-061-0/+1
| | | | | | | | | | | | | the third_party/Webkit change ( http://codereview.chromium.org/16494). Update Webkit to 7592 in DEPS BUG=1303 Review URL: http://codereview.chromium.org/17036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7594 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of 'Add common words for each language, and remove forbidden words'sidchat@google.com2009-01-0629-476293/+515964
| | | | | | | | | Added .dic_delta files, used for adding new words to the spell check dictionaries, for 20 languages, to the trunk. In addition, forbidden words have been appended to the existing dictionary files for 4 languages. Issue=2837 Review URL: http://codereview.chromium.org/17063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7593 0039d316-1c4b-4281-b951-d872f2087c98
* * Check expand.exe exit code.kuchhal@chromium.org2009-01-061-1/+3
| | | | | | Review URL: http://codereview.chromium.org/17058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7591 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on GetVisibleVisitsInRange test on POSIX.jeremy@chromium.org2009-01-062-5/+1
| | | | | | Review URL: http://codereview.chromium.org/16524 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7590 0039d316-1c4b-4281-b951-d872f2087c98
* This is a redo of my previous notification registrar change. I saw a crash ↵brettw@chromium.org2009-01-068-89/+64
| | | | | | | | | in handling NAV_ENTRY_COMMITTED, so am changing all consumers of this to use the registrar so that it is impossible to forget to unregister. The difference is that in tab_contents I moved the removal code in RemoveInfoBar to only remove the listener if an infobar was actually removed. Review URL: http://codereview.chromium.org/16534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7589 0039d316-1c4b-4281-b951-d872f2087c98
* Move plugins to FilePaths, some cleanupavi@google.com2009-01-0635-139/+178
| | | | | | Review URL: http://codereview.chromium.org/16456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7588 0039d316-1c4b-4281-b951-d872f2087c98
* Add third_party/icu38/public/i18n to release-mode HEADER_SEARCH_PATHS inmark@chromium.org2009-01-061-0/+1
| | | | | | | chrome.xcodeproj. Fixes r7570/r7575 build break. Review URL: http://codereview.chromium.org/17204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7587 0039d316-1c4b-4281-b951-d872f2087c98
* Add using_generated_resources.scons to the build. Thistc@google.com2009-01-064-4/+4
| | | | | | | | | | | is the same as using_generated_resources.vsprops. Replace existing paths with this scons file if the SConscript file has already been converted to the using_ format. Review URL: http://codereview.chromium.org/14902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7583 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7581.brettw@chromium.org2009-01-068-61/+86
| | | | | | Review URL: http://codereview.chromium.org/17069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7582 0039d316-1c4b-4281-b951-d872f2087c98
* Change all classes that use the NOTIFY_NAV_ENTRY_COMMITTED notification to ↵brettw@chromium.org2009-01-068-86/+61
| | | | | | | | use the notification registrar. This is a speculative fix for a crash I happened to catch in a debugger where the pointer was invalid when dispatching this notifcation. It could be one of these consumers is leaking it's registered observer (the TabContents is the most suspicious one). Review URL: http://codereview.chromium.org/16519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7581 0039d316-1c4b-4281-b951-d872f2087c98
* The timing is somewhat arbitrary, but trunk is now developing a major rev ↵mal@chromium.org2009-01-061-1/+1
| | | | | | (new http, new webkit, new features). Bump Major version to 2. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7580 0039d316-1c4b-4281-b951-d872f2087c98
* * Disable test that seems to have been broken by r7570\kuchhal@chromium.org2009-01-061-1/+3
| | | | | | | | | TBR=dglazkov BUG=6030 Review URL: http://codereview.chromium.org/16530 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7577 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7574 which reverted 7570. It was an error on my part.maruel@chromium.org2009-01-066-31/+108
| | | | | | Review URL: http://codereview.chromium.org/16529 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7575 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7570.maruel@chromium.org2009-01-066-108/+31
| | | | | | Review URL: http://codereview.chromium.org/16528 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7574 0039d316-1c4b-4281-b951-d872f2087c98
* Keep trying to undo 7564.estade@chromium.org2009-01-051-2/+2
| | | | | | | | tbr=jhawkins Review URL: http://codereview.chromium.org/17062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7572 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak unit tests. Revert r7564.estade@chromium.org2009-01-0514-193/+182
| | | | | | | | tbr=jhawkins Review URL: http://codereview.chromium.org/16522 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7571 0039d316-1c4b-4281-b951-d872f2087c98
* * Port l10n_utiL and it's unit test on POSIX.jeremy@chromium.org2009-01-056-31/+108
| | | | | | | | * Bringup visit_database_unittest.cc on POSIX Review URL: http://codereview.chromium.org/17025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7570 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an uninitialized memory read that purify exposed.brettw@chromium.org2009-01-051-6/+7
| | | | | | Review URL: http://codereview.chromium.org/16520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7568 0039d316-1c4b-4281-b951-d872f2087c98
* * switch download manager to using FilePathestade@chromium.org2009-01-0513-180/+191
| | | | | | | | | * add empty() function to FilePath * implement file_util::GetFileExtensionFromPath Review URL: http://codereview.chromium.org/17032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7564 0039d316-1c4b-4281-b951-d872f2087c98
* Checking in a patch from m0interactive, reviewed by pkasting. Quote:finnur@google.com2009-01-051-1/+1
| | | | | | | | | | | | | | | Ctrl+U should show up view-source on Application shortcuts. According to pkasting in dev mailing list: "Ctrl-U for an application should do what the context menu option does: open a source tab in some normal window." Hence, made it a NEW_FOREGROUND_TAB for disposition BUG=http://crbug.com/5115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7563 0039d316-1c4b-4281-b951-d872f2087c98
* Some more GRIT refactoring.tc@google.com2009-01-059-19/+8
| | | | | | | | | | | | | | | | | | Moved the grit .vsprops file from chrome/tools/build/win/ to /tools/grit/build and renamed to using_generated_resources.vsprops. Updated non-chrome projects to use the this new vsprops file. Created a new .rules file and renamed the old one. Now there are grit_resources.rules and grit_localized_resources.rules. The latter is what we use now, but I'll be adding some grd files that use the former in a follow up change. This is just vsprops reshuffling for now. I'll also add a using_generated_resources.scons in a follow up change. Review URL: http://codereview.chromium.org/14901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7560 0039d316-1c4b-4281-b951-d872f2087c98
* Add the home page url of the ICU project to the credit file. jungshik@google.com2009-01-051-2/+3
| | | | | | Review URL: http://codereview.chromium.org/14180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7550 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the render widget unittest so it can be reused to create a render viewbrettw@chromium.org2009-01-0511-213/+538
| | | | | | | | | | | | | | | | | unit test. Change the mock render thread to save all IPC messages it is asked to send so that tests can verify that the correct ones were sent. There are some new functions that support this checking. Plumb the form state change notification through the render view so that we will correctly update the form state to the browser. Write two RenderView unit tests. One arbitrarily tests OnLoadAlternateHTMLText which I used as a testcase for my testing framework. The other tests the above form state change notification. I had to expose the timeout of this message through the RenderView API so that the test can change it. Review URL: http://codereview.chromium.org/16482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7549 0039d316-1c4b-4281-b951-d872f2087c98
* Update some comments/nits following r7486.ericroman@google.com2009-01-052-4/+5
| | | | | | Review URL: http://codereview.chromium.org/17047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7547 0039d316-1c4b-4281-b951-d872f2087c98
* Windows SCons build fixes.phajdan.jr@chromium.org2009-01-052-1/+6
| | | | | | Review URL: http://codereview.chromium.org/17054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7546 0039d316-1c4b-4281-b951-d872f2087c98
* Fix part of linking problems in Windows SCons build.phajdan.jr@chromium.org2009-01-031-0/+4
| | | | | | Review URL: http://codereview.chromium.org/17049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7540 0039d316-1c4b-4281-b951-d872f2087c98
* g++ 4.3.x doesn't seem to like forward declarationsphajdan.jr@chromium.org2009-01-031-1/+3
| | | | | | | | | | with namespace::classname so declare the forward declaration inside the appropriate namespace. Review URL: http://codereview.chromium.org/16508 Patch from Craig Schlenter. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7539 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in unzip code. I was calling the wrong close function.erikkay@google.com2008-12-311-1/+1
| | | | | | | | TBR=aa Review URL: http://codereview.chromium.org/17039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7531 0039d316-1c4b-4281-b951-d872f2087c98
* Add generic unzip support. This is to be used by extensions.erikkay@google.com2008-12-3113-9/+384
| | | | | | | depends on http://codereview.chromium.org/16605 Review URL: http://codereview.chromium.org/16487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7530 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/phajdan.jr@chromium.org2008-12-319-22/+20
| | | | | | Review URL: http://codereview.chromium.org/17016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7529 0039d316-1c4b-4281-b951-d872f2087c98
* Bug fix issue 4669 (http://code.google.com/p/chromium/issues/detail?id=4669)hclam@chromium.org2008-12-311-1/+2
| | | | | | | | | When doing a view source action and then go to other address and back to view source page. Forward addresses become backward addresses. The reason is that every view source page is treated as a standard load because content_state() is always empty. The content state should be filled in SetContentStateIfEmpty() Review URL: http://codereview.chromium.org/16221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7524 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 7508.7509 and 7510nsylvain@chromium.org2008-12-3019-375/+222
| | | | | | Review URL: http://codereview.chromium.org/17030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7514 0039d316-1c4b-4281-b951-d872f2087c98
* Add FTP unit test in preparation for portable FTP implementation.erikkay@google.com2008-12-3019-222/+375
| | | | | | | | | | | Clean up test server code. Originally from issue 12939, written by Ibrar Ahmed (ibrar.ahmed@gmail.com) Review URL: http://codereview.chromium.org/16490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7508 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusting the name of a function to make it more descriptive.avi@google.com2008-12-302-2/+2
| | | | | | Review URL: http://codereview.chromium.org/16489 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7504 0039d316-1c4b-4281-b951-d872f2087c98
* Provide and use auto startup/teardown for tracked objectsjar@google.com2008-12-301-21/+9
| | | | | | | | | | Avoid races with message loop teardown r=nsylvain Review URL: http://codereview.chromium.org/17023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7503 0039d316-1c4b-4281-b951-d872f2087c98
* Revert sdk 6.1 upgrade changes.jungshik@google.com2008-12-301-32/+31
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/17021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7501 0039d316-1c4b-4281-b951-d872f2087c98
* Change build-related files to use Windows SDK 6.1 instead of Windows SDK 6.0.jungshik@google.com2008-12-301-0/+1
| | | | | | | | | | | SDK upgrade is necessary to support dynamic/webfont because SDK 6.0 does not have t2embapi.h and t2embed.lib. SDK 6.1 is compatible with WIn XP and VS 2005 or later. FYI: http://codereview.chromium.org/14084/show is the CL for adding web/dynamic font support. Review URL: http://codereview.chromium.org/14908 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7500 0039d316-1c4b-4281-b951-d872f2087c98
* Remove compatibility #defines in string_util.hphajdan.jr@chromium.org2008-12-302-5/+8
| | | | | | Review URL: http://codereview.chromium.org/17014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7499 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Hebrew spell checker after Jeremy fixed the underlying Webkit bug.xji@chromium.org2008-12-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Related bug: http://code.google.com/p/chromium/issues/detail?id=2779 Related Webkit fix: http://trac.webkit.org/changeset/36874 Test: Steps to repro: 1) open chrome, Hebrew UI 2) make sure the spell checker is on, and is set to Hebrew 3) type some Hebrew text in a RTL box (like RTL plain text finto), and use a Hebrew word that the speller does not know. 4) type some more Without the underlying Webkit fix: the highlight marker is in a wrong location, and keeps moving while typing more words after the unrecognized one. With the underlying Webkit fix: the highlight marker is in a correct and fixed location. Review URL: http://codereview.chromium.org/16606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7496 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of 'Add common words for each language, and remove forbidden words'.sidchat@google.com2008-12-292-27/+59
| | | | | | | | | | | Updated the Dic Reader to read additional words from additional-words dictionary file, created as a text file with UTF-8 encoding, with extension dic_delta. Test: Tested with all the 21 languages that are currently supported by the spell checker and for which common/additional words have been obtained. Resulting bdic files generated have those additional words. Issue=2837. Review URL: http://codereview.chromium.org/14856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7492 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 01:46:28 +0000