summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Remove an overzealous version check from keystone_install.sh.mark@chromium.org2009-10-161-14/+14
| | | | | | | | | | | | | | The existing version check compared the previously-installed version's KSVersion with the newly-installed version's KSVersion after completing the update. In a case where a previous update attempt was interrupted after the new KSVersion was set, this check could fail on a subsequent run of the update script. BUG=none TEST=keystone_install_test.sh Review URL: http://codereview.chromium.org/287006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29296 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the ParseFeed as flaky again.finnur@chromium.org2009-10-161-9/+9
| | | | | | | | | | | | This makes me very sad... :( TBR=nsylvain BUG=23686 TEST=None Review URL: http://codereview.chromium.org/283015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29294 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure you can type in the homepage box.thomasvl@chromium.org2009-10-161-36/+36
| | | | | | | | TEST=can type in the homepage box BUG=24740 Review URL: http://codereview.chromium.org/289002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29293 0039d316-1c4b-4281-b951-d872f2087c98
* A recent change to the way we close tabs (http://codereview.chromium.org/235050)jcampan@chromium.org2009-10-161-2/+5
| | | | | | | | | | | | | | | causes Browser::CanCloseContentsAt() to be called several times for the same tab. This was triggering a DCHECK in the "download in progress" warning. BUG=24974 TEST=See bug. Test thoroughly the "dowload in progress" warning: start a big download, then close Chrome (by closing all tabs, by using the top window close button). Make sure both behaviors (continue/abort closing) work as expected. Review URL: http://codereview.chromium.org/273076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29289 0039d316-1c4b-4281-b951-d872f2087c98
* Implementations of net::CookieStore are supposed to use thread-safe ref ↵cmasone@google.com2009-10-161-15/+16
| | | | | | | | counting. My MockCookieStore objects were just statically allocated and destroyed, so it wasn't a problem, but doing things with a scoped_refptr and obeying the newly-implemented checks is more fool-proof. Review URL: http://codereview.chromium.org/273078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29288 0039d316-1c4b-4281-b951-d872f2087c98
* Landing patch from Thiago Farina:finnur@chromium.org2009-10-161-4/+4
| | | | | | | | | | | | | [Windows] Make the order of the buttons of Languages Tab to match with the Linux version. BUG=None TEST=compiled and tested on windows. Originally review as: http://codereview.chromium.org/269019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29287 0039d316-1c4b-4281-b951-d872f2087c98
* Convert devtools interfaces over to using WebString.darin@chromium.org2009-10-165-33/+59
| | | | | | | | | | | | | | | | | | | | | | | | Also converts some internal std::string usage to WebCore::String. Note: copying WebString to WebCore::String is very cheap (just increments a reference count). The ugly WebStringToString and StringToWebString calls inside the devtools implementation are temporary. Once this code moves into the WebKit API implementation, those methods will go away. I thought about changing the devtools IPCs to use string16 instead of std::string because that would avoid the UTF8 conversions. I'm not sure if that is worth it though given that UTF16 would increase the amount of data being sent over IPC. I figure this is something that could be studied later. R=pfeldman BUG=24597 TEST=none Review URL: http://codereview.chromium.org/264077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29286 0039d316-1c4b-4281-b951-d872f2087c98
* Getting rid of the final flakiness in the ParseFeed test.finnur@chromium.org2009-10-161-93/+89
| | | | | | | | | | TBR=jcampan BUG=23686 TEST=These are modifications to a browser test. Review URL: http://codereview.chromium.org/285001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29285 0039d316-1c4b-4281-b951-d872f2087c98
* Limit extensions to 1 UI surface (either Page/Browser action, but not both).finnur@chromium.org2009-10-164-1/+22
| | | | | | | | | BUG=24473 TEST=Tested using unit test. Review URL: http://codereview.chromium.org/271117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29284 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Eat mouse clicks in the findbar to prevent them from falling through ↵rohitrao@chromium.org2009-10-164-9/+131
| | | | | | | | | | to views below. BUG=http://crbug.com/22854 TEST=See test case in bug. Review URL: http://codereview.chromium.org/273041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29281 0039d316-1c4b-4281-b951-d872f2087c98
* Fix logic test in "remember my choice" dialog for protocols.avi@chromium.org2009-10-161-2/+2
| | | | | | | | | | BUG=http://crbug.com/25035 TEST=as in bug Review URL: http://codereview.chromium.org/283011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29280 0039d316-1c4b-4281-b951-d872f2087c98
* Mark some disabled tests as flaky to increase test coverage.phajdan.jr@chromium.org2009-10-165-11/+12
| | | | | | | | | | | | When a test doesn't hang or crash, it can run on the bots and on developers' machines. BUG=none TEST=none Review URL: http://codereview.chromium.org/269104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29279 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/276054 for sosa:sky@chromium.org2009-10-163-11/+8
| | | | | | | | | | Remove dependency to browser_window TEST=none BUG=none Review URL: http://codereview.chromium.org/274074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29276 0039d316-1c4b-4281-b951-d872f2087c98
* Test has failed a few times in the current waterfall display. The bug that ↵thomasvl@chromium.org2009-10-161-1/+2
| | | | | | | | | | enabled it is still open, so tagging it to that bug and just marking as flaky. TEST=none BUG=20809 Review URL: http://codereview.chromium.org/276060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29275 0039d316-1c4b-4281-b951-d872f2087c98
* Popup width and height are now dynamic.erikkay@chromium.org2009-10-1632-117/+273
| | | | | | | | | BUG=24471 TEST=none Review URL: http://codereview.chromium.org/273046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29274 0039d316-1c4b-4281-b951-d872f2087c98
* Make the auto-update script really smart. It no longer replaces the versionedmark@chromium.org2009-10-162-53/+203
| | | | | | | | | | | directory corresponding to the version that was just replaced or to any version that is in use on the system. BUG=14610 TEST=keystone_install_test.sh, and play with auto-update. A lot. Review URL: http://codereview.chromium.org/285002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29272 0039d316-1c4b-4281-b951-d872f2087c98
* Flagging as flaky again, they like to fail with some frequency on Chromium ↵thomasvl@chromium.org2009-10-161-2/+2
| | | | | | | | | | | XP but not the testers. TBR=finnur@chromium.org TEST=none BUG=23686 Review URL: http://codereview.chromium.org/284011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29271 0039d316-1c4b-4281-b951-d872f2087c98
* Disable backspace until I have fixed it in IME mode.thakis@chromium.org2009-10-161-2/+0
| | | | | | | | | BUG=25000 TEST=hit opt-u backspace. Browser should not go back a page. Browser should in fact never go back when you hit backspace. Review URL: http://codereview.chromium.org/288002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29270 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac theme provider so it returns nil when there is no theme provided ↵avi@chromium.org2009-10-162-19/+29
| | | | | | | | | | | color. Partial revert of r28560. BUG=http://crbug.com/24551 TEST=as in bug Review URL: http://codereview.chromium.org/274069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29269 0039d316-1c4b-4281-b951-d872f2087c98
* Keep the "place bookmarks here" text vertically centered on the Mac.avi@chromium.org2009-10-162-0/+15
| | | | | | | | | | | | BUG=http://crbug.com/24934 TEST=the text should be vertically centered always: - confirm text is vertically centered when bookmark bar is visible - confirm text is vertically centered when bookmark bar is set to "not visible" but on the new tab page so it is floating Review URL: http://codereview.chromium.org/281009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29267 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1618-64/+86
| | | | | | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29258 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29263 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 223.1 to 223.2chrome-bot@google.com2009-10-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29262 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29258.akalin@chromium.org2009-10-1617-84/+62
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29259 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1617-62/+84
| | | | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29258 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in incognito mode when clicking the wrench menu.nick@chromium.org2009-10-161-0/+4
| | | | | | | | | | | | This was a regression recent sync UI changes. This fixes the regression to match the old incognito mode behavior. TBR=tim@chromium.org BUG=25014 TEST=See bug. It doesn't crash anymore. Review URL: http://codereview.chromium.org/283008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29257 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29255.akalin@chromium.org2009-10-1617-84/+62
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29256 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1617-62/+84
| | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29255 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29253.akalin@chromium.org2009-10-1616-83/+61
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29254 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1616-61/+83
| | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29253 0039d316-1c4b-4281-b951-d872f2087c98
* Kill WebViewDelegate::WasOpenedByUserGesture, and instead havedarin@chromium.org2009-10-162-5/+9
| | | | | | | | | | | | the RenderView implement the logic that was using that method. R=dglazkov BUG=24598 TEST=none Review URL: http://codereview.chromium.org/276059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29250 0039d316-1c4b-4281-b951-d872f2087c98
* Move scripting / v8 related methods out of WebKit.hmhm@chromium.org2009-10-162-0/+2
| | | | | | | | | BUG=24602 TEST=Compiled Webkit/Chromium Review URL: http://codereview.chromium.org/275026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29245 0039d316-1c4b-4281-b951-d872f2087c98
* Move autofill related WebView{Delegate} methods into the WebKit API.darin@chromium.org2009-10-1614-148/+167
| | | | | | | | | | | | This CL also changes a bunch of autofill related wstring values to string16. R=jcampan BUG=24595 TEST=none Review URL: http://codereview.chromium.org/279001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29244 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 'Create an account' and 'Help' links on gaia login dialog.tim@chromium.org2009-10-161-4/+4
| | | | | | | BUG=19918,21509 Review URL: http://codereview.chromium.org/267135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29243 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable worker-script-error.html in ui_test nowlevin@chromium.org2009-10-161-2/+1
| | | | | | | | | | that r49408 form WebKit has been rolled in. BUG=23391 TEST=enabling a test Review URL: http://codereview.chromium.org/281012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29242 0039d316-1c4b-4281-b951-d872f2087c98
* Flesh out the intro and summary for the debugging tutorialkathyw@google.com2009-10-163-105/+258
| | | | | | | | | | | | so I can remove TBDs. Miscellaneous other fixes/improvements. BUG=none TEST=none TBR=aa Review URL: http://codereview.chromium.org/276055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29241 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: nick@chromium.orgakalin@chromium.org2009-10-1614-79/+58
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29240 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1614-58/+79
| | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29239 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up ClientToServerResponse::THROTTLED to the client sync loop.tim@chromium.org2009-10-1615-36/+159
| | | | | | | | TEST=Added SyncerThreadWithSyncerTest.Throttling Review URL: http://codereview.chromium.org/269101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29236 0039d316-1c4b-4281-b951-d872f2087c98
* Removing a synchronous pause that reduces impact on the IO threadhclam@chromium.org2009-10-161-36/+63
| | | | | | | | | | | | | | | | Audio pause is implemented synchronously in the browser process. This can easily choke the IO thread when user does a series of pause of looping a very short audio / video. This change will make the pause action asynchronous. The drawback of this change is that we cannot stop audio playback immediately as we receive the pause request. This is still an improvement over chrome 3.0 as the "playback" period after pause is noticably shorter. Review URL: http://codereview.chromium.org/279010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29234 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an erroneous set of tab change notifications sent whenever closing a tab ↵pkasting@chromium.org2009-10-161-3/+3
| | | | | | | | | | before the current one. GetSelectedTabContents() was using the old |selected_index_|, which was no longer the selected tab, leading to bogus notifications, which in turn caused other problems. BUG=16753 TEST=Open Chrome. Hit ctrl-t twice. Type a few letters. Middle click the tab to the left of the current tab (the first "New Tab" you opened). Your typing should not disappear. Review URL: http://codereview.chromium.org/276052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29233 0039d316-1c4b-4281-b951-d872f2087c98
* Minor fix to some instructions.kathyw@google.com2009-10-162-2/+14
| | | | | | | | | | TEST=none BUG=none TBR=aa Review URL: http://codereview.chromium.org/274073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29232 0039d316-1c4b-4281-b951-d872f2087c98
* Let cmd-` switch windows again.thakis@chromium.org2009-10-161-0/+25
| | | | | | | | | BUG=24817 TEST=Open three windows. Focus web contents. Cmd-` should cycle windows Cmd-shift-` should cycle in the other direction. Review URL: http://codereview.chromium.org/280005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29229 0039d316-1c4b-4281-b951-d872f2087c98
* Within libjingle, add an abstraction of winsock initialization.nick@chromium.org2009-10-161-0/+4
| | | | | | | | | | | | | | | | | | When building chrome, override the default implementation so that we share the winsock initialization singleton with net/base. Trigger the winsock initialization lazily in a few places. This is intended to fix a startup perf regression that appeared when sync (and libjingle) became linked into chrome.dll, rather than a separate delay-loaded sync dll. BUG=24448 TEST=Verified deferred winsock initialization via debugger. Measured before and after time of the StartupTest.PerfTest. Verified sync notification still work. Review URL: http://codereview.chromium.org/267089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29228 0039d316-1c4b-4281-b951-d872f2087c98
* Update the terms or service.laforge@chromium.org2009-10-1646-2415/+2617
| | | | | | Review URL: http://codereview.chromium.org/264074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29226 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move scripting / v8 related methods out of WebKit.h"tony@chromium.org2009-10-162-2/+0
| | | | | | | | | | This reverts commit r29218. TBR=mhm Review URL: http://codereview.chromium.org/283004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29225 0039d316-1c4b-4281-b951-d872f2087c98
* Move scripting / v8 related methods out of WebKit.hmhm@chromium.org2009-10-162-0/+2
| | | | | | | | | BUG=24602 TEST=Compiled Webkit/Chromium Review URL: http://codereview.chromium.org/275026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29218 0039d316-1c4b-4281-b951-d872f2087c98
* Added link to bookmarks example.kathyw@google.com2009-10-152-0/+10
| | | | | | | | | TBR=erikkay BUG=none TEST=none Review URL: http://codereview.chromium.org/273080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29215 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the HTTP cache to use FilePath rather than wstring for thetony@chromium.org2009-10-151-3/+3
| | | | | | | | | | disk cache path. BUG=24672 Review URL: http://codereview.chromium.org/276048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29213 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add theme install bubble.estade@chromium.org2009-10-154-2/+203
| | | | | | | | | BUG=24360 TEST=load a theme Review URL: http://codereview.chromium.org/273074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29212 0039d316-1c4b-4281-b951-d872f2087c98
* Fix status area to use icognito mode background when in icognito mode.chocobo@google.com2009-10-152-10/+18
| | | | | | | | BUG=24970 TEST=none Review URL: http://codereview.chromium.org/274070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29208 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 06:38:12 +0000