| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
It depends on http://codereview.chromium.org/126046
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155912
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
still broke valgrind ui_tests.
Review URL: http://codereview.chromium.org/159694
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
valgrind test failure.
This CL implements the second TODO item of issue 12343:
2) We should send back an ACK to the second process. If the second process doesn't get an ACK in the given timeout, it should kill the first process and go ahead and start.
The approach of this CL is to append process id to the singleton's socket filename, such as "SingletonSocket-12345", and creates a symbol link "SingletonSocket" to the real socket file. In ProcessSingleton::NotifyOtherProcess() if it's successfully connected to "SingletonSocket" but no ACK received, then the original process can be killed by its process id retrieved from the symbol link.
BUG=http://crbug.com/12343 ProcessSingleton Linux cleanups
TEST=In one terminal, launch chrome and stop the process by pressing ctrl-z, then launch chrome again in another terminal. The second chrome shall be started in 5 seconds, and the first one shall be killed.
Review URL: http://codereview.chromium.org/160436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This would remove the download list (CTRL+J) as well.
BUG=60 (http://crbug.com/60)
TEST=Download a file from the net, download shelf appears, click the download item's arrow and "Remove from list". The item removes from the shelf and list.
Review URL: http://codereview.chromium.org/155749
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
foreground.
BUG=none
TEST=tabs opened via "Open link in new tab..." should open in foreground, not background.
Review URL: http://codereview.chromium.org/155671
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/160439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A "Remove from list" link would be added to the download items and once clicked, it will remove it from the shelf and list.
BUG=60 (http://crbug.com/60)
TEST=Download a file from the net, CTRL+J. Click on "Remove from list". The item removes from the list and download shelf.
Review URL: http://codereview.chromium.org/155750
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Perhaps this got in from git not running
gcl lint / gcl presubmit checks?
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159678
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gtk_util/gtk_tree_util.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
too slow.
TEST=none
http://crbug.com/18122
Review URL: http://codereview.chromium.org/160430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159649
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/159662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the call is async, we need to manually tell Browser that
we're no longer in full screen mode.
BUG=18104
Review URL: http://codereview.chromium.org/159670
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=make your browser very narrow in debug mode, it doesn't crash
Review URL: http://codereview.chromium.org/159665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It was contributing to test flakiness. I also updated a comment explaining why the code doesn't kill the plugin process.
TEST=none
http://crbug.com/18108
Review URL: http://codereview.chromium.org/159602
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally reviewed at: http://codereview.chromium.org/159642
Patch by Anton Muhin
R=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17632
Review URL: http://codereview.chromium.org/159664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18071
Review URL: http://codereview.chromium.org/160422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159657
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also reverting 22065/22046/22041 which are changes to knowncrashes.txt.
TBR=huanr
Review URL: http://codereview.chromium.org/160418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a few bugs of button sensitivity not updating when it should.
Add the unittest to the valgrind/unit_tests.gtest_linux.txt list since Gtk is
causing UninitCondition errors when run with no DISPLAY.
BUG=11507
BUG=15445
Review URL: http://codereview.chromium.org/160420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the issues caused by static_cast<ChromeURLRequestContext*>.
There were assumptions in the code that a URLRequestContext*
will always be ChromeURLRequestContext* and resulting
'static_cast's. This assumption is no longer true. Instead,
URLlRequestContext now has a member GetChromeURLRequestContext
that returns a ChromeURLRequestContext* if it really that type.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/18085
Review URL: http://codereview.chromium.org/159658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18025
Review URL: http://codereview.chromium.org/160369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ownership of its list of subviews. The subviews of the TabStripView are
now generated directly (in appropriate z-order) from a list of permanent
subviews (e.g., the new tab button) and the list of tabs. In general,
this patch seems to make tab manipulation much more stable. Patch from
Viet-Trung Luu (viettrungluu@gmail.com)
BUG=14913
TEST=open/move/close/duplicate/rip/etc. tabs and observe; also check context
menus
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=sgk
BUG=none
TEST=building interactive_ui_tests should build chrome
Review URL: http://codereview.chromium.org/160409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=pkasting
BUG=18079
TEST=covered by TabDraggingTest.Tab2OutOfTabStrip
Review URL: http://codereview.chromium.org/160412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 91bd4c1a4703db44ea45852bf2f62822e1ded743, which caused valgrind errors.
TBR=erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
targeting an existing window. Makes things much nicer.
BUG=14923, 14925, 15667
TEST=dragging tabs in and out of windows, and within windows. Make sure new tab button goes away when it should and always comes back.
Review URL: http://codereview.chromium.org/160345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
scripts.
BUG=11797
TEST=no
Review URL: http://codereview.chromium.org/159542
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18047
TEST=see bug
Review URL: http://codereview.chromium.org/159654
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fix a few bugs of button sensitivity not updating when it should.
BUG=11507
Review URL: http://codereview.chromium.org/159625
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
engine.
If a search engine entry is already in the main group, MakeDefaultTemplateURL should return the current index(so that button states will be updated) rather than -1(which should mean nothing was done.)
BUG=17566
TEST=Select search engine that is already in the main group but not the default, and click "make default". The "make default" and "remove" buttons should no longer be clickable.
Review URL: http://codereview.chromium.org/159557
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch from joel.stan@gmail.com: http://codereview.chromium.org/160377
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159648
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a crash where events were being sent to an unknown, unrealized widget.
BUG=18049
TEST=Quickly drag a tab down out of the tab strip. The browser should not crash.
Review URL: http://codereview.chromium.org/160379
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some plugins assume that the GtkSocket container is in the same process as the plugin, so we give them one.
This fixes bug 16928 and the gdk_window_get_origin issue.
BUG=16928
Review URL: http://codereview.chromium.org/160380
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
without tcmalloc for testing purpose. The linker complains about
_set_new_mode so I remove the call from the code for now.
Note this change is different from the change Bradley is working
on which provides an option for building chrome without tcmalloc.
This change simply removes tcmalloc from the build. The plan is
checking it in, keeping it in trunk for 24 hours, and then
reverting it. The benefits are
- Having another round of performance comparison between build
with and w/o tcmalloc.
- Having a full run of UI test under purify with tcmalloc disabled.
- Getting a verified CL in case we'd like to build an alternative
dev build w/o tcmalloc for A/B test.
Review URL: http://codereview.chromium.org/159599
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17913
TEST=None
Review URL: http://codereview.chromium.org/159574
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159644
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running in UI test.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/11598
TEST=Visit an HTTPS page, click the lock icon, the page info should show.
Review URL: http://codereview.chromium.org/159521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The script which verifies whether a crash callstack is known expects the
callstack to be in lowercase.
Converting the recently added Flash callstacks to lowercase.
Added a new stack with the associated bug 18083
Please review this at http://codereview.chromium.org/160404
Review URL: http://codereview.chromium.org/160405
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
they are sent.
A good portion of this CL is to support the new UI test.
The IPC to notify the renderer of a redirect now includes a ResponseInfo struct
allowing WebURLLoaderImpl to provide detailed response info (including response
headers) to WebKit. This isn't strictly necessary, but I thought I'd include
this to make the code more future proof.
A cross origin restriction is added to SyncResourceHandler::OnRequestRedirected
that mimics the code in WebCore/platform/network/cf/ResourceHandleCFNet.cpp.
This is most unfortunate, and I filed a bug at bugs.webkit.org about the
similar duplication of logic in WebCore.
There seemed to be enough code paths leading to request cancellation at the
ResourceDispatcher level that I couldn't easily ensure that a request only gets
cancelled once. So, I added an is_cancelled flag to record if it is not
necessary to send a ViewHostMsg_CancelRequest IPC. This avoids some warnings
in the ResourceDispatcherHost.
To support my UI test, I needed to change URLRequestMockHttpJob to know how to
serve redirects. I moved URLRequestHttpJob::IsRedirectResponse to its base
class, URLRequestJob so that the implementation could be shared. This revealed
a minor bug in URLRequest. We were never resetting response_info_ upon
following a redirect. I added this code consolidated similar code from
URLRequest::Redirect and URLRequest::RestartWithJob into a new PrepareToRestart
method.
To support my UI test, I added a "hit count" field to URLRequestFilter, and I
added an associated automation IPC to query the value. The test was a bit
challenging to write because there is no way to tell the difference from JS.
Before and after, it appears to JS as though the cross-origin redirect failed.
However, the server can see the extra redirect request. So, I simply record
the number of hits against URLs of the form http://mock.http/foo, and use that
to observe if any extra requests were made. I implemented the new IPC message
by extending the AutomationResourceMessageFilter. This allowed me to trap the
IPC message on the IO thread where it is safe to probe the URLRequestFilter. I
then changed the implementation of AutomationMsg_SetFilteredInet to work
similarly.
I revised URLRequestMockHTTPJob::GetOnDiskPath to support ports. This actually
allowed me to reuse URLRequestMockHTTPJob to service URLs in different security
origins. My test redirects from http://mock.http/ to http://mock.http:4000/.
Please see the comments in cross-origin-redirect-blocked.html for details about
how the test functions.
R=brettw,wtc
BUG=16413
TEST=covered by resource_dispatcher_host_uitest.cc
Review URL: http://codereview.chromium.org/159370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=4928
TEST=Open about:memory page a see if the browser name of Google is what is expected.
Review URL: http://codereview.chromium.org/159385
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
callstack to be in lowercase.
Converting the recently added Flash callstacks to lowercase.
Added a new stack with the associated bug 18083
Review URL: http://codereview.chromium.org/160404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also rearrange installer targets with better grouping for easier reading.
Review URL: http://codereview.chromium.org/159641
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Kill a plugin process; sad tab should be right-side up.
Review URL: http://codereview.chromium.org/159611
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=avi
BUG=18079
TEST=none
Review URL: http://codereview.chromium.org/160400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22061 0039d316-1c4b-4281-b951-d872f2087c98
|