summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* WriteThumbnailToDisk runs on a bg thread so it cannot access the cache_ ↵meelapshah@chromium.org2009-06-263-6/+15
| | | | | | | | | | directly. Instead, pass the data to be written to disk so no cache_ lookups are necessary. Review URL: http://codereview.chromium.org/149105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19435 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19425.ericroman@google.com2009-06-265-19/+31
| | | | | | Review URL: http://codereview.chromium.org/147242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19432 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark model public interface use const BookmarkNode* instead ofmunjal@chromium.org2009-06-2684-1084/+1196
| | | | | | | | | | | | | | | BookmarkNode*. This helps in making the BookmarkNode class setters public also without worrying about someone inadvertently changing BookmarkNode properties directly for bookmark model bookmarks. Change all the call sites to reflect this. BUG=none TEST=none Review URL: http://codereview.chromium.org/146116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash that happens when changing themes.tc@google.com2009-06-263-22/+55
| | | | | | | | | | | | | | | | | | We were holding references to images that got deleted when themes changed. These all happen to be in a NineBox, so have NineBox reload images when the theme change notification is sent. Also fix an expose bug that wasn't noticeable in the original theme. We need to always place the image at 0, 0 for the background and paint it all the way across the window (should get clipped by cairo). BUG=15366 Review URL: http://codereview.chromium.org/149102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19426 0039d316-1c4b-4281-b951-d872f2087c98
* Make net::HostResolver refcounted.ericroman@google.com2009-06-265-31/+19
| | | | | | | | | | | This way it can be properly shared between the url request contexts, and the dns prefetcher, and dns observer. BUG=http://crbug.com/14664 TEST=existing unit tests. Review URL: http://codereview.chromium.org/149053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19425 0039d316-1c4b-4281-b951-d872f2087c98
* Add notifications for when V8Proxy creates or destroys a V8 Context.mpcomplete@chromium.org2009-06-264-0/+33
| | | | | | | | | | BUG=no TEST=no Review URL: http://codereview.chromium.org/147124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19424 0039d316-1c4b-4281-b951-d872f2087c98
* Missed a test that needed to be updated with r19418.mark@chromium.org2009-06-261-7/+15
| | | | | | | | BUG=15462 TEST=unit_tests --gtest_filter=JSONValueSerializerTest.Roundtrip Review URL: http://codereview.chromium.org/149103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19422 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the win KeywordEditorView for cross platform friendliness.mattm@chromium.org2009-06-268-561/+706
| | | | | | | | | | | The TableModel is moved to search_engines/template_url_table_model.* The shared logic, and ownership of the url_model_ and table_model_, is moved to search_engines/keyword_editor_controller.* BUG=13326 Review URL: http://codereview.chromium.org/146138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19421 0039d316-1c4b-4281-b951-d872f2087c98
* Use platform-appropriate newlines in JSON output.mark@chromium.org2009-06-265-39/+41
| | | | | | | | BUG=15462 TEST=base_unittests, unit_tests, check newlines in bookmarks file Review URL: http://codereview.chromium.org/147220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19418 0039d316-1c4b-4281-b951-d872f2087c98
* Do some minor cleanup I noticed in SiteInstance. Before, we would parse andbrettw@chromium.org2009-06-263-19/+24
| | | | | | | | | | | | canonicalize the three about URLs every time this function was called (I think for every page transition). This is unnecessary, so I just added a string comparison. TEST=none BUG=none Review URL: http://codereview.chromium.org/149084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19416 0039d316-1c4b-4281-b951-d872f2087c98
* Validates links which are to be passed on to the NTP by ensuring that they ↵mirandac@chromium.org2009-06-262-8/+14
| | | | | | | | | | | start with "http://" or "https://". BUG= http://crbug.com/15457 TEST= Change cached tip link in preferences file to be invalid. Note that this tip will not be included on the NTP. Review URL: http://codereview.chromium.org/149083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19415 0039d316-1c4b-4281-b951-d872f2087c98
* Use regular notifications for theme changes.tc@google.com2009-06-263-4/+15
| | | | | | | | | | | | | This should have no impact on the current behavior. On linux, we'll want to get these notifications in a few places other than just the root browser windows so having it as a regular notification makes it easier for us to just listen for the event. Review URL: http://codereview.chromium.org/149032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19414 0039d316-1c4b-4281-b951-d872f2087c98
* Create a webkit thread for use within the browser process. This patch also ↵jorlow@chromium.org2009-06-2619-5/+539
| | | | | | | | | | | includes some (soon to be fleshed out in another CL) code to demonstrate how it'll be used in DOM Storage. BUG=None TEST=None Review URL: http://codereview.chromium.org/139003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19413 0039d316-1c4b-4281-b951-d872f2087c98
* Add stubs for the rest of the gtk advanced options sections. Hook up the ↵mattm@chromium.org2009-06-263-2/+135
| | | | | | | | | | reset prefs function. BUG=11507 Review URL: http://codereview.chromium.org/149097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19412 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 2 memory leaks in UtilityProcessHostTest.ExtensionUnpacker.tc@google.com2009-06-261-5/+6
| | | | | | | | | | | Valgrind says this test is now clean, let's hope purify agrees. BUG=15456 Review URL: http://codereview.chromium.org/149092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19410 0039d316-1c4b-4281-b951-d872f2087c98
* s/OS_MAC/OS_MACOSX/willchan@chromium.org2009-06-261-2/+2
| | | | | | Review URL: http://codereview.chromium.org/149087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19405 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tab overview show the arrow at the right location.sky@chromium.org2009-06-265-10/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/147218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19403 0039d316-1c4b-4281-b951-d872f2087c98
* GTK bookmark manager: workaround for multi row dragging.estade@chromium.org2009-06-262-14/+78
| | | | | | | | | http://crbug.com/15240 TEST=click around in the bookmark manager a lot, everything works as you'd expect. In particular, if you hold ctrl and select a few rows, then release control, then click on those rows and try to drag them, they will drag. Review URL: http://codereview.chromium.org/147188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19402 0039d316-1c4b-4281-b951-d872f2087c98
* Fix download shelf z ordering during close.estade@chromium.org2009-06-261-3/+11
| | | | | | | | | | | Pretty much the same as what we do in the find bar. I think the flickering thing in the bug desc. was another result of <http://crbug.com/14786>, as it was only present in 3.0.190.2 and not ToT, and toggling the bookmark bar fixed it. http://crbug.com/15427 TEST=see bug Review URL: http://codereview.chromium.org/149054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19401 0039d316-1c4b-4281-b951-d872f2087c98
* Enable extension protocols on all platforms. This should enable background ↵erikkay@google.com2009-06-261-8/+1
| | | | | | | | | | | pages and tab-hosted pages from extensions. BUG=none TEST=load an extension that has a background page and verify that the process is created (see chrome://extensions) Review URL: http://codereview.chromium.org/149091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19400 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two issues with Drag-N-Drop in gtk tabstrip:jhawkins@chromium.org2009-06-262-2/+37
| | | | | | | | | | | * Handle drag-leave and drag-failed by hiding or destroying the drag arrow respectively. * Hide the drop arrow instead of destroying the drop info when we set the drop index to -1. This compensates for the fact that gtk emits the drag-leave signal before the drag-data-received signal. BUG=none TEST=Drag a URL in and out of the tabstrip. The drop arrow should disappear when the dragged mouse leaves the tabstrip or when the drag fails. Review URL: http://codereview.chromium.org/149093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19399 0039d316-1c4b-4281-b951-d872f2087c98
* Change BrowserBubble so that clients can say if they expect canvas mirroring ↵cira@chromium.org2009-06-262-7/+3
| | | | | | | | | | | | | to happen or not. ExtensionShelf doesn't need mirroring since View methods already provide most of the RTL functionality. BUG=http://crbug.com/11880 TEST=Run chrome --lang=he and add 1+ extensions, and see if the handle is in proper position. Review URL: http://codereview.chromium.org/149045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19395 0039d316-1c4b-4281-b951-d872f2087c98
* move the ResetToDefault function for prefs to chrome/browser/options_utilmattm@chromium.org2009-06-264-54/+89
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/147190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19390 0039d316-1c4b-4281-b951-d872f2087c98
* Foundations for gtk advanced options page.mattm@chromium.org2009-06-266-44/+275
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/147187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19389 0039d316-1c4b-4281-b951-d872f2087c98
* linux plugins: eliminate GtkWidget* from plugin processevan@chromium.org2009-06-263-4/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | [retry with mac hopefully fixed this time] GtkWidget* (and its wrapper, gfx::NativeView) only work within a single process. Plugins already work with a lower-level type that works across processes -- an X Window id. The parent of a plugin is an HWND on windows, but it's an X Window id on X. So we introduce a new typedef wrapping that and push it through all the places in the code that needs it. Since we no longer have a GtkSocket in the WebPluginDelegateImpl, we need to do a bit more work in the WebViewDelegate (aka the browser process in the multiproc world). We also need the plugin host (the browser) to track the GtkSockets that are hosting the plugin, as well as destroy them when necessary. To do this we require the plugin owner to grab the plug-removed signal rather than putting its handler in GtkPluginContainer; this is the way it worked before I'd refactored into GtkPluginContainer so it shouldn't be so bad. This change still only works in test_shell, but the refactoring should translate to the multiprocess case pretty easily. Review URL: http://codereview.chromium.org/146009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19387 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash 15371finnur@chromium.org2009-06-261-1/+2
| | | | | | | | | | | We need to null check the return from GetActiveEntry. BUG=15371 TEST=Watch the crash data from the field and make sure the crash is gone. Review URL: http://codereview.chromium.org/147214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19386 0039d316-1c4b-4281-b951-d872f2087c98
* fix windows build break.kuchhal@chromium.org2009-06-261-0/+2
| | | | | | Review URL: http://codereview.chromium.org/147222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19385 0039d316-1c4b-4281-b951-d872f2087c98
* Given the results of Rohit's investigation, I think that the times that we'remark@chromium.org2009-06-265-34/+49
| | | | | | | | | | | | | getting out of the pageload tests right now are highly suspect because we're not actually getting the bits from each page to the screen. As such, I'm much less inclined to treat the "regression" in these tests as a problem. BUG=15232 TEST=throbber changes between waiting (gray) and loading (blue) at appropriate times; animation still disabled Review URL: http://codereview.chromium.org/147211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19383 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Firefox import on OS X. No UI yet.kuchhal@chromium.org2009-06-2611-201/+352
| | | | | | Review URL: http://codereview.chromium.org/143001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19381 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebFrame::CaptureImage in favor of having consumers call Layoutdarin@chromium.org2009-06-262-8/+16
| | | | | | | | | | | | and Paint manually on the WebView. BUG=10034 TEST=none R=brettw Review URL: http://codereview.chromium.org/147212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19379 0039d316-1c4b-4281-b951-d872f2087c98
* Enable back the test disabled in r19348,r19345 since dank disabled them fromnirnimesh@chromium.org2009-06-261-3/+0
| | | | | | | | valgrind itself. Review URL: http://codereview.chromium.org/147213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19378 0039d316-1c4b-4281-b951-d872f2087c98
* Adding chrome start-up parameters to information passed back in breakpad crashcpu@google.com2009-06-261-20/+42
| | | | | | | | | | | | | - we collect the first two params : switch-1 and switch-2 - up to 64 chars, then it truncates BUG=b/1910452 TEST=starting chrome should work as usual, otherwise see the bug Review URL: http://codereview.chromium.org/149034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19376 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug when launching chromecpu@google.com2009-06-262-5/+4
| | | | | | | | | | | | - Toast experiment was missing a space before "--" - Quote the first param (exe path) because it can contain spaces BUG= none TEST=chrome should uninstall as usual (launches chrome to confirm user action) Review URL: http://codereview.chromium.org/149048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19373 0039d316-1c4b-4281-b951-d872f2087c98
* Change ExtensionHost to use notificationserikkay@chromium.org2009-06-269-60/+36
| | | | | | | | | | | rather than direct communication with ExtensionProcessManager. This simplifies ownership and lifetime issues which allows me to also revert the change that made ExtensionProcessManager owned by ExtensionsService. Review URL: http://codereview.chromium.org/147208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19370 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on NavigationEntry from RenderViewHost. The code forbrettw@chromium.org2009-06-263-66/+47
| | | | | | | | | | converting a NavigationEntry to a Navigate message is now in TabContents and it will send the params rather than the NavigationEntry to the RenderViewHost. I also removed "virtual" fron a bunch of functions that were never overridden. Review URL: http://codereview.chromium.org/147128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19369 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19361.davemoore@chromium.org2009-06-266-89/+38
| | | | | | | tbr=darin Review URL: http://codereview.chromium.org/149081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19368 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BookmarkEditorGtkTest.* instead of just one, sincedkegel@google.com2009-06-261-1/+1
| | | | | | | | | | they all run the init code that makes Valgrind unhappy. BUG=http://crbug.com/15445 TEST=none Review URL: http://codereview.chromium.org/149078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19365 0039d316-1c4b-4281-b951-d872f2087c98
* Revert cl 19359 due to browser_tests timeout.tim@chromium.org2009-06-2621-207/+157
| | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/147206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19363 0039d316-1c4b-4281-b951-d872f2087c98
* Restrict how often javascript can annoy the user with the print dialog. If ↵sverrir@google.com2009-06-264-15/+62
| | | | | | | | | | | | | a page continuously calls print() through javascript and the user cancels the printing no other printer dialog will be shown for 15 seconds. Also removed "Print failed" notification when the user cancels printing (since this should be obvious to the user). BUG=http://crbug.com/7880 TEST=See bug. Review URL: http://codereview.chromium.org/146052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19362 0039d316-1c4b-4281-b951-d872f2087c98
* A recent change broke the load times. It also revealed some deficiencies.davemoore@chromium.org2009-06-266-38/+89
| | | | | | | | | | | | This adds a new time marker for when a load is committed, which is a more interesting value than the start of the load (which we still keep). Also, the first layout time wasn't an interesting time to keep, instead we keep the time of the first paint. The histograms were modified to use the new values when appropriate. Review URL: http://codereview.chromium.org/147123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19361 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools Profiler: add sanity test.mnaganov@chromium.org2009-06-262-8/+29
| | | | | | | | | | | Add a test that opens a page which executes JS, profiles it, and checks the result displayed. BUG=none TEST=chrome\browser\debugger\devtools_sanity_unittest.cc Review URL: http://codereview.chromium.org/147204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19360 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 'RegisterMessages' function to DOMMessageHandler to make it easy to ↵tim@chromium.org2009-06-2621-157/+207
| | | | | | | | | | | | | | construct these objects by deferring the DOMUI dependency to the init / "Attach" step. Add GetMessageHandlers to HtmlDialogUIDelegate to allow sending/receiving messages to the page hosted in the dialog as opposed to only on open/close. BUG=none TEST=none Review URL: http://codereview.chromium.org/131094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19359 0039d316-1c4b-4281-b951-d872f2087c98
* Don't valgrind BookmarkEditorGtkTest.EditTitleKeepsPosition,dkegel@google.com2009-06-261-0/+3
| | | | | | | | | | | | since it seems to hit an uninitialized variable in gtk 2.12.9 on the bot (but not on my desktop...?) BUG=http://crbug.com/pr15445 TEST=none Review URL: http://codereview.chromium.org/149072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19355 0039d316-1c4b-4281-b951-d872f2087c98
* Fix breakagenirnimesh@chromium.org2009-06-261-1/+3
| | | | | | Review URL: http://codereview.chromium.org/147196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19348 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling BookmarkEditorGtkTest::ModelsMatch_Testnirnimesh@chromium.org2009-06-261-1/+2
| | | | | | | | | | http://crbug.com/15436 TBR=nsylvain Review URL: http://codereview.chromium.org/147195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19345 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks to tab overview to get it performant:sky@chromium.org2009-06-265-6/+71
| | | | | | | | | | | | | | | | . Delay getting thumnbails until 300ms after the window is shown. This is necessary as getting the thumnbails is very expensive. . Configure the thumnbail for one cell at a time. For same reason as last one. . Don't show new tab window widget as we don't yet have the type set up. BUG=none TEST=none Review URL: http://codereview.chromium.org/147174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19340 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the image used for the new tab button.sky@chromium.org2009-06-263-0/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/146056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19339 0039d316-1c4b-4281-b951-d872f2087c98
* The following 3 ui tests have been flaky on Linux.jshin@chromium.org2009-06-262-4/+12
| | | | | | | | | | | | | | | | | DownloadTest.DownloadMimeType DownlaodTest.ContentDisposition SavePageTest.FilenameFromPageTitle BUG=15416,15244 http://crbug.com/15416 http://crbug.com/15244 TEST=Linux UI test bots do not fail due to these tests TBR=estade Original review: http://codereview.chromium.org/147179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19334 0039d316-1c4b-4281-b951-d872f2087c98
* More BIDI support:estade@chromium.org2009-06-263-6/+18
| | | | | | | | | | | | | - mirror nine boxes - mirror menu positioning - mirror download item show/hide logic http://crbug.com/15406 is relevant, although I'm not sure this 100% fixes it. TEST=use download shelf in Hebrew chrome. Things should be mirrored. Use it in English and nothing should be borked. Review URL: http://codereview.chromium.org/147176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19333 0039d316-1c4b-4281-b951-d872f2087c98
* Fix proper MACOSX exlussion.rvargas@google.com2009-06-261-3/+3
| | | | | | | | | | TBR=rafaelw BUG=none TEST=none Review URL: http://codereview.chromium.org/149051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19332 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 03:40:24 +0000