summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* More refactoring for WebPlugin.darin@chromium.org2009-08-276-45/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL eliminates direct calls to WebPluginDelegate::DidFinishLoadWithReason from WebFrameLoaderClient. This CL also moves WebDataSourceImpl into webkit/api/src. That change was needed so that WebPluginContainerImpl can add a WebPluginLoadObserver to it, which WebFrameLoaderClient uses to communicate back to the WebPlugin upon completion of the frame load. WebViewDelegate::DidFinishLoadWithReason is modified to include url and notify_data parameters, eliminating the URLRequestRouted method. This is done so that we can support overlapping NPN_GetURLNotify targetting different frames. WebPluginContainer grows an executeScriptURL method to deal with javascript: URLs. NOTE: I'm working on some UI tests to better cover the case of overlapping NPN_GetURLNotify calls. R=jam BUG=10036 TEST=none yet Review URL: http://codereview.chromium.org/174514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24655 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 20398: PageAction icon disappears on reader.google.com when url includes ↵finnur@chromium.org2009-08-271-2/+9
| | | | | | | | | | | | | reference We now strip away the reference when comparing the url's (for the purpose of clearing the page action icons). BUG=20398 TEST=None Review URL: http://codereview.chromium.org/174613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24654 0039d316-1c4b-4281-b951-d872f2087c98
* Miscellaneous doc changes, nothing earthshaking.kathyw@google.com2009-08-279-21/+149
| | | | | | | | TBR=aa,rafaelw Review URL: http://codereview.chromium.org/173586 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24652 0039d316-1c4b-4281-b951-d872f2087c98
* Send release events as well as press events in linux event mocking ↵estade@chromium.org2009-08-271-35/+90
| | | | | | | | | | infrastructure. Also send events for the modifier keys. This matches Windows more closely. I needed this for an test I was writing which I decided to throw away as it was using the wrong approach. Review URL: http://codereview.chromium.org/178002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24650 0039d316-1c4b-4281-b951-d872f2087c98
* Adding in missing dependency on chrome_strings in browser_tests.bradnelson@google.com2009-08-271-0/+1
| | | | | | | | | | | | Browser tests use the header files generated from the chrome_strings grd files, thus they need a direct dependency on chrome_strings. BUG=19866 TEST=None Review URL: http://codereview.chromium.org/173583 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24646 0039d316-1c4b-4281-b951-d872f2087c98
* Only allow in-process tests in few binaries.phajdan.jr@chromium.org2009-08-272-0/+13
| | | | | | | | | | | | And it is not the final set. The main goal of this patch is to prevent further regressions. TEST=none BUG=none Review URL: http://codereview.chromium.org/173547 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24644 0039d316-1c4b-4281-b951-d872f2087c98
* Add call to BrowserThemeProvider::GenerateBitmap removed in r24170.erg@google.com2009-08-272-1/+5
| | | | | | | | | | (Linux relies on the lazy generation provided by GenerateBitmap; having to call GenerateTabImages() regressed linux startup; theoretically it'd be nice if everything was done lazily...) Review URL: http://codereview.chromium.org/180004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24643 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the settings tab to options on chrome os. The contents is just a placesky@chromium.org2009-08-276-0/+95
| | | | | | | | | | holder at this point. BUG=none TEST=none Review URL: http://codereview.chromium.org/174596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24642 0039d316-1c4b-4281-b951-d872f2087c98
* Add a technical overview of extensions.kathyw@google.com2009-08-272-17/+407
| | | | | | | | | | | Content Scripts is in this CL because I moved some first-draft text out of the overview and into it. It has a couple of other minor changes, as well. TBR=aa, rafaelw Review URL: http://codereview.chromium.org/174230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24636 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of bugs in the "custom home pages" list in the Preferences window.ben@chromium.org2009-08-274-1/+53
| | | | | | | | | | | | | 1. It was possible to add empty rows to the list by repeatedly clicking the + button. 2. There was a crash when editing an existing item, clearing the text and pressing enter. CustomHomePagesEntry::setURL didn't handle a nil NSString passed to it in this condition. I added a controlTextDidEndEditing method to PreferencesWindowController that forces a revalidation of the contents of the model backing the TableView. http://crbug.com/19555 TEST=Click the + button below the custom home pages table view in the Basics page of Preferences. You should get an active edit but not add the item if you don't type anything. Also, try adding a few valid URLs, then click one to edit and delete the URL, then press enter. It should be removed from the table. See also attached unit test. Review URL: http://codereview.chromium.org/174173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24635 0039d316-1c4b-4281-b951-d872f2087c98
* Skip ImporterTest.Firefox35Importer unit test again as it is still crashing ↵kuchhal@chromium.org2009-08-271-0/+3
| | | | | | | | | | Purify. BUG=19820 Review URL: http://codereview.chromium.org/180002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24634 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Subtract the tabstrip x offset from the last tab x offset when ↵jhawkins@chromium.org2009-08-271-1/+1
| | | | | | | | | | calculating the available tab width. The tabstrip and its tabs are not necessarily based at (0,0). BUG=20329 TEST=Open many tabs until they resize smaller. Repeatedly close the left-most tab with the close button. The tabs should not resize at all until the mouse leaves the tabstrip. Review URL: http://codereview.chromium.org/173559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24630 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Remove base/values dependency from devtools.pfeldman@chromium.org2009-08-2710-44/+60
| | | | | | Review URL: http://codereview.chromium.org/173480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24623 0039d316-1c4b-4281-b951-d872f2087c98
* Fix invalidates from off-screen plugins on the Mac.stuartmorgan@chromium.org2009-08-271-2/+12
| | | | | | | | | BUG=20234 TEST=Flash plugins that start offscreen should look correct when scrolled into view. Review URL: http://codereview.chromium.org/173552 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24621 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r24606-24607. The tree didn't like them. :(phajdan.jr@chromium.org2009-08-2711-96/+32
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/173574 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24608 0039d316-1c4b-4281-b951-d872f2087c98
* Wait correctly for navigations in ErrorPage UI test.phajdan.jr@chromium.org2009-08-271-4/+4
| | | | | | | | | | | TBR=darin TEST=none http://crbug.com/19361 Review URL: http://codereview.chromium.org/173571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24607 0039d316-1c4b-4281-b951-d872f2087c98
* Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness.phajdan.jr@chromium.org2009-08-2711-28/+92
| | | | | | | | | | | Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward. TEST=Covered by ui_tests and browser_tests. http://crbug.com/18365, http://crbug.com/19361 Review URL: http://codereview.chromium.org/174179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24606 0039d316-1c4b-4281-b951-d872f2087c98
* Draw background of Linux extension toolstrips.phajdan.jr@chromium.org2009-08-276-0/+36
| | | | | | | | | | | This makes Linux extension shelf quite pretty now IMHO. TEST=Just see it. http://crbug.com/16759 Review URL: http://codereview.chromium.org/174585 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24605 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in ExtensionTest.aa@chromium.org2009-08-271-1/+0
| | | | | | TBR=mpcomplete@chormium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24600 0039d316-1c4b-4281-b951-d872f2087c98
* Update of the extension install UI:aa@chromium.org2009-08-2750-170/+656
| | | | | | | | | | | | | | | | | - Give the user more information about which hosts an extension can access. - Remove the red severe warning because it doesn't play well with themes and because it adds nothing when the other text is more specific. - Make the image a bit smaller. Also integrate this new idea with the silent/not-silent update flow. BUG=12129,12140,19582 Review URL: http://codereview.chromium.org/173463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24599 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a crash caused due to a call to NPP_DestroyStream occuring in the ↵ananta@chromium.org2009-08-272-0/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | context of NPP_NewStream. The plugin would invoke NPN_Evaluate to display an alert in the context of NewStream. This would cause the didFail IPC to be dispatched which would cause the plugin to invoke another call to NPP_NewStream which would repeat these steps and crash. The didFail call from the renderer did not honor the deferred load flag which we set in WebPluginImpl prior to dispatching stream IPCs to the plugin. Fix is to dispatch the didFail call when we receive an ack from the plugin indicating that it is ready to accept stream data. This fixes bug http://code.google.com/p/chromium/issues/detail?id=20063 The other change is in WebPluginImpl::TearDownPluginInstance, where we run through the list of resource clients and cancel them. We call didFail on these clients here, which occurs anyway through the PluginDestroyed code path. Bug=20063 Test=Convered by interactive UI test. Review URL: http://codereview.chromium.org/174383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24593 0039d316-1c4b-4281-b951-d872f2087c98
* Extension docs: fix 404 errorrafaelw@chromium.org2009-08-271-2/+4
| | | | | | | | TBR=kathyw,aa Review URL: http://codereview.chromium.org/173558 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24589 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] The autocomplete popup now gets its position from the toolbar controller,rohitrao@chromium.org2009-08-2711-23/+83
| | | | | | | | | | rather than simply growing its width by 2*height. BUG=None TEST=The autocomplete popup should continue to appear in the same location. Review URL: http://codereview.chromium.org/173439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24586 0039d316-1c4b-4281-b951-d872f2087c98
* Don't flip out in debug mode when launching the bookmark manager and the ↵estade@chromium.org2009-08-271-2/+0
| | | | | | | | model isn't yet loaded. Review URL: http://codereview.chromium.org/174593 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24583 0039d316-1c4b-4281-b951-d872f2087c98
* The PluginHostMsg_CancelResource message is now an async routed message. It ↵ananta@chromium.org2009-08-271-2/+2
| | | | | | | | | | does not need to be a sync message anymore with the stream IPC's now being async. Review URL: http://codereview.chromium.org/174500 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24582 0039d316-1c4b-4281-b951-d872f2087c98
* assure model is loaded *before* showing the bookmark managerestade@chromium.org2009-08-271-4/+4
| | | | | | Review URL: http://codereview.chromium.org/173554 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24581 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux views build.estade@chromium.org2009-08-271-2/+4
| | | | | | | | TBR=rvargas Review URL: http://codereview.chromium.org/174589 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24578 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Set the default icon list so we don't have to set it on every window ↵estade@chromium.org2009-08-2713-14/+23
| | | | | | | | all the time. Review URL: http://codereview.chromium.org/174586 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24576 0039d316-1c4b-4281-b951-d872f2087c98
* Enable welcome page for non-windows platforms.estade@chromium.org2009-08-271-9/+1
| | | | | | | | | | Later we may wish to customize the welcome page per platform (particularly for chrome os) but for now it looks helpful enough to be worth showing on the first run. BUG=20327 Review URL: http://codereview.chromium.org/174551 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24575 0039d316-1c4b-4281-b951-d872f2087c98
* Add a nullable string16 class to base. It combines a string16 + a null paramjorlow@chromium.org2009-08-274-40/+31
| | | | | | | | | | | | | | | | | | in order to cover all the possible states of a WebKit string. For strings where the null state is not meaninfully different from the empty state, this class should NOT be used. There are, however, some cases where we do need to track null. LocalStorage is an example. This class should be a fairly light weight way to do so. This change also adds implicit conversion to and from WebStrings. This also switches LocalStorage's IPCs over to using this new class. BUG=17343 TEST=none Review URL: http://codereview.chromium.org/174484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24574 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage r24568hclam@chromium.org2009-08-271-0/+2
| | | | | | | | TBR=scherkus Review URL: http://codereview.chromium.org/173549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24570 0039d316-1c4b-4281-b951-d872f2087c98
* Make audio and video in sync while playback rate != 1.0hclam@chromium.org2009-08-271-0/+7
| | | | | | | | | | | | | | BUG=20290 TEST=play a video with rate 0.5, audio and video should be in sync This change use the playback rate as a scaling factor for delay introduced in the audio hardware buffer. After we scaled the amount of audio buffer not played, we'll be able to make audio / video in sync again. Review URL: http://codereview.chromium.org/174584 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24568 0039d316-1c4b-4281-b951-d872f2087c98
* Uses FilePath instead of std::wstring in webkit_glue::GetApplicationDirectory.avi@google.com2009-08-271-2/+2
| | | | | | | | | | | | Patch by tfarina. BUG=None TEST=None Review URL: http://codereview.chromium.org/173304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24565 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leaks in Firefox impoter unittest.kuchhal@chromium.org2009-08-262-10/+11
| | | | | | | | | BUG=19820 TBR=erikkay Review URL: http://codereview.chromium.org/173546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24564 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix the bounds of the clip region for tab title text.jhawkins@chromium.org2009-08-261-4/+4
| | | | | | | | BUG=19741 TEST=Open many tabs. The ellipses should not be rendered if the tab is not large enough. Review URL: http://codereview.chromium.org/174582 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24560 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Fix the find bar so the match count is inside the entry.erg@google.com2009-08-266-51/+158
| | | | | | | | | | In addition, only draw the dirty rectangle area when manually drawing a gtk entry. http://crbug.com/17962 Review URL: http://codereview.chromium.org/174577 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24558 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the bookmark model is loaded before running bookmark manager ↵estade@chromium.org2009-08-262-13/+63
| | | | | | | | | | tests. Fixes flaky browser test failures on the build bots. Also restructure the test to make adding future tests easier. Review URL: http://codereview.chromium.org/173527 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24557 0039d316-1c4b-4281-b951-d872f2087c98
* Make extension install UI text on Mac match Windows version. Still to come ifpam@chromium.org2009-08-262-9/+34
| | | | | | | | | | | | | | possible: coloring the "severe" warning red, applying a style to the rest of the text, and changing the default warning icon to the extension's install_icon. Remove dead function declaration, no longer used. BUG=19654 TEST=install an extension on Mac, observe dialog Review URL: http://codereview.chromium.org/174498 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24553 0039d316-1c4b-4281-b951-d872f2087c98
* A smaller image to avoid a huge blank area in the pageActions doc.kathyw@google.com2009-08-263-6/+12
| | | | | | | | | I ended up taking a screenshot of the RSS page action and editing it to be less wide. Review URL: http://codereview.chromium.org/173519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24552 0039d316-1c4b-4281-b951-d872f2087c98
* Second part of memory_test for Mac.paul@chromium.org2009-08-262-9/+52
| | | | | | | | | | | This CL implements the actual memory measurements. BUG=16434 (http://crbug.com/16434) TEST=memory_test should now run and report accurate memory numbers on Mac. Review URL: http://codereview.chromium.org/173454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24549 0039d316-1c4b-4281-b951-d872f2087c98
* AutomationProvider: Implement GetBrowserForWindow() on mac and linux views.estade@chromium.org2009-08-264-56/+22
| | | | | | Review URL: http://codereview.chromium.org/174505 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24547 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't reposition the findbar when it's not visible.estade@chromium.org2009-08-262-8/+18
| | | | | | | | This gives us ~8ms of startup improvement that we lost previously from r22012. Review URL: http://codereview.chromium.org/173510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24546 0039d316-1c4b-4281-b951-d872f2087c98
* Fix startup regression in gtk theme mode.erg@google.com2009-08-262-1/+18
| | | | | | | | | Don't populate the image dictionary in gtk mode, in addition to not writing the images to disk. Review URL: http://codereview.chromium.org/173525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24541 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Linux Extensions Install Prompt""rafaelw@chromium.org2009-08-263-1/+149
| | | | | | | | | | | | | This relands http://codereview.chromium.org/174462 which was reverted. It now only includes the new panel for TOOLKIT_GTK (was OS_LINUX). TBR=sgk Review URL: http://codereview.chromium.org/173522 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24540 0039d316-1c4b-4281-b951-d872f2087c98
* Polish the look of Linux extension shelf.phajdan.jr@chromium.org2009-08-262-34/+50
| | | | | | | | | TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/174564 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24539 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SharedMemory Object leakjeremy@chromium.org2009-08-261-2/+1
| | | | | | | | | | | Detected via Valgrind. BUG=16209 TEST=None Review URL: http://codereview.chromium.org/174560 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24537 0039d316-1c4b-4281-b951-d872f2087c98
* First half of updating Worker.postMessage(), DOMWindow.postMessage(), andjorlow@chromium.org2009-08-2613-111/+159
| | | | | | | | | | | | | | | MessagePort.postMessage() to accept multiple MessagePorts. Original review: http://codereview.chromium.org/173193 TBR=atwilson TEST=None (new functionality not yet exposed via bindings, so existing tests suffice) BUG=19948 Review URL: http://codereview.chromium.org/174566 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24536 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a string comparison bug in DeleteFolder.kuchhal@chromium.org2009-08-261-2/+3
| | | | | | | Review URL: http://codereview.chromium.org/174455 Patch from Ken Kania <kkania@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24532 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in Linux extension shelf.phajdan.jr@chromium.org2009-08-263-4/+16
| | | | | | | | | | | We need to delay creating render view until we're fully constructed. TEST=none BUG=none Review URL: http://codereview.chromium.org/173506 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24530 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable importer unit tests one more time to debug on buildbot.kuchhal@chromium.org2009-08-261-2/+5
| | | | | | | | BUG=19820 Review URL: http://codereview.chromium.org/174561 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24529 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 07:31:35 +0000