| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Also adds SyncerThreadAdapter (temp code) to facilitate swapping between
implementations without tearing syncapi apart.
BUG=26339
TEST=unit_tests, sync_unit_tests
Review URL: http://codereview.chromium.org/6576049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11896,chromium-os:12300,chromium-os:12302
TEST=None. Punt until the underlying support is implemented.
Review URL: http://codereview.chromium.org/6592079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74690
TEST=Start up cloud print or remoting, then quit chrome. Move chrome.app somewhere else on your system. Restart chrome. Shouldn't crash.
Review URL: http://codereview.chromium.org/6613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I will be doing some refactoring that will change the way pending extension records for a single extension ID are merged. This change will make PendingExtensionInfo a class with nontrivial member functions. As a first step, this change moves PendingExtensionInfo into its own file.
Fixing crbug.com/61000 by merging pending requests is an example of the changes that will add members to class PendingExtensionInfo.
I changed the type ShouldInstallExtensionPredicate to PendingExtensionInfo::ShouldAllowInstallPredicate. I wanted to get the type defined inside the class, and changing the name avoids some ugly 80-colunm gymnastics because it is slightly shorter.
BUG=None
TEST=ExtensionServiceTest.*
Review URL: http://codereview.chromium.org/6579005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also use a single delete function when removing extension files.
BUG=None
TEST=ExtensionServiceTest.*
Review URL: http://codereview.chromium.org/6596041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The volume indicator is moved up, 'Speak now' text comes in the middle and when recognition
is in progress we show only the spinner with no text. When showing error messages, include
a hyperlink to launch the microphone settings UI. Also includes a bunch of spacing changes
to look like in the mocks.
XIB changes: Added a NSButton widget, changed the cell class to HyperlinkButtonCell and linked it to the obj-c code for handling the click event.
BUG=69886
TEST=manual, start speech input on Mac and verify the bubble UI looks similar to the mocks.
Review URL: http://codereview.chromium.org/6594122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was previously Ctrl-Shift-Delete, which can only be
typed as Ctrl-Shift-Alt-Backspace on Chrome OS devices
without Delete keys. Ctrl-Shift-Delete still deletes to the
end of the line when the focus is in a textarea.
BUG=chromium-os:11137
TEST=manual
Review URL: http://codereview.chromium.org/6606008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where it's needed. Prior to this, at least with the
CHROME_ALLOCATOR=winheap environment variable set, the pointer passed
to kernel32!RegisterApplicationRestart could be invalid.
BUG=70824
TEST=run debug build under full page heap on Windows with CHROME_ALLOCATOR=winheap
Review URL: http://codereview.chromium.org/6602092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows loading of icons in the platform format, avoiding unnecessary
conversions if the image is going to be used with the platform toolkit. In other
cases, this just pushes image conversion to the callsite rather than the actual
image load.
BUG=19685
TEST=unit_tests and visual inspection of icons in the download shelf
Review URL: http://codereview.chromium.org/6597043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
While I was at it, I also fixed a PLOG that should have been a LOG and fixed a debug-only crash resulting from an overly-greedy attempt to open HKLM in a user-level uninstall.
BUG=74723
TEST=follow the steps in the bug. after uninstall, Temp dir should be gone.
Review URL: http://codereview.chromium.org/6609015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(without this fix users complain that notification is shown too early).
BUG=chromium-os:11839
TEST=Manual
Review URL: http://codereview.chromium.org/6591067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The volume indicator is moved up, 'Speak now' text comes in the middle and when recognition
is in progress we show only the spinner with no text. When showing error messages, include
a hyperlink to launch the microphone settings UI. Also includes a bunch of spacing changes
to look like in the mocks.
BUG=69886
TEST=manual, start speech input on GTK and verify the bubble UI looks similar to the mocks.
Review URL: http://codereview.chromium.org/6617001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Interestingly, gtest_prod_util were #included...
TBR=rtenneti
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6603014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
assertion.
TBR=rtenneti
BUG=74727
TEST=unit_tests
Review URL: http://codereview.chromium.org/6613014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update crash signature: Crash in HTMLFormControlElement (74545)
Add new crash signature: Crash in WTF::StringImpl::createUninitialized (74796)
Found http://build.chromium.org/p/chromium/builders/Win%20Reliability/builds/2422/steps/reliability%3A%20partial%20result%20of%20current%20build/logs/stdio
These weren't found in next build.
BUG=74545,74796
TEST=none
TBR=huanr
Review URL: http://codereview.chromium.org/6615011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6602039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
preferences overlay
BUG=74655
TEST=none
Review URL: http://codereview.chromium.org/6603009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
that no horizontal scroll is needed for the default window size (930 pixels).
BUG=71471
Review URL: http://codereview.chromium.org/6591096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All calls to OffsetY were passing |this| as the |parent|. The
combination of using member variables (target_height_) and parent's
info (parent->height()) were confusing and undocumented.
Removing the need to deal with parent helps for adjusting the layout
so that OffsetY can be from the perspective of the bar portion of the
InfoBarView (shifted down by the tab portion), because all
calculations are done on |this| (they are anyway since everyone passes
|this|).
BUG=74437
TEST=LANGUAGE=he_IL out/Release/chrome --user-data-dir=.dev-profile
--enable-tabbed-options russia.ru for RTL and without the LANGUAGE=
for LTR.
Review URL: http://codereview.chromium.org/6604011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74656
TEST=none
Review URL: http://codereview.chromium.org/6609006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and remove old functions now no-one uses them.
Continuation of: Land the new functions added by 76483 - but do not use them anywhere outside of their tests. This will help me incrementally re-deploy these functions and identify what is causing the buildbot test redness.
BUG=72040
TEST=none
TBR=sky (all code originally reviewed here: http://codereview.chromium.org/6598069/ )
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also adds streaming for CFStringRefs and CFErrorRefs making it
easier to add them to LOG() type statements.
BUG=NONE
TEST=BUILD
Review URL: http://codereview.chromium.org/6594096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-> CGImageRef ...""
There was no change to vm_rss_final_b in
mac-release-10.5/intl2, so reverting this change.
BUG=74775
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6609013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add copyright headers. Use textContent instead of innerHTML.
BUG=69500
TEST=
Review URL: http://codereview.chromium.org/6594136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Continuation of: Land the new functions added by 76483 - but do not use them anywhere outside of their tests. This will help me incrementally re-deploy these functions and identify what is causing the buildbot test redness.
BUG=72040
TEST=none
TBR=sky (all code originally reviewed here: http://codereview.chromium.org/6598069/ )
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
conversions"
This is a test to look for the cause of a steady
vm_rss_final_b regression on the Mac 10.5 intl2 page
cycler.
BUG=74775
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6609010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=64154
TEST=manual, so very manual
Review URL: http://codereview.chromium.org/6538012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Continuation of: Land the new functions added by 76483 - but do not use them anywhere outside of their tests. This will help me incrementally re-deploy these functions and identify what is causing the buildbot test redness.
BUG=72040
TEST=none
TBR=sky (all code originally reviewed here: http://codereview.chromium.org/6598069/ )
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is to match the recent change that flipped non-fullscreen pepper GL.
BUG=none
TEST=youtube with pepper flash, go fullscreen
Review URL: http://codereview.chromium.org/6610001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the parent/child index be sorted by SERVER_POSITION_IN_PARENT, rather than arbitrarily.
This fixes two longstanding TODOs and yields the following perf improvement on "SyncerTest.OneBajillionUpdates":
Release build (7000ms -> 500ms)
Debug build (70000ms -> 3000ms)
BUG=60236, chromium-os:11226
TEST=sync_unit_tests (SyncerPosition* gives good coverage)
Review URL: http://codereview.chromium.org/6588119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Continuation of:
Land the new functions added by 76483 - but do not use them anywhere outside of their tests. This will help me incrementally re-deploy these functions and identify what is causing the buildbot test redness.
BUG=72040
TEST=none
TBR=sky (all code originally reviewed here: http://codereview.chromium.org/6598069/ )
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- allow minimum size values down to 6.
- show font samples in 'px' values rather than 'pt' so that samples are accurate.
- adjust some layout sizes to improve appearance and behavior.
Review URL: http://codereview.chromium.org/6602043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71421
TEST=Install/Uninstall extension with background page, see no badges or crashes.
Review URL: http://codereview.chromium.org/6602064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6610004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move logs into GpuDataManager. This fixes false reporting of the gpu blacklistedness.
New custom message shown at top of about:gpu page when blacklisted.
Blacklisting reason is provided per blacklist entry
Tweak the GpuInfoUpdated call chain to have more-consistent naming.
BUG=73796,74025
TEST=
Review URL: http://codereview.chromium.org/6592004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=74656
TEST=none
Review URL: http://codereview.chromium.org/6588112
TBR=isherman@chromium.org
Review URL: http://codereview.chromium.org/6610003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
defined within, so that each piece is shorter and clearer.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6598057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Loaded extension, tried some searches.
Review URL: http://codereview.chromium.org/6597084
Patch from Tessa MacDuff <tessamac@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The policy is fairly restrictive token-wise but still the process
needs access to the interactive desktop.
Tweaks to the Job level in a different CL once it has baked in the dev channel.
BUG=48607
TEST=see bug.
Review URL: http://codereview.chromium.org/6594100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6576036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=67889
TEST=none
Review URL: http://codereview.chromium.org/6580031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also switches to using the hidden property for the main elements than show and hide.
BUG=71247
TEST=Opening and closing subpages and overlays should animate
Review URL: http://codereview.chromium.org/6597091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74656
TEST=none
Review URL: http://codereview.chromium.org/6588112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
by a merge conflict
BUG=None
TEST=Scroll down on a prefs page, then open a subpage. The underlying page should not scroll to the top.
Review URL: http://codereview.chromium.org/6608001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: This patch might have resulted in some
flakiness in the sync bots on the chromium waterfall.
The range vector is calculated once when a histogram is
constructed, and should never change over the lifetime of the
histogram. When it does change, it means that memory is being
overwritten. We now crash (via CHECK) when there is any
detected corruption of the range vector.
This CL uses a more robust check-sum algorithm to detect corruption
of the vector. The previous algorithm just did a sum, and was
too easilly tricked by small (offsetting) changes in several
ranges. Hopefully, this CRC-32 implementation will not be
so easilly fooled.
I had to refactor the class to ensure that each histogram was completely
constructed before I registered it. The old code could sometimes
register a base class (tradtional Histogram, with exponential
bucket spread) and then run the derived constructor (such as
when creating a LinearHistogram, with a second construction
of the ranges and checksum). I now carefully avoid
generating the checksum until fully constructing the instance,
and then I run InitializeBuckets only once on
the instance before registering it.
bug=73939,74467
r=mbelshe
Review URL: http://codereview.chromium.org/6577013
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/6611001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The webkit side is here:
https://bugs.webkit.org/show_bug.cgi?id=55095
BUG=64049
TEST=
Review URL: http://codereview.chromium.org/6596065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/6594117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
address.
Since we can't discern the remote IP address if the page was loaded via a proxy, also disable phishing detection in that case.
The pre-classification checks are moved to ClientSideDetectionHost, since it is already set up as a TabContentsObserver and receives the ViewHostMsg_FrameNavigate_Params for each navigation.
BUG=none
TEST=ClientSideDetectionHostTest.ShouldClassifyUrl
Review URL: http://codereview.chromium.org/6594006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This code only affects the browser process, so put it into the
browser process startup code instead of the shared code.
Review URL: http://codereview.chromium.org/6602096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76655 0039d316-1c4b-4281-b951-d872f2087c98
|