summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Track removal of browser\navigation_controller_base.cc.sgk@google.com2008-08-211-1/+0
| | | | | | TBR: brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1142 0039d316-1c4b-4281-b951-d872f2087c98
* Fix one bug in the URL list.mbelshe@google.com2008-08-211-2/+7
| | | | | | | Add timeout to NavigateToURL in case there are timeouts. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1140 0039d316-1c4b-4281-b951-d872f2087c98
* Kill NavigationControllerBase. I merged the two into NavigationController.brettw@google.com2008-08-215-710/+536
| | | | | | | | | This fixes a leak of NavigationEntry's by using the spiffy linked ptr. I had to add a const to linked_ptr for the comparisons to work. BUG=1319484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1137 0039d316-1c4b-4281-b951-d872f2087c98
* Don't compile installer_util_strings.rc as a separate .res,sgk@google.com2008-08-201-10/+5
| | | | | | | it's getting #included by the other .rc files that need it. (While here, refactor the way the libs are configured for consistency.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1128 0039d316-1c4b-4281-b951-d872f2087c98
* TrackedObjects assumes you can use a "TLS slot" of -1 to indicate ↵evanm@google.com2008-08-206-23/+25
| | | | | | uninitialized. This isn't true for the pthread_key_t type, which is unsigned on Linux and reportedly a struct on Macs. This change modifies the Slot type to be a struct containing an "initialized" flag. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1122 0039d316-1c4b-4281-b951-d872f2087c98
* Revert a fix where I mistakenly assumed that numbers coming into erg@google.com2008-08-203-10/+8
| | | | | | | | | | | | Browser::MoveContents() were content sizes instead of window sizes; this broke a unit test and is incorrect. Reopening the other bug; it seems like webkit is getting totally wrong numbers when asking for a window's size. BUG=1334628, git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1121 0039d316-1c4b-4281-b951-d872f2087c98
* Revert. Failing unit tests.evanm@google.com2008-08-206-25/+23
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1118 0039d316-1c4b-4281-b951-d872f2087c98
* Allow popups using the new frames to be sized correctly. This involved a ↵beng@google.com2008-08-205-51/+131
| | | | | | | | | slight tweak to how RestoreWindowPosition on Window works - if the window is opened with specified bounds, we still ask the delegate to try and restore the position. The delegate can use the provided bounds as a hint (in the popup case the bounds aren't the true layout bounds of the window, rather the rect contains the window position and content area size) to return the actual bounds of the window. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1117 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak in BookmarkBarContextMenu test.sky@google.com2008-08-201-8/+7
| | | | | | | | BUG=1335232 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1116 0039d316-1c4b-4281-b951-d872f2087c98
* TrackedObjects assumes you can use a "TLS slot" of -1 to indicate ↵evanm@google.com2008-08-206-23/+25
| | | | | | uninitialized. This isn't true for the pthread_key_t type, which is unsigned on Linux and reportedly a struct on Macs. This change modifies the Slot type to be a struct containing an "initialized" flag. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1113 0039d316-1c4b-4281-b951-d872f2087c98
* Do not leave temp files in %TEMP% folder. The log file initialization ↵rahulk@google.com2008-08-205-55/+0
| | | | | | | | | creates these temporary files and these log files are of no use. BUG=1330260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1111 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in newly added sync channel unit tests.jabdelmalek@google.com2008-08-201-0/+1
| | | | | | BUG=1334220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1103 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes to allow non-ASCII characters in shortcut filenames.mpcomplete@google.com2008-08-204-9/+35
| | | | | | BUG=1331408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1098 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround for truncation of "Search from right here" text when using Hebrew ↵glen@google.com2008-08-201-2/+8
| | | | | | | | | Chrome on Vista. Will file separate bug so the root cause is fixed. BUG=1325257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1097 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome strings.tc@google.com2008-08-202-5/+5
| | | | | | TBR=mal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1094 0039d316-1c4b-4281-b951-d872f2087c98
* Disable this interactive ui tests because it fails on the bot.nsylvain@google.com2008-08-201-1/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1082 0039d316-1c4b-4281-b951-d872f2087c98
* Add wow_helper.exe to chrome-win32.ziprvargas@google.com2008-08-191-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1072 0039d316-1c4b-4281-b951-d872f2087c98
* Update archive script to not include rlz.dll unless we are building Google ↵rahulk@google.com2008-08-193-11/+33
| | | | | | | | | Chrome. BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1065 0039d316-1c4b-4281-b951-d872f2087c98
* Move time formatters that only use ICU into base/time.*tc@google.com2008-08-198-130/+27
| | | | | | | | | | | | | This allows us to use the time formatters in, e.g., net or webkit. Remove CookieExpires since it's not used. BUG=1164516 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1063 0039d316-1c4b-4281-b951-d872f2087c98
* Add installer/util/browser_distribution.cc to SCons build.sgk@google.com2008-08-192-0/+3
| | | | | | | | Add $CHROME_DIR/installer/util to CPPPATH when compiling the .res files so chrome_dll.res can #include installer_util_strings.rc. TBR: rahulk git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1061 0039d316-1c4b-4281-b951-d872f2087c98
* SCons build accommodation of change from generated setup_string.{rc,h}sgk@google.com2008-08-192-3/+3
| | | | | | | to generated installer_util_strings.{rc,h}. TBR: rahulk git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1056 0039d316-1c4b-4281-b951-d872f2087c98
* Add test_notification_tracker.cc to SCons build unit tests.sgk@google.com2008-08-191-0/+1
| | | | | | TBR: brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1055 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new PrintResult() method that outputs perf-test results in a particularpamg@google.com2008-08-194-35/+81
| | | | | | | | | | | arcane format expected by the Python post-processing script. Switch memory_test to use that method. Fix a small typo in the vcproj group name. BUG=1326725,1221588 TEST=none yet; will be covered by buildbot git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1051 0039d316-1c4b-4281-b951-d872f2087c98
* Drag tab 2 out of the tab strip.sidchat@google.com2008-08-191-0/+148
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1049 0039d316-1c4b-4281-b951-d872f2087c98
* The truncation on the match count label (bug 1110432) has been bugging me a ↵finnur@google.com2008-08-191-2/+0
| | | | | | | | | | bit. This problem has actually improved a bit over time (we used to truncate from the left, but now we are cutting off a small 1 px strip from the bottom). I noticed that we are extending the label one pixel too far down anyway, so by removing that the problem goes away. BUG=1110432 TEST=Open Find, paste some random text into the Find box (something that will result in 0 matched) and notice that the red background on the match-count label is rectangular, not 6-sided. :) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1047 0039d316-1c4b-4281-b951-d872f2087c98
* The automation system can be torn down before all of the notification observersdarin@google.com2008-08-191-0/+5
| | | | | | | that the automation system created. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1046 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor localized strings used in installer for Chromium/Google Chrome ↵rahulk@google.com2008-08-1919-148/+90
| | | | | | | | | | | | | | | separation (see other change out for review - chromium_1). - Rename resources files as util_strings.* as they will be used by classes in util project. - Instead of directly accessing resource, chrome.dll and setup.exe will get the resource from helper class in util project. Remove references to header file from projects. - The resources still need be bundled in the binary so directly include util_strings.rc in resource file. - Add another string "Google Inc" in resource file to use as Publisher name. - Remove uninstall URL from resource file. This URL is not going to be localized, we are manually appending language parameter to it. BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1044 0039d316-1c4b-4281-b951-d872f2087c98
* Add renderer\external_host_bindings.cc to the SCons build.sgk@google.com2008-08-193-1/+3
| | | | | | TBR: joshia git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1043 0039d316-1c4b-4281-b951-d872f2087c98
* Cleans up notifications for the NavigationController. There were severalbrettw@google.com2008-08-1917-86/+418
| | | | | | | | | | | | notifications before and some of them were very unclear and misused (STATE_CHANGED). This one, and PRUNED were called unnecessarily in some cases as well. I replaced STATE_CHANGED and INDEX_CHANGED with ENTRY_COMMITTED which is more clear and covers (I think!) all the cases that the callers care about. I added a simple notification testing helper class, and used in the navigation controller unit tests to make sure we get the proper notifications. I had to change NotificationSource/Details to have a = and copy constructor so I can track them easily in my helper. I don't see why this would be bad. BUG=1325636,1321376,1325779 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1039 0039d316-1c4b-4281-b951-d872f2087c98
* Make the otr avatar icon not show in detached OTR popup windows.beng@google.com2008-08-195-28/+29
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1038 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome strings.tc@google.com2008-08-198-15/+15
| | | | | | TBR=mal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1034 0039d316-1c4b-4281-b951-d872f2087c98
* Factor the SSL state out of the main NavigationEntry into a helper class. Thisbrettw@google.com2008-08-1915-175/+187
| | | | | | | | | | | makes it easier to find stuff and also copy ssl state (just assign). I made one "real" change in web_contents where I copy the entire SSL state now to the new entry rather than just a few fields like the old one. I couldn't figure out why this was necessary: running it shows that this leaves the other two fields in the uninitialized state which seems wrong. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1032 0039d316-1c4b-4281-b951-d872f2087c98
* Update a few forgotten users of the Sys StringPiece conversion functions to ↵deanm@google.com2008-08-191-0/+1
| | | | | | include string_piece.h git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1028 0039d316-1c4b-4281-b951-d872f2087c98
* Use LF for newlines in all DEPS filesmmentovai@google.com2008-08-188-62/+62
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1011 0039d316-1c4b-4281-b951-d872f2087c98
* * Land the fix for issue 1322174 (which is not last-minute) on the trunk. ↵pkasting@google.com2008-08-181-13/+7
| | | | | | | | | | | This has already landed on branch. * Revert one of my earlier fixes to hack some RTL engine names to be "LTR-friendly" to work around bugs in the engine management dialog. We also show these names in _other_ places (like the keyword UI in the omnibox) which are not buggy, so I broke these. * Change the URLs for msn.co.il, which unlike seemingly all other MSN sites is actually really using MSN and not Live Search under the hood, and thus has a different URL layout. BUG=1322174,1329557,1329566 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1003 0039d316-1c4b-4281-b951-d872f2087c98
* First set of changes to start separating Google specific branding from ↵rahulk@google.com2008-08-1825-351/+725
| | | | | | | | | | | | | Chromium. This change mostly tries to modify installer to install Chromium or Google Chrome depending on a compile flag. The goal is to try to isolate all the differences in a single class that can be overridden for customization. There is also a lot of refactoring to make this happen. Some changes are yet to be done but I didn't want to make this change even bigger than it already is. With all these changes the default build should still work as it is (Google Chrome should get installed/uninstalled). The changes yet to be done: - Separating string resources (this is marked by TODO in one of the files) - Generate different chrome.7z (Chromium will not include rlz.dll) for mini_installer BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@999 0039d316-1c4b-4281-b951-d872f2087c98
* The CL is consist of CLs(1624,1580) for bug:1281734 which are reviewed and ↵jnd@google.com2008-08-1823-43/+139
| | | | | | | | | LG by brett. I just merge them to single one for passing compilation. The CL is to fix bug http://b/issue?id=1281734. FireFox uses encoding used by the original webpage to decode the source of the webpage, Chrome does not. We need to add a new parameter which carries the override encoding when opening a view-source URL for viewing its source. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@997 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the window icon for app windows, with a throbber etc.beng@google.com2008-08-189-37/+174
| | | | | | Also add support for OTR icon.B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@992 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some comment typos.ericroman@google.com2008-08-181-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@984 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly include logging.h in a header that assumed it was already getting ↵maruel@google.com2008-08-161-4/+9
| | | | | | | | included. TBR=nsylvain@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@972 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the --disable-breakpad flag. It had no effect with the CRT asserts ↵maruel@google.com2008-08-161-10/+13
| | | | | | because they were simply disabled. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@970 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break.iyengar@google.com2008-08-152-0/+37
| | | | | | | TBR=joshia git-svn-id: svn://svn.chromium.org/chrome/trunk/src@965 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for PostMessage from the automation framework toiyengar@google.com2008-08-158-0/+64
| | | | | | | the renderer. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@964 0039d316-1c4b-4281-b951-d872f2087c98
* git-svn-id: svn://svn.chromium.org/chrome/trunk/src@963 ↵brettw@google.com2008-08-1516-414/+83
| | | | 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing files from the previous changejoshia@google.com2008-08-153-0/+15
| | | | | | | TBR=iyengar git-svn-id: svn://svn.chromium.org/chrome/trunk/src@959 0039d316-1c4b-4281-b951-d872f2087c98
* Code to facilitate sending message to external host.joshia@google.com2008-08-1512-3/+203
| | | | | | | | | | Note that at this time the parameters to the message are still tentative. The call goes as a sync call from renderer to the browser. From then onwards it happens async and no return value is available yet. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@957 0039d316-1c4b-4281-b951-d872f2087c98
* Cleans up notifications for the NavigationController. There were severalbrettw@google.com2008-08-1516-83/+414
| | | | | | | | | | | | | | | | | | | | | | | | notifications before and some of them were very unclear and misused (STATE_CHANGED). This one, and PRUNED were called unnecessarily in some cases as well. I replaced STATE_CHANGED and INDEX_CHANGED with ENTRY_COMMITTED which is more clear and covers (I think!) all the cases that the callers care about. I added a simple notification testing helper class, and used in the navigation controller unit tests to make sure we get the proper notifications. I had to change NotificationSource/Details to have a = and copy constructor so I can track them easily in my helper. I don't see why this would be bad. As part of this, I got very frustrated recompiling the world whenever navigation_types.h changed. So I removed this dependency from the notification service which everybody includes. Most of the changed files are adding notification_types.h in the .cc file where it's needed. BUG=1325636,1321376,1325779 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@956 0039d316-1c4b-4281-b951-d872f2087c98
* Copy from http://chrome-reviews.prom.corp.google.com/1237 (new gcl ↵timsteele@google.com2008-08-1519-22/+232
| | | | | | | | | | | | | | | | | | | changelist model). Description was: Conditionally include personalization/ code by surrounding the hooks into this module with #ifdef CHROME_PERSONALIZATION in various .h/.cc files. Building with the module requires adding this macro as a preprocessor definition in build/internal/essential.vsprops, and adding it to the VCResourceCompiler tool's command line (using /d). We will try and make this easier in the future. TBR=darin git-svn-id: svn://svn.chromium.org/chrome/trunk/src@955 0039d316-1c4b-4281-b951-d872f2087c98
* Step 1 at making Gears run in the renderer process (enabled by switchmpcomplete@google.com2008-08-1517-7/+704
| | | | | | | | | "--gears-in-renderer"). Requires some changes to gears to work. Most things work if you disable the sandbox. One major hole is that update tasks don't report status to the appropriate renderer. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@954 0039d316-1c4b-4281-b951-d872f2087c98
* String update (maybe the last one?)tc@google.com2008-08-151-1/+1
| | | | | | TBR=mal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@943 0039d316-1c4b-4281-b951-d872f2087c98