| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
the download manager. Move chrome_paths_mac from a .cc to a .mm to allow Cocoa.
Review URL: http://codereview.chromium.org/39041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/31014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
files from the tree."
Revert "window_ is null during BrowserWindow creation. Assume full screen"
Revert "Move SupportsWindowFeature from BrowserView to Browser so"
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Committed on behalf of rohitrao.
http://codereview.chromium.org/28299/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/39040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/40033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the tree.
I made a small change to grit so we can use our resource ID as the translation ID making it a bit easier to read.
I also used a script to convert the existing .rc files to .xtb files.
Review URL: http://codereview.chromium.org/28327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHostTest, RenderWidgetHostTest (added to gyp)
RenderDnsMasterTest, DnsQueueTest (already in gyp)
MetricsLogTest, MetricsResponseTest (already in gyp)
NOTE: Now that we're all-gyp-all-the-time, only the first couple tests are really being added.
Review URL: http://codereview.chromium.org/27297
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is false.
TBR=pkasting
Review URL: http://codereview.chromium.org/39023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we can share the code on all platforms. I still left a
SupportsWindowFeature method in BrowserView that handles
fullscreen mode which is (for now) a Windows specific
feature.
Review URL: http://codereview.chromium.org/27372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
page.
BUG=none
TEST=press the star button on a page you haven't bookmarked. The star
should light up. Press escape, the bubble should close and the
bookmark should be removed. Repeat with an existing bookmark and
make sure pressing escape doesn't remove the bookmark.
Review URL: http://codereview.chromium.org/40019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Correct the includes, forward declare TabContents.
Review URL: http://codereview.chromium.org/39011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The toolbar will own the LocationBarView, which implements the LocationBar interface. Plumb the request for the LocationBar through from the browser window to the toolbar.
Review URL: http://codereview.chromium.org/40008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- provide apis to get and override the app bundle
- w/in the core code, use this api for fetching the bundle
- render sandbox config
- resource bundles
- test shell font
- w/in the unittest boot straps, use the mac util to override the bundle so resources can be found.
Review URL: http://codereview.chromium.org/28214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
or filing a bug as a placeholder. Reduces noise at startup.
Review URL: http://codereview.chromium.org/27353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
std::wstring to utf8 url fixer upper function.
These files should now compile on Linux.
Review URL: http://codereview.chromium.org/28323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Make sure the scoped_ptr is initialized before trying to open a file.
* Assign the result of FilePath::Append to download_file_path_.
R=ananta
BUG=8087
Review URL: http://codereview.chromium.org/28349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This change makes our IME backend run not only on Windows but also on Linux and Mac. This change also adds another unit-test which verifies the backend runs on Linux and Mac without problems.
Review URL: http://codereview.chromium.org/27124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
their view.
Also fix the back dropdown so that it opens the DOMUI version of History rather than the NativeUI version.
BUG=8086,8297
Review URL: http://codereview.chromium.org/39002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
activated because I removed code to explicitly activate the window in my change earlier today
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
NonClientView::GetPreferredSize method... it was returning the preferred size of the client area not the non-client area!
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://crbug.com/8247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
called multiple times. We need to add UI to make what's happening clearer to the user, but this gets us over the hump for now. Also change the history page to queue deletions.Allow history search from the new tab page.Make history title inclusion safer (createTextNode changes).Show starred status on history page.BUG=8214,8163,8271,8284
Review URL: http://codereview.chromium.org/28308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=7828
Original patch by Craig Schlenter <craig.schlenter@gmail.com> at
http://codereview.chromium.org/20529/show
Review URL: http://codereview.chromium.org/27374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
releases.
Review URL: http://codereview.chromium.org/28347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28324
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutomationProvider::OnMessageFromExternalHost signature
change.
TBR=nsylvain
Review URL: http://codereview.chromium.org/27368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
explicitly passing
in a target Javascript function to execute. The onmessage handler is a one argument Javascript
function for now.
Review URL: http://codereview.chromium.org/28291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This completes the collapsing of window types and browser frames around a single class: views::Window. CustomFrameWindow is removed with this change.
The Browser window is represented by a single views::Window subclass: BrowserFrame, which replaces both AeroGlassFrame and OpaqueFrame.
NonClientView is now a container of two sibling classes - the Window's ClientView (in the Browser's case, BrowserView), and a NonClientFrameView subclass, which provides the rendering for the non-client portions of the window. These Views are siblings rather than the ClientView a child of the NonClientFrameView because when the DWM is toggled, the ClientView would have to be re-parented. Many Views make the assumption they are only inserted into a View hierarchy once, and so this is problematic. By having the views be siblings, this is avoided.
With this in mind, all of the former NonClientViews now become NonClientFrameView subclasses:
DefaultNonClientView -> CustomFrameView
(non-existent, NonClientView) -> NativeFrameView
AeroGlassNonClientView -> GlassBrowserFrameView
OpaqueNonClientView -> OpaqueBrowserFrameView
The latter two derive from NonClientFrameView via BrowserNonClientFrameView, which adds some extras.
I also had to modify the TabRenderer class to know how to drop its cache of tab background images when the theme changes since it uses different ones for Glass and non-Glass.
This change also fixes a few non-client flicker issues relating to window non-client activation by using more ScopedRedrawLocks. (Touches info_bubble.cc, window.cc)
Bugs fixed:
http://crbug.com/153
http://crbug.com/747
http://crbug.com/2371
http://crbug.com/3264
http://crbug.com/8234
Plumbing for http://crbug.com/8247
Design docs:
http://dev.chromium.org/developers/design-documents/views-windowing
http://dev.chromium.org/developers/design-documents/browser-window
Review URL: http://codereview.chromium.org/27317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
unittest to try to solve intermittent memory leaks in those tests.
Review URL: http://codereview.chromium.org/27360
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
had been deallocated.
Review URL: http://codereview.chromium.org/27363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also, normalize extension IDs to lower case when reading them in. GURL
lower cases them when used as hostnames, so string comparisons need to be done
in lower case to work.
Review URL: http://codereview.chromium.org/28331
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- created dom_operations_private.h for things that mention WebCore types
that are only needed within webkit/glue.
- moved contents of webkit_glue.h to the right locations.
- moved FilePath::StringType <-> WebString conversion out of glue_util
into webkit_glue since it is part of the public API.
- minimized includes in webkit_glue.h
R=dglazkov
Review URL: http://codereview.chromium.org/27351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Highlights of changes:
- Added methods to disk_cache::Entry:
- Entry::PrepareTargetAsExternalFile(int index)
Prepare a stream in an entry to use external file for storage.
- Entry::GetExternalFile(int index)
Get the external file backing the stream in the entry.
- Added a property "CacheType type_" to HttpCache, along with setter and getter.
There shall be two cache types, COMMON_CACHE and MEDIA_CACHE for distinguishing between different purpose of HttpCache. We have this property to trigger special behavior for caching needs of media files.
- Added static methods to ChromeURLRequestContext
- ChromeURLRequestContext::CreateOriginalForMedia
Create a URLRequestContext for media files for the original profile.
- ChromeURLRequestContext::CreateOffTheRecordForMedia
Create a URLRequestContext for media files for off the record profile.
- Added method to Profile interface.
- GetRequestContextForMedia
To get the request context for media files from the context.
Design decissions:
- Enforce writing to external file by calling methods to Entry rather than construct Backend by a different flag.
Since we only want a valid and full response to go into an external file rather than redirection response or erroneous response, we should let HttpCache::Transaction to decide when to have an external file for response data. We eliminate a lot of useless external cache files.
- Adding the CacheType enum and property to HttpCache, we could allow possible (?) future extensions to HttpCache to handle other different caching needs. And there's no need to add change constructors of HttpCache, but maybe we should add a specific constructor to accomodate a media HttpCache?
- Adding Profile::GetRequestContextForMedia()
Since we will need to use this new request context in ResourceDispatcherHost, I think the best place to keep it is in the profile. Also we will expose to user that there's a separate cache for media, so it's better to expose it in the Profile level to allow settings to the media cache, e.g. max file size, etc.
Review URL: http://codereview.chromium.org/19747
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=wtc@chromium.org
Review URL: http://codereview.chromium.org/27357
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10744 0039d316-1c4b-4281-b951-d872f2087c98
|