| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3050035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(A.k.a. shaving a yak to get rid of a FromWStringHack().)
BUG=24672
TEST=builds
Review URL: http://codereview.chromium.org/3064032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3060042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change from Ascender* to Arimo, Tinos and Cousine.
BUG=cros:5287 (http://crosbug.com/5287)
TEST=On CrOS, go to Options | Advanced (under the hood) | Fonts and see
Arimo, et al are the default fonts for Sans-serif, serif and monospace.
TBR=tony
Review URL: http://codereview.chromium.org/3029049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=49590
TEST=this test
Review URL: http://codereview.chromium.org/3085007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=phajdan.jr
Review URL: http://codereview.chromium.org/3091003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile
TBR=mad
Review URL: http://codereview.chromium.org/3072018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48862
TEST=editing image exceptions works
Review URL: http://codereview.chromium.org/2883045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
common/ is for files shared between the renderer and browser processes, and OwnedWidgetGtk is not used outside of browser/.
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/3063023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
relating to http://code.google.com/p/chromium/issues/detail?id=51058
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3066032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
because an event listener registered by a singleton tried to access the
current message loop, which may not exist.
BUG=48717
TEST=Re-enables AccessibilityEventRouterViewsTest.TestFocusNotification
Review URL: http://codereview.chromium.org/3092004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should delete the callback after running it.
This change removes Valgrind suppressions for the leak.
TEST=valgrind
BUG=50729
Review URL: http://codereview.chromium.org/2819085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50927
TEST=Manually configure a profile with prefs::kHomepage = chrome://newtab and prefs::kHomePageIsNewTabPage = true, fire up chrome and try to configure a different homepage URL through the options dialog.
Review URL: http://codereview.chromium.org/3092003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes:
* Replace the edit item's segmented control with 3 buttons
* Make the root view of both items a MenuTrackedRootView
* Use the custom MenuTrackedButton for all the buttons
BUG=49356
TEST=Click open the Wrench menu, hold, and drag over the buttons and they perform their function.
Review URL: http://codereview.chromium.org/3072014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3054037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3010046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notify the user of the error event if the user has been
notified about the update progress already. Stay quiet
otherwise.
BUG=chromium-os:5266
TEST=unit tests
Review URL: http://codereview.chromium.org/3033048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Toolbar.xib change brings browser-action container view out from under
Omnibox.
Push browser-action sizing code into controller to reduce exposed
constants. Make size consistent with other toolbar buttons. 4px
visual spacing from omnibox to first browser action (grippy in that
area), between browser actions, and last action to wrench menu.
browser_actions_overflow_Template.pdf resource for browser-action
chevron. Chevron same height as browser actions. Get rid of divider
between browser actions and wrench (future CL will integrate it into
chevron button). Chevron 4px from Omnibox or 2px from last browser
action, then 4px to wrench menu. Chevron button has hover like other
buttons.
BUG=50575
TEST=Browser-actions area still works right WRT spacing and rearranging and everything else.
Review URL: http://codereview.chromium.org/3012044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is a small change to expect the directory of extensions and the urls file to be in the data directory instead of the current directory.
Review URL: http://codereview.chromium.org/3067028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes Autocomplete filling to force preview of "suggested" Autocomplete value before setting the value proper. This accounts for the delayed refresh of the WebCore HTMLInputElement UI where |HTMLInputElement::setValue()| defers UI refresh until the control loses focus.
BUG=50426
TEST=Manual test according to bug.
Review URL: http://codereview.chromium.org/3015049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteMatch is a struct, and should thus be forward-declared as such.
Otherwise, Clang warns about the mismatch, and we treat the warning as an error.
BUG=49304
TEST=None
Review URL: http://codereview.chromium.org/2805086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=verify clear browser data buttons work correctly via --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3027039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50307
TEST=Start chrome with --enable-expose-for-tabs. cmd-f10 should toggle a grey overlay instead of doing something strange to the tabstrip.
Review URL: http://codereview.chromium.org/3007028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
separator. This proves a bit tricky as normally separators are closer
to the bottom of the space provided. I've centered them now so that
the buttons look centered too.
BUG=50099
TEST=see bug
Review URL: http://codereview.chromium.org/3072015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Added histogram to track utilization (vs waste).
r=mbelshe
Review URL: http://codereview.chromium.org/3026038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Overide section css to make things look like mock;
- CSS/JS updates per arv's previous reviews to make everything in CSS;
BUG=chromium-os:4744
TEST=none.
Review URL: http://codereview.chromium.org/3080017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
3px from top and bottom of images to cell edges in popup. With this
change baselines worked out without tweaking.
Omnibox popup text wasn't quite aligned with field because previous
change used leading 'w' (regression). This change measured using
leading 'P'.
Adjust keyword-hint decoration spacing around the image. Also adjust
baseline to match font (regression).
Modify ImageDecoration to center the image horizontally, which allows
the decoration width to be independent of the image width.
PageActionDecoration uses this to pin the effective size at
|kPageActionIconMaxSize|.
Position page-action and bookmark popups so top border is at same gap
from Omnibox (2px) as Omnibox popup. The mocks actually show the
bookmark point as an additional px from the star "crotch", but I think
this is reasonable for M6.
BUG=50575, 50765
TEST=none. Everything still works?
Review URL: http://codereview.chromium.org/3015046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
destructor.
BUG=45400
TEST=None
Review URL: http://codereview.chromium.org/2856082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Added two new hooks for extensions: GetExtensionsInfo returns information about all installed extensions and UninstallExtensionById uninstalls a given extension based on its id.
Review URL: http://codereview.chromium.org/3053034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Windows.
Review URL: http://codereview.chromium.org/3043044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3073020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Still to do: do the same for DictionaryValue.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3023037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
string_number_conversions.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3054036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ASCIIToUTF16. I removed string_util includes from a few places where it
obviously wasn't needed.
In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm
going to do an even later pass to find the unnecessary string_util.h includes
and remove them.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3058027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: pfeldman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
click-to-play is enabled.
BUG=50506
TEST=none
Review URL: http://codereview.chromium.org/3033046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45464,10764
TEST=See first bug for manual test.
Review URL: http://codereview.chromium.org/3029040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/4411
TEST=On login screen change the language through new user pod and verify that for existing user pods text is translated to the new language.
Review URL: http://codereview.chromium.org/3047044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
connect page.
Review URL: http://codereview.chromium.org/3071016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50416
Review URL: http://codereview.chromium.org/3013057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3037037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The webRequest API doesn't support the planned filter and extraInfoSpec parameters yet, these will be added later.
BUG=50943
TEST=ExtensionApiTest.WebRequest,ExtensionApiTest.WebNavigation
Review URL: http://codereview.chromium.org/3061041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3005044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
click-to-play is enabled.
Screenshot: http://imgur.com/ZKsQB.png
XIB changes: Add a rounded rect button hooked up to |loadAllPlugins:| in the File's Owner and referenced by its |loadAllPluginsButton_| outlet, wrapped in a GTMWidthBasedTweaker.
BUG=49677
TEST=ContentSettingBubbleModelTest.*
Review URL: http://codereview.chromium.org/3015036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This enables the renderer to get more information about a plugin than just the path.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3015029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54719 0039d316-1c4b-4281-b951-d872f2087c98
|