| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Original patch by Philippe Beaudoin (see http://codereview.chromium.org/554143 ), r=me, tweaked.
BUG=33460
TEST=Write goog in the omnibox, drag around, while pressing the left mouse button hit ESC. The selection should return to the first entry and not move as you continue to drag.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
modified.
Instead, add an association table at the top of browser_theme_pack.cc that maps
the JSON string name and IDR# to a stable constant that won't change between
releases.
The ThemePack version number has been bumped to two, forcing a rebuild.
BUG=33416
TEST=none
Review URL: http://codereview.chromium.org/548207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows systems.
BUG=28176
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37578
Review URL: http://codereview.chromium.org/542030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to HKCU\Software\Adobe. Since we already have write access
to HKCU\Software\Macromedia, I don't believe this is making it
less secure than it actually is. We also give it write access to
AppData\Adobe.
Finally, we also need to let it do a directory listing
in c:\users\<user> and c:\users\<user>\AppData, otherwise
it crashes.
Review URL: http://codereview.chromium.org/554095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the extension autoupdater downloads .crx files, we rely on the UrlFetcher
class to do it for us. Inside OnCrxFetchComplete I had put a sanity check that
the url we finished with was the same one we started with, but of course this
breaks the case of redirects and wasn't needed because the API of UrlFetcher is
that there's one UrlFetcher per outstanding fetch.
BUG=26177
TEST=Extension Autoupdate should keep working normally, and work with redirects
such as the example mentioned in the bug.
Review URL: http://codereview.chromium.org/549215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a DOMMessageHandler to FileBrowse based SelectFileDialog that supports
a "setDialogTitle" call from javascript.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/554136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
warning.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/552253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/548203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
they were marked as optional and if either functions were called no arguments, the extension process was terminated because it thought was expecting an argument list.
BUG=33628
Review URL: http://codereview.chromium.org/558049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
All I did was re-save in IB, no changes.
Review URL: http://codereview.chromium.org/557081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 34052
TEST= no valgrind error.
Review URL: http://codereview.chromium.org/555199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/557043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=20812
TEST=
* Click right part of download item. Menu should appear on mouse down.
* After menu is closed, mousing over the menu should not show the depressed state.
* Click left part of download item. File should be opened on mouse up.
* http://crbug.com/28215 should not have regressed.
Review URL: http://codereview.chromium.org/380002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We should not raise an "auth needed" event if we're not supposed to attempt
auth in the first place.
TBR=albertb
Review URL: http://codereview.chromium.org/549222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
UI coming soon), and provide the hooks for the Win7 implementation.
BUG=http://crbug.com/8039
TEST=download; see progress in the dock icon
Review URL: http://codereview.chromium.org/545157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the UI.
Also selects the first cookie node whene expanding an origin node.
BUG=33248
TEST=With a lot of cookies in your profile: Chromium-->Preferences-->Under the Hood-->Show cookies... Filter by a domain, expand the domain and the first cookie should be selected. Clear the filter and list should reappear speadily.
Review URL: http://codereview.chromium.org/554151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This gives plugins mostly correct window activation information; there are still a few loose ends like initial focus state and changes that happen while plugins are in background tabs, but those will be handled in follow-up bugs.
BUG=31847
TEST=Plugins that are in background windows should act accordingly (e.g., Silverlight hover effects shouldn't trigger)
Review URL: http://codereview.chromium.org/549194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Vernon Tang.
BUG=33483
TEST=Check that user can't select an .app using an html file input element. Check that the "load unpacked extension" and "pack extension" browse dialogs in chrome://extensions/ continue to work as expected.
Review URL: http://codereview.chromium.org/548199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Make Import settings dialog app modal.
* No longer allow display of multiple dialogs at once.
* For some reason, unit test was present but missing from .gyp file - re-added and freshened up.
BUG=33011
TEST=selecting Chrome->Import Bookmarks and settings multiple times should only open bookmarks once.
Review URL: http://codereview.chromium.org/556097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/549217
Review URL: http://codereview.chromium.org/558065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
selected.
BUG=29397
TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 and select entire text in Omnibox, then copy the text.
Paste the copied text into other applications such as gedit and check if the pasted text contains %E4%B8%8A%E5%9C%B0, not 上地.
Paste the copied text into Firefox's URL bar and type return. Check if you are navigated to the same website.
Paste the copied text into textareas in Chrome and check if the pasted text contains %E4%B8%8A%E5%9C%B0.
TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 again and select "q=上地" in Omnibox, then copy the text.
Paste it into somewhere and check if you see "q=上地".
TEST=Copy "上地" from somewhere and paste it into Omnibox.
Copy from Omnibox and paste it into other apps such as gedit. Then check if the pasted text is NOT encoded.
TEST=Paste the copied text into Gmail's rich text editing mode and check if the pasted text contains 上地. Right click the link you pasted in Gmail and check if you see "Go to: http://www.google.com/...%E4%B8%8A%E5%9C%B0".
TEST=Steps described in http://codereview.chromium.org/173098.
Review URL: http://codereview.chromium.org/465053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the default monitor, not the current monitor when disabling the
full screen hack in metacity/compiz.
This is just a guess, I don't have a multimonitor setup here.
BUG=32347
Review URL: http://codereview.chromium.org/557056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Slightly complicated because the default theme's "clicked" gradient is not transparent.
BUG=21176
TEST=Start long download (e.g. ubuntu disk image), then go through a lot of themes and make sure the status text stays readable, both in normal and clicked states. Also check with default theme.
Review URL: http://codereview.chromium.org/551224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/549217
TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/555195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/549217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension bubble.
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/556098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Adds ExtensionInstalledBubble.xib, which contains the framework for the bubble itself (icon view, close button, and three message fields).
BUG= 26974
TEST= Install an extension. Bubble should show same information as windows bubble.
Review URL: http://codereview.chromium.org/527012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=1426
TEST=Enable Chrome based login-manager. Login should work.
Review URL: http://codereview.chromium.org/553132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28062
Review URL: http://codereview.chromium.org/552252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pfeldman
Review URL: http://codereview.chromium.org/558064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a simple change to replace the old preference-using code w/
code that just pokes the HostContentSettingsMap directly to toggle
the third-party cookie blocking setting.
R=pkasting
Review URL: http://codereview.chromium.org/548218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28062
Review URL: http://codereview.chromium.org/553148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
so I'm doing a quick hack here so that we don't ship more builds with it broken.
BUG=30291
TEST=Install news sample extension. Expand a section, then contract it. Popup should contract too.
Review URL: http://codereview.chromium.org/556058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
clean up various other bits.
This also adds some functionality useful to the Exceptions dialogs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/557074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I renamed the method name in preparation of using this for opening the bookmark manager extension.
BUG=None
TEST=Open History. Do a search and open history again. We should not create a new tab but go to the existing one.
Review URL: http://codereview.chromium.org/553151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allow cookies instead of denying them.
I broke this yesterday when I made the CookiePolicy be an optional
element of the URLRequestContext. See r37624.
R=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/557073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the bookmark manager.
BUG=32194
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.BookmarkManager
Review URL: http://codereview.chromium.org/551220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33657
TEST=Drag and drop thumbnails on the NTP to reorder them.
Review URL: http://codereview.chromium.org/558055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/554145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=still compiles
Review URL: http://codereview.chromium.org/555189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33696
TEST=See bug report for repro steps and make sure they no longer apply. Verify that dragging stuff to web contents works as before.
Review URL: http://codereview.chromium.org/551221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Omaha active user reporting.
BUG=33457
TEST=The dr value of "1" is written with length 4 bytes.
Review URL: http://codereview.chromium.org/548204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This also rewrites the affected UI bits to make it easier to do this, get rid of unnecessary code, and be more consistent with the blocked content bubble code.
BUG=32719
TEST=Content settings windows now have radio buttons that work, and remember their settings. The Flash link works too.
Review URL: http://codereview.chromium.org/558060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/549218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pkasting
Review URL: http://codereview.chromium.org/552247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
1- net::CookiePolicy becomes an interface.
2- Old implementaiton of CookiePolicy copied to StaticCookiePolicy.
3- ChromeULRRequestContext implements CookiePolicy.
4- HostContentSettingsMap gets a global "BlockThirdPartyCookies" pref.
R=pkasting
Review URL: http://codereview.chromium.org/556095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37622 0039d316-1c4b-4281-b951-d872f2087c98
|