summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Rename AutoFillForm to FormFieldValues to better reflect the purpose of the ↵jhawkins@chromium.org2009-10-2014-101/+107
| | | | | | | | | | data structure. BUG=none TEST=none Review URL: http://codereview.chromium.org/306014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29580 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unused handlers as wellarv@chromium.org2009-10-201-321/+1
| | | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/292001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29579 0039d316-1c4b-4281-b951-d872f2087c98
* Allow ESC to cancel ALT+SHIFT+T in Toolbar.mhm@chromium.org2009-10-203-16/+57
| | | | | | | | | | | By overriding SkipDefaultKeyEventProcessing in View, it will ensure that the current hackish implementation of Toolbar request focus will be dealt before any other focus related actions and accelerators. BUG=8239 TEST=Press ESC while in accessibility mode. Review URL: http://codereview.chromium.org/272024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29572 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bubbles deactivating the opaque frame.ben@chromium.org2009-10-201-8/+8
| | | | | | | | | | | The theme work caused a check that had been included to see if the frame view should be painted as active even if it was inactive. This reintroduces that check. http://crbug.com/20966 TEST=see bug Review URL: http://codereview.chromium.org/303012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29571 0039d316-1c4b-4281-b951-d872f2087c98
* Make escape remove a bookmark if it's just been added (but not if it already ↵pinkerton@chromium.org2009-10-202-5/+66
| | | | | | | | | | existed). Add unit tests for both behaviors. Add metrics to match windows code. BUG=24466 TEST=if bookmark existed prior to clicking star, esc should leave it. if clicking star added bookmark, esc should remove it. Review URL: http://codereview.chromium.org/300022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29562 0039d316-1c4b-4281-b951-d872f2087c98
* Add WebFrameClient::cancelledError to avoid a dependency ondarin@chromium.org2009-10-202-18/+30
| | | | | | | | | | | | | | | | | the net/ module. This CL also tweaks some existing WebFrameClient methods: 1) to ensure that they have a WebFrame pointer for context 2) to rename cannotShowURLError to cannotHandleRequestError to better match the canHandleRequest method. R=yaar BUG=24606 TEST=none Review URL: http://codereview.chromium.org/306011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29561 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 29457, because this is making ExtensionBrowserTest.PageAction ↵mpcomplete@chromium.org2009-10-2011-94/+68
| | | | | | | | | | | | | | | | | | crash on Vista" Original description: Implement badges for page actions. Also add badge text color API. Also change color APIs from wanting ARGB to RGBA. BUG=24635 BUG=24644 BUG=25215 Review URL: http://codereview.chromium.org/293031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29556 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race bug where content scripts would not apply to the first page load.mpcomplete@chromium.org2009-10-201-0/+4
| | | | | | | | BUG=11547 Review URL: http://codereview.chromium.org/302011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29555 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prevent browser window from re-displaying when partially shut down.shess@chromium.org2009-10-201-0/+8
| | | | | | | | | | | http://crbug.com/24734 TEST=Start Chrome, Command-o, Command-q, should quit cleanly. TEST=download a file. Should be able to Quit the browser cleanly. TEST=Open two windows with one tab apiece. Drag one to the other. Should not crash. Review URL: http://codereview.chromium.org/295028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29554 0039d316-1c4b-4281-b951-d872f2087c98
* Adding new image needed for the managment UI. This way I might befinnur@chromium.org2009-10-201-0/+0
| | | | | | | | | | | | able to try this change on the try bot in my other changelist. TBR=aa BUG=12119 TEST=None Review URL: http://codereview.chromium.org/295029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29553 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some structures in webkit/glue to string16.darin@chromium.org2009-10-2027-165/+193
| | | | | | | | | | R=yaar BUG=none TEST=none Review URL: http://codereview.chromium.org/305002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29549 0039d316-1c4b-4281-b951-d872f2087c98
* Remove +x bit from files that shouldn't have it.evan@chromium.org2009-10-20103-0/+0
| | | | | | Review URL: http://codereview.chromium.org/307007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29548 0039d316-1c4b-4281-b951-d872f2087c98
* "Fix" a NOTIMPLEMENTED on Linux by using the default password store.evan@chromium.org2009-10-201-8/+6
| | | | | | | | | We haven't yet resolved how to integrate with OS-native password stores, so printing this NOTIMPLEMENTED isn't helpful. Review URL: http://codereview.chromium.org/308003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29545 0039d316-1c4b-4281-b951-d872f2087c98
* If we're in the middle of a drag, don't allow the user to middletony@chromium.org2009-10-201-1/+14
| | | | | | | | | | | | click to close or right click for the context menu. BUG=21627 TEST=On a tab, left mouse down, right mouse click, then drag. Left mouse up should release the tab. Review URL: http://codereview.chromium.org/305004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29542 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: guarantee removal of BROWSER_WINDOW_READY registration.estade@chromium.org2009-10-201-3/+3
| | | | | | | | | | | | | In unit tests, we were not removing the registration because we never get the BROWSER_WINDOW_READY notification. When a browser later gets allocated the same memory address, we hit a DCHECK in registrar_.Add(). This change should be safe because BROWSER_WINDOW_READY only gets called at most once per browser instance. BUG=none TEST=linux build bots stop flaking on this test Review URL: http://codereview.chromium.org/306009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29538 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 223.6 to 224.0chrome-bot@google.com2009-10-201-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29537 0039d316-1c4b-4281-b951-d872f2087c98
* PanelControler supportoshima@chromium.org2009-10-209-135/+367
| | | | | | | | | | | | | | | | * Refactored BrowserExtender and added NormalExtender and PopopExtender. BrowserExtender::Create factory method returns appropriate extender for given BrowserView. * Added #if/#else to PanelController to accept BrowserView in Constructor. * added guard code in Close so that it will ignore 2nd invocation of Close. (views seems to call Close() (when it requests, and when it's really closed) Added missing code in TabOverviewMessageListener BUG=None TEST=None Review URL: http://codereview.chromium.org/276075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29533 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an annoying NOTIMPLEMNETED.estade@chromium.org2009-10-201-2/+1
| | | | | | | | | | | | This notimpl shows up every time a renderer crashes. People frequently post it in bug reports as if it's meaningful. Get rid of it. BUG=TEST=none Review URL: http://codereview.chromium.org/294028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29532 0039d316-1c4b-4281-b951-d872f2087c98
* Make dropped tabs animate from where they were dropped. Make room for the ↵pinkerton@chromium.org2009-10-203-11/+43
| | | | | | | | | | full width of the tab placeholder. Make tab dragging as smooth as glass. BUG=24982, 24983 TEST=tab dragging between windows, tab dragging w/in a window. Review URL: http://codereview.chromium.org/306006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29531 0039d316-1c4b-4281-b951-d872f2087c98
* Enable browser commands unit test on linux.estade@chromium.org2009-10-201-3/+0
| | | | | | | | | It works. BUG=25078 Review URL: http://codereview.chromium.org/297007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29530 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore invalid urls on command line.estade@chromium.org2009-10-201-2/+4
| | | | | | | | | BUG=none TEST=chrome doesn't dcheck if you launch with a command line such as "chrome %U" Review URL: http://codereview.chromium.org/293010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29529 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Change text for extension download UI.estade@chromium.org2009-10-201-2/+5
| | | | | | | | | BUG=25257 TEST=none Review URL: http://codereview.chromium.org/303009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29528 0039d316-1c4b-4281-b951-d872f2087c98
* Add dialog to tell user to close Firefox during import, if it's open and ↵mirandac@chromium.org2009-10-203-7/+12
| | | | | | | | | | | | | blocking. OS-Mac only. BUG= http://crbug.com/20899 TEST= Open Firefox; start up Chrome and try to import settings from Firefox. Dialog box warns you to close Firefox. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29481 Review URL: http://codereview.chromium.org/283023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29527 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash bug when attempting to download a url with unsupported scheme,tony@chromium.org2009-10-201-3/+4
| | | | | | | | | | | | | | | | | e.g. 'data:', by 'Alt + Click'. Note: This change only fixes crash. Supporting a download for URL with 'data:' scheme is not implemented in the change. BUG=24846 TEST=See the first entry of bug 24846 and confirm that the browser won't crash. Original patch by hayato@google.com at http://codereview.chromium.org/287002/show Review URL: http://codereview.chromium.org/306007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29524 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup unneccessary include.thakis@chromium.org2009-10-201-1/+0
| | | | | | Review URL: http://codereview.chromium.org/308002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29519 0039d316-1c4b-4281-b951-d872f2087c98
* Adding two images for the new Extension managment UI.finnur@chromium.org2009-10-202-0/+0
| | | | | | | | | | | | | | I separated this from the other changelist so that the try servers wouldn't fail because a binary file had been added. TBR=rafaelw BUG=12119 TEST=None, no code change. Review URL: http://codereview.chromium.org/294024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29517 0039d316-1c4b-4281-b951-d872f2087c98
* Disables session restore on chrome os when running tests. This causessky@chromium.org2009-10-201-0/+10
| | | | | | | | | | | | problems with some tests as the nested message loop run by session restore gets prematurely exited and Chrome is left in a weird state. BUG=none TEST=none Review URL: http://codereview.chromium.org/294009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29515 0039d316-1c4b-4281-b951-d872f2087c98
* Minimize dependency of user scripts.mad@chromium.org2009-10-209-82/+72
| | | | | | | | | | | And made some minor lint fixes and code refactoring on the way, based on CR comments of previous attempt. BUG=none TEST=Make sure that the extension resources can still be properly localized and that they also load correctly when they are not localized. Review URL: http://codereview.chromium.org/267051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29512 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: change PIDs to base::ProcessId (or pid_t, as appropriate).viettrungluu@chromium.org2009-10-205-8/+9
| | | | | | | | | | | We probably want to discourage the use of ints for PIDs. This is a start; there are many other places where we should fix this. BUG=25272 TEST=none Review URL: http://codereview.chromium.org/300010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29511 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29457, because this is making ExtensionBrowserTest.PageAction crash ↵nsylvain@chromium.org2009-10-2011-67/+94
| | | | | | | | | | | | | | | | | | | | on Vista Original description: Implement badges for page actions. Also add badge text color API. Also change color APIs from wanting ARGB to RGBA. BUG=24635 BUG=24644 BUG=25215 Review URL: http://codereview.chromium.org/291003 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/306004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29509 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 223.5 to 223.6chrome-bot@google.com2009-10-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29503 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at new page and browser action docs basedaa@chromium.org2009-10-2040-1011/+410
| | | | | | | | on new API. Deleted old stuff. TBR=kathyw@google.com,rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29500 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle extension reloading in the task manager.phajdan.jr@chromium.org2009-10-207-5/+69
| | | | | | | | | BUG=18693 TEST=Added new tests to browser_tests. Review URL: http://codereview.chromium.org/300005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29498 0039d316-1c4b-4281-b951-d872f2087c98
* add enableWebSockets in WebKit APIukai@chromium.org2009-10-203-5/+4
| | | | | | | | | | | | and remove experimentalWebSocketsEnabled from WebPreferences/Settings. Patch for http://bugs.webkit.org/show_bug.cgi?id=29896 will remove Settings::experimentalWebSocketsEnabled(), so we need to remove it from WebPreferences too. This is because such configuration in Settings confuses other WebKit developers and such control is only required for chromium. Instead add WebKit::enableWebSockets() in this change to control WebSockets feature. Review URL: http://codereview.chromium.org/292012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29497 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.browserAction.setIcon({path:...});aa@chromium.org2009-10-2014-105/+245
| | | | | | | | BUG=22575 Review URL: http://codereview.chromium.org/269103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29495 0039d316-1c4b-4281-b951-d872f2087c98
* Add the first event ui test + a bunch of refactoring.jorlow@chromium.org2009-10-204-49/+117
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/271020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29491 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit up to 49830 and fix a build error caused by that revision.jorlow@chromium.org2009-10-201-1/+1
| | | | | | | | | | TBR=yutak TEST=none BUG=none Review URL: http://codereview.chromium.org/294017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29489 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK.thakis@chromium.org2009-10-202-0/+8
| | | | | | | | | BUG=none TEST=Focus background of google.com, hit "a". Shouldn't DCHECK. Review URL: http://codereview.chromium.org/297017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29488 0039d316-1c4b-4281-b951-d872f2087c98
* Split the arg to --extra-chrome-flags by spaces before passing to Chromenirnimesh@chromium.org2009-10-201-1/+5
| | | | | | | | | | | Otherwise the whole string (with spaces) is passed to Chrome, and it doesn't work. BUG=none TEST=ui tests should work Review URL: http://codereview.chromium.org/276073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29487 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Chromebotnirnimesh@chromium.org2009-10-202-47/+43
| | | | | | | | | | A step towards chromebot for mac. Sets up Breakpad to build and run with Chromium build if mac_chromium_breakpad==1. Do things similar to linux so far. Not enabled on any bot yet. Review URL: http://codereview.chromium.org/278014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29484 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use gtk_dialog_run for extension install errors becausetony@chromium.org2009-10-203-6/+6
| | | | | | | | | | it blocks the main message loop. BUG=19441 Review URL: http://codereview.chromium.org/294014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29482 0039d316-1c4b-4281-b951-d872f2087c98
* Add dialog to tell user to close Firefox during import, if it's open and ↵mirandac@chromium.org2009-10-204-2/+55
| | | | | | | | | | | blocking. OS-Mac only. BUG= http://crbug.com/20899 TEST= Open Firefox; start up Chrome and try to import settings from Firefox. Dialog box warns you to close Firefox. Review URL: http://codereview.chromium.org/283023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29481 0039d316-1c4b-4281-b951-d872f2087c98
* New directory to hold files that aren't directly referenced by the docs,kathyw@google.com2009-10-203-0/+1902
| | | | | | | | | | | but that are used to produce images for the docs. TEST=none BUG=none Review URL: http://codereview.chromium.org/293015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29480 0039d316-1c4b-4281-b951-d872f2087c98
* Assigning INFINITE (which is 0xFFFFFFFF) to an int, is not a very good idea...mad@chromium.org2009-10-191-1/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/285012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29478 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate PathService::Get(..., wstring*) and use FilePath instead.evan@chromium.org2009-10-198-32/+42
| | | | | | | | | | | | I tried fixing all the Windows code but there's a *ton* of it. This change will at least prevent people from adding new code that uses the deprecated version (as that won't compile on Lin/Mac). BUG=24672 Review URL: http://codereview.chromium.org/293013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29472 0039d316-1c4b-4281-b951-d872f2087c98
* (Copy of previous CL that existed in a client I lost)cevans@chromium.org2009-10-191-3/+10
| | | | | | | | | | | | | - Don't treat the body of an "authentication required" response as a valid dictionary! - In the event of a 200 status code, check the response actually looks like a dictionary. BUG=24486 TEST=Verified the appearance of new dictionaries after changing spell-check language; verified spell-checking on new dictionaries. TBR=sidchat Review URL: http://codereview.chromium.org/295014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29471 0039d316-1c4b-4281-b951-d872f2087c98
* Delete unused themes from disk on shutdown.tony@chromium.org2009-10-194-2/+28
| | | | | | | | | | | | This reduces the size of the Preferences file and frees up some disk space. The smaller Preferences file should help improve startup time for users who have installed lots of themes. BUG=24377 Review URL: http://codereview.chromium.org/303006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29468 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to SendAndRunNestedMessageLoop in Mac printingstuartmorgan@chromium.org2009-10-191-6/+1
| | | | | | | | | | | With the recent fix for nested message loops on the Mac, this works correctly. BUG=24808 TEST=Printing on the Mac should continue to work. Review URL: http://codereview.chromium.org/295012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29466 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/269066/show for Thiago:sky@chromium.org2009-10-191-0/+1
| | | | | | | | | | | Add missing file (bookmark_model_observer.h) to chrome.gyp. BUG=None TEST=None Review URL: http://codereview.chromium.org/300009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29463 0039d316-1c4b-4281-b951-d872f2087c98
* Degrade the https color and lock icon for the page that has a worker that ↵dimich@google.com2009-10-199-45/+172
| | | | | | | | | | | loads subresource with bad cert. The idea is to make UI reflect loading of resources with bad certificates that were previously approved by the user. bug=20176 TEST=SSLUITest.TestUnsafeContentsInWorker unit_test. Review URL: http://codereview.chromium.org/268006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29461 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 08:06:58 +0000