summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* When an extension is uninstalled, close all desktop notifications from that ↵johnnyg@chromium.org2010-11-1233-231/+355
| | | | | | | | | | | | | | | extension. This change also refactors the balloon collection code to remove duplication between chrome and chromeos. Removes some gross removal code which was using fake notifications just to get the right ID. BUG=58266 TEST=open notifications from extension, uninstall extensions Review URL: http://codereview.chromium.org/4635007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65879 0039d316-1c4b-4281-b951-d872f2087c98
* Removed supports_extension and calling methods fromkbr@google.com2010-11-122-32/+0
| | | | | | | | | | | | | | WebGraphicsContext3DCommandBufferImpl which are no longer used after https://bugs.webkit.org/show_bug.cgi?id=46894 . Built on Mac OS X to test. BUG=61801 TEST=none Review URL: http://codereview.chromium.org/4836002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65878 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race in syncer thread unit test.zea@chromium.org2010-11-111-1/+1
| | | | | | | | | BUG=62876 TEST=unit_test and tsan Review URL: http://codereview.chromium.org/4833001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65876 0039d316-1c4b-4281-b951-d872f2087c98
* Updated comment to remove expectation thatkbr@google.com2010-11-111-2/+3
| | | | | | | | | | | WebGraphicsContext3DDefaultImpl is going to be removed. BUG=none TEST=none Review URL: http://codereview.chromium.org/4845002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65875 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK in ~CrashHandlerHostLinux.thestig@chromium.org2010-11-112-6/+22
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4655008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65874 0039d316-1c4b-4281-b951-d872f2087c98
* NaCl: Implement CreateMemoryObject() to support dynamic loading on Macmseaborn@chromium.org2010-11-112-0/+66
| | | | | | | | | | | | | Since NaCl needs only one shared memory object that is mappable with PROT_EXEC, we can take a short cut and pass one in at startup, saving on IPC. BUG=http://code.google.com/p/nativeclient/issues/detail?id=583 TEST=test_runner.html with NaCl-side change applied, on a Mac Review URL: http://codereview.chromium.org/4745001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65873 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in TabStripModel. If during close all a tab wassky@chromium.org2010-11-112-4/+66
| | | | | | | | | | | | | removed out from under the TabStripModel it would still attempt to remove the tab. At least this is my best guess as to what is causing the crash. BUG=34135 TEST=none Review URL: http://codereview.chromium.org/4687009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65872 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] clear widget pointer instead of letting it go stale.estade@chromium.org2010-11-114-18/+18
| | | | | | | | | BUG=62610 TEST=see bug Review URL: http://codereview.chromium.org/4820001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65871 0039d316-1c4b-4281-b951-d872f2087c98
* Update DOMUI pref stylestuartmorgan@chromium.org2010-11-111-9/+13
| | | | | | | | | | | | | | This makes a few small changes to bring things more in line with the latest mocks: - Larger font size for page and section titles. - Removes the trailing divider line after the last section. - Tweaks the inter-section spacing. BUG=59237,59264 TEST=DOMUI prefs should look more like mocks. Review URL: http://codereview.chromium.org/4826002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65870 0039d316-1c4b-4281-b951-d872f2087c98
* Revise the omnibox extension API so that specifying descriptionStyles is easier.mpcomplete@chromium.org2010-11-119-204/+391
| | | | | | | | | | | | Now each style has a range that it applies to. The styles can also overlap and be listed out of order. BUG=62385 TEST=covered by unit/browser tests Review URL: http://codereview.chromium.org/4660008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65869 0039d316-1c4b-4281-b951-d872f2087c98
* Marking test flaky.jcivelli@chromium.org2010-11-111-1/+4
| | | | | | | | | | BUG=62880 TEST=None TBR=tim Review URL: http://codereview.chromium.org/4837001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65868 0039d316-1c4b-4281-b951-d872f2087c98
* Implements a C++ version of JSONSchemaValidator.aa@chromium.org2010-11-1113-0/+1532
| | | | | | | | | BUG=none TEST=covered by unit tests Review URL: http://codereview.chromium.org/4673001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65867 0039d316-1c4b-4281-b951-d872f2087c98
* Restrict file protocol on chromeos to certain whitelisted directories. ↵achuith@chromium.org2010-11-115-0/+17
| | | | | | | | | | | Disable this for tests. BUG=chromium-os:3412 TEST=Access file: directories on chromeos. browser, ui, interactive ui and unit tests should continue to pass. Review URL: http://codereview.chromium.org/4160003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65866 0039d316-1c4b-4281-b951-d872f2087c98
* Add some verbose logging when registering COM components.tommi@chromium.org2010-11-111-0/+5
| | | | | | | | | BUG=none TEST=When using --verbose-logging with the installer, there will be entries for each COM component we [un]register. Review URL: http://codereview.chromium.org/4821001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65865 0039d316-1c4b-4281-b951-d872f2087c98
* We should use SSLInfo or related types for HTTPSwtc@chromium.org2010-11-113-6/+14
| | | | | | | | | | | URLs only. R=eroman,finnur BUG=53366 TEST=net_unittests --gtest_filter=HTTPSRequestTest.HTTPS*Test Review URL: http://codereview.chromium.org/4210004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65864 0039d316-1c4b-4281-b951-d872f2087c98
* OS X: Allow a stat in the file dialog function on the UI threaddavidben@chromium.org2010-11-111-0/+4
| | | | | | | | | | R=avi BUG=none TEST=OS X file dialogs don't trigger AssertIOAllowed DCHECKS Review URL: http://codereview.chromium.org/4673009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65863 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at removing the instant close button. Mac is using thesky@chromium.org2010-11-113-172/+7
| | | | | | | | | | | | | image, so I'm leaving it and the grd change in. A separate cl will fix the mac side and remove the image/grd change. BUG=59068 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/4801002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65862 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill form submission creates wrong addresses.dhollowa@chromium.org2010-11-114-75/+262
| | | | | | | | | | | Adds logic to filter out address submissions that are redundant, or merge addresses that match existing addresses already stored in Autofill settings. BUG=57975 TEST=PersonalDataManagerTest.Aggregate* Review URL: http://codereview.chromium.org/4765001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65861 0039d316-1c4b-4281-b951-d872f2087c98
* Add a client-side phishing detection service class.noelutz@google.com2010-11-118-1/+921
| | | | | | | | | | | | This class is responsible for talking to the client-side detection servers and to fetch the machine learning model. BUG=none TEST=ClientSideDetectionServiceTest Review URL: http://codereview.chromium.org/3815014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65860 0039d316-1c4b-4281-b951-d872f2087c98
* Tighten access to webstore private APIsasargent@chromium.org2010-11-111-1/+4
| | | | | | | | | | | | | During the security review Erik and Cris noticed that if for some reason the web store app came back null, we could end up allowing access to the webstorePrivate APIs by returning a true comparison of null to null. BUG=61954 TEST=Should be covered by existing tests. Review URL: http://codereview.chromium.org/4665008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65858 0039d316-1c4b-4281-b951-d872f2087c98
* Add multi install support to MasterPreferences and start using it in a few ↵tommi@chromium.org2010-11-1113-106/+328
| | | | | | | | | | | | | places.I'm also adding a constant for CEEE - I named it kCeee instead of kEnableCeee since it's also used in uninstalls.This change is just a beginning of being aware of having more than one product available in setup. I added some todos and dcheck for myself to keep track of places that will need more significant changes when running multiple installs. BUG=61609 TEST=All installations (chrome, chrome frame, ceee) should work as before with the exception that the CEEE switch is now --ceee and not --enable-ceee. Review URL: http://codereview.chromium.org/4635006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65855 0039d316-1c4b-4281-b951-d872f2087c98
* Fix autofill pyauto tests to deal with invalid credit card numbersnirnimesh@chromium.org2010-11-112-13/+25
| | | | | | | | | Autofill model has been changed to strip off non-digit chars in credit card input. Fix pyauto tests expectations. Review URL: http://codereview.chromium.org/4812001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65851 0039d316-1c4b-4281-b951-d872f2087c98
* Use the hard-coded list of timezones obtained from the Android, whichjshin@chromium.org2010-11-112-33/+186
| | | | | | | | | | | | | | | | | | | | | is more comprehensive than the current list. Among the added zones are zones with non-integer hour offsets (like Indian, Nepali and some timezones in Austrailia). Change the display name generation as well to use "LONG" name followed with the exemplar city of a zone. This is necessary to distinguish between timezones like Mountain Time (Phoenix) from Mountain Time (Denver). BUG=chromiumos:2613 TEST=Go to the timezone setting UI and make sure that all the timezones (including those with non-integer hour offset) such as Indian and Nepali timezones are listed. Review URL: http://codereview.chromium.org/3432015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65850 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use xdg-email instead of xdg-open to handle mailto: URLs.mdm@chromium.org2010-11-111-4/+15
| | | | | | | | BUG=61942 TEST=set $MAILER and click on mailto: links when not using gnome/kde, it should open the mailer Review URL: http://codereview.chromium.org/4769003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65849 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Prevent reading uninitialized variables.jhawkins@chromium.org2010-11-111-0/+3
| | | | | | | | | | CID=13648 BUG=none TEST=none Review URL: http://codereview.chromium.org/4771003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65848 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Fix a bug that only showed proxy settings if cloud print proxy UI isjhawkins@chromium.org2010-11-111-3/+3
| | | | | | | | | | | enabled. BUG=none TEST=none Review URL: http://codereview.chromium.org/4752006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65846 0039d316-1c4b-4281-b951-d872f2087c98
* Implement getVertexAttribOffsetgman@chromium.org2010-11-111-3/+6
| | | | | | | | | TEST=ran WebGL conformance tests BUG=none Review URL: http://codereview.chromium.org/4666004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65844 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing themes sync integration tests.rsimha@chromium.org2010-11-112-4/+8
| | | | | | | | | | | | | Some of the integration tests for themes fail due to http://crbug.com/62779. Marking them as FAILS until the bug is fixed. TBR=akalin@chromium.org BUG=62779 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/4809001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65842 0039d316-1c4b-4281-b951-d872f2087c98
* Disable translate for FTP sites.jcivelli@chromium.org2010-11-112-2/+3
| | | | | | | | | | | | FTP sites tend to show long list of file names that can confuse the CLD. Don't translate them automatically. BUG=50173 TEST=Navigate to a ftp site that contains a text in a foreign language. Open that file in Chrome. No translation bar should be shown. Review URL: http://codereview.chromium.org/4596001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65841 0039d316-1c4b-4281-b951-d872f2087c98
* Provide sync integration tests with a way to set a favicon for a bookmark.rsimha@chromium.org2010-11-116-24/+167
| | | | | | | | | | | | | | | | The sync integration test framework does not provide tests with a way to set a favicon for a bookmark and verify that it gets synced. This patch adds a method called SetFavicon, that allows tests to set either a generic favicon, or a variable favicon (using an index) for a bookmark. BUG=57234 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/4749003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65840 0039d316-1c4b-4281-b951-d872f2087c98
* Crash fix: Don't use const-ref parameter for an async callback.jhawkins@chromium.org2010-11-113-3/+3
| | | | | | | | | BUG=62739 TEST=none Review URL: http://codereview.chromium.org/4708007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65836 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed GetNameTooltip in UserController, added unittest and made a couple of ↵avayvod@chromium.org2010-11-115-18/+55
| | | | | | | | | | | places tolerant to tests BUG=chromiumos:8931 TEST=Unittest should pass. Check manually according to bug description. Review URL: http://codereview.chromium.org/4637006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65835 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash on 'clear form data' in otr windowsadrul@chromium.org2010-11-111-1/+4
| | | | | | | | | | | | An OTR profile does not have a PersonalDataManager, so check for its existence before refreshing it after clearing autofill form data from browsing history. BUG=62533 TEST=see bug Review URL: http://codereview.chromium.org/4771006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65832 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill form submission creates wrong credit cards.dhollowa@chromium.org2010-11-1110-29/+492
| | | | | | | | | | | Adds logic to filter out credit card submissions that are invalid, or to merge credit cards that match the card number. BUG=57975 TEST=PersonalDataManagerTest.Aggregate* Review URL: http://codereview.chromium.org/4734001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65830 0039d316-1c4b-4281-b951-d872f2087c98
* Fix warnings on Mac that has been reported by Eric.gene@google.com2010-11-111-4/+4
| | | | | | | | | | | | | | | | | | "warning: 'cloud_print::PrintSystemCUPS' has a field 'cloud_print::PrintSystemCUPS::printer_map_' whose type uses the anonymous namespace" For some reasons my machine did not produce such warnings and print_system_cups.cc compiled just fine. Eric, Could you please verify this fixes the issue? BUG=none TEST=Verify no warnings produced on Mac Review URL: http://codereview.chromium.org/4632004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65829 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a test to test a craher with the select popup on Mac.jcivelli@chromium.org2010-11-112-5/+40
| | | | | | | | | | | | The crasher was fixed in WebKit: https://bugs.webkit.org/show_bug.cgi?id=49108 BUG=61997 TEST=Run the browser tests. Review URL: http://codereview.chromium.org/4642001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65827 0039d316-1c4b-4281-b951-d872f2087c98
* Change the protocol specifics files to unblock the server teamlipalani@chromium.org2010-11-111-0/+3
| | | | | | | | | | | Change the protocol specific files to support the guid BUG= TEST= Review URL: http://codereview.chromium.org/4675006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65826 0039d316-1c4b-4281-b951-d872f2087c98
* gtk bookmark bar: destroy the menu, if any, before we destroy ourselvesevan@chromium.org2010-11-111-0/+5
| | | | | | | | | | | | The popup menu holds a pointer back to the widget that spawned it, so we should be sure to close it before we destroy our members. BUG=62610 TEST=fixes an error in BookmarkBarGtkBrowserTest.ClickOnFloatingTest Review URL: http://codereview.chromium.org/4780005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65825 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up very old safe-browsing databases.shess@chromium.org2010-11-112-0/+43
| | | | | | | | | | | | Some users still have v1 safe-browsing databases, which were very large. Track and delete them. BUG=36380 TEST=Track histograms Review URL: http://codereview.chromium.org/4688007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65824 0039d316-1c4b-4281-b951-d872f2087c98
* Disables full sync option for the owner when password is changed.altimofeev@chromium.org2010-11-116-14/+50
| | | | | | | | | | | | | | | Currently, full sync for the owner leads to ownership loss. This CL disables full sync radio button in the view, that appears when password was changed. BUG=chromium-os:8630 TEST=Login to device. Log out. Change user password in Guest Session. Try to login again. In the showed window notice, that full sync options is grayed out. Review URL: http://codereview.chromium.org/4699001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65823 0039d316-1c4b-4281-b951-d872f2087c98
* Disallow unknown TLD's for phishing classification.bryner@chromium.org2010-11-112-3/+7
| | | | | | | | | | | This avoids classifying partial hostnames ("www.subdomain"). BUG=none TEST=PhishingUrlFeatureExtractorTest Review URL: http://codereview.chromium.org/4650002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65822 0039d316-1c4b-4281-b951-d872f2087c98
* SandboxedExtensionUnpacker::ValidateSignature should check for an empty ↵jschuh@google.com2010-11-111-0/+4
| | | | | | | | | | | | signature Without an expicit check we crash on a hard int3 when trying to allocate 0 bytes. BUG=62791 TEST=None. Review URL: http://codereview.chromium.org/4723007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65821 0039d316-1c4b-4281-b951-d872f2087c98
* [Chrome OS] Add special-case handling of HOSTED accounts to parallel auth ↵cmasone@chromium.org2010-11-1111-66/+165
| | | | | | | | | | | | | | pathway The functionality added to GoogleAuthenticator that handles HOSTED accounts, ported to code paths used by ParallelAuthenticator. BUG=chromium-os:8978 TEST=unit tests, install on device and run chrome with --parallel-auth Review URL: http://codereview.chromium.org/4799001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65820 0039d316-1c4b-4281-b951-d872f2087c98
* All SSL UI tests work with ephemeral ports.cbentzel@chromium.org2010-11-114-59/+128
| | | | | | | | | | | | | This also changes the testserver text replacement hooks to accept base64 encoded pairs, and to support multiple replacement texts. These changes were needed for some of the "ssl/top_frame.html" based tests, which contained a frame with an HTML page referencing three URLs on three tdifferent test servers. BUG=56814 TEST=browser_tests --gtest_filter="*SSLUI*" Review URL: http://codereview.chromium.org/4664009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65819 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb datatype information to syncer from nudges.zea@chromium.org2010-11-1112-48/+256
| | | | | | | | | | | | Add plumbing to support tracking which datatypes are triggering nudges. This gets plumbed from the nudges to the actual sync session. Also added some histogramming for the frequency at which particular datatypes trigger syncs (as a result, also supports tracking how often datatypes are changing). New histograms are of the form "Sync.Freq<datatype>", with bucket units in milliseconds. BUG=None TEST=unit_tests Review URL: http://codereview.chromium.org/4659003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65818 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 65813 - Removes the close button from instant on windows.sky@chromium.org2010-11-115-7/+173
| | | | | | | | | | | BUG=59068 TEST=none Review URL: http://codereview.chromium.org/4667008 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65815 0039d316-1c4b-4281-b951-d872f2087c98
* Wait a bit for the helper to exit before continuing with removing files.tommi@chromium.org2010-11-112-6/+48
| | | | | | | | | | | Also adding a bit of logging for easier diagnostics when we can't remove a folder due to files being in use on uninstall. TEST=Should improve our chances of being able to uninstall without needing to reboot. BUG=61609 Review URL: http://codereview.chromium.org/4773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65814 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the close button from instant on windows.sky@chromium.org2010-11-115-173/+7
| | | | | | | | | BUG=59068 TEST=none Review URL: http://codereview.chromium.org/4667008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65813 0039d316-1c4b-4281-b951-d872f2087c98
* Move base::ThreadLocalPlatform to base::internal::ThreadLocalPlatform.willchan@chromium.org2010-11-111-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4744002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65812 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused tip menu string from NTP.mirandac@chromium.org2010-11-112-6/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4747006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65810 0039d316-1c4b-4281-b951-d872f2087c98