| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension.
This change also refactors the balloon collection code to remove duplication between chrome and chromeos.
Removes some gross removal code which was using fake notifications just to get the right ID.
BUG=58266
TEST=open notifications from extension, uninstall extensions
Review URL: http://codereview.chromium.org/4635007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebGraphicsContext3DCommandBufferImpl which are no longer used after
https://bugs.webkit.org/show_bug.cgi?id=46894 .
Built on Mac OS X to test.
BUG=61801
TEST=none
Review URL: http://codereview.chromium.org/4836002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62876
TEST=unit_test and tsan
Review URL: http://codereview.chromium.org/4833001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebGraphicsContext3DDefaultImpl is going to be removed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4845002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4655008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since NaCl needs only one shared memory object that is mappable with
PROT_EXEC, we can take a short cut and pass one in at startup, saving
on IPC.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=583
TEST=test_runner.html with NaCl-side change applied, on a Mac
Review URL: http://codereview.chromium.org/4745001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removed out from under the TabStripModel it would still attempt to
remove the tab. At least this is my best guess as to what is causing
the crash.
BUG=34135
TEST=none
Review URL: http://codereview.chromium.org/4687009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62610
TEST=see bug
Review URL: http://codereview.chromium.org/4820001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes a few small changes to bring things more in line with the latest mocks:
- Larger font size for page and section titles.
- Removes the trailing divider line after the last section.
- Tweaks the inter-section spacing.
BUG=59237,59264
TEST=DOMUI prefs should look more like mocks.
Review URL: http://codereview.chromium.org/4826002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now each style has a range that it applies to. The styles can also overlap and
be listed out of order.
BUG=62385
TEST=covered by unit/browser tests
Review URL: http://codereview.chromium.org/4660008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=62880
TEST=None
TBR=tim
Review URL: http://codereview.chromium.org/4837001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/4673001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Disable this for tests.
BUG=chromium-os:3412
TEST=Access file: directories on chromeos. browser, ui, interactive ui and unit tests should continue to pass.
Review URL: http://codereview.chromium.org/4160003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=When using --verbose-logging with the installer, there will be entries for each COM component we [un]register.
Review URL: http://codereview.chromium.org/4821001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
URLs only.
R=eroman,finnur
BUG=53366
TEST=net_unittests --gtest_filter=HTTPSRequestTest.HTTPS*Test
Review URL: http://codereview.chromium.org/4210004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=avi
BUG=none
TEST=OS X file dialogs don't trigger AssertIOAllowed DCHECKS
Review URL: http://codereview.chromium.org/4673009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
image, so I'm leaving it and the grd change in. A separate cl will fix
the mac side and remove the image/grd change.
BUG=59068
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/4801002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds logic to filter out address submissions that are redundant, or merge addresses that match existing addresses already stored in Autofill settings.
BUG=57975
TEST=PersonalDataManagerTest.Aggregate*
Review URL: http://codereview.chromium.org/4765001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class is responsible for talking to the client-side detection
servers and to fetch the machine learning model.
BUG=none
TEST=ClientSideDetectionServiceTest
Review URL: http://codereview.chromium.org/3815014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During the security review Erik and Cris noticed that if for some reason the
web store app came back null, we could end up allowing access to the
webstorePrivate APIs by returning a true comparison of null to null.
BUG=61954
TEST=Should be covered by existing tests.
Review URL: http://codereview.chromium.org/4665008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
places.I'm also adding a constant for CEEE - I named it kCeee instead of kEnableCeee since it's also used in uninstalls.This change is just a beginning of being aware of having more than one product available in setup.
I added some todos and dcheck for myself to keep track of places that will need more significant changes when running multiple installs.
BUG=61609
TEST=All installations (chrome, chrome frame, ceee) should work as before with the exception that the CEEE switch is now --ceee and not --enable-ceee.
Review URL: http://codereview.chromium.org/4635006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Autofill model has been changed to strip off non-digit chars in credit card
input. Fix pyauto tests expectations.
Review URL: http://codereview.chromium.org/4812001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is more comprehensive than the current list.
Among the added zones are zones with non-integer hour offsets
(like Indian, Nepali and some timezones in Austrailia).
Change the display name generation as well to use "LONG"
name followed with the exemplar city of a zone. This is
necessary to distinguish between timezones like
Mountain Time (Phoenix) from Mountain Time (Denver).
BUG=chromiumos:2613
TEST=Go to the timezone setting UI and make sure
that all the timezones (including those with non-integer hour offset)
such as Indian and Nepali timezones are listed.
Review URL: http://codereview.chromium.org/3432015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61942
TEST=set $MAILER and click on mailto: links when not using gnome/kde, it should open the mailer
Review URL: http://codereview.chromium.org/4769003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=13648
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4771003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enabled.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4752006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=ran WebGL conformance tests
BUG=none
Review URL: http://codereview.chromium.org/4666004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of the integration tests for themes fail due to
http://crbug.com/62779. Marking them as FAILS until the bug is fixed.
TBR=akalin@chromium.org
BUG=62779
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/4809001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
FTP sites tend to show long list of file names that can confuse the CLD. Don't translate them automatically.
BUG=50173
TEST=Navigate to a ftp site that contains a text in a foreign language.
Open that file in Chrome. No translation bar should be shown.
Review URL: http://codereview.chromium.org/4596001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration test framework does not provide tests with a way to
set a favicon for a bookmark and verify that it gets synced.
This patch adds a method called SetFavicon, that allows tests to set
either a generic favicon, or a variable favicon (using an index) for a
bookmark.
BUG=57234
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/4749003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62739
TEST=none
Review URL: http://codereview.chromium.org/4708007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
places tolerant to tests
BUG=chromiumos:8931
TEST=Unittest should pass. Check manually according to bug description.
Review URL: http://codereview.chromium.org/4637006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
An OTR profile does not have a PersonalDataManager, so check for its existence
before refreshing it after clearing autofill form data from browsing history.
BUG=62533
TEST=see bug
Review URL: http://codereview.chromium.org/4771006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds logic to filter out credit card submissions that are invalid, or to merge credit cards that match the card number.
BUG=57975
TEST=PersonalDataManagerTest.Aggregate*
Review URL: http://codereview.chromium.org/4734001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"warning: 'cloud_print::PrintSystemCUPS' has a field
'cloud_print::PrintSystemCUPS::printer_map_' whose type uses the
anonymous namespace"
For some reasons my machine did not produce such warnings and
print_system_cups.cc compiled just fine.
Eric, Could you please verify this fixes the issue?
BUG=none
TEST=Verify no warnings produced on Mac
Review URL: http://codereview.chromium.org/4632004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crasher was fixed in WebKit:
https://bugs.webkit.org/show_bug.cgi?id=49108
BUG=61997
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/4642001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change the protocol specific files to support the guid
BUG=
TEST=
Review URL: http://codereview.chromium.org/4675006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The popup menu holds a pointer back to the widget that spawned it, so
we should be sure to close it before we destroy our members.
BUG=62610
TEST=fixes an error in BookmarkBarGtkBrowserTest.ClickOnFloatingTest
Review URL: http://codereview.chromium.org/4780005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some users still have v1 safe-browsing databases, which were very
large. Track and delete them.
BUG=36380
TEST=Track histograms
Review URL: http://codereview.chromium.org/4688007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, full sync for the owner leads to ownership loss. This CL
disables full sync radio button in the view, that appears when password
was changed.
BUG=chromium-os:8630
TEST=Login to device. Log out. Change user password in Guest Session.
Try to login again. In the showed window notice, that full sync options
is grayed out.
Review URL: http://codereview.chromium.org/4699001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids classifying partial hostnames ("www.subdomain").
BUG=none
TEST=PhishingUrlFeatureExtractorTest
Review URL: http://codereview.chromium.org/4650002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
signature
Without an expicit check we crash on a hard int3 when trying to allocate 0 bytes.
BUG=62791
TEST=None.
Review URL: http://codereview.chromium.org/4723007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pathway
The functionality added to GoogleAuthenticator that handles HOSTED accounts,
ported to code paths used by ParallelAuthenticator.
BUG=chromium-os:8978
TEST=unit tests, install on device and run chrome with --parallel-auth
Review URL: http://codereview.chromium.org/4799001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also changes the testserver text replacement hooks to accept base64 encoded pairs, and to support multiple replacement texts.
These changes were needed for some of the "ssl/top_frame.html" based tests, which contained a frame with an HTML page referencing three URLs on three tdifferent test servers.
BUG=56814
TEST=browser_tests --gtest_filter="*SSLUI*"
Review URL: http://codereview.chromium.org/4664009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add plumbing to support tracking which datatypes are triggering nudges. This gets plumbed from the nudges to the actual sync session. Also added some histogramming for the frequency at which particular datatypes trigger syncs (as a result, also supports tracking how often datatypes are changing).
New histograms are of the form "Sync.Freq<datatype>", with bucket units in milliseconds.
BUG=None
TEST=unit_tests
Review URL: http://codereview.chromium.org/4659003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=59068
TEST=none
Review URL: http://codereview.chromium.org/4667008
TBR=sky@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also adding a bit of logging for easier diagnostics when we can't remove a folder due to files being in use on uninstall.
TEST=Should improve our chances of being able to uninstall without needing to reboot.
BUG=61609
Review URL: http://codereview.chromium.org/4773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59068
TEST=none
Review URL: http://codereview.chromium.org/4667008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4744002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4747006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65810 0039d316-1c4b-4281-b951-d872f2087c98
|