| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
the sort_sln.py script.
TBR=brettw
Review URL: http://codereview.chromium.org/11291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11485
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
detect address space collisions where chrome.dll is needing to be rebased, and it will help us choose a better base address.
Review URL: http://codereview.chromium.org/6540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
javascript from setting a new httponly cookie, and more importantly from overwriting httponly cookies.
Patch from Marius Schilder.
Review URL: http://codereview.chromium.org/11275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
header files in the original locations that include the ones in the new location so I don't have to change all the includes in Chrome at once. These will be removed later.
I kept the names, indenting, and the namespaces the same for now. I will also be cleaning this up in separate passes.
Review URL: http://codereview.chromium.org/11244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is the same version of the class present in the Gears tree, modifications
are only the file & header guard names and the license.
Review URL: http://codereview.chromium.org/11278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The LPITEMIDLIST returned from SHBrowseForFolder might not get released if
SHGetPathFromIDList fails
Added in the comment changes
Added GetDisplayNameOf for getting selection, using old way if
STRRET Structure type does not equal STRRET_WSTR as I was
unable to get complete code coverage.
Added BrowseCallbackProc and listen to MSG so
that we can highlight existing value
Added in the comment changes ( changed to smart pointer for managing
COM interface pointers.)
Review URL: http://codereview.chromium.org/11481
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the most recently used download path when displaying a "save as" dialog. Reset the download path when the user clears the download history.
BUG=293 (http://code.google.com/p/chromium/issues/detail?id=293)
Review URL: http://codereview.chromium.org/10743
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specific code so we should handle it before we get
to webkit.
CF_HTML needs the source URL to resolve relative URLs
so I added that to the format and plumb it through
from webcore.
I also did some small refactoring so we only have one
implementation of converting to/from CF_HTML and regular
markup. We can tweak these converters (and add unit tests)
in follow up changes.
Review URL: http://codereview.chromium.org/11247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
because SetWorldTransform and a graphics mode of COMPATIBLE don't work
together. Instead we must use SetViewportOrgEx.
BUG=4515
TEST=see bug
Review URL: http://codereview.chromium.org/11253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it should be hidden. This fixes the problem of invisible browser window when launched from bash.
http://crbug.com/4438
Review URL: http://codereview.chromium.org/11454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is possible that during the shutdown process, the database thread
posts tasks back to the IO thread which result in calls to the
SafeBrowsing protocol manager object. This object will have been
deleted by the time the posted task runs, resulting in a crash.
This change checks the enabled_ flag (which is set to false when
the shutdown starts) for all tasks posted to the IO thread to
protect against access to deleted objects.
BUG = http://crbug.com/4531
Review URL: http://codereview.chromium.org/11245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
on all the new locales.
Review URL: http://codereview.chromium.org/11804
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reduce the crashiness any :-/
r5335 dragged_tab_controller.cc (delegate NULL setting)
r5124 changes to make AutomationProvider::WindowSimulateDrag use SendInput instead of SendMessage
r5117 dragged_tab_controller.cc (delegate NULL setting)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Add more DCHECKs.
Review URL: http://codereview.chromium.org/10957
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the terms_xx.html files and the xx.vcproj files to the
solution and makes mini_installer depend on them.
This only gets the locale DLLs built. Actually being able to use
them in the product is another issue (http://crbug.com/4473).
R= tony
Review URL: http://codereview.chromium.org/10776
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This just adds the .vcproj files and the locale_settings.rc files
they need.
I also updated SConscript.
I'll make the changes to chrome.sln and check it in after this is
checked in. Just checking these in should not affect the build until
chrome.sln is updated.
R= tony
Review URL: http://codereview.chromium.org/10968
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This rev just adds the _terms files. These are copied from the
en-US version.
I don't know how these get generated, nor whether translations for
the terms exist for these languages.
R=glen
Review URL: http://codereview.chromium.org/10775
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is used to plumb though extra flags to pass to chrome.exe.
For example, to run reliability tests with WinHTTP stack:
reliability_tests.exe --extra-chrome-flags="--winhttp"
Note that no attempt is made to avoid duplicate parameters.
Review URL: http://codereview.chromium.org/11436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove frame_util.cc, moving functions to BrowserList (endsession) and BrowserView (GetBrowserWindowForHWND)
- Tidy up interface for TabIconView model. The model now sources only the information it needs (loading state and favicon).
- Replace BrowserType class with an enum on Browser.
http://crbug.com/2320
http://crbug.com/3363
Review URL: http://codereview.chromium.org/10786
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
entries.Also fix up some of the suggest URLs to be more consistent.
BUG=4102
Review URL: http://codereview.chromium.org/11214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
this case.
BUG=3906
Review URL: http://codereview.chromium.org/11213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
possible to get more than one NOTIFY_WEB_CONTENTS_DISCONNECTED. The
first time ModalHTMLDialogDelegate gets a
NOTIFY_WEB_CONTENTS_DISCONNECTED it sets the contents_ to NULL. This
is problematic because the destructor than removes the observer using
a source of NULL. Instead we should remove the observer immediately,
then NULL out the contents_.
BUG=4129
TEST=covered by QEMU
Review URL: http://codereview.chromium.org/11413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
even though the field is disabled you get a white background.
BUG=4511
TEST=Bring up about chrome and make sure background of version string
is white.
Review URL: http://codereview.chromium.org/11421
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
:-/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=1487502
Review URL: http://codereview.chromium.org/10960
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4447
TEST=see bug
Review URL: http://codereview.chromium.org/10765
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initial letter".
This issue is caused by our IME code that does not filter out focus events raised by an IME function of WebKit, WebCore::Editor::setComposition().
Its details are listed below:
1. WebKit sometimes creates a WebCore::EditingText instance and moves the input focus to the instance while updating a composition string in the Editor::setComposition() function;
2. Our IME code automatically finishes the ongoing composition everytime when WebKit moves the input focus to the WebCore::EditingText instance.
As a wordaround for this issue, this change ignores focus events while a renderer process updates a composition string with the Editor::setComposition() function.
Review URL: http://codereview.chromium.org/10827
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
R=brettw ReviewURL: http://codereview.chromium.org/10967/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(plus various renaming ripple effects masked by merge build errors):
* Move invocation of recently-created *.scons files from
chrome\SConscript into chrome\chrome.scons.
* Move the ChromeVersionRC() Builder up into chrome\chrome.scons
so it's available in all the newer *.scons files (specifically
installer\mini_installer\mini_installer.scons and
installer\setup\setup.scons).
* Build chrome.dll in a chrome_dll subdirectory, and chrome.exe in
a chrome_exe subdirectory, to avoid the name conflict when both
try to create a chrome.lib library as part of linking. Re-name
them to chrome.{dll,lib,exe} on installation into $DESTINATION_ROOT.
* Install underneath Hammer\ ($DESTINATION_ROOT) copies of:
themes\default.dll
* Portability: link against 'chrome' and 'common' from the LIBS variable,
not by explicitly listing 'chrome.lib' and 'common.lib'.
* Link interactive_ui_tests.exe links against sdch, not google_update,
and add CPPPATH directories for included resource files.
* Install a number of necessary ancillary files in explicitly in
$DESTINATION_ROOT, not $TARGET_ROOT: chrome.dll, icudt38.dll, rlz.dll,
"First Run", themes\*, locales\, Dictionaries.
* Add a 'chrome_locales' Alias for the locale .dll files installed
into the locales\ subdirectory, and use Requires() to make sure
they're installed for chrome.exe regardless of what target is used.
* Add a 'chrome_Dictionaries' Alias for the hunspell dictionaries
into the Dictionaries\ subdirectory, and use Requires() to make sure
they're installed for chrome.exe regardless of what target is used.
* Clone() the automated_ui_tests.scons construction environment so its
settings don't pollute builds of other targets.
* Add explicit dependencies on various generated .rc files (with
TODO(sgk) to figure out why they're not picked up by the
implicit dependency scan).
Review URL: http://codereview.chromium.org/10976
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Changes dependencies from
rlz
browser
interactive_ui_tests
unit_tests
to
rlz
interactive_ui_tests
mini_installer
unit_tests
Review URL: http://codereview.chromium.org/10760
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
of crashes.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
there is no selected tab. This is significantly simpler than NULL checking all over the place since no one should call ExecuteCommand without first calling IsCommandEnabled.
TBR=sky
Review URL: http://codereview.chromium.org/10783
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
iterator renders it invalid. We were continuing to use this iterator.
R=darin
Review URL: http://codereview.chromium.org/10925
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the stability test is going well (so far) on
".google.com," this change will open up support for SDCH
compression to all sites. This will allow for more
international testing as well.
I tightened down the restrictions on who can set up a dictionary for
a given domain. I'm pretty sure it is at least as restrictive as the
current SDCH spec.
I also supplied a default expiration time for using an SDCH
dictionary at 30 days (as per SDCH spec).
To be safer with the latency histograms, I also tightened the period of
time we measure, on the off chance that the page some-how asks for more
bytes after everything has been read/rendered.
r=openvcdiff,hunar
Review URL: http://codereview.chromium.org/11009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Remove third_party/dmg_fp complete since nothing else depends on it.
Review URL: http://codereview.chromium.org/10963
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
checks that are.
Review URL: http://codereview.chromium.org/10962
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
base/third_party/dmg_fp and compile it into base_lib.
Review URL: http://codereview.chromium.org/10769
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
code rather than hand-rolling its own.
Review URL: http://codereview.chromium.org/10959
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
webkit\SConscript, as a place for calling renamed *.scons files.
Add 'webkit' and 'chrome' COMPONENT_PROGRAM_GROUPS and
COMPONENT_TEST_PROGRAM_GROUPS so the generated .exe files get
copied correctly into the Hammer\ build subdirectory.
Review URL: http://codereview.chromium.org/10768
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10767
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Rename SConscript to *.scons in the following directories:
third_party\{bspatch,bsdiff,lzma_dsk}
chrome\installer\{setup,mini_installer,util}
* Split mini_installer and installer_unittests into separate *.scons files.
* Add using_bspatch.scons and using_lzma_sdk.scons "properties" files,
modifying other *.scons files to use them as appropriate.
Review URL: http://codereview.chromium.org/10952
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5515 0039d316-1c4b-4281-b951-d872f2087c98
|