summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Linux sandbox: save full list of SUID unsafe environment variables.agl@chromium.org2009-07-171-6/+24
| | | | | | | | | | | | | r20733 added code to save LD_LIBRARY_PATH when using the SUID sandbox. That fixed a P0, show-stopper bug, however, LD_LIBRARY_PATH isn't the only variable which is stomped when using SUID binaries. This patch extends support to all variables that we so affected. BUG=16815 http://codereview.chromium.org/159025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21009 0039d316-1c4b-4281-b951-d872f2087c98
* Several changes to the benchmark extension:mbelshe@google.com2009-07-173-431/+504
| | | | | | | | | | | | | | * Cleaned up the UI - can auto-start a benchmark from a given url * added bandwidth measurements for testing bandwidth efficiency * added time to docload, time to first paint, in addition to overall PLT. BUG=none TEST=none Review URL: http://codereview.chromium.org/155675 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21007 0039d316-1c4b-4281-b951-d872f2087c98
* Do not block all task manager tree view mouse release events.estade@chromium.org2009-07-171-4/+2
| | | | | | | | | BUG=16974 TEST=you can resize rows of the task manager Review URL: http://codereview.chromium.org/155670 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21006 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where the i18n template logic was not applied to the document element.arv@google.com2009-07-171-1/+1
| | | | | | | | | | | | TBR=glen@chromium.org BUG=16965 TEST=Start with --lang=he and makes sure UI is in RTL mode Review URL: http://codereview.chromium.org/159026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20997 0039d316-1c4b-4281-b951-d872f2087c98
* Makes enter/shift-enter find next/previous on Mac.rohitrao@chromium.org2009-07-171-0/+19
| | | | | | | | | | BUG=htp://crbug.com/14890 TEST=Cmd-F to find in page. Type a word into the box, then ensure that pressing Enter finds the next instance, Shift-Enter finds the previous instance. Review URL: http://codereview.chromium.org/149100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20996 0039d316-1c4b-4281-b951-d872f2087c98
* For system-level installs, if the spellcheck dictionary fails to get ↵sidchat@google.com2009-07-172-31/+95
| | | | | | | | | | downloaded in the profile Application directory, download it in the User Data directory instead. BUG=http://www.crbug.com/9650 TEST=Launch Chrome, and navigate to translate.google.com. Before typing anything in the text box, change name of folder Chrome/Application/Dictionaries to something else. Then, start typing something. The spellcheck dictionary, unable to get the folder Dictionaries, will fail to download, which will trigger its download in Chrome/User Data/Dictionaries. After it has downloaded, spellchecker will start working automatically. Review URL: http://codereview.chromium.org/155394 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20995 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the Cancel button to Close in gtk Clear Browsing Data.mattm@chromium.org2009-07-171-1/+1
| | | | | | | | | BUG=16955 TEST=Open Clear Browsing Data dialog. The button should now say Close. Review URL: http://codereview.chromium.org/159023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20994 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20516 by re-landing this previous patch.brettw@chromium.org2009-07-171-10/+3
| | | | | | | | | | | | | Keep the cairo clipping region in sync with the Skia one. The PlatformCanvas now tracks this, so we don't need to have the similar code in gfx::Canvas. I moved most references of cairo_surface_t to cairo_t since the cairo_t has a transform and clip but the surface does not. Review URL: http://codereview.chromium.org/149409 Review URL: http://codereview.chromium.org/155700 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20992 0039d316-1c4b-4281-b951-d872f2087c98
* Fix same crashy assumption that I fixed in r20967 later on in normal theme mode.erg@google.com2009-07-171-3/+6
| | | | | | Review URL: http://codereview.chromium.org/155709 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20991 0039d316-1c4b-4281-b951-d872f2087c98
* Flip screen coordinates when converting NSEvent to WebMouseEvent. Enable ↵pinkerton@chromium.org2009-07-171-2/+4
| | | | | | | | | | processing of events during drag. BUG=16909, 113616 TEST=dragging thumbnails works on NTP, dragging emails in gmail. Review URL: http://codereview.chromium.org/159021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20989 0039d316-1c4b-4281-b951-d872f2087c98
* Set the default minimum font size webkit pref to 12 for Chinese and 10 for ↵jshin@chromium.org2009-07-176-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | ja,ko,ar and th. This will partly resolve [2] one of frequent complains of Chinese users (as long as they use Chinese Chrome). See http://www.google.com/support/forum/p/Chrome/thread?tid=389f306a52817110&hl=en Leave alone other UI language versions alone for now (Firefox has per-script/per-language min font size [1]). Eventually, there need to be per-script which requires the webkit change. [1] http://mxr.mozilla.org/seamonkey/search?string=font.minimum-size (note that Firefox does not set these values by default except for Thai, but offers a UI for a user to adjust). [2] See other issues (feature requests) mentioned in http://crbug.com/16868 BUG=16875 (http://crbug.com/16875) TEST=Open Chrome with '--lang=zh-CN' and go to http://www.popyard.org/ and Chinese characters are larger than before. Review URL: http://codereview.chromium.org/155607 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20987 0039d316-1c4b-4281-b951-d872f2087c98
* Disable text-encoding.html from Worker http layout tests, it appears to be ↵dimich@google.com2009-07-171-1/+1
| | | | | | | | | | unreliable. BUG=16934 TEST=none TBR=sverrir@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20986 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the width of pinned tabs to be slightly bigger.sky@chromium.org2009-07-172-22/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155701 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20985 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 6- and 7-parameter IPC message macros. Replace with a struct that ↵dimich@google.com2009-07-177-133/+85
| | | | | | | | | | packs parameters. BUG=16685 TEST=none Review URL: http://codereview.chromium.org/149775 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20980 0039d316-1c4b-4281-b951-d872f2087c98
* linux: splash page updateevan@chromium.org2009-07-172-32/+33
| | | | | | | | Mention how to turn on plugins. Review URL: http://codereview.chromium.org/159016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20978 0039d316-1c4b-4281-b951-d872f2087c98
* This matches the behavior on Windows. Also this change lets user close ↵kuchhal@chromium.org2009-07-172-0/+15
| | | | | | | | | | | Chrome by clicking 'x' button even if a popup (for example - bookmark bubble) is open. BUG=NONE TEST=1. Click on bookmark star button to open bookmark bubble. Switch focus to some other Window, bubble should close automatically. 2. Click on bookmark star button to open bookmark bubble. Close chrome by clicking on Window close button ('x') and Chrome should close. Review URL: http://codereview.chromium.org/149757 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20977 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to re-enable the http worker tests. I can't repro the 'flak' so I'm ↵dimich@google.com2009-07-171-1/+1
| | | | | | | | | | going to enable them and watch closely. BUG=16934 TEST=none Review URL: http://codereview.chromium.org/149763 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20974 0039d316-1c4b-4281-b951-d872f2087c98
* Need to cleanup first run dialog on cancellation too.kuchhal@chromium.org2009-07-171-3/+4
| | | | | | | | Fixing what r20898 broke. Review URL: http://codereview.chromium.org/155676 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20973 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Fix issue where focused buttons where not distinguisgable fromarv@google.com2009-07-171-5/+10
| | | | | | | | | | | | | non focused buttons. BUG=16973 TEST=Tab to the buttons at the top of the NNTP. They should have a *outlined* look (same as hover). Review URL: http://codereview.chromium.org/159013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20971 0039d316-1c4b-4281-b951-d872f2087c98
* Fix occasional crash at startup in gtk_chrome_button_expose.erg@google.com2009-07-171-2/+3
| | | | | | Review URL: http://codereview.chromium.org/155697 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20967 0039d316-1c4b-4281-b951-d872f2087c98
* Silence compile errors on some compilers by checking return value of fwrite.estade@chromium.org2009-07-171-4/+13
| | | | | | | | | | | hat tip to spotrh BUG=16948 TEST=none Review URL: http://codereview.chromium.org/149786 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20966 0039d316-1c4b-4281-b951-d872f2087c98
* Added an observer for 'pref::kDefaultCharset' change I forgot to add in ↵jshin@chromium.org2009-07-172-3/+26
| | | | | | | | | | | | | | | | | | | r15113 (http://src.chromium.org/viewvc/chrome?view=rev&revision=15113) . Besides, set referrer_charset_ (used in guessing the C-D charset in GetFileNameFromCD) to pref::kDefaultCharset without any q values appended. TEST=1. Set the default charset in Options | Advanced | Fonts & Languages to ISO-8859-1. 2. Type http://i18nl10n.com/moztest/random21.yyy in the omnibox and the filename in the download bar should start with "횉횗짹횤21" 3. Change the default charset to Korean 4. Try #2 again and the filename in the download bar should start with '?쒓?21'. BUG=1148 (http://crbug.com/1148 ) Review URL: http://codereview.chromium.org/149705 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20965 0039d316-1c4b-4281-b951-d872f2087c98
* Qurey redirects when a thumbnail is set.meelapshah@chromium.org2009-07-174-25/+107
| | | | | | | | Update list of most visited URLs on an exponential timer, resetting when the history is cleared. Review URL: http://codereview.chromium.org/155619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20964 0039d316-1c4b-4281-b951-d872f2087c98
* More bad ipc message handling for RenderWidgetHostcpu@google.com2009-07-172-5/+18
| | | | | | | | | | | - For input handling so far BUG=16673 TEST=unit test included Review URL: http://codereview.chromium.org/155613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20962 0039d316-1c4b-4281-b951-d872f2087c98
* Small improvements to the hello world tutorial.kathyw@google.com2009-07-174-13/+36
| | | | | | | | | | | | Still not done yet. BUG=none TEST=none TBR=aa Review URL: http://codereview.chromium.org/155696 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20960 0039d316-1c4b-4281-b951-d872f2087c98
* Implement SetSize for valid size requests.avi@chromium.org2009-07-171-6/+19
| | | | | | | | | BUG=http://crbug.com/15334 TEST=type in a popup containing more than one item; as the number of items decreases, the list should properly shrink and draw itself. Review URL: http://codereview.chromium.org/155694 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20959 0039d316-1c4b-4281-b951-d872f2087c98
* Move into browser/cocoa from browser/pinkerton@chromium.org2009-07-172-1/+1
| | | | | | | | BUG=15475 TEST=none Review URL: http://codereview.chromium.org/155690 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20958 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a leak in [LinkInfoBarController addAdditionalControls].rohitrao@chromium.org2009-07-171-2/+2
| | | | | | | | | | | | Removes the valgrind suppression for this leak. Valgrind: 1, rohitrao: 0 BUG=17002 TEST=No more leaky. Review URL: http://codereview.chromium.org/159005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20955 0039d316-1c4b-4281-b951-d872f2087c98
* Add JS Console menu item to View > Developer submenu. Remove extra Downloads ↵pinkerton@chromium.org2009-07-171-42/+79
| | | | | | | | | | menu from View. Add stub menu item for Task Manager (disable). BUG=16135 TEST=js console opens Review URL: http://codereview.chromium.org/149677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20952 0039d316-1c4b-4281-b951-d872f2087c98
* Adds languages supported by the platform spellchecker to the rightpinkerton@chromium.org2009-07-175-5/+85
| | | | | | | | | | | click menu. Also includes a couple of methods which will be needed once support for the spelling panel is finished. Patch from Paul Wicks (pwicks86@gmail.com) BUG=NONE TEST=Context menu on the mac should show and allow switching between languages for the spellchecker git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20951 0039d316-1c4b-4281-b951-d872f2087c98
* Fix merge error (benign) from r20910rafaelw@chromium.org2009-07-172-2/+1
| | | | | | | | TBR=mpcomplete Review URL: http://codereview.chromium.org/149783 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20948 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 13711 (the second part)hbono@chromium.org2009-07-171-1/+88
| | | | | | | | | | | | | | Because of a hard-disk problem, I lost the original change. So, I would like to send another change for this fix. This is the second part of the fix for Issue 13711. On non-ASCII keyboards (e.g. Russian and Hebrew), |event->keyval| represents a non-ASCII value that BrowserWindowGtk::HandleAccelerator() cannot handle. To fix this issue, this change uses |event->hardware_keycode| to retrieve its ASCII value before calling BrowserWindowGtk::HandleAccelerator(). BUG=13711 "Alt-D does not work when in editbox" TEST=Type alt+d keys on a Russian keyboard and verify the input focus is moved to an onmibox. Review URL: http://codereview.chromium.org/155555 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20944 0039d316-1c4b-4281-b951-d872f2087c98
* Set window icon on task manager.estade@chromium.org2009-07-171-0/+1
| | | | | | | | | | patch by <joel.stan@gmail.com> original review url: http://codereview.chromium.org/155677 Review URL: http://codereview.chromium.org/149797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20942 0039d316-1c4b-4281-b951-d872f2087c98
* A small start: add icons to the extension manifest.aa@chromium.org2009-07-178-11/+84
| | | | | | Review URL: http://codereview.chromium.org/155662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20941 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a crash in the plugin process caused by the XStandard plugin passing ↵ananta@chromium.org2009-07-171-0/+24
| | | | | | | | | | | | | | in a NULL NPObject to NPN_HasMethod. I checked out Firefox's implementation and they check for NULL NPObjects in all functions except NPN_Evaluate and NPN_SetException. Fix is to emulate Firefox behavior. Fixes http://code.google.com/p/chromium/issues/detail?id=16900 Bug=16900 Review URL: http://codereview.chromium.org/155628 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20940 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce WebLocalizedString and queryLocalizedString methodsdarin@chromium.org2009-07-173-17/+24
| | | | | | | | | | | | | on WebKitClient. This allows glue/localized_strings.cc to move into the WebKit API implementation. BUG=16933 TEST=none R=dglazkov Review URL: http://codereview.chromium.org/149760 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20938 0039d316-1c4b-4281-b951-d872f2087c98
* Include output of "lsb_release -d" in crash reports.thestig@chromium.org2009-07-175-67/+138
| | | | | | | | | /etc/lsb-release does not exist on all distros, and sometimes it does not provide any useful info. Whereas all LSB complaint distros return useful data with the lsb_release command. Review URL: http://codereview.chromium.org/155653 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20936 0039d316-1c4b-4281-b951-d872f2087c98
* Makes --pinned-tab-count work if session restore is enabled, but wesky@chromium.org2009-07-171-3/+26
| | | | | | | | | | | don't restore anything. BUG=none TEST=none Review URL: http://codereview.chromium.org/155667 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20935 0039d316-1c4b-4281-b951-d872f2087c98
* Begin implementation of the context menu for Video and Audio tags.ajwong@chromium.org2009-07-177-21/+245
| | | | | | | | | | | This code should enable the creation of a basic context menu for the Video and Audio tags. The actions for fullscreen, save screenshot, loop, and set playback rate are not yet implemented. BUG=15686 TEST=None Review URL: http://codereview.chromium.org/149604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20931 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at infobars on Mac. These are not expected to berohitrao@chromium.org2009-07-1724-29/+1901
| | | | | | | | | | | | | | pretty. Animations and aesthetic appeal will come in a future CL. BUG=http://crbug.com/14462 BUG=http://crbug.com/14937 BUG=http://crbug.com/15839 BUG=http://crbug.com/16487 TEST=Infobars should show up when expected. Review URL: http://codereview.chromium.org/155494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20930 0039d316-1c4b-4281-b951-d872f2087c98
* forgot a file (or rather gcl was hiding it in another cl)estade@chromium.org2009-07-171-10/+3
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/149787 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20929 0039d316-1c4b-4281-b951-d872f2087c98
* Set window icon on options dialog, bookmark manager.estade@chromium.org2009-07-175-3/+17
| | | | | | | | | BUG=16951 TEST=launch bookmark manager on gnome/metacity, observe that window has icon Review URL: http://codereview.chromium.org/155672 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20928 0039d316-1c4b-4281-b951-d872f2087c98
* Experiment with opening links opened via context menu in the foreground.ben@chromium.org2009-07-171-1/+1
| | | | | | | | | BUG=none TEST=tabs opened via "Open link in new tab..." should open in foreground, not background. Review URL: http://codereview.chromium.org/155671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20927 0039d316-1c4b-4281-b951-d872f2087c98
* Make testers happy.estade@chromium.org2009-07-171-1/+2
| | | | | | | | | | | | | Only show linux splash page for new windows. May this be the end of this sad saga. TEST=if chrome is already running, `./out/Debug/chrome test.html` doesn't open splash page BUG=http://crbug.com/16893 Review URL: http://codereview.chromium.org/149780 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20925 0039d316-1c4b-4281-b951-d872f2087c98
* Allow dragging a link from the web contents to the bookmark bar to get a ↵estade@chromium.org2009-07-1711-94/+162
| | | | | | | | | | | | | named bookmark. Also, change the naming scheme of the DnD targets. BUG=16791 TEST=select a link in the web page and drag it to the bookmark bar. Review URL: http://codereview.chromium.org/155661 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20921 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux unit tests by checking for NULL that's impossible in real code, ↵erg@google.com2009-07-161-2/+2
| | | | | | | | | | but needed in unit tests. TBR=willchan Review URL: http://codereview.chromium.org/155663 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20917 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Make the location bar area look native.erg@google.com2009-07-1611-38/+218
| | | | | | | | | | | | | | | | | Replace the star and go buttons with a native looking thing, where we manually draw the theme's button image for the full omnibox area and then position the star/go buttons on top of that. Also adds stand in versions of star_noborder and starred_noborder until Glen can make real icons. http://crbug.com/16227 http://crbug.com/13967 http://crbug.com/16915 Review URL: http://codereview.chromium.org/149681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20914 0039d316-1c4b-4281-b951-d872f2087c98
* Do not set/unset magic string during setup.exe patching step.kuchhal@chromium.org2009-07-161-7/+0
| | | | | | | | | BUG=NONE TEST=Make 3 stage updater fail by deleting <chrome>\Application\Installer\chrome.7z file and make sure "ap" key still contains "-full". Review URL: http://codereview.chromium.org/149776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20912 0039d316-1c4b-4281-b951-d872f2087c98
* Adds window position save/restore support for multiple monitors on Mac.rohitrao@chromium.org2009-07-162-18/+59
| | | | | | | | | | | | Fixes a bug where windows would creep up the screen every time you quit/restarted. BUG=http://crbug.com/16176 BUG=http://crbug.com/12854 TEST=Windows should save/restore in the correct location, with either a single monitor or multiple monitors. Review URL: http://codereview.chromium.org/155647 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20911 0039d316-1c4b-4281-b951-d872f2087c98
* First step in abstracting extension api to common/shared "IDL" files ↵rafaelw@chromium.org2009-07-1612-174/+158
| | | | | | | | | | | | | | (jsonschema). In this step, All "normal" api calls and events (those that arrive or originate from the browser process) are routed through a single v8::Extension API Call ("StartRequest"). Additionally, internal string names for methods and events now match the js namespace (i.e. "RemoveTab" -> "tabs.remove"), in anticipation of having names be implicit from their api module & name in the api "IDL". TBR=aa,mpcomplete Review URL: http://codereview.chromium.org/149730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20910 0039d316-1c4b-4281-b951-d872f2087c98