summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fix startup_test failures on Windows buildbot.phajdan.jr@chromium.org2009-03-051-3/+16
| | | | | | | | | | | | | The problem seems to be an error when overwriting file which is in use (that's how EvictFileFromSystemCache works on Windows). So I used a standard workaround for such Windowsic problems and created a wrapper which retries 10 times. Similar code was there before my porting patch. TBR=agl Review URL: http://codereview.chromium.org/40160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10981 0039d316-1c4b-4281-b951-d872f2087c98
* - DevToolsAgent is notified in render thread when RenderView is being detroyed.yurys@google.com2009-03-053-3/+20
| | | | | | | | | | - Methods of RenderView are called only on render thread in DevToolsAgent(earlier routing_id() was called on IO thread) BUG=8378 Review URL: http://codereview.chromium.org/39182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10980 0039d316-1c4b-4281-b951-d872f2087c98
* Make startup_tests build and run on Linux (except reference tests).phajdan.jr@chromium.org2009-03-0514-124/+142
| | | | | | Review URL: http://codereview.chromium.org/27240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10978 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of ResourceDispatcher::OnDownloadProgresshclam@chromium.org2009-03-051-3/+19
| | | | | | | | | | Implemented ResourceDispatcher::OnDownloadProgress to handle ViewMsg_DownloadProgress IPC message, implementation is a clone of ResourceDispatcher::OnUploadProgress because they have identical behavior. Review URL: http://codereview.chromium.org/39104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10975 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable cookie codepaths that use WebKitClient to analyzedarin@chromium.org2009-03-051-0/+11
| | | | | | | | | | performance impact. TBR=dglazkov Review URL: http://codereview.chromium.org/39177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10974 0039d316-1c4b-4281-b951-d872f2087c98
* Highlights of changes:hclam@chromium.org2009-03-056-4/+59
| | | | | | | | | | | | | | | | | | | 1. Added entry to ResourceResponseHead so that it contains either a base::PlatformFile (OS_WIN) or base::FileDescriptor (OS_POSIX) for passing the file handle from browser to renderer process. 2. Also added IPC messages for reporting download progress and ACK message for it. ResourceLoaderBridge::Peer::OnDownloadProgress is added so that the peer is notified of the download progress in the renderer process. 3. Load flag to kick start the resource loading for media files. LOAD_MEDIA_RESOURCE is added so that ResourceDispatcherHost knows how to use a different ResourceHandler for handling media resource request. Review URL: http://codereview.chromium.org/27168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10972 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes Issue 7377: Regression: Omnibox trims URL ending with 0x85 (Take 2)hbono@chromium.org2009-03-052-1/+21
| | | | | | | | | This is the same change as "http://codereview.chromium.org/20219/show", which I reverted it because it caused build breaks on sandbox. To investigate this build break, it seems this build break is somehow caused by "base/string_util.cc" that includes the TrimWhiteSpaceUTF8() function. To fix this build break, I moved the TrimWhiteSpaceUTF8() function to "base/string_util_icu.cc". BUG=7377 Review URL: http://codereview.chromium.org/28310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10970 0039d316-1c4b-4281-b951-d872f2087c98
* Put the dropdown menu button on the linux download shelf.estade@chromium.org2009-03-056-49/+146
| | | | | | | | | | Also set the background color. Also extend NineBox a little bit. Review URL: http://codereview.chromium.org/40139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10969 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in chrome.exe caused by the external tab container instance ↵ananta@chromium.org2009-03-052-7/+18
| | | | | | | | | | | | | | getting destroyed without going through the proper window shutdown sequence when the external host crashes. The fix is to ensure that we clean up correctly when the external tab instance goes away. Will add a unit test in a subsequent CB. Bug=1688967 Review URL: http://codereview.chromium.org/39086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10962 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that we display a sad face for a windowed plugin when the plugin ↵ananta@chromium.org2009-03-052-21/+45
| | | | | | | | | | | | | | | process crashes. This was a regression introduced by creating the plugin parent on the browser UI thread, which remains valid when the plugin process crashes. The fix is to track plugin wrapper windows in the PluginProcessHost class and destroy any remaining windows in the destructor. Removed the DestroyWindowTask which destroys the windows on the UI thread. We can achieve the same result by posting WM_CLOSE messages to these windows. This fixes http://code.google.com/p/chromium/issues/detail?id=7673 Bug=7673 Review URL: http://codereview.chromium.org/40120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10960 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a notimplemented with a bug about full screen mode.tc@google.com2009-03-051-2/+4
| | | | | | | Review URL: http://codereview.chromium.org/40142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10956 0039d316-1c4b-4281-b951-d872f2087c98
* Use grit to generate locale rc files and remove the old locale rc files from ↵tc@google.com2009-03-05153-4019/+3473
| | | | | | | | | | | | | | the tree. I made a small change to grit so we can use our resource ID as the translation ID making it a bit easier to read. The old locale_settings*.rc files would #include the google_strings.rc or chromium_strings.rc. Instead, I added it to the vcproj file using $(CHROMIUM_BUILD) to grab the right file. This required changing the output names in the grd files. TBR=deanm Review URL: http://codereview.chromium.org/39152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10955 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a toolbar width TODO.evan@chromium.org2009-03-051-4/+3
| | | | | | Review URL: http://codereview.chromium.org/39168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10954 0039d316-1c4b-4281-b951-d872f2087c98
* Changes spellcheck_unittest to read dictionaries directly from the src tree. ↵shess@chromium.org2009-03-056-75/+20
| | | | | | | | | Removes the build rules to copy test dictionaries to Dictionaries/. Review URL: http://codereview.chromium.org/40082 Patch from rohitrao. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10951 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't call gtk_init in the renderer process.agl@chromium.org2009-03-051-8/+5
| | | | | | | | | | | | | Previously, our command line objects were created /after/ gtk_init had processed |argc| and |argv|. With this patch, it's created before hand and main's |argc| and |argv| are now kept pristine. Thus our command line will now reflect GTK arguments that previously it wouldn't have seen. This should be harmless. Review URL: http://codereview.chromium.org/39172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10950 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression where bookmark manager would show black backgroundsky@google.com2009-03-051-3/+6
| | | | | | | | | | | | when not results are found for a search string. Using your halo methods does the trick. BUG=8367 TEST=see bug Review URL: http://codereview.chromium.org/39165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10944 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the browser about URL handler to not derive from WebContents. It isbrettw@chromium.org2009-03-0410-353/+355
| | | | | | | | | | | | | | | | | | | | instead integrated in the BrowserURLHandler for special schemes. This solves a number of problems and cleans things up nicely. Most of the functions were not necessary to have in the header file of the browser about handler, so I made them local to the .cc file. I moved everything around, but there was no change to any of the About...() functions. This improves the about:memory page to not include the memory of the new tab page it replaced. The entry for itself also has the proper title. This works by using a meta refresh to the actual page, the the process transition no longer happens at the same time as the about:memory page computation. This also fixes problems with the about:network and about:ipc dialogs opening blank pages and also re-opening the dialog when you close the browser. Review URL: http://codereview.chromium.org/27238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10941 0039d316-1c4b-4281-b951-d872f2087c98
* Changed several references from "char" to "uint8" which is the appropriate ↵ralphl@chromium.org2009-03-042-15/+17
| | | | | | | | | | | | | | | | definition for byte data buffers. This change is small, but modifies the data source interface Read() method, and the VideoSurface data structure. Mocks and tests all have very small changes. There are some changes in the mock_media_filters.h file that go beyond the scope of just changing char to uint8. These changes are required for future tests, and simply fill in parts of mocks that previously were NOTIMPLEMENTED(). The MockVideoFrame was modified to allow other tests to create a video frame directly without using the MockFilterConfiguration data structure. Also, it is now possible to construct a mock pipeline that has no audio. The currently checked-in pipeline will NOT work if you don't have audio. In a 2nd changelist, I will submit a new Pipeline_Impl and unit test that DOES support video without audio. Review URL: http://codereview.chromium.org/40059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10940 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup of backing_store_win.cccpu@google.com2009-03-042-60/+42
| | | | | | | | | | | | | | | | | | - Fix a small leak (solved by re-selecting the initial bitmap into the dc at dtor time) - Remove one set of GetDC(NULL) + GetDeviceCaps() + ReleaseDC() - Remove some dead code The removal of GetDC(NULL) might speed up Vista drawing a little bit, as is rummored that this operation is expensive when DWM + Aero is enabled. The integer overflow check is no longer possible. I'll file a bug so it is not lost. TEST= existing test suffice Review URL: http://codereview.chromium.org/21516 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10938 0039d316-1c4b-4281-b951-d872f2087c98
* Take two at hooking up title bar on linux.tc@google.com2009-03-042-24/+24
| | | | | | | | | | | | The only change from before is moving a method from a windows #ifdef section to outside it. TBR=evan Review URL: http://codereview.chromium.org/39158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10937 0039d316-1c4b-4281-b951-d872f2087c98
* Add download items to the download shelf in linux.estade@chromium.org2009-03-046-5/+182
| | | | | | Review URL: http://codereview.chromium.org/40136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10935 0039d316-1c4b-4281-b951-d872f2087c98
* Fix transparency for dragged downloads and links by using the halo textbrettw@chromium.org2009-03-042-62/+9
| | | | | | | routines. This also removes CreateDragImageForLink which is never called. Review URL: http://codereview.chromium.org/39082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10934 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r9953 since it caused regressions like: ben@chromium.org2009-03-048-56/+26
| | | | | | | | | http://crbug.com/8287 Eyeballing the code in RootView, this change seems wrong. Review URL: http://codereview.chromium.org/40124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10929 0039d316-1c4b-4281-b951-d872f2087c98
* Fix potential crash if the saved options tab is ever out of bounds.ben@chromium.org2009-03-041-1/+4
| | | | | | | | http://crbug.com/8342 Review URL: http://codereview.chromium.org/40090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10928 0039d316-1c4b-4281-b951-d872f2087c98
* Basic download shelf implementation on linux.estade@chromium.org2009-03-049-47/+200
| | | | | | | | | | It shows and hides at appropriate times, and that's about it. TEST=navigate to a savable page and select "save page as" from the page menu. Click the x. Save the page again. The shelf should pop up, go away, pop up again. Review URL: http://codereview.chromium.org/38004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10927 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Hook up the app title to the page title."tc@google.com2009-03-042-9/+9
| | | | | | | | | This reverts commit 10923. Review URL: http://codereview.chromium.org/40130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10924 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the app title to the page title.tc@google.com2009-03-042-9/+9
| | | | | | | Review URL: http://codereview.chromium.org/39114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10923 0039d316-1c4b-4281-b951-d872f2087c98
* Move files instead of copying them.kuchhal@chromium.org2009-03-0410-7/+562
| | | | | | | | | BUG=1184319,8218 Review URL: http://codereview.chromium.org/39048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10921 0039d316-1c4b-4281-b951-d872f2087c98
* Branding of Chrome.app.jrg@chromium.org2009-03-042-3/+37
| | | | | | | | | To brand, do a "src/tools/gyp/gyp_dogfood -Dbranding=Chrome src/build/all.gyp" (Then build, of course.) Review URL: http://codereview.chromium.org/40066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10920 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing WebKeyboardEvent.avi@chromium.org2009-03-046-14/+11
| | | | | | Review URL: http://codereview.chromium.org/39075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10918 0039d316-1c4b-4281-b951-d872f2087c98
* Make UITest::CrashAwareSleep portable.phajdan.jr@chromium.org2009-03-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/40119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10916 0039d316-1c4b-4281-b951-d872f2087c98
* Add trivial theming support in extensions.erikkay@google.com2009-03-044-10/+103
| | | | | | | NOTE: This is not final API. It *will* change. It's purely for testing purposes. Review URL: http://codereview.chromium.org/40042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10913 0039d316-1c4b-4281-b951-d872f2087c98
* Fix stupid mistake of forgetting negation in if condition.kuchhal@chromium.org2009-03-041-1/+1
| | | | | | | | | BUG=8371 Review URL: http://codereview.chromium.org/39149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10912 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another regression. Coordinate calculation in the ↵ben@chromium.org2009-03-041-1/+5
| | | | | | | | | | OpaqueBrowserFrameView::HitTest method was wrong. http://crbug.com/8365 Review URL: http://codereview.chromium.org/37008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10907 0039d316-1c4b-4281-b951-d872f2087c98
* add the webkit resources/strings to the combined pak files for mac/linux.thomasvl@chromium.org2009-03-041-0/+2
| | | | | | Review URL: http://codereview.chromium.org/39145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10904 0039d316-1c4b-4281-b951-d872f2087c98
* Register SSLManager preferences on linux and mac.evan@chromium.org2009-03-041-3/+3
| | | | | | | | | This should fix the following error: FATAL:common/pref_service.cc(314)] Check failed: false. Trying to read an unregistered pref: security.mixed_content_filtering Review URL: http://codereview.chromium.org/39006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10903 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the scripts that aren't needed in a gyp based mac build.thomasvl@chromium.org2009-03-042-71/+0
| | | | | | Review URL: http://codereview.chromium.org/40116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10902 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r10674, which got lost during Ben's reorg of the frame code.pkasting@chromium.org2009-03-042-7/+7
| | | | | | | | | I guess CalculateWindowSizeForClientSize() disappeared in that reorg? That's the one part of the old change I can't find where to put. BUG=8151 Review URL: http://codereview.chromium.org/39074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10896 0039d316-1c4b-4281-b951-d872f2087c98
* Use actual file system directory for Desktop shortcut instead of virtual folder.kuchhal@chromium.org2009-03-041-1/+2
| | | | | | | | | BUG=8310 Review URL: http://codereview.chromium.org/39087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10895 0039d316-1c4b-4281-b951-d872f2087c98
* Change line endings to Unix on url_constants.*brettw@chromium.org2009-03-041-33/+33
| | | | | | Review URL: http://codereview.chromium.org/40113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10893 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher in InitCurrentUI.glen@chromium.org2009-03-041-2/+8
| | | | | | | | | | Also fix a leak while I'm here. TBR=brettw Review URL: http://codereview.chromium.org/40112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10891 0039d316-1c4b-4281-b951-d872f2087c98
* It appears that ExtensionViewTest is behind a few bugs on the purify unit ↵erikkay@google.com2009-03-041-1/+4
| | | | | | | | | | | test bot. It's causing it to crash some of the time, and causing some UMRs and MLKs. TBR=mpcomplete,deanm BUG=8362,8363,8314 Review URL: http://codereview.chromium.org/40111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10890 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix a Purify UMR error. This isn't great, but it's better than nothing.deanm@chromium.org2009-03-041-2/+5
| | | | | | | | BUG=8314 Review URL: http://codereview.chromium.org/39125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10889 0039d316-1c4b-4281-b951-d872f2087c98
* Commit http://codereview.chromium.org/27037aa@chromium.org2009-03-044-259/+173
| | | | | | | | | Implement GM_xmlhttpRequest Review URL: http://codereview.chromium.org/39121 Patch from Steve Krulewitz <skrulx@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10886 0039d316-1c4b-4281-b951-d872f2087c98
* Also fixes a bug where an externally installedaa@chromium.org2009-03-043-197/+194
| | | | | | | | | | | | | | | | | | | | | | | extension was loaded twice the first run after installation. I still ExtensionServiceBackend is begging to be split apart into individual tasks, this was just a quick spruce-up while I was in the file. The main things I changed are: * Moved extension_path_ from a member back into parameters where relevant. This just didn't feel right as state to me. It isn't relevant to all the methods the way alert_on_error_ and frontend_ are. This created the majority of the noise in the change, but is the least important. * Renamed OnExtensionsLoadedFromDirectory to OnExtensionsLoaded since it is called in response to LoadExtension() too. * Made install_directory_ be a parameter to backend's constructor instead of passed into each appropriate method. Again, this felt more appropriate because the install directory is relevant to the whole object. * Hoisted checking for uninstalled external extensions up out of LoadExtension() into LoadExtensionsFromInstallDirectory(). It wasn't doing any harm in LoadExtension(), but it didn't seem relevant to other places where LoadExtension() is used (for example --load-extension and --install-extension). * Hoisted installation success notification up out of InstallOrUpdateExtension() into InstallExtension(). This prevented having to pass around a be_noisy argument since InstallExtension() is only used for handling --install-extension, and InstallOrUpdateExtension() is just the private impl. Review URL: http://codereview.chromium.org/40002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10885 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce string conversions related to cookie handling, and eliminate somedarin@chromium.org2009-03-041-7/+8
| | | | | | | | | | | | unnecessary WebKit:: scoping. This is part of a speculative fix for the intl1 page cycler regression. TBR=dglazkov Review URL: http://codereview.chromium.org/39120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10884 0039d316-1c4b-4281-b951-d872f2087c98
* Move the main entry point *.scons files in the key remaining componentssgk@google.com2009-03-041-0/+0
| | | | | | | | | (net, webkit, chrome) to *_main.scons, so we can use GYP=1 on the command line to switch between old and new while tracking down the remaining inconsistencies. Review URL: http://codereview.chromium.org/39080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10882 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bone-headed bug where ExtensionErrorReporteraa@chromium.org2009-03-042-2/+9
| | | | | | | | | gets deleted after first message is sent from a background thread. Review URL: http://codereview.chromium.org/39034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10881 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate an implicit string copy from WebString to string16 in order to testdarin@chromium.org2009-03-041-1/+2
| | | | | | | | | | | | if this might explain the intl1 performance regression. The theory is that this function is called a lot (once per anchor), so it may be a hot-spot. Previously, we did not have this extra string copy. TBR=brettw Review URL: http://codereview.chromium.org/39118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10880 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux buildbrettw@chromium.org2009-03-041-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10878 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 06:57:34 +0000