summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* This CL fixes xji@chromium.org2009-04-212-25/+72
| | | | | | | | | | | | | | | | | issue 6125 - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse and issue 8686 - RTL: Can't select RTL text from Chrome UI boxes The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout). The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605 BUG=6125 BUG=8686 Review URL: http://codereview.chromium.org/86003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14158 0039d316-1c4b-4281-b951-d872f2087c98
* Unittest gardening. Enable VisitedLinkTest and SessionBackendTest on Mac.shess@chromium.org2009-04-211-2/+0
| | | | | | Review URL: http://codereview.chromium.org/87051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14157 0039d316-1c4b-4281-b951-d872f2087c98
* Better omnibox handling of numeric input. Now we search based on the user's ↵pkasting@chromium.org2009-04-213-11/+46
| | | | | | | | | | original input instead of a transformed dotted quad when typing numeric hostnames; this should help noticeably in countries like China where such hostnames ("56.com") are popular. Original patch by Fumitoshi Ukai (see http://codereview.chromium.org/88011 ), r=me. BUG=10054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14156 0039d316-1c4b-4281-b951-d872f2087c98
* Merge BookmarkContextMenuGtk back into BookmarkContextMenu.erg@google.com2009-04-2110-546/+180
| | | | | | Review URL: http://codereview.chromium.org/87038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14155 0039d316-1c4b-4281-b951-d872f2087c98
* Use webtextinput to insert text for middle-click paste.estade@chromium.org2009-04-211-1/+4
| | | | | | | | Remove InsertText() from webview. Review URL: http://codereview.chromium.org/87002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14153 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in WebMediaPlayerDelegateImpl::Seek() where we (wrongly) assumed ↵scherkus@chromium.org2009-04-212-5/+5
| | | | | | | | | | time was in milliseconds. TBR=hclam Review URL: http://codereview.chromium.org/90009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14151 0039d316-1c4b-4281-b951-d872f2087c98
* Reland this change from yesterday. Gets basic text in omnibox2 popup ↵ben@chromium.org2009-04-212-40/+53
| | | | | | working. Ugly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14149 0039d316-1c4b-4281-b951-d872f2087c98
* posix: URLFixerUpper would DCHECK on input "/".evan@chromium.org2009-04-212-6/+17
| | | | | | | | Also, add some more tests to cover this case. Review URL: http://codereview.chromium.org/87048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14148 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor DialogDelegate so the DialogButton enum is in cross platform"tc@google.com2009-04-2162-223/+260
| | | | | | | | | | | | This reverts commit r14146. MessageBox is redefined to MessageBoxW by windows. I need to rename the class. Review URL: http://codereview.chromium.org/87064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14147 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DialogDelegate so the DialogButton enum is in cross platformtc@google.com2009-04-2162-260/+223
| | | | | | | | | | | | | | | | | code. This is mostly a find & replace in our code to use the new location of the enum. I also deleted some GetDialogButtons methods in child classes because they were identical to the parent version in DialogDelegate. This will allow more code to be enabled on linux/mac in the automation provider. Review URL: http://codereview.chromium.org/88008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14146 0039d316-1c4b-4281-b951-d872f2087c98
* comment test again as the fix didnt work.kuchhal@chromium.org2009-04-211-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/89008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14145 0039d316-1c4b-4281-b951-d872f2087c98
* Enable WebDatabaseTest on non-Win.shess@chromium.org2009-04-211-1/+0
| | | | | | Review URL: http://codereview.chromium.org/87053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14144 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak when we fail to load a gdkpixbuf. I meant to do this intc@google.com2009-04-211-7/+7
| | | | | | | | | the last change, but forgot. Review URL: http://codereview.chromium.org/69042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14143 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using and remove deprecated file_util::TrimFilename().thestig@chromium.org2009-04-211-1/+3
| | | | | | Review URL: http://codereview.chromium.org/67267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14142 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it possible to mock URLFetcher.sky@chromium.org2009-04-215-4/+165
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/87035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14141 0039d316-1c4b-4281-b951-d872f2087c98
* Fix installer tests broken by r13926.kuchhal@chromium.org2009-04-215-7/+44
| | | | | | | Review URL: http://codereview.chromium.org/87011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14140 0039d316-1c4b-4281-b951-d872f2087c98
* Add 8 locale dll files for 8 Indian languages to FILES. The list is used for ↵jungshik@google.com2009-04-211-2/+10
| | | | | | | | | | | zip file packaging. BUG=10828 Review URL: http://codereview.chromium.org/87055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14138 0039d316-1c4b-4281-b951-d872f2087c98
* Fix hang seen in plugin process because plugin creation ended up having to ↵jam@chromium.org2009-04-2111-216/+188
| | | | | | | | | | wait on UI thread. Instead of using sync messages, the plugin hwnd is initially parented to the RenderWidgetHost's HWND. It's then lazily reparented to an intermediate HWND on the UI thread when it comes time to move it. BUG=10711 TEST=added regression tests, but testers please confirm plugins on top video sites are placed correctly. Review URL: http://codereview.chromium.org/67285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14137 0039d316-1c4b-4281-b951-d872f2087c98
* Implement (kinda) ProcessSingleton for the Mac.avi@google.com2009-04-214-21/+39
| | | | | | Review URL: http://codereview.chromium.org/88031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14136 0039d316-1c4b-4281-b951-d872f2087c98
* Handle file drops and URL open requests. Along with declaring that we handle ↵avi@google.com2009-04-213-9/+209
| | | | | | | | the http scheme, this allows Chromium to be set as a default browser for the Mac. Review URL: http://codereview.chromium.org/87043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14134 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak accelerators, and add ctrl+_ for zoom out.estade@chromium.org2009-04-211-1/+5
| | | | | | Review URL: http://codereview.chromium.org/87041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14133 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Properly escape download item label markup.estade@chromium.org2009-04-211-9/+10
| | | | | | | | BUG=10766 Review URL: http://codereview.chromium.org/88055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in the download shelf.estade@chromium.org2009-04-211-2/+5
| | | | | | | | | | Windows doesn't explicitly delete the DownloadItemView objects because the View destructor deletes child views automatically. BUG=10739 Review URL: http://codereview.chromium.org/88044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14131 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to fix "maximized window size wrong after unlock". This is a ↵pkasting@chromium.org2009-04-211-20/+11
| | | | | | | | | | | blind fix but it seems like it should work. Instead of adjusting the window rect by the change in work rect for maximized windows, just size to (work area inflated by SM_CXSIZEFRAME), which is what a maximized window normally does. This makes the new window size independent of the previous window size, which could prevent problems if during a chain of resizes Windows doesn't like one of the desired window sizes and modifies it. BUG=8873 Review URL: http://codereview.chromium.org/88001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14129 0039d316-1c4b-4281-b951-d872f2087c98
* Fix #include (.h, not .cc).sgk@google.com2009-04-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/88050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14127 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up alt-d on linux.estade@chromium.org2009-04-211-2/+2
| | | | | | | | | | Also clean up some accelerators. BUG=10803 Review URL: http://codereview.chromium.org/90008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14123 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 2674 - search engine name containing parenthesis is not ↵xji@chromium.org2009-04-215-10/+16
| | | | | | | | | | | | | | displayed correctly in Omnibox NavSuggest drop-down list. The fix is to adjust the search engine name according to locale direction so that the search engine name containing parenthesis are marked with RLE-PDF to be displayed correctly in RTL UI. BUG=2674 Review URL: http://codereview.chromium.org/79005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14119 0039d316-1c4b-4281-b951-d872f2087c98
* I missed this file in my last checkinestade@chromium.org2009-04-211-4/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14118 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate a circular dependency by making BGRAToRGBA() generic (no pulling ↵sgk@google.com2009-04-211-2/+2
| | | | | | | | in guchar from gtk.h) and moving it from base/gfx to base. Review URL: http://codereview.chromium.org/87016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14117 0039d316-1c4b-4281-b951-d872f2087c98
* Add open/close animations to infobar, download shelf.estade@chromium.org2009-04-217-48/+216
| | | | | | | | Animations are implemented by packing the native widget structure into a GtkFixed which resizes and moves its contents around based on AnimationDelegate callbacks. Review URL: http://codereview.chromium.org/88005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14116 0039d316-1c4b-4281-b951-d872f2087c98
* Handle a race between the remove tab animation resizing the closing tab and ↵jhawkins@chromium.org2009-04-211-1/+11
| | | | | | | | | the gtk mouse events. Fixes a crash where the hover index would become stale before a leave-notify event. BUG=10776 Review URL: http://codereview.chromium.org/88037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14115 0039d316-1c4b-4281-b951-d872f2087c98
* Video and audio now pauses by playing NULL (0) PCM audio when the playback ↵ralphl@chromium.org2009-04-212-10/+15
| | | | | | | | | | | | rate is != 1.0. This is a non-optimal, but easy to implement interem solution. Correct fix is to actually stop audio playback, but that requires refactoring of components. Addede TODO's() where refactor needs to occur. Review URL: http://codereview.chromium.org/88014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14112 0039d316-1c4b-4281-b951-d872f2087c98
* During uninstall on Vista try to elevate if registry entries from HKLM need ↵kuchhal@chromium.org2009-04-213-1/+57
| | | | | | | | | | | to be deleted. BUG=7178 Review URL: http://codereview.chromium.org/82003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14106 0039d316-1c4b-4281-b951-d872f2087c98
* - Add a new time marker for loadtimes, the time of the first layoutdavemoore@chromium.org2009-04-212-83/+30
| | | | | | | | | | - Add new histograms for request -> first layout and start load -> first layout - Remove per navigation type histograms. They weren't being used and the logic was getting too complex. Review URL: http://codereview.chromium.org/88015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14100 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test for sad tab view.pinkerton@chromium.org2009-04-212-0/+40
| | | | | | Review URL: http://codereview.chromium.org/87028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14099 0039d316-1c4b-4281-b951-d872f2087c98
* Unit tests for button cells we use in the UI.pinkerton@chromium.org2009-04-213-0/+85
| | | | | | Review URL: http://codereview.chromium.org/87023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14098 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak introduced in http://codereview.chromium.org/62061dkegel@google.com2009-04-211-2/+2
| | | | | | | | | | | | | | Fixes valgrind warning 09:57:13 valgrind_analyze.py [ERROR] Leak_DefinitelyLost 1 bytes in 1 blocks are definitely lost in loss record 2 of 260 operator new(unsigned int) (vg_replace_malloc.c:195) FileVersionInfo::CreateFileVersionInfoForCurrentModule() (base/file_version_info_linux.cc:21) AutomationProvider::ConnectToChannel(std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&) (chrome/browser/automation/automation_provider.cc:811) Review URL: http://codereview.chromium.org/79087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14097 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/77006apavlov@chromium.org2009-04-217-41/+51
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14096 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bunch of basic unit tests for view classes.pinkerton@chromium.org2009-04-216-0/+205
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14095 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the RWHV so that when it gets a paint message from the renderer it ↵avi@google.com2009-04-212-45/+57
| | | | | | | | immediately paints. Also, implement the fix for updates done for the other platforms in http://codereview.chromium.org/66013 . Review URL: http://codereview.chromium.org/89001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14093 0039d316-1c4b-4281-b951-d872f2087c98
* More solid detection of browser process in chrome_process_util_linux.cc:phajdan.jr@chromium.org2009-04-216-22/+43
| | | | | | | | | | | | | | | | - use GetAppOutput instead of popen - make unexpected conditions fatal (otherwise the tests using this code would mistakenly assume that there is no running browser process) Also add a constant for SingletonSocket. Make necessary adjustments to GetAppOutput - ignore stderr (because fuser prints the file name to stderr and having stderr in |output| would require more parsing). Review URL: http://codereview.chromium.org/77031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14091 0039d316-1c4b-4281-b951-d872f2087c98
* Add 3 crashes to known list.huanr@chromium.org2009-04-211-0/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14089 0039d316-1c4b-4281-b951-d872f2087c98
* Remove crash 9566 from known list.huanr@chromium.org2009-04-211-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14088 0039d316-1c4b-4281-b951-d872f2087c98
* Rename web_contents_view to tab_contents_view to fix the mac build.brettw@chromium.org2009-04-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/88019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14086 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak of the NavigationController during many tests. A duplicatebrettw@chromium.org2009-04-214-22/+14
| | | | | | | | | | NavigationController was begin created from when we had to create this separately. BUG=10781 Review URL: http://codereview.chromium.org/88018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14084 0039d316-1c4b-4281-b951-d872f2087c98
* Rename web_contents_view* files to tab_contents_view* to reflect my previousbrettw@chromium.org2009-04-2124-63/+56
| | | | | | | rename of the classes. Review URL: http://codereview.chromium.org/87009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14083 0039d316-1c4b-4281-b951-d872f2087c98
* I managed to break test_shell. Reverting. I'll fix tomorrow.agl@chromium.org2009-04-2113-305/+93
| | | | | | | Reverts r14075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14080 0039d316-1c4b-4281-b951-d872f2087c98
* Build fixagl@chromium.org2009-04-211-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14079 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: add a stub for background_x11_thread for unit testsagl@chromium.org2009-04-211-0/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14078 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move X operations from the IO to UI2 thread.agl@chromium.org2009-04-2112-93/+299
| | | | | | | | | | | | | | | | | | | | | | | | | | | Currently we perform several X operations on the IO thread including geometry and clipboard work. This is causing races inside Xlib and crashing the browser. These are the result of synchronous calls from the renderer, so we cannot route these requests to the UI thread without risking deadlock. Thus we introduce the UI2 thread. This thread has a second connection to the X server and can perform X operations safely the without UI thread. Work remains to be done: Since we still have the hack where we pass GtkWidget pointers into the renderer and back, we still have to access these structures from the IO and UI2 threads. This still needs to be fixed, but this is not the patch for it. Also, not all the X calls from the IO thread have been moved over in this patch; just a few small ones. http://codereview.chromium.org/67145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14075 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 22:34:50 +0000