| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Add new option fields to the "User Data" tab and reorganize the "Under the Hood"
to fit a better User Experience.
RELANDING http://codereview.chromium.org/113896
TBR=ben
Review URL: http://codereview.chromium.org/115971
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR: beng
Review URL: http://codereview.chromium.org/118051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ben
Review URL: http://codereview.chromium.org/115968
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
included in the issue.
Add new option fields to the "User Data" tab and reorganize the "Under the Hood" to fit a better User Experience.
BUG=11435 (http://crbug.com/11435)
TEST=Opened the option dialog and checked if functional.
Review URL: http://codereview.chromium.org/113896
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17271
Review URL: http://codereview.chromium.org/116007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115966
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a new chrome switch called "print" and after the urls are being loaded, I call the last active browser and print the selected tab.
BUG=6942 (http://crbug.com/6942)
TEST=Added command line arguments [chrome.exe --print http://google.ca and the print dialog appeared for the selected tab component.
based on: http://codereview.chromium.org/100027
Review URL: http://codereview.chromium.org/118048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=deanm
BUG=http://crbug.com/12810
TEST=None
Review URL: http://codereview.chromium.org/113969
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115965
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I followed the Windows code rather than the Mac code, and saved whenever
the window is moved.
Note that we only restore window *size*, not position. We looked at every software we could find and none restored position.
BUG=12374
Review URL: http://codereview.chromium.org/115932
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix ctor to init members
- CID 4186
BUG = none
TEST = well, it is a unit test
Review URL: http://codereview.chromium.org/112076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix ctor to init members
- CID 4187
BUG = none
TEST = none
Review URL: http://codereview.chromium.org/118035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bug 12479. The Linux pieces are still disabled, however.
BUG=8205
TEST=Password autofill should continue to work on Windows.
Review URL: http://codereview.chromium.org/114057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/116007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/112077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=aa
Review URL: http://codereview.chromium.org/115681
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/115962
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add the 'automation' library target.
Add rlz.gyp and gmock.gyp to the pull_in_all target.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115950
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
messages a little bit.
BUG=11553
TEST=Uninstall system level chrome and select "delete profile data", %LOCALAPPDATA%\Chromium folder should get deleted.
Review URL: http://codereview.chromium.org/115945
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
docked window usually showing out of current screen
The problem is that the dragged tab view is not rendered correctly in RTL locale. The view should be rendered in a position that the mouse is on tabstrip, which is consistent with the position in which the view will be docked when mouse release.
The root cause is the dragged tab view's width is calculated incorrectly in RTL locale.
BUG=http://crbug.com/6223
TEST=Open Chrome in Hebrew, drag and drop a tab, observe the tab view while dragging, the view should be rendered in a position that the mouse is on tabstrip.
Review URL: http://codereview.chromium.org/115938
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of being a const.
BUG= http://crbug.com/1275
TEST=Set Windows XP font size to large or extra-large. Open Chrome.
Hover over a link to bring up the status bubble. Text should sit
comfortably in bubble, without being squeezed.
Review URL: http://codereview.chromium.org/113490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since it also had a default button (that would also register an accelerator for Enter), there would be an assertion failure when unregistering the first accelerator.
Also removed the Esc accelerator (it is already handled by the dialog by default).
BUG=12922
TEST=Repro the scenario described in bug.
Review URL: http://codereview.chromium.org/115956
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
between, as they may refer to acronyms or terms not in the dictionary.
BUG = www.crbug.com/12921
TEST = Type CLD (a library), should not change back to LCD
Review URL: http://codereview.chromium.org/118008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DefaultThemeProvider (whose accessor was mistakenly named 'getDIALOGthemeprovider')
BUG=11702
TEST=Install a theme and verify that the find bar matches it.
TBR=finnur
Review URL: http://codereview.chromium.org/115729
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Previous review: http://codereview.chromium.org/113909/diff/16/17
Patch my Meelap Shah
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to NativeViewHostGtk and location bar view colors.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115958
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
well as CLIPBOARD.
BUG=12716
Review URL: http://codereview.chromium.org/115949
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115952
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/115948
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=non
Review URL: http://codereview.chromium.org/115951
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
To do this, I needed to add a new TabStripModelObserver call that fired before the tab had been changed, since when the Omnibox asks for the current permanent_text_ it gets it from the selected tab's navigation controller.
BUG=6850
Review URL: http://codereview.chromium.org/113983
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
flag for Extensions. Expand themes unittests.
BUG=12205,12231
TEST=Without any flags, try installing an extension and a theme. The extension should fail and the theme should succeed. Attempts to install a theme with extension components in the manifest should similarly result in failure.
Review URL: http://codereview.chromium.org/115798
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
interactive UI tests unhappy.
TBR=tommi
Review URL: http://codereview.chromium.org/118029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115930
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115946
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Original patch by Yuzo Fujishima (see http://codereview.chromium.org/115180 ), r=me.
BUG=9587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
users since there's no indicator of it).
BUG=6856
TEST=In Omnibox or in a native textfield (e.g. the "Add a site" URL field for the Options dialog's "Open these sites at startup" pref), type text, set cursor at beginning, hit insert, and type. Your text should prepend to the existing text instead of replacing it.
Review URL: http://codereview.chromium.org/115934
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Put the chrome pdfs back in the mac_bundle_resources list since rules now match there also.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/112071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
escaped and showed up as &.
Get rid of manual escaping in bookmark context menu gtk.
BUG=12868
Review URL: http://codereview.chromium.org/118024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the code now does range request without any caching
the code path for passing file handle is not used any more.
Changes:
1. Remove response_data_file in webkit_glue::ResourceResponseHead
2. Remove response_data_file in net::ResourceInfo
3. Remove code that passes file handle using IPC
4. Remove code that passes file hadnle from network layer to ResourceDispatcherHost
5. Remove MediaResourceHandler
6. Remove code in disk_cache that expose the file handle
7. Remove ChromeURLRequestContext::CreateOffTheRecordForMedia() so no more OTR request context for media, in OTR mode simply memory cache is used
8. Reset cache size for media cache to default
BUG=12249
BUG=12256
Review URL: http://codereview.chromium.org/113931
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DefaultThemeProvider (whose accessor was mistakenly named 'getDIALOGthemeprovider')
BUG=11702
TEST=Install a theme and verify that the find bar matches it.
Review URL: http://codereview.chromium.org/115729
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ExternalTabContainer by re-routing those dispositions to new popups.
Review URL: http://codereview.chromium.org/115943
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
after it sends a response to the browser.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113867
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=none
Review URL: http://codereview.chromium.org/118001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Uninstall Chromium and verify that the "also delete your browsing data" text looks right.
Review URL: http://codereview.chromium.org/112073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=right click on a tab and see a context menu popup (i.e. no regression). Also, right click, hold, drag, release to select an item.
Review URL: http://codereview.chromium.org/118023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=deanm
Review URL: http://codereview.chromium.org/115935
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17217 0039d316-1c4b-4281-b951-d872f2087c98
|