| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
- alternate shortcut name for OEM install
- tooltips for our shortcuts
BUG=b/1640034
BUG=b/1522969
Review URL: http://codereview.chromium.org/20195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
When I stubbed out IsLinkVisitied, I didn't add a NOTIMPLEMENTED.
Review URL: http://codereview.chromium.org/21224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
from browser, and write unit tests for it.
Review URL: http://codereview.chromium.org/20233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
M VERSION
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
is true. This fixes a regression when the code got refactored.
BUG=7541
Review URL: http://codereview.chromium.org/20211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
generated_resources.vcproj rename.
TBR=deanm
Review URL: http://codereview.chromium.org/20235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I missed a file.)
Review URL: http://codereview.chromium.org/20226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* hook up mouse presses
* hook up resizes
* move gtk widget code into a container class (a la WebWidgetHostGtk)
Review URL: http://codereview.chromium.org/20230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
thumbnail images for Most Visited page.
Issue=2608
Review URL: http://codereview.chromium.org/24003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as that is a more accurate name.
I'm going to next rename the generated_resources.vcproj file to
chrome_strings so I can introduce a chrome_resources.vcproj which
is for things like browser_resources, common_resources,
renderer_resources and theme_resources.
Review URL: http://codereview.chromium.org/21202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is more accurate and after issue 21202 lands, more parallel with
the naming in webkit.
This will also make it less confusing once I add
chrome_resources.vcproj.
Review URL: http://codereview.chromium.org/21218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Adding proper project dependency in chrome.sln.
Review URL: http://codereview.chromium.org/21188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
refactoring, since the logger functions only got registered in the browser. This fix registers them using a global object for each message type (that's only compiled when debugging is enabled). One less thing to take care of when creating new message types.
Review URL: http://codereview.chromium.org/20213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make following unit tests compile and pass on Linux:
browser/
command_updater_unittest.cc
metrics/metrics_log_unittest.cc
search_engines/template_url_parser_unittest.cc
search_engines/template_url_prepopulate_data_unittest.cc
- Add renderer/renderer_main_unittest.cc to list of compiled files (currently stubbed out on Linux)
- Remove DebuggerWrapper stubs and make more files from browser/debugger build on Linux.
- Sync XCode project file.
- Misc cleanups needed for GCC.
Review URL: http://codereview.chromium.org/21181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/21215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
found the automation tests not hanging.
I also took a look at the logs from the hanging buildbots and the reverted change didn't touch on any of the code that appeared to be hanging.
I also put breakpoints on the modified functions while running ui_tests.exe and nothing hit, so it looks like a fluke.
I did get a hang though when running an old build of ui_tests.exe with a new version of chrome.dll.
Is there any chance that there could have been a stale version on the build bots?
Review URL: http://codereview.chromium.org/20214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the ViewMsg_New, we pass a NativeViewId to the renderer. When
WebKit wishes to know the metrics of the window, it echos that id back
in a ViewHostMsg_GetScreenInfo. Without this patch, it echos back NULL
and the browser crashes.
This highlights a semi-major TODO for the porting effort at some
point. We need to abstract the NativeViewIds from the NativeViews as
we cannot trust pointer values from the renderers.
The conversion code is in base/gfx/native_widget_types.h and currently
just casts between them (which is correct for Windows, where both
typedefs are HWNDs). One, maybe interresting idea is that we could
generate a random secret key in the browser and HMAC sign the pointer
values.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we don't have a HistoryService. This stops the
VisitiedLinkMaster from sucessfully calling Init(). In that case, no
message is ever sent to the renderer with the VisitiedLink shared
memory region and we end up crashing with SIGFPE as we try to hash by
taking a fingerprint mod 0.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Windows doesn't have a DescriptorSet, so don't try to copy it.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes the IPC Message logging code parses the message multiple
times. When we have a side array of FileDescriptors, this fails
because the array is consumed by the first parse and so the second
parse fails - causing a DCHECK failure.
Although we could write a system to all the side array to be parsed
multiple times, this code is only enabled in debugging mode and the
only advantage would be that we could log the actual descriptor
numbers. It doesn't appear that the performance hit would be
worthwhile.
Thus, we make hitting the end of the descriptor array a non-fatal
error. The returned descriptor will be -1. Since we have the number of
descriptors in the message header, the only case where this could mask
an actual issue would be where the browser and renderer disagree on
the structure of a given message. However, such a mismatch will
probably cause much more grevious errors anyway.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The kernel sets msghdr.msg_controllen to the length of the received
control data on successful return. Thus, we need to reset this
variable to the length of the buffer before each call.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Although descriptor passing was working fine in tests, it didn't work
at all in real code. When a Message is taken off the wire, it's copied
before processing. Message has an explicit copy constructor which
wasn't copying the list of FileDescriptors.
This changes makes the Message copy constructor steal the
FileDescriptors from the source Message.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Commit a few cleanups from my tree before starting on getting async
resources working.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
M VERSION
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/24008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RVH is getting deleted some how and the RVHM isn't cleanly up
correctly.
BUG=6316
TEST=none
Review URL: http://codereview.chromium.org/20185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
also update the WebContents display hack to not crash on startup
Review URL: http://codereview.chromium.org/21204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can't link in any more of these fixed .cc files because of a chain of
dependencies:
- temp_scaffolding_stubs defines the same symbols as these files
- removing the scaffolding pulls in more source
- pulling in that extra source breaks on Mac.
I have resigned myself to checking in this small bit.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
and I lack the patience to diagnose why mac doesn't link in libjpeg.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* implement some stubbed functions
* comment out some unimplemented IPC calls
* hack a webcontents widget into BrowserWindow so that something displays
Review URL: http://codereview.chromium.org/20204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- history
- autocomplete
- bookmarks
These were all reviewed separately but turned out to be interdependent. :~(
Review URL: http://codereview.chromium.org/21170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glen
Review URL: http://codereview.chromium.org/24007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Split FD tests into a separate file in preparation for additional tests.
Review URL: http://codereview.chromium.org/20202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For example, ./Hammer/chrome --renderer-cmd-prefix="gdb --args"
Review URL: http://codereview.chromium.org/21190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I forgot to to update the browser_resources.rc path in
unit_tests.vcproj.
TBR=deanm
Review URL: http://codereview.chromium.org/21196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
refactoring. More cleanup. Change tabstrip layout to match opaque frame.
BUG=5054
Review URL: http://codereview.chromium.org/20161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9433 0039d316-1c4b-4281-b951-d872f2087c98
|