| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This affects the sidenav, so if we go ahead with this I'll
regenerate all the files and add them to this CL.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/338007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab-specific state.
Future changelists will move Page Actions over to
ExtensionAction2, then replace ExtensionAction and
ExtensionActionState with ExtensionAction2.
Also, fix a bug in setIcon({path:...}) where it
would work only the first time.
BUG=24669,24472
Review URL: http://codereview.chromium.org/306044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.browserAction.setIcon().
SkBitmap expects premultiplied values, canvas returns them
not premultiplied.
BUG=24643
TEST=install gmail browser action sample. Should not have
weird colorful artifacts around edges.
Review URL: http://codereview.chromium.org/333011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/330010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/293038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I didn't go so far as to add support for arrows-on-the-bottom
in this change; I'm just making the bubble extend left or right
as needed. I'll add a parameter to specify the default arrow
location (needed for browser action popups) in another CL.
Tested by:
- dragging a window to the right edge of the screen and
confirming that bookmark bubbles open extended to the left
- opening a bookmark bubble, using a little X program to move
the Chrome window to the right side of the screen (can't drag
it there since the pointer is grabbed), and confirming that
the bubble gets updated to extend to the left
- running in Arabic and confirming that bubbles extend to the
left by default but get switched to extend to the right as
needed
BUG=23373
TEST=see above
Review URL: http://codereview.chromium.org/316006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/333020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Credits for the bookmark bar fix to dmac; stolen from http://codereview.chromium.org/267082 .
BUG=18289
TEST=Drag a link or bookmarklet from the web to the bookmark bar. It should be added at the end of the bar.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29906
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=29908
Review URL: http://codereview.chromium.org/336001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/329016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25444
Review URL: http://codereview.chromium.org/316019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
Review URL: http://codereview.chromium.org/337015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
violations, some to be consistent with prevailing team style, some merely in hopes of increasing readability.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/330007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
speculative fix was correct.
I tracked this down to my earlier change to not leak NPObjects on channel shutdown (which now happens a lot more often because of sudden termination for tab close). Since we now call an NPObject's deallocate function, it's possible that it leads to an NPObjectProxy being deleted, in which case we would delete an object in the listener's array while we're looping across it.
BUG=25439
Review URL: http://codereview.chromium.org/332013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
function.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/295053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I slightly jumped the gun on committing CL 328010, and this patch does some things requested in a review.
BUG=23825
TEST=none
Review URL: http://codereview.chromium.org/326024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I misunderstood how allocations work in the original
version and wasn't handling the case where there are
intermediate GdkWindows between the target widget and
its toplevel window correctly.
TEST=first-run, bookmark, and browser action bubbles get opened in the correct places under xmonad, metacity, and ion3
BUG=23373
Review URL: http://codereview.chromium.org/326017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This only removes the binding to the functions, not their implementation, as we may want to bring back badges for pageActions if we can make them look good.
BUG=25552
Review URL: http://codereview.chromium.org/329001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/337008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=25689
Review URL: http://codereview.chromium.org/334014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/328016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/328015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/338006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also change windows so that it always shows the Extensions menu item, but greys it out if it's disabled.
BUG=25424
Review URL: http://codereview.chromium.org/316017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bookmark bar calls IsFullScreen() during startup, which queries state_.
I checked to see if relying on a dummy value would get us into trouble with some crazy corner case where we are in the wrong floating state---it doesn't appear to.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/328014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Linux and Mac, so that even though the code is compiled, it won't run.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/314016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Whenever a plugin-opened window is closed, check for other visible windows and only reactive the browser process if there aren't any.
BUG=23566
TEST=Press command-shift-G on a plugin-opened open dialog, then dismiss the sheet. The open dialog should stay visible and active.
Review URL: http://codereview.chromium.org/328013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently it often leads to a useless home page. I kept the ImportHomepage() method in case we ever change our minds.
BUG=25603
TEST=Set the home page in Safari to something interesting; run Chromium with --first-run to bring up import dialog; select Safari and continue; make sure home page isn't imported.
Review URL: http://codereview.chromium.org/328010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
activates the browser window that the themes gallery is opened in.
http://crbug.com/24866
TEST=see bug
Review URL: http://codereview.chromium.org/308013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
creating it, for the memory purger.
BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/326014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
but undo a previous change to the way we measure strings in pango.
Review URL: http://codereview.chromium.org/338001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24621
TEST=none
Review URL: http://codereview.chromium.org/306057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fork the show home button string since mac uses it with different context.
- Updated text on the toolbar control buttons for the mac prefs window.
TEST=text is changed, see bugs
BUG=25667
BUG=25668
Review URL: http://codereview.chromium.org/330006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=arv
BUG=25509
TEST=Open the extensions page and it should have a plugin as it's favicon.
Review URL: http://codereview.chromium.org/329012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
makes the naming of string_escape more clear (it's actually JSON-specific).
Move the files into the base namespace.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/316016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/307020
Changed active URL handling in RenderView::OnMessageReceived and RenderView::OnNavigate. Now we call SetActiveURL directly so that we don't unset the URL when falling out of scope.
We can try this in the render process on dev channel for a few weeks. If we're happy with the results, we do the same thing on the plugin process.
TBR=cpu
BUG=22033
TEST=Trigger a crash in the render process and see if the dump includes the URL
Review URL: http://codereview.chromium.org/328008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=manually tested
BUG=19993
Review URL: http://codereview.chromium.org/295052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/326012
Check word lengths before adding to dictionary and spellchecking.
TBR=brettw
BUG=20469
TEST=None
Review URL: http://codereview.chromium.org/332012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CocoaNoWindowTestHelper.
Is responsible for bootstrapping cocoa and verifying that all windows are
closed down correctly between tests. Also includes a macro for doing some
very repetitive view testing that we had multiple copies of. I included a single
changed over test so that you can see the difference.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/327010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25594
TEST=background is white
Review URL: http://codereview.chromium.org/332011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
function crashes.
BUG=25104
Review URL: http://codereview.chromium.org/337004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25509
TEST=Open the extensions page and its tab should have an icon.
Review URL: http://codereview.chromium.org/332009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
APIs to forward (and thus stub out in your test), while others will
keep being fulfilled as per usual. This lets you build tests that
stub out one piece of behavior while testing that some side effects of
another API happen as expected.
BUG=none
TEST=Run ui_tests.exe
Review URL: http://codereview.chromium.org/314015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=maruel
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/338003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/335002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hold more autofill data about each form field.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/306061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Made it into a class with static methods.
BUG=24602
TEST=Compiled Webkit/Chromium and Try Bot'd
Review URL: http://codereview.chromium.org/308015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23865
Review URL: http://codereview.chromium.org/320009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Adjust the edit buttons after adding a new keyword.
* Don't make NSPointerArray calls which cause exceptions.
Patch from rsesek@chromium.org http://codereview.chromium.org/262028
BUG=23350, 22545
TEST=Preferences-->Manage. Add a search engine. Click "Make Default", delete it ("-)". Crash.
Review URL: http://codereview.chromium.org/319006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=24669,24472
TBR=mpcomplete@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Revert
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29908 0039d316-1c4b-4281-b951-d872f2087c98
|