summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* More tweaks and fixes for extension and bookmark sync promo. mirandac@chromium.org2009-11-204-37/+86
| | | | | | | | | | | | Make bookmark sync link start up the sync process. Make the message more aesthetically pleasing. Improve the overall layout of the message; ensure it doesn't overlap the NTP content. Also add a border to the notification line so that it matches the promo line in appearance, and stands out against themes of all colors. BUG= 27853, 28047 TEST= start chrome, click on "bookmark sync" in promo message on NTP. chrome should start up the bookmark sync process. Review URL: http://codereview.chromium.org/402021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32619 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window.close() for page action popups.erikkay@chromium.org2009-11-208-37/+105
| | | | | | | | | | | | Convert mappy to a page action popup. Also fix a bug where disabling an extension with a page action didn't cause the icon to hide. BUG=27519 TEST=none Review URL: http://codereview.chromium.org/414019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32616 0039d316-1c4b-4281-b951-d872f2087c98
* Add some security considerations to our extension docs.abarth@chromium.org2009-11-209-14/+378
| | | | | | | | | BUG=26594 TEST=None, just documentation Review URL: http://codereview.chromium.org/412003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32614 0039d316-1c4b-4281-b951-d872f2087c98
* RESUBMIT of http://src.chromium.org/viewvc/chrome?view=rev&revision=32319 ↵jorlow@chromium.org2009-11-206-71/+47
| | | | | | | | | | | | | | | | | with unit test fixes. Make the WebKitThread object start the WebKit thread on construction (not lazily). NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing. TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread. TEST=The WebKit thread gets spun up early in the initialization process. BUG=24144 Review URL: http://codereview.chromium.org/404025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32608 0039d316-1c4b-4281-b951-d872f2087c98
* Making grd dependencies more correct for grds in app.bradnelson@google.com2009-11-204-113/+118
| | | | | | | | | BUG=17706 TEST=None Review URL: http://codereview.chromium.org/414006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32602 0039d316-1c4b-4281-b951-d872f2087c98
* Add compiler-specific "examine printf format" attributes to printfs.evan@chromium.org2009-11-209-30/+38
| | | | | | | | | | | | Functions that take a printf-style format get a new annotation, which produces a bunch of compiler warnings when you use printf impoperly. This change adds the annotations and fixes the warnings. We now must use PRId64 for 64-bit numbers and the PRIsz for size_t. Review URL: http://codereview.chromium.org/339059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32600 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run TextEliderTest.ElideTextLongStrings under ThreadSanitizertimurrrr@chromium.org2009-11-201-0/+2
| | | | | | | | | It hangs. BUG=28332 TBR=dank Review URL: http://codereview.chromium.org/412009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32599 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: remove cursor turd from About dialog.viettrungluu@chromium.org2009-11-203-645/+112
| | | | | | | | | | | | | (The cursor was displayed with full keyboard accessibility enabled.) Changes to About.xib: changed the class of the view containing the legal text to |AboutLegalTextView| (from |NSTextView|). BUG=25570 TEST=Enable Full Keyboard Access, All controls in System Preferences; look in the About Chromium/Google Chrome; there should be no cursor displayed (at the end of the text). Review URL: http://codereview.chromium.org/414028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32598 0039d316-1c4b-4281-b951-d872f2087c98
* Go back to a single toast flavor.cpu@chromium.org2009-11-205-39/+22
| | | | | | | | | | | | | - We have picked a winner, code can go back to being simple. - result codes are now TFxx TEST=launch setup with --inactive-user-toast BUG=none Review URL: http://codereview.chromium.org/416002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32597 0039d316-1c4b-4281-b951-d872f2087c98
* Fix assert in sad_tab when requested width for message is < -1.kuan@chromium.org2009-11-201-2/+4
| | | | | | | | BUG=28270 TEST=verify per bug report. Review URL: http://codereview.chromium.org/414022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32595 0039d316-1c4b-4281-b951-d872f2087c98
* Add extensions BookmarkModel observer automatically when manifest has ↵mattm@chromium.org2009-11-202-5/+5
| | | | | | | | | | | bookmarks permission. BUG=28136 TEST=see bug Review URL: http://codereview.chromium.org/412007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32594 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 253.0 to 254.0chrome-bot@google.com2009-11-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32593 0039d316-1c4b-4281-b951-d872f2087c98
* Adds popups to browser actions, completing the feature.andybons@chromium.org2009-11-2011-18/+410
| | | | | | | | | | | | Adds functionality to choose between two different InfoBubbleView types: white background and gradient background. Screenshot: http://andybons.com/chrome/news_popup.png BUG=23881 TEST=Install a browser action extension that has a popup, click and observe the popup being shown. Initial unit test added, but disabled. Review URL: http://codereview.chromium.org/402077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32589 0039d316-1c4b-4281-b951-d872f2087c98
* Special case the gallery to not show the scary download roadblock.aa@chromium.org2009-11-209-28/+42
| | | | | | | | | | That was only needed because of clickjacking. BUG=28227 Review URL: http://codereview.chromium.org/411004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32588 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.levin@chromium.org2009-11-201-1/+1
| | | | | | | | | | TBR=jam@chromium.org TEST=None BUG=None Review URL: http://codereview.chromium.org/414023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32587 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unitialized memory access in workers.levin@chromium.org2009-11-202-6/+71
| | | | | | | | | | | | | | | | | | | | The primary issue was that OnDestroy didn't change the entangled port to have its entangled port be none. A secondary issues that came up is that in very rare circumstances (like a crash happening early in a worker process), it seemed like it may be possible that one of the message ports may think it is entangled and the other half may not, so the Erase method guards against this. Also, some code was added to verify the internal structure before running code and after. BUG=27839 TEST=valgrind on linux running ui tests, specifically WorkerTest.WorkerFastLayoutTests. Review URL: http://codereview.chromium.org/402106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32586 0039d316-1c4b-4281-b951-d872f2087c98
* GTK bookmark manager polish.estade@chromium.org2009-11-201-6/+15
| | | | | | | | | | | | 1. on right tree view, deselect everything when user presses below lowest row. This is not native gtktreeview behavior, but it is used in windows and by nautilus via libegg, so it matches user expectations. 2. allow default left click handler to run on right tree view. This allows a left click below the lowest row to cause the tree view pane to take focus. 3. continue blocking empty drags. BUG=27869,27872 Review URL: http://codereview.chromium.org/417002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32585 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac ui test valgrind.estade@chromium.org2009-11-201-2/+0
| | | | | | | | | | | | | this define should have been SPELLCHECKER_IN_RENDERER, but instead it was OS_LINUX, so I didn't notice it. BUG=none TEST=none TBR=thestig Review URL: http://codereview.chromium.org/414021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32584 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unique naming from syncer! This reduces the complexity. Modify the ↵chron@google.com2009-11-2032-2647/+1160
| | | | | | | | | | | | | | | | | | | | | index to store things with parent id and metahandle instead of parent id and name. Add a template function for extracting name from proto buffers. Refactor some unit tests to work without unique naming. Remove path calls since they make no sense without unique names. Remove find by parentID and names. Remove unique name resolution from conflict resolver. Remove syncable name class. TEST=included unit tests Review URL: http://codereview.chromium.org/371029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32583 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix regression issue 27964: ctrl+tab loses focus from the text box.suzhe@chromium.org2009-11-202-6/+36
| | | | | | | | | BUG=27964 TEST=Open two tabs, and load www.google.com in one tab and place the cursor in the search box, then press ctrl-tab twice. The cursor should be still in the search box. Review URL: http://codereview.chromium.org/402083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32581 0039d316-1c4b-4281-b951-d872f2087c98
* Set the label for a chrome link button when the text is set, not whentony@chromium.org2009-11-201-2/+14
| | | | | | | | | | | | the expose event fires. This avoids a relayout that happens when the label is set the first time the link is exposed. TEST=Put a breakpoint in gtk_chrome_link_button_expose and open the about dialog. You should hit the breakpoint twice, not four times. Review URL: http://codereview.chromium.org/411007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32579 0039d316-1c4b-4281-b951-d872f2087c98
* Undo my revert at r32524 due to a startup test regression.mpcomplete@chromium.org2009-11-206-9/+92
| | | | | | | | | | | | ExtensionHosts once again spawn extension processes asynchronously. However, if the process is already started, we now initialize the RenderView synchronously. This is so bug 28049 stays fixed. BUG=28049 Review URL: http://codereview.chromium.org/402101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32578 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change in r31143 which caused crash signal msg size to change and ↵mmoss@chromium.org2009-11-201-1/+1
| | | | | | | | | | | | subsequent read to fail. This was causing MetricsServiceTest.CrashRenderers to fail on Linux branded builds with CHROME_HEADLESS set: http://build.chromium.org/buildbot/waterfall.fyi/builders/Google%20Chrome%20Linux/builds/4723/steps/ui_tests/logs/CrashRenderers Review URL: http://codereview.chromium.org/414010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32575 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Fix issue where a thumbnail was stuck in hover mode after a delete.arv@chromium.org2009-11-201-0/+18
| | | | | | | | | | | | | | | | | | | The reason why the thumbnail was stuck is that it was focused due to the mousedown (the element was reused). Now we blur the element when we blacklist the thumbnail. This also adds support for Del (and Cmd+Backspace for mac) to blacklist the focused thumbnail. This also fixes the issue where the user could tab to a filler. BUG=28185 TEST=Remove a thumbnail and move the mouse out of the mostvisited thumbnails. None of them should be highlighted. Review URL: http://codereview.chromium.org/414011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32573 0039d316-1c4b-4281-b951-d872f2087c98
* Making the browser tests run out-of-process on Windows.jcampan@chromium.org2009-11-192-190/+143
| | | | | | | | | | | | | | | | | | | Windows was the only platform where they were run in-process. Arguably running out-of-proc is more stable (a test that crashes won't crash the entire test suite run). I timed in-proc/out-of-proc runs, the out-of-proc is also slightly faster. This as the added benefit that we don't need the --lib flag anymore. This CL also adds usage and fixes the --help flag. BUG=27677 TEST=Make sure browser tests run well on Windows. Try using the --help flag, the --gtest_help flag and a combination of --gtest_filter and --single-process. Review URL: http://codereview.chromium.org/402061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32570 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: tell webkit to permit WebDragOperationMove drags.estade@chromium.org2009-11-191-3/+5
| | | | | | | | | BUG=28235 TEST=drag text between two text fields in a web page, e.g. google.com search results page has two <input>s. The dragged text should Move (not Copy) from one to the other. Review URL: http://codereview.chromium.org/414009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32563 0039d316-1c4b-4281-b951-d872f2087c98
* Move Mac to using renderer spellchecker.estade@chromium.org2009-11-1937-2633/+845
| | | | | | | | BUG=25677 Review URL: http://codereview.chromium.org/395007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32561 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add support for growing or shrinking the window during animations.rohitrao@chromium.org2009-11-197-44/+174
| | | | | | | | BUG=http://crbug.com/14900 TEST=No visible impact, yet. Review URL: http://codereview.chromium.org/391035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32560 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLs out of *.pak files and put them into code. This savestony@chromium.org2009-11-198-58/+55
| | | | | | | | | | 28k of pak file size, but will make the binary a tad bit larger. BUG=28174 Review URL: http://codereview.chromium.org/407007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32556 0039d316-1c4b-4281-b951-d872f2087c98
* Making the toast localizedcpu@chromium.org2009-11-191-69/+29
| | | | | | | | | | | Current code had 4 flavors of non-localized strings, now we have selected one and localized BUG=none TEST=start chrome with --try-chrome-again=0 and observe. Review URL: http://codereview.chromium.org/399102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32552 0039d316-1c4b-4281-b951-d872f2087c98
* Moved a whole pile of unittests over to CocoaTest.dmaclach@chromium.org2009-11-1948-1249/+537
| | | | | | | | | | | AboutIPC.xib - Connected up controller to its window and the window delegate to the controller. BUG=26484, 26484 TEST=See repro steps in bugs. Review URL: http://codereview.chromium.org/402066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32551 0039d316-1c4b-4281-b951-d872f2087c98
* Do not run user scripts on chrome.google.comabarth@chromium.org2009-11-191-1/+8
| | | | | | | BUG=28228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32550 0039d316-1c4b-4281-b951-d872f2087c98
* Removed parentWindow parameter from HtmlDialogWindowController.akalin@chromium.org2009-11-194-44/+16
| | | | | | | | | | | Center HTML dialogs using [window screen]. BUG= TEST=manual Review URL: http://codereview.chromium.org/407010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32549 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Show page action popup bubbles.derat@chromium.org2009-11-191-9/+20
| | | | | | | | | | | | | | | | | Focus is a bit weird within these; I suspect that it's the same with the browser action bubbles. It looks like the same issue that the bookmark bubble had: the bubble grabs the pointer; when a widget within it (e.g. combobox) gets clicked it steals the grab; when it ungrabs it the grab is released instead of being transferred back to the bubble. Unsure of what the correct fix is for this. BUG=28061 TEST=installed two separate extensions with page action popups and clicked on their icons Review URL: http://codereview.chromium.org/412001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32547 0039d316-1c4b-4281-b951-d872f2087c98
* Use TabSwitchPaintDuration in tab switching test.chase@chromium.org2009-11-191-20/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | Modified the tab switching test to use the new tab switch paint duration histogram in place of the whiteout duration histogram. As a measure, whiteout duration would not carry a value if we kept the backing store around for a tab, and we would end up with a result of zero instead of a useful result. Local results with the new measure are consistent with the number of operations we perform on the tabs. The tab switching test now fails if it cannot locate the correct histogram. In that case, it will output the contents of the log file for remote debugging. BUG=4104 TEST=count of tab switch paint duration histogram results in tab switching test equals number of tabs used in test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32196 Review URL: http://codereview.chromium.org/385121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32543 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Rename a poorly named class.rohitrao@chromium.org2009-11-191-5/+5
| | | | | | | | BUG=http://crbug.com/28261 TEST=None Review URL: http://codereview.chromium.org/402088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32541 0039d316-1c4b-4281-b951-d872f2087c98
* Made FlowHandler() be created by SyncSetupFlow itself.akalin@chromium.org2009-11-192-13/+27
| | | | | | | | | | | | Clean up SyncSetupFlow's flow_handler_ if ownership isn't taken away from it. BUG= TEST=SyncSetupWizard unit tests Review URL: http://codereview.chromium.org/405027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32540 0039d316-1c4b-4281-b951-d872f2087c98
* Add an .order file to ensure that no global text symbol winds up at an addressmark@chromium.org2009-11-193-2/+109
| | | | | | | | | | | | higher than _ChromeMain, so that CrashReporter stacks and other symbolized stacks aren't so confusing. Add a tool to verify that nothing violates this ordering requirement. BUG=28257 TEST=verify_order, which is part of the build Review URL: http://codereview.chromium.org/414003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32539 0039d316-1c4b-4281-b951-d872f2087c98
* Prep for printing common memory stats from page_cycler_tests and memory_test:sgk@google.com2009-11-193-162/+173
| | | | | | | | | | | | Move PrintIOPerfInfo(), PrintMemoryUsageInfo() and PrintSystemCommitCharge() into the UITest base class so both page_cycler and memory_test will be able to use them. Make the user data dir a parameter so that memory_test will be able to point to its temporary copy. BUG=none TEST=none Review URL: http://codereview.chromium.org/402052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32538 0039d316-1c4b-4281-b951-d872f2087c98
* Moved HtmlDialogWindowDelegateBridge into html_dialog_window_controller.mm.akalin@chromium.org2009-11-192-66/+65
| | | | | | | | | BUG= TEST=trybots,manually compiled Review URL: http://codereview.chromium.org/402075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32537 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extension port connection requests to provide tab information.mad@chromium.org2009-11-195-23/+42
| | | | | | | | | | For Siggi: http://codereview.chromium.org/408015 BUG=0 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32536 0039d316-1c4b-4281-b951-d872f2087c98
* Trying to unsplit chrome.gyp again.bradnelson@google.com2009-11-197-4249/+4156
| | | | | | | | | | BUG=None TEST=None TBR=mark Review URL: http://codereview.chromium.org/402090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32535 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32531 - Merging back chrome.gyp into a single piece.thestig@chromium.org2009-11-197-4145/+4249
| | | | | | | | | | | | | | | | Splitting may cause merge pain for m4. Will do this over again in about 2 weeks. BUG=None TEST=None Review URL: http://codereview.chromium.org/409006 TBR=bradnelson@google.com Review URL: http://codereview.chromium.org/414004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32533 0039d316-1c4b-4281-b951-d872f2087c98
* Merging back chrome.gyp into a single piece.bradnelson@google.com2009-11-197-4249/+4145
| | | | | | | | | | | | | Splitting may cause merge pain for m4. Will do this over again in about 2 weeks. BUG=None TEST=None Review URL: http://codereview.chromium.org/409006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32531 0039d316-1c4b-4281-b951-d872f2087c98
* Addition of the optional flag for the experimental.popup.show(...) callback ↵twiz@google.com2009-11-191-0/+1
| | | | | | | | | | | argument. BUG=none TEST=none Review URL: http://codereview.chromium.org/407005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32528 0039d316-1c4b-4281-b951-d872f2087c98
* Implement "Import Bookmarks and Settings".mrossetti@chromium.org2009-11-1911-1705/+1932
| | | | | | | | | | | | | Changed to MainMenu.xib: Added a new menu item under the ^IDS_SHORT_PRODUCT_NAME menu with the name . This menu item has a tag of 40014 corredponsing to IDC_IMPORT_SETTINGS and is connected to the commandDispatch: action of the CrApplication (First Responder). Changes to Toolbar.xib: Added a new menu item with the name ^IDS_IMPORT_SETTINGS in the same manner as above. BUG=26157 TEST=Launch Chrome and inspect the current bookmarks and settings. With no browser window open and then with a browser window open choose the "Import Bookmarks and Settings..." menu option found under the "Chromium" menu. Also, with a browser window open, hoose the "Import Bookmarks and Settings..." menu option found under the page's tool menu. Select a browser from the popup, choose the items to be imported, and press OK. Then inspect the bookmarks and other settings to insure that the selected items have indeed been imported. Review URL: http://codereview.chromium.org/378036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32526 0039d316-1c4b-4281-b951-d872f2087c98
* Revert old change that created an ExtensionHost's RenderView asynchronously.mpcomplete@chromium.org2009-11-196-85/+9
| | | | | | | | | | | | | With jam's recent change to spawn renderers from a background thread, ExtensionHost spawns processes asynchronously for free. Reverting this change also fixes a bug due to an extension popup closing before the next one can be created. BUG=28049 Review URL: http://codereview.chromium.org/399098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32524 0039d316-1c4b-4281-b951-d872f2087c98
* Sort the origins in the cookies_tree_model by effective TLD, as opposedian@chromium.org2009-11-192-8/+87
| | | | | | | | | | to a lexicographical sort on the entire origin as a string. BUG=28192 TEST=cookies_tree_model_unittest.cc Review URL: http://codereview.chromium.org/404039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32522 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a NTP resource cache. Instead of re-generating thetony@chromium.org2009-11-198-377/+401
| | | | | | | | | | | | | | | | | | | | | | | HTML for the NTP each time, keep a cached copy as part of the profile. - This changes the handling of StartDataRequest to always happen on the UI thread since it needs to use the Profile. Previously we would generate on the UI thread then handle all the requests on the IO thread. - first_view_ got changed into a static bool. I also removed it from being added to the json because it didn't appear to be used anywhere. - Merge the incognito and regular handler into one since I added that as a flag to the request in a previous change. I plan to add the CSS to NTPResourceCache next. BUG=23120 Review URL: http://codereview.chromium.org/399055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32520 0039d316-1c4b-4281-b951-d872f2087c98
* Mac language/locale cleanupthomasvl@chromium.org2009-11-194-24/+12
| | | | | | | | | | | | | | | - Effectively revert revision 28193 (http://codereview.chromium.org/258037), this makes Mac match the other platform for what at it's core is used for the chrome concept of locale. - For the ApplicationLanguage, the browser will end up with what Cocoa picks (same as before) - All other process types will honor the language they got on the command line when starting up. - When asked the apps language, have the same side effect as Windows and Linux has of pushing the language through to ICU also (so dates format right, etc.) - During browser startup, if someone passed a language, bail because Mac can't support that. TEST=The tips on the NTP and the dates on the history page are in the same language at the UI. BUG=26856 BUG=22727 Review URL: http://codereview.chromium.org/399086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32515 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 20:30:56 +0000