| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Some small cleanups of wstring::npos usage.
BUG=23581
Review URL: http://codereview.chromium.org/3390035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is up.
BUG=none
TEST=Start enabling cloud print proxy from advanced UI, button should dim.
Review URL: http://codereview.chromium.org/3550001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
options in each apps context menu.
o Updated some comments that were using the outdated NOTIFY_PREF_CHANGED notification.
o Make LAUNCH_PINNED the default type returned by ExtensionPrefs if it does not already exist.
o Some minor refactoring within the code to reduce duplication.
BUG=54731
TEST=NONE
patch from issue 3419010
Review URL: http://codereview.chromium.org/3453029
TBR=andybons@chromium.org
Review URL: http://codereview.chromium.org/3517004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To address the vulnerability of stale WebFrame pointers in the FormManager's cache this CL changes the cache from a map (with the WebFrame pointer as "key") to a flat vector of simplified "FormElement*" items.
To avoid leaking memory, we need to still observe |frameDetached|, and use that as a signal to reap any associated WebFormElements or WebFormControlElements.
BUG=48857
TEST=FormMananagerTest.*, and manual test of regular form filling, form filling a form with sub-iframes, and form filling a form with sub-frames.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60949
Review URL: http://codereview.chromium.org/3492015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
context menu.
o Updated some comments that were using the outdated NOTIFY_PREF_CHANGED notification.
o Make LAUNCH_PINNED the default type returned by ExtensionPrefs if it does not already exist.
o Some minor refactoring within the code to reduce duplication.
BUG=54731
TEST=NONE
patch from issue 3419010
Review URL: http://codereview.chromium.org/3453029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19991
TEST=run with --enable-tabbed-options, click certificate manager button in options
Review URL: http://codereview.chromium.org/3389001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3576004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension id.
This is to enable some work we're doing to change the uninstall event to be
delivered after the unload event.
BUG=54415
TEST=An extension using the management API should just get the extension id
instead of the full ExtensionInfo data for the onUninstalled event.
Review URL: http://codereview.chromium.org/3575003
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/3550002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54332
TEST=ExtensionTest.IsPrivilegeIncrease
Review URL: http://codereview.chromium.org/3590004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=
TEST=
Review URL: http://codereview.chromium.org/3539005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=compiles
Review URL: http://codereview.chromium.org/3555002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also stop the display link thread for background tabs even if --disable-hole-punching is active.
BUG=55754
TEST=Go to a page that uses the compositor (e.g. http://webkit.org/blog/386/3d-transforms/), then keep resizing the browser window for ~10 minutes. The browser should stay functional.
Review URL: http://codereview.chromium.org/3549004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Establishes that HttpNetworkSession owns all the socket pools.
Move out all the socket pools into a ClientSocketPoolManager. This is because
of the dependency tree amongst socket pools, which dictates the order in which
they must be constructed and destructed. In order to better establish it, I
moved them out to their own class. HttpNetworkSession owns the
ClientSocketPoolManager which owns the pools. We pass the pools as raw
pointers everywhere.
Note that ClientSocketPoolManager owns more pools than are publicly accessible via its interface. That's because some of them are wrapped by publicly exposed pools.
Also, ClientSocketPoolHistograms used to be reference counted. That's because it can be shared by multiple ClientSocketPools. But it's effectively a global as well, so I make their lifetimes persist for the length of ClientSocketPoolManager too.
I also removed internal refcounting in ClientSocketPoolBase. I had refcounted
it before I knew about ScopedRunnableMethodFactory back when I first started.
I cleaned up the unit tests a lot. Back when I was a young padawan, I didn't
really know what I was doing, so I copy/pasted a metric asston of code. Turns
out most of it was stupid, so I fixed it. I also stopped the use of
implementation inheritance with ClientSocketPoolTest because it's discouraged
by the style guide and more importantly because it caused the
ClientSocketHandles within the TestSocketRequest vector to be destroyed _after_
the pools themselves were destroyed, which is bad since the handles will call
pool_->Release() which blows up.
BUG=56215,56215
TEST=Existing unit tests
Review URL: http://codereview.chromium.org/3389020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
needed one-line deletion.
Tested, reproed the breakage, verified the fix.
BUG=none
TEST=none
TBR=ericu@google.com
Review URL: http://codereview.chromium.org/3567006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
deletion.
Tested, reproed the breakage, verified the fix.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Created 2 tabs, one for for clearing local browsing data, one for clearing server data
- Refactored the old local browsing code to use a grid layout rather than less-wieldy math
- Controls on all tabs block while, closing dialog is disabled, new throbber is going while clear is in progress
- Clear server tab will be behind a flag until I deploy the server endpoint
- Retained old clearing behavior: dialog closes on successful lear
- Clear server UI only visible if user is syncing
Outstanding issues:
- Clearing currently causes an account to become unusable. The cause of the issue is a known problem with auth; currently investigating a fix
- Unlike local clearing, clearing server data is more likely to error out. For now I just show a label next to the clear button that says Error, allowing the user to try again
BUG=54349
TEST=Clear from UI, or run sync backend tests checked in for issue 54280
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60845
Review URL: http://codereview.chromium.org/3412032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to enable some work we're doing to change the uninstall event to be
delivered after the unload event.
BUG=54415
TEST=An extension using the management API should just get the extension id
instead of the full ExtensionInfo data for the onUninstalled event.
Review URL: http://codereview.chromium.org/3575003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
set of hosts. this shouldn't be treated as a privilege increase, but is.
Also, centralize the logic for permission messages in preparation for splitting this out of Extension altogether.
BUG=56794
TEST=ExtensionTest.IsPrivilegeIncrease
Review URL: http://codereview.chromium.org/3501013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented VLOG(), VLOG_IF(), VLOG_IS_ON(). Added --v and --vmodule
switches.
Changed some spammy sync-related logs to use VLOG.
BUG=56965
TEST=New unittests
Review URL: http://codereview.chromium.org/3448028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means that these template instantiations will be built once in cancelable_request.cc instead of in each of the 20 files that use it. The definitions have been moved to make them not inline (as explicit template instantiation only works with non-inline members).
This cuts more than 4 megabytes off libbrowser.a in Debug mode.
This patch does nothing when compiled with MSVC, due to compiler problems.
BUG=none
TEST=compiles smaller
Review URL: http://codereview.chromium.org/3520001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54095
TEST=none
Review URL: http://codereview.chromium.org/3571002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the disabled pyauto test.
BUG=57189
TEST=crash_reporter.py on official build
Review URL: http://codereview.chromium.org/3530003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it can be reused.
Added GeImageDataUrl(SkBitmap& bitmap) that convert SkBitmap to data url. This will be used in DOMUI based menu.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3561001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Commit the match preview on mouse up for instant results. This is
needed as instant results may shift up during the commit. If we
didn't do this it could mean the mouse up event appears over a
different item then the mouse went down on.
. Makes match preview revert if focus goes to the page and wasn't
initiated by a mouse event.
. Makes transition from about:crash to valid page not commit the match
preview.
. Changes setOmniboxDimensions to setDropdownDimensions.
BUG=54833 56179
TEST=none
Review URL: http://codereview.chromium.org/3531001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and AsyncFileWriterClient.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3397030
TBR=ericu@google.com
Review URL: http://codereview.chromium.org/3590002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AsyncFileWriterClient.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3397030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test was testing to be sure that timing was
correctly monitored during the lifetime of
these UrlHostInfo instances. The new code defensively
checks values, and when tehy appear to be out of
spec, it verifies that the test bot is indeed
running slowly, and exits. This will usually
run the test as expected, but gracefully
exit when the bot is just too slow (or
has too much variance in execution speed)
to run the test carefully.
r=phajdan.jr
BUG=55169
Review URL: http://codereview.chromium.org/3431028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to remove gtk dependency from menu2 code in chromeos and to make DOMUI transition smooth (crosbug.com/6497)
Removed LanguageSwitchModel::GetFirstLevelMenuWidth as this does not seem to be used by anyone.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3533001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sergeyu
BUG=None.
TEST=None.
Review URL: http://codereview.chromium.org/3571007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Together, these sit for two minutes and fail every run.
BUG=55477,56364
Review URL: http://codereview.chromium.org/3586003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To address the vulnerability of stale WebFrame pointers in the FormManager's cache this CL changes the cache from a map (with the WebFrame pointer as "key") to a flat vector of simplified "FormElement*" items.
To avoid leaking memory, we need to still observe |frameDetached|, and use that as a signal to reap any associated WebFormElements or WebFormControlElements.
BUG=48857
TEST=FormMananagerTest.*, and manual test of regular form filling, form filling a form with sub-iframes, and form filling a form with sub-frames.
Review URL: http://codereview.chromium.org/3492015
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/3543003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a BubbleFrameView that uses BubbleBorder as its border;
- Add a BubbleWindow that uses BubbleFrameView as its window frame;
- Change NativeDialogHost to use BubbleWindow as its container;
BUG=chromium-os:6305
TEST=Verify javascript dialog is inside a bubble frame per mock in chromium-os:6305.
Review URL: http://codereview.chromium.org/3402037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is first step towards "offline first login".
BUG=http://code.google.com/p/chromium-os/issues/detail?id=6638
TEST=Manual: login, login failures, Guest mode should work well.
Review URL: http://codereview.chromium.org/3461033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To address the vulnerability of stale WebFrame pointers in the FormManager's cache this CL changes the cache from a map (with the WebFrame pointer as "key") to a flat vector of simplified "FormElement*" items.
To avoid leaking memory, we need to still observe |frameDetached|, and use that as a signal to reap any associated WebFormElements or WebFormControlElements.
BUG=48857
TEST=FormMananagerTest.*, and manual test of regular form filling, form filling a form with sub-iframes, and form filling a form with sub-frames.
Review URL: http://codereview.chromium.org/3492015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was broken for external_extensions.json key "update_url".
BUG=57044
TEST=ExtensionsServiceTest.ExternalInstallPrefUpdateUrl
Review URL: http://codereview.chromium.org/3471022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the default registry factory would crash if it saw a Negotiate header when trying to do a CNAME lookup because of a NULL resolver. Since then I've changed HttpAuthHandlerNegotiate to skip the CNAME lookup step when the resolver_ is NULL.
So, one option is to make CreateDefault accept an optional HostResolver argument. My concern is that since passing in NULL is the easier choice, people will do it and encounter user problems when going through a Negotiate proxy. Hence, I force the correct behavior.
BUG=56819
TEST=net_unittests, try fetch client through a Negotiate authenticating proxy.
Review URL: http://codereview.chromium.org/3518001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In webkit patch https://bugs.webkit.org/show_bug.cgi?id=46799 I'm renaming the
input element's @speech attribute to @webkitspeech. This chromium CL updates
the relevant test files with both the old and new attribute names so that they
won't break while the webkit change is being submitted.
BUG=53598
TEST=browser_tests --gtest_filter=SpeechInputBrowserTest.*
Review URL: http://codereview.chromium.org/3585001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=satish
BUG=44548
TEST=none
Review URL: http://codereview.chromium.org/3587001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=54955
TEST=PrefChangeRegistrarTest.*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60169
Review URL: http://codereview.chromium.org/3304015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium-os/issues/detail?id=7123
TEST=manual
Review URL: http://codereview.chromium.org/3526003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7166
TEST=Wizard screen accelerators are not working in official build.
Review URL: http://codereview.chromium.org/3455030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test was failing on mac due to fractional numbers and this CL fixes it.
The test also fails on windows sometimes complaining about a missing comma,
so I have added a log message and marked the test as flaky. I'll be watching
the tree for failures and log messages
BUG=51337
TEST=Tree turns green
TBR=bulach@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- FilePathWatcherTest.DeleteAndRecreate (bug 54822)
- FilePathWatcherTest.DirectoryChain (bug 54822)
- FilePathWatcherTest.MoveChild (bug 54822)
- FilePathWatcherTest.MoveParent (bug 54822)
- FilePathWatcherTest.NonExistentDirectory (bug 54822)
- AccountScreenTest.TestSchemeInspector (bug 46274)
- SavePageBrowserTest.SaveCompleteHTML (bug 52292)
- DownloadRequestLimiterTest.Allow (bug 39753)
- PPAPITest.Graphics2D (bug 54150)
- ExtensionApiTest.Storage (bug 42943)
- BrowserEncodingTest.TestEncodingAliasMapping (bug 51716)
- BrowserCrApplicationAppleScriptTest.InsertWindow (bug 53584)
- ExtensionInstallUIBrowserTest.TestThemeInstallUndoResetsToDefault (bug 43441)
TBR=mal
BUG=54822, 46274, 52292, 39753, 54150, 42943, 51716, 53584, 43441
TEST=none
Review URL: http://codereview.chromium.org/3545003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Seeing that GpuVideoDecoderHost has a very similar interface to
VideoDecodeEngine, this patch makes GpuVideoDecoderHost implments
VideoDecodeEngine.
Also did some cleanup work to remove code patch that doesn't fit
into the buffer allocation model we are moving to.
BUG=53714
TEST=Tree is green. Code still doesn't work yet.
Review URL: http://codereview.chromium.org/3393014
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/3531002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=less flakiness on the tree
Review URL: http://codereview.chromium.org/3520004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test was having issues in Mac and was disabled. After that we also added a webkit change
to not allow programmatic events from Javascript to trigger speech input, so this test was not
working anymore.
In this CL I have rewritten the test to send the mouse click via the RenderView and this
should fix the flakiness and get it working again.
BUG=51337
TEST=SpeechInputBrowserTest.TestBasicRecognition on all platforms.
Review URL: http://codereview.chromium.org/3446029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Seeing that GpuVideoDecoderHost has a very similar interface to
VideoDecodeEngine, this patch makes GpuVideoDecoderHost implments
VideoDecodeEngine.
Also did some cleanup work to remove code patch that doesn't fit
into the buffer allocation model we are moving to.
BUG=53714
TEST=Tree is green. Code still doesn't work yet.
Review URL: http://codereview.chromium.org/3393014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change just adds a virtual destructor so scoped_ptr<TabHandler> calls it. It seems we are leaking all the objects created in DefaultTabHandler::DefaultTabHandler() because the TabHandler class does not have the virtual destructor and scoped_ptr<TabHandler> cannot call DefaultTabHandler::~DefaultTabHandler().
BUG=57251
TEST=make the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3518003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60911 0039d316-1c4b-4281-b951-d872f2087c98
|