| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionsServiceBackend into a set of utility functions.
The intent of this is:
a) make extensions_service.cc smaller
b) have smaller pieces hanging around that we can more easily
reconfigure to implement new features.
c) improve testability.
Review URL: http://codereview.chromium.org/159400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160285
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also update the section background so that it looks the same on white, but is actually transparent.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159549
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
change as small as possible for beta merge.
TBR=ben
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No chrome code changes (does not affect any files that are used in build or tests).
This is the precursor to a build/check-in step to generate extension docs if underlying api or static content has changed.
TBR
Review URL: http://codereview.chromium.org/159551
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Install two themes without closing the infobar - make sure only one infobar is visible.
Review URL: http://codereview.chromium.org/160296
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tweaks for the list view mode.
This also fixes an issue where the thumbnails were not positioned
correctly at startup in RTL
BUG=17810, 17811, 17751
TEST=Hide the recent activities and make sure that the right border of
even more is shown. Switch to list mode. Make sure that the filler are
hidden. Try dragging the items in the list view. The text should not
dissappear.
Review URL: http://codereview.chromium.org/160291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now when an extension is loaded, you will see its entry in the task manager.
However, on the shelf there is still only a placeholder label (I have to
work on setting proper size for the render widget).
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/159527
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=awong
Review URL: http://codereview.chromium.org/159550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- ctrl+e = ctrl+k
- alt + e and alt + f to open the page and wrench menus respectively (emulating menu bar _File and _Edit)
BUG=none
TEST=use the new hotkeys
Review URL: http://codereview.chromium.org/160292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
iframe.
Also, override some styles that gets set in the theme css which is
written for the new new tab page.
BUG=None
TEST=Start chrome with --old-new-tab-page
Review URL: http://codereview.chromium.org/160290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
picker.
BUG=none
TEST=in a debug build, go to wrench->options->basics, select "open the following pages", click "add", select something from the list, and then deselect it by holding ctrl and clicking it again; chromium should not crash
Review URL: http://codereview.chromium.org/159540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(This is a patch of http://codereview.chromium.org/160109
Reviewer: aa.)
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
get called after Cleanup, which
results in the AutomationResourceMessageFilter member getting destroyed and a subsequent crash.
Added a NULL check for the same.
Review URL: http://codereview.chromium.org/160293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/160239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
an unused version of the OnMessageReceived method.
R=brettw
BUG=17104
TEST=none
Review URL: http://codereview.chromium.org/160242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I don't think we're guaranteed to have a pending one.
BUG=17916
Review URL: http://codereview.chromium.org/160286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When we use gtk_scrolled_window_add_with_viewport, it sets its own
shadow.
BUG=16913
Review URL: http://codereview.chromium.org/159535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(I went through the rest of the .grd to check all the window titles,
and filed a bug on the one other bad one.)
Spotted by Michael Monreal.
Review URL: http://codereview.chromium.org/159533
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I didn't even realize I checked in the code that disabled it.
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/159454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/17806
Review URL: http://codereview.chromium.org/160210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to ChromeURLRequestContext.
BUG=16932
TEST=none
Review URL: http://codereview.chromium.org/159519
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
references to each other) anywhere in the Chromium code base.
BUG=none
TEST=rebuild
Review URL: http://codereview.chromium.org/159523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Proxy settings are set using Gnome's network properties dialog, by running the
binary directly. The binary was renamed from gnome-system-preferences to
gnome-system-properties in Janurary 2009, so to ensure the dialog works on both
newer and older systems, this patch searches the users PATH for the binary to use.
Upstream rename: http://git.gnome.org/cgit/gnome-control-center/commit/?id=4f1b6aafba338a267b6c1b911ceb33358b2eca09
BUG=17756
TEST='Under the Hood' -> 'Change proxy settings' still works on Ubuntu Hardy as well as Ubuntu Jaunty.
Review URL: http://codereview.chromium.org/160146
Patch from Joel Stanley.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
causes a blank spot which no other thumbnail can be dragged to. This
will go away on page refresh, but we can easily redraw all items
keeping the filler in the rightmost indices.
Original patch by pierre.lafayette@gmail.com, http://codereview.chromium.org/160152
BUG=17738
r=me
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We can use a TYPE_IO loop for the renderer thread on Linux
in single-process mode since we run the plugins out of process.
Review URL: http://codereview.chromium.org/160274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the panel up to compensate for new text.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR
Review URL: http://codereview.chromium.org/159515
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17668
TEST=Run the test
Review URL: http://codereview.chromium.org/160108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159509
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
seconds.
This is as opposed to the value of 1 hour in release mode, which makes testing
difficult for people trying to test out autoupdate.
BUG=http://crbug.com/17867
TEST=Run with --enable-extensions --extension-update-frequency=30 will actually update an extension
that has updates after 30 seconds.
Review URL: http://codereview.chromium.org/159490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15418
Review URL: http://codereview.chromium.org/149758
Patch from Chris Masone <cmasone@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Switch NIB.
* Use NSWindowController.
* "Make default browser" button hooked up.
* Import bookmarks still not implemented.
Review URL: http://codereview.chromium.org/149512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SafeBrowsingProtocolManagerTest.TestGetHashBackOffTimes
and undisable the test.
TEST=none
http://crbug.com/1880
Review URL: http://codereview.chromium.org/160225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the ability to load multiple text blacklists into the binary blacklist representation.
NOTE: Included Binary file means this change expects to fail on the trybots
in blacklist_io_test.cc:103. All other checks must pass.
BUG=16932
TEST=BlacklistIO*
Review URL: http://codereview.chromium.org/159199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Give Automation better visibility and control over navigations.
Also, make it possible for automation to implement a dummy cookie
store to go with dummy request serving over automation.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17859
TEST=Download a largish file (iTunes or XCode). The download item's state should update several times a second, not just on hover.
Review URL: http://codereview.chromium.org/160237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also disable it for the cookie behavior combobox, because it fights with the scrolled window.
The GtkFileChooserButton spews the following 2 errors (and possibly others) when you scroll on it quickly:
Gtk-WARNING **: idle activate multiple times without clearing the folder object first.
Gtk: gtk_tree_model_get_iter: assertion `path != NULL' failed
This causes us to crash in debug, and causes undesirable console output in release. I verified that this is their bug and not ours by reproing in a simple program that just has a window with a GtkFileChooserButton in it.
BUG=17805
Review URL: http://codereview.chromium.org/159459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename shell_integration.cc to shell_integration_win.cc, so
shell_integration.cc can be used for cross-platform stuff.
Move DefaultBrowserWorker from GeneralPageView to ShellIntegration.
BUG=17179
Review URL: http://codereview.chromium.org/160218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
database.
Note that we're deliberately leaving NSS user databases open until NSS shutdown since closing and reopening it does not work correctly (NSS bug).
Also, enable the firefox_importer_unittest.cc for linux. Move out some tests to firefox_profile_unittest.cc.
Fix lock file deletion in the posix implementation of FirefoxProfileLock.
BUG=http://crbug.com/17490
TEST=Import bookmark and settings, verify that passwords are indeed imported.
Review URL: http://codereview.chromium.org/160077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159470
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There are models and an language array that are needed for the linux gtk views afaik. So extracting the classes from the windows specific code into separate files would allow code reusabiliy.
BUG=13524
TEST=Windows Language Dialog functions properly.
Review URL: http://codereview.chromium.org/151138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/159458
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21786 0039d316-1c4b-4281-b951-d872f2087c98
|