| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This also contains changes to the ExtensionsService to hook up the ExtensionUpdater.
BUG=http://crbug.com/12117
TEST=Extensions still work
Review URL: http://codereview.chromium.org/149213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=enable extensions using the toolstip.html code (added with this CL) and load pages in different languages. The corresponding language should appear in the bottom left after the page is loadedm or when the button is clicked, or when you navigate back to that tab after visiting some other tab.
Review URL: http://codereview.chromium.org/150062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/16148
TEST=Find in page should report match counts correctly.
Review URL: http://codereview.chromium.org/155353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/16070
Review URL: http://codereview.chromium.org/149416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is another my stupid mistake that my r19238 sends a Char event even when its text[] member does not contains any characters.
I mis-understoold I needed to send a Char event every time when gtk_keyval_to_unicode() returns 0 to avoid Issue 15024. But this is wrong.
(Page Down, Page Up, Arrow Keys work without Char events. Only return keys need Char events.)
BUG=15971 "drop down list moves 2 positions when using the keyboard".
TEST=Open the attached test-case
Review URL: http://codereview.chromium.org/155207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=9015 (http://crbug.com/9015)
TEST=Launch CHrome with '--lang=ar'. In options - Advanced tab, open up 'Fonts and Languages' dialog
and select 'Languages' tab. The string above 'Chrome UI language combobox' should not be truncated.
TBR=finnur
Review URL: http://codereview.chromium.org/126009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r20349.
Unit test failure. I suspect the test, but let's keep the tree green.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Accidently reverted the anti-revert.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit 4d74c3b46aeb8c7e3a05087d3b1f05f6906fd6e2.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we used a special Watcher object to watch the process,
but that is not portable to POSIX and this is simpler anyway.
With this change, I now see ~PluginProcessHost() running when a
plugin crashes.
If you recall all the way back to
http://codereview.chromium.org/16814
we did a similar thing to the renderer host.
Review URL: http://codereview.chromium.org/155331
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
GetCurrentPageTitle.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155334
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
In the plugin process, gtk_init needs to be called from the UI thread (PluginThread) not the main thread (PluginMain) which is an IO thread.
Review URL: http://codereview.chromium.org/149424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16374
TEST=added regression test
Review URL: http://codereview.chromium.org/149412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
More cleanup relating to pipeline cleanup.
BUG=16008
TEST=no real code chage, nothing should change
Review URL: http://codereview.chromium.org/155230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently on linux if the plugin process dies, the PluginProcessHost is not destroyed.
A side effect of that is that if a renderer tries to create a new plugin, the OpenChannelToPlugin message returns success with an empty handle, which is interpreted as the host channel, to which the renderer tries to connect to a second time, causing DCHECKs and havok in the browser process.
This CL fixes that particular problem, returning failure if the browser can't connect to the plugin process.
Review URL: http://codereview.chromium.org/155313
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=evmar
Review URL: http://codereview.chromium.org/155333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do as much as possible server side.
I suspect the main factors that made our previous implementation slow were blitting from client to server, several unnecessary copies of the entire image, and doing an in-memory rgba->bgra swap.
Now, even in debug mode with a 30" chrome window, the performance is very fast.
BUG=16257,15869
TEST=drag a tab out of the tabstrip, with and without compositing
Review URL: http://codereview.chromium.org/155321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=context menu shows when you right click (and doesn't immediately disappear)
Review URL: http://codereview.chromium.org/149417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ones in the patch are those that are implemented by other classes, avoiding
TabContents pass-throughs.
Review URL: http://codereview.chromium.org/149373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The code was introduced in r13044 and should have been removed in r13396 (when the majority of r13044 was undone).
BUG=16195
TEST=selection clipboard still works in render view, memory leak is gone
Review URL: http://codereview.chromium.org/149358
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
appears that some times Layout isn't invoked on initial size, so that
positioning the tab overview button only during Layout isn't enough.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't handle inline HTML in the item description (it just
dumps it as text) and the feed needs to be valid XML for it
to show any preview, but it is better than nothing. We can
easily change it to display the HTML but we want to (at some
point) try to use a separate origin so that we can render
the HTML code from untrusted sources safely.
Also fix a bug in the image tracker. It should not try
to communicate with the view if the view has gone away
(which was the whole point of the image tracker...)
BUG=None
TEST=Install the extension, browse to a page with a feed
and click onthe rss icon in the Omnibox. An interstitial
page should appear with a preview of the feed.
Review URL: http://codereview.chromium.org/155180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
canvas.
BUG=15869
TEST=Drag a tab out of the Linux tab strip. There should be a light-blue border around the dragged tab contents.
Review URL: http://codereview.chromium.org/155317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window manager says the window isn't active.
ActiveWindowWatcher listens for X events and notifies the browser
windows when the active window changes. We can't just use focus
events because popup menus cause browser windows to lose focus,
but it's still the "active" window.
Some window managers don't track active window, in which case we
don't get the x event and we just say that all windows are
active (our current behavior).
BUG=14649
Review URL: http://codereview.chromium.org/155303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Fix typo.
Review URL: http://codereview.chromium.org/155318
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=15148
TEST=Download a large file with a very long file name. The file name should wrap.
Review URL: http://codereview.chromium.org/149349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and caches them, line NSImage imageNamed: but lets us control the bundle that's checked.
Unittest for the helper.
Updated the current places that use +[NSImage imageNamed:] to use our cache helper.
BUG=none
TEST=All the ui images still load.
Review URL: http://codereview.chromium.org/149393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Some engines (clearlooks) query the bg color of a widget directly, so wrap the toolbar in an event box so that the bg value set in browser_window_gtk.cc doesn't leak through.
http://crbug.com/13967
Review URL: http://codereview.chromium.org/155310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
looking for the top-left origin of the tab strip in screen coordinates, but we sent in the coordinates of this point relative to the entire window to gtk_util::ConvertWidgetPointToScreen.
BUG=15867
TEST=Open enough tabs so that they must be resized. Repeatedly press the mouse over a close button so that many tabs are closed. The tabs should not resize until the mouse leaves the tab strip.
Review URL: http://codereview.chromium.org/155308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
here. Split out a few large functions into sub functions (Layout -> LayoutIcon, LayoutTitle, etc; Paint -> PaintIcon, PaintTitle etc).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149380
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=1316
Review URL: http://codereview.chromium.org/155053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whether opening from a tab or extension.
Also, move the callback handling back to extension_process_bindings, since I
didn't need it in event_bindings to implement this, and it didn't make sense
there anyway.
BUG=12461
TEST=no
Review URL: http://codereview.chromium.org/149237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16358
Review URL: http://codereview.chromium.org/149398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was added as a speculative crash fix by eseidel back in June of 2008. See
http://b/1211911 for details. It didn't appear to resolve the crash then (as
another patch was required to fix the bug), and it doesn't seem to be necessary
since the RenderView, which is the delegate and owns the WebView, is the one in
charge of allocating the WebView and destroying the WebView. So, it is not
possible for the WebView to outlive the RenderView.
BUG=16234
TEST=none
R=brettw
Review URL: http://codereview.chromium.org/155292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The save file indexes are 1 based, and if there is only one file type
that the page can be saved as (such as a page like foo.com/notes.txt),
the index is set to 0 which will cause a crash.
BUG=15555 (http://crbug.com/15555)
TEST=Go to a web page that is a text file and try to save it. Chrome
should not crash.
Review URL: http://codereview.chromium.org/155264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12699
TEST=throbber animations in tabs while page loading.
Review URL: http://codereview.chromium.org/149400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155300
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mirandac
BUG=13821
TEST=Verify that our toolbar buttons have the same visual style in normal, hover and pressed states
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
would be unexpected and cause the test to hang waiting for user interaction.
BUG=None
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/155293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155296
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20280 0039d316-1c4b-4281-b951-d872f2087c98
|