| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
(or can be deleted).
BUG=7176
Review URL: http://codereview.chromium.org/27258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests.
Add a helper class to manage Windows' transparency issues. It will create layers
and manage transforms in such a way that most effects can be achieved with
fonts and form controls on Windows while looking nice.
This removes the magic transparency color and associated infrastructure since
it is no longer needed.
This fixes semitransparent ClearType antialiasing and pngs with alpha channels
with opacity applied.
BUG=559,2791,3229,6372
Review URL: http://codereview.chromium.org/21201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
popup window as an app too.
To not lose this functionality, yet fix bug 5739 about those app popup windows which would persist their window placement, I decided to add a new enum browser type item which is a bit combination of both popup and app so we can track those.
bug= http://crbug.com/5739
Review URL: http://codereview.chromium.org/28271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
code would attempt to access an HTREEITEM after it was removed,
leading to weird problems.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/28275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
manager (Glen says no context menus for now). All
BookmarkModelObservers have been updated appropriately.
BUG=1750
TEST=bring up the bookmark manager and try the 'Reorder by title' menu
item, make sure it works and I didn't screw up anything around it.
Review URL: http://codereview.chromium.org/27262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
or not they fully render their own frame. This simplifies things a bit on the way to unification of Window and CustomFrameWindow.
Review URL: http://codereview.chromium.org/27286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we create the OK & Cancel dialog buttons in
DialogClientView, we were registering OK as a handler
for Escape, even though the dialog had a Cancel button.
This is because we register for Esc if the member variable
|cancel_ button_| is NULL. Problem is, that member isn't
created until later on in that function.
We should be checking the |buttons| flags instead.
TEST=Open the Clear Browsing Data dialog, press Tab twice,
press Esc and make sure that the dialog closes and nothing
is cleared (from whatever checkbox was selected).
BUG=8200
Review URL: http://codereview.chromium.org/28267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
buildbots.
TBR=aa
Review URL: http://codereview.chromium.org/28273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and its children could be relative to it rather than their grandparent. Plumb loading status into Mac controllers. Add more loading status info to stub TabContents. Make browser window a little taller and wider so NTP didn't show scrollbars.
Review URL: http://codereview.chromium.org/31017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
rough edges. Mostly this just fires up a renderer with an "extension" object
exposed, which right now only has a single method "getTestString".
I also did some misc cleanup along the way.
Review URL: http://codereview.chromium.org/27187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to using a bug to track. Cleans up console output significantly.
Review URL: http://codereview.chromium.org/28260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extensions sytem. This can be called from any
component on any thread. The hope is that this
will encourage more thorough error handling.
Review URL: http://codereview.chromium.org/27165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a renderer crashes, the RenderProcessHost may be reused once the
user refreshes. Because of this, the TransportDIB cache, added in
r10071 was getting used while stale, causing painting issues.
This patch clears the TransportDIB cache after a renderer crash.
BUG=8065
Review URL: http://codereview.chromium.org/28238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
corresponding .lproj folder so we can more easily find them. The nibs have not yet been moved, that'll be a further step.
Review URL: http://codereview.chromium.org/28259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The AutocompletePopupModel needs to be able to communicate with the view. Since the view implementation will be platform specific, we abstract our a virtual interface that the different platform view implementations must all implement. This allows the Model and View to communicate, while hiding the platform differences.
This change makes the previous Windows AutocompletePopupView into AutocompletePopupViewWin, a subclass of AutocompletePopupView.
Review URL: http://codereview.chromium.org/28258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- autocomplete_popup.h is now autocomplete_popup_{model,view}.h.
- autocomplete_popup.cc is now autocomplete_popup_{model,view_win}.cc
- The view header is still Windows specific, but this will be addressed soon.
- Rename is_open to IsOpen, in preparation for making a interface for the view.
- Update the project files.
Review URL: http://codereview.chromium.org/27272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
a map of TabContents to controllers since the TabContents can change with no way
to update the map.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Reformat / reword some comments.
- Update include guards to the new style.
- Remove trailing blank lines from end of files.
- Clean up some includes.
- Pull the CompareQuality functor into the implementation.
- Pull kQueryDelayMs into the implementation.
Review URL: http://codereview.chromium.org/27206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes a problem I hit when porting startup_tests that the controlling
startup_tests process didn't use FIFO, and the child chrome process did
(and obviously they couldn't communicate).
Review URL: http://codereview.chromium.org/27220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It would have to be done anyway as part of my startup_tests porting effort.
Review URL: http://codereview.chromium.org/28212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Remove references to toolbar_importer.cc as that file was removed from the tree.
* Add firefox[23]_importer.cc to the Posix build.
* Move ie_importer.cc to the win-only section of the scons file.
Review URL: http://codereview.chromium.org/28249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Sorry for my slow change. I noticed we should use the DLU size to calculate the expected text width only when it is smaller than average character width, i.e. ave_char_width(). (The DLU size becomes smaller than the average character width only when a font contains lots of CJK characters because most of CJK characters are much wider than alphabets.) So, this change uses the DLU size only when it is smaller than the average character width. I wish this makes you happy.
Also, this change replaces TAB characters with spaces.
Review URL: http://codereview.chromium.org/28181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Simple fix to make sure the task bar placement and size is
taking into consideration when placing a new popup window.
BUG=7318
Review URL: http://codereview.chromium.org/29002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Make firefox_importer_utils.cc compile on Posix.
TBR=evan
Review URL: http://codereview.chromium.org/29006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
need to sort the "Default Encoding" drop down list under "Chrome Options->Minor
Tweaks->Fonts and Encoding" since Firefox already supports it.
BUG=8084
Review URL: http://codereview.chromium.org/28179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
performance drop...
But only for Windows so the guys on the Mac can still play with it...
Review URL: http://codereview.chromium.org/28198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
invalid startup order.
R=munjal
Review URL: http://codereview.chromium.org/28243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
for painting a windowless plugin.
BUG=6317
Review URL: http://codereview.chromium.org/28242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This can happen when zooming on an image as identified in related bug.
So we split it in two phases.
BUG=5873
Review URL: http://codereview.chromium.org/27064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the resources which the WebKit changes need. This
shouldn't change anything.
Review URL: http://codereview.chromium.org/27255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
activate when originally shown.
BUG=4513
TEST=Start Chrome, the Chrome entry in the task bar should be shown as active.
R=ben
Review URL: http://codereview.chromium.org/28240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=5549
R=sky
Review URL: http://codereview.chromium.org/27229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The browser process now keeps a queue of the last keyboard
events that it sent to the renderer in a queue and pops them
on ACK. If a key is unhandled, we use the copy in the browser
process; we don't even send the key back in the ACK anymore.
Review URL: http://codereview.chromium.org/27244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additionally, wire in a bit of setup for the --single-process case,
because it cannot be done by the renderer thread because that thread
is not the main thread.
Fair warning: --single-process often seems to be broken by various
unrelated changes, which may-or-may-not make assumptions about the
process architecture. I will try to stay on top of these.
Review URL: http://codereview.chromium.org/21330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
status.
Original patch by Kim Christensen (see http://codereview.chromium.org/28150 ), r=me,brettw, tweaked slightly.
BUG=7227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
platform.
Review URL: http://codereview.chromium.org/28237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10556 0039d316-1c4b-4281-b951-d872f2087c98
|