summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Adding support to installerdata provided by Google update.huanr@chromium.org2008-11-067-38/+158
| | | | | | | | BUG=1442838 Review URL: http://codereview.chromium.org/9422 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4913 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function for eliding filenames to a set pixel width while preserving ↵glen@chromium.org2008-11-0623-76/+125
| | | | | | | | the display of the extension. This touches a lot of files because it renames url_elider to text_elider (as it already contained a bunch of text ellision functions), and so requires header file reference changes. BUG=1208 Review URL: http://codereview.chromium.org/9613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4912 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the autofill popu CL as it creates perf regression.jcampan@chromium.org2008-11-0619-174/+36
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/9460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4908 0039d316-1c4b-4281-b951-d872f2087c98
* Enable unload UI tests again, but don't run them for single-process.ojan@google.com2008-11-061-4/+21
| | | | | | Review URL: http://codereview.chromium.org/9464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4906 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Chrome do not launch problem.kuchhal@chromium.org2008-11-061-1/+3
| | | | | | Review URL: http://codereview.chromium.org/9650 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4900 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the call to attach the debugger to V8 to run in the renderer thread. ↵sgjesse@chromium.org2008-11-062-2/+21
| | | | | | | | | | | | | With V8 r648 (Review URL: http://codereview.chromium.org/8909) attaching the debugger to V8 will initialize V8 if not already initialized. This needs to be serialized with the initialization of V8 in the renderer thread. This change does not require the changes in V8 r648, but will not have any effect without. Added a few comments. BUG=3723 Review URL: http://codereview.chromium.org/8735 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4875 0039d316-1c4b-4281-b951-d872f2087c98
* Changes parameters used by IME code to fix several issues caused by Japanese ↵hbono@chromium.org2008-11-0610-57/+73
| | | | | | | | | | | | | | IMEs. Recent Japanese IMEs (ATOK2008 and MSIME 2007) display a suggestion window (a window which contains suggestions) above a composition string. To fix this issue, we do not only send the lower-left corner of a composition string but also send its upper-left corner and its upper-right corner. So, this change changes IPC parameters used by IME from a tuple of integers to gfx::Rect. Also, this change fixes cursor positions for Japanese IMEs. BUG=2770 "IME: Candidate window of Japanese IME follows the end of composition" BUG=2771 "ATOK 2008 IME pop-ups are displayed below the main Chrome window." BUG=2775 "IME: Caret is always displayed at the last of IME composition." Review URL: http://codereview.chromium.org/7385 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4872 0039d316-1c4b-4281-b951-d872f2087c98
* Disable one IPCSyncChannel test in purify to see if the tree remains green. ↵jam@chromium.org2008-11-061-0/+3
| | | | | | | | | | | | I tested on the buildbot and this is the only one I could see leaks in. If it stays green, I'll narrow it more by modifying the test. TBR=erikkay Review URL: http://codereview.chromium.org/9451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4871 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Large Font issues in About box (issue 2458).finnur@google.com2008-11-0650-108/+151
| | | | | | Review URL: http://codereview.chromium.org/9432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4870 0039d316-1c4b-4281-b951-d872f2087c98
* Toolbar Importer Pass2brg@chromium.com2008-11-0612-259/+774
| | | | | | | | | | | | | Implements the following features 1. Toolbar import always available after first run 2. Deduping of imported favorites 3. Removes attempt to import favicons (not supported through Toolbar UI atm) 4. Always the user to cancel from the UI safely 5. Unittests for parsing (TODO Better UI for login) Review URL: http://codereview.chromium.org/9414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4867 0039d316-1c4b-4281-b951-d872f2087c98
* Disable new tests that are failing on buildbot.ojan@google.com2008-11-061-4/+4
| | | | | | Review URL: http://codereview.chromium.org/9446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4861 0039d316-1c4b-4281-b951-d872f2087c98
* A reported crasher seems to indicate the ViewStorage can be NULL. I don't ↵jcampan@chromium.org2008-11-061-1/+17
| | | | | | | | | | | | see how it could happen. Just bullet-proofing the code so we don't crash. BUG=981648 Review URL: http://codereview.chromium.org/9190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4857 0039d316-1c4b-4281-b951-d872f2087c98
* Bandaid patch so that we continue with crosssite navigations instead of ↵ojan@google.com2008-11-0617-25/+233
| | | | | | | | | | | | | | | closing the tab if the beforeunload /unload handler hangs. This patch does the right user-visible behavior, but I'm not a huge fan of the plumbing necessary to make it work. Totally open to cleanup suggestions. There's also currently one bug that I haven't been able to pinpoint in the UI test. It only treats the first UI test of the four that I run as a cross-site navigation. No matter which test I run first. I wonder if there is some state I should be setting/clearing before/after each test run? Also there's a DHECK that we hit that the UI test exposed. I 'm not sure it's a case that a user could actually hit though and it's not new with this code, so I added a TODO. Can I get help from a mac person on adding the UI test to the xcode project? BUG=3198 Review URL: http://codereview.chromium.org/8920 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4855 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a crash if you put chrome in a very short directorycpu@google.com2008-11-061-9/+2
| | | | | | | | | | | - like c:\bang. - it will crash at startup on a bad iterator use. BUG=4112 Review URL: http://codereview.chromium.org/9610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4854 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate CursorChromium's dependency on webkit/glue.darin@chromium.org2008-11-065-102/+32
| | | | | | | | | | | Also modified WidgetChromium to use ChromiumBridge instead of talking to ChromeClientChromium. I want to eliminate that fake interface in favor of just having our code talk directly to ChromeClientImpl, but that means a dependency on webkit/glue, so I needed to use ChromiumBridge. Long-term, I'd like to propose changes upstream to HostWindow and ChromeClient to avoid this usage of ChromiumBridge. The most impactful part of this CL is the change to move the enumeration of cursor types from WebCursor to PlatformCursor. This means that WebCursor consumers no longer have access to the type enumeration. I replaced that with helper functions on WebCursor. I think the result not only achieves the goal of breaking CursorChromium's dependency on webkit/glue but is also much cleaner. R=iyengar,eseidel Review URL: http://codereview.chromium.org/9072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4846 0039d316-1c4b-4281-b951-d872f2087c98
* Whitespace typo fix from CL 8722agl@chromium.org2008-11-051-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/9611 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4839 0039d316-1c4b-4281-b951-d872f2087c98
* Add two UMA histograms for DNS prefetchingjar@google.com2008-11-051-2/+2
| | | | | | | | | | | I have a more complex change list, and wanted to be able to carefully constrast the before-and-after impact. r=mbelshe Review URL: http://codereview.chromium.org/9166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4833 0039d316-1c4b-4281-b951-d872f2087c98
* Actually preload the cookie database. The previous logic was inverted.deanm@chromium.org2008-11-051-11/+15
| | | | | | Review URL: http://codereview.chromium.org/9183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4830 0039d316-1c4b-4281-b951-d872f2087c98
* Quick and easy fix for vista taskbar auto hide issueamit@chromium.org2008-11-052-10/+67
| | | | | | | | | | | | | | | | | | | | | | In vista we designate the main frame border as a part of non-client area. This is similar to a popup window having resizing border. The default logic to maximize such a window, stretches the borders outside of the screen and the client area occupies the entire work area. As a result windows taskbar treats it as a 'full screen' application and hides itself in an auto-hide mode. An XP-like fix for this, that is to reduce client area vertically by one pixel, would most likely involve overriding WM_SYSCOMMAND of SC_MAXIMIZE. Hence, this is a cheap, although a bit ugly fix in WM_GETMINMAXINFO handling. BUG=20 Review URL: http://codereview.chromium.org/9305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4825 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash when getting strings out of the database. column_text is a ↵brettw@google.com2008-11-053-5/+5
| | | | | | | | | little dangerous because it can return NULL. Most STL string stuff can't handle this. I changed the uses to column_string() which handles NULL properly and generates STL strings for us. BUG=3770 Review URL: http://codereview.chromium.org/9189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4811 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where we failed to paint infobars and other fast-moving items correctly.glen@chromium.org2008-11-051-1/+1
| | | | | | | | | BUG=4048 Review URL: http://codereview.chromium.org/9192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4810 0039d316-1c4b-4281-b951-d872f2087c98
* Added functions to WebDatabase and WebDataService for recording frequent ↵petersont@google.com2008-11-0514-6/+595
| | | | | | | | entries in text input elements in forms. Also added the class AutofillManager which gets instantiated once per WebContents and provides an API from which the database can be easily accessed to provide a list of possible desired values to be entered in a text field given what the user has already typed there. Review URL: http://codereview.chromium.org/8845 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4809 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back. Sigh. Still not fixed.ben@chromium.org2008-11-052-2/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4808 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds the autofill UI in forms.jcampan@chromium.org2008-11-0519-40/+176
| | | | | | | | | | | | When the user types text in a text field in a form, the renderer queries the browser for suggestion based on the entered text and displays the suggestions in a popup. Listeners are set on the form text field in a similar fashion than for password save. The popup showing the suggestion uses the same mechanism as the select popup. Note that a difference between the select and the autofill popup is that the autofill should not take focus, so the page still has focus and the user can still type in while it shows. The creation of the render widget was modified for that purpose so we can specify the popup should not be focused when shown. Review URL: http://codereview.chromium.org/8885 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4804 0039d316-1c4b-4281-b951-d872f2087c98
* Reinstate this commented-out code now the root cause of the problem has been ↵ben@chromium.org2008-11-052-4/+2
| | | | | | fixed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4803 0039d316-1c4b-4281-b951-d872f2087c98
* Some bandaids for tab dragging UI tests:ben@chromium.org2008-11-052-3/+8
| | | | | | | | | | | | | | - automation provider was moving mouse pointer to position in client coords, not screen coords as required. - TabStrip was allowing drags to occur in invalid conditions. This doesn't completely fix the underlying broken-ness of the SimulateDrag function, however I've not yet been able to get a version of it using SendInput working. http://crbug.com/4067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4802 0039d316-1c4b-4281-b951-d872f2087c98
* This is r4523, with a few changes to make things work under Vista.erg@google.com2008-11-0531-1235/+776
| | | | | | | | | | | | | - Explicitly set_delegate(NULL) before releasing a TabContents. (I think the order messages are getting handled is different from XP; this only seems neccessary under Vista.) - r4523 and someone elses change added entries to theme_resources.rc at roughly the same time, causing happy fun crashes. - Roll in sgk's SConscript fix. Review URL: http://codereview.chromium.org/9373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4799 0039d316-1c4b-4281-b951-d872f2087c98
* New batch of dlls to evict from the render process (top crashers).rvargas@google.com2008-11-051-43/+60
| | | | | | Review URL: http://codereview.chromium.org/9376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4797 0039d316-1c4b-4281-b951-d872f2087c98
* When a windowless plugin is hanging, the browser processnsylvain@chromium.org2008-11-051-4/+0
| | | | | | | | | | | | | | | | | | | | | | | is also hanging because of the "dummy activation window". Unfortunately we used to skip the hung plugin notification dialog for this window. I'm changing this behavior to display it even for this window. We don't know what plugin it is, so we just display "an unknown plugin", but this is better than nothing. This is a potential fix for 3383. I do not expect to completely fix 3383 with it, but it should help minimize the problem. bug:3383 Review URL: http://codereview.chromium.org/9386 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4792 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome\installer\util\master_preferences.cc to the SCons build.sgk@google.com2008-11-051-0/+1
| | | | | | Review URL: http://codereview.chromium.org/9171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4789 0039d316-1c4b-4281-b951-d872f2087c98
* Make the test "pass" when the internal data is not found.maruel@chromium.org2008-11-051-0/+8
| | | | | | Review URL: http://codereview.chromium.org/9416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4788 0039d316-1c4b-4281-b951-d872f2087c98
* SCons rename: automated_ui_tests and ui_tests.sgk@google.com2008-11-056-241/+213
| | | | | | Review URL: http://codereview.chromium.org/8225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4784 0039d316-1c4b-4281-b951-d872f2087c98
* Add to SCons build:sgk@google.com2008-11-052-1/+4
| | | | | | | | | chrome\browser\bookmarks\bookmark_drop_info.cc chrome\browser\importer\toolbar_importer.cc chrome\views\view_constants.cc Review URL: http://codereview.chromium.org/9387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4782 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bookmark manager bugs:sky@google.com2008-11-054-11/+39
| | | | | | | | | | | | | | . Pressing enter when more than one folder is selected opens them all. . Show in folder is only enabled when it makes sense: you've selected a bookmark in the table and the table is showing recently bookmarked or search results. BUG=4034 4044 TEST=see bugs Review URL: http://codereview.chromium.org/9367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4780 0039d316-1c4b-4281-b951-d872f2087c98
* Delete chrome\common\clipboard_service.cc from the SCons build.sgk@google.com2008-11-051-1/+0
| | | | | | Review URL: http://codereview.chromium.org/9397 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4779 0039d316-1c4b-4281-b951-d872f2087c98
* Tell the user that HTML documents can harm their computer because they can. abarth@chromium.org2008-11-054-5/+12
| | | | | | | | | | | This patch blocks all the extensions that we register. R=nsylvain BUG=1463961 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4769 0039d316-1c4b-4281-b951-d872f2087c98
* Remove duplicate save_file.cc from the Windows-specific list.sgk@google.com2008-11-051-1/+0
| | | | | | Review URL: http://codereview.chromium.org/9153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4728 0039d316-1c4b-4281-b951-d872f2087c98
* Enable building of chrome/tools/test/image_diff in Linuxagl@chromium.org2008-11-053-20/+25
| | | | | | | | | | BUG=3650 Review URL: http://codereview.chromium.org/8065 Patch from James Vega. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4724 0039d316-1c4b-4281-b951-d872f2087c98
* Wrap forward declarations in their relevant namespaceagl@chromium.org2008-11-053-3/+10
| | | | | | | | | | Forward declarations can't simply use "class $namespace::$class;" syntax. Instead one needs to use "namespace $namespace { class $class; }" syntax. Review URL: http://codereview.chromium.org/8722 Patch from James Vega. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4723 0039d316-1c4b-4281-b951-d872f2087c98
* Add the test certificates. Rename the directory to make the transition easier.maruel@chromium.org2008-11-056-2/+160
| | | | | | | BUG=b/1330770 Review URL: http://codereview.chromium.org/9332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4721 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrote the clipboard API to be more concurrent. Added a helper class to ↵estade@chromium.org2008-11-0511-157/+108
| | | | | | | | make it more foolproof. Updated all clients and unittests. Mac port by jeremy@chromium.org Review URL: http://codereview.chromium.org/9154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4719 0039d316-1c4b-4281-b951-d872f2087c98
* Evil hack to prevent a crash with interstitials across different tab ↵brettw@google.com2008-11-051-0/+23
| | | | | | | | | contents types. BUG=2855 Review URL: http://codereview.chromium.org/9141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4717 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a string we haven't used for a while.pkasting@chromium.org2008-11-051-3/+0
| | | | | | Review URL: http://codereview.chromium.org/9379 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4715 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary code to upgrade Chrome open command for existing users.kuchhal@chromium.org2008-11-052-3/+40
| | | | | | | | From 'chrome %1' to 'chrome -- %1'. For more information see r4016 and crbug.com/3808 Review URL: http://codereview.chromium.org/8988 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4713 0039d316-1c4b-4281-b951-d872f2087c98
* Always write 'dr' key to HKCU.kuchhal@chromium.org2008-11-052-6/+1
| | | | | | Review URL: http://codereview.chromium.org/9291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4710 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the following bugs1. http://b/issue?id=1447957 For machine ↵ananta@chromium.org2008-11-046-38/+113
| | | | | | | | installs we need to use a different version of the Omaha updater.2. http://b/issue?id=1447951 For Vista we need to elevate while performing the update operation. This only applies to machine installs. Update checks also instantiate the same COM object. However it does not need elevation.Bug=1447957, 1447951R=finnur, kuchhal Review URL: http://codereview.chromium.org/8221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4705 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo.ericroman@google.com2008-11-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/9371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4700 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring master preference parsing code into installer util sohuanr@chromium.org2008-11-046-100/+184
| | | | | | | | | it can be shared by first run and set up. There is no functionality change in this CL. Review URL: http://codereview.chromium.org/9338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4688 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menu code. If after dropping you quickly rightsky@google.com2008-11-041-0/+7
| | | | | | | | | | | click the mouse we would crash. This is the same fix as you first saw, I couldn't repro interactive ui test anymore. BUG=4047 TEST=see bug git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4671 0039d316-1c4b-4281-b951-d872f2087c98
* My last fix breaks an interative ui test. I'm going to back out until I ↵sky@google.com2008-11-041-7/+0
| | | | | | | | | | figure out why. TBR=ben Review URL: http://codereview.chromium.org/9353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4656 0039d316-1c4b-4281-b951-d872f2087c98