| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=42116
TEST=None
Review URL: http://codereview.chromium.org/2102007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fix variable name that seems to be cut© error. (loader_ makes sense only for library_loader, and others should be lib_)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2128007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
testNavigationStateOnSessionRestore -- from Sunand
testDownloadDirPref -- from Deepak
testToolbarButtonsPref, testHomepagePrefs -- from Rohit
TEST=python chrome/test/functional/prefs.py
Review URL: http://codereview.chromium.org/2087005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
values.
BUG=none
TEST=CookiesWindowControllerTest.*
Review URL: http://codereview.chromium.org/2129006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
resize to a wrong size.
BUG=None
TEST=On ChromeOS, press the new tab button, the app launcher should show
correctly.
Review URL: http://codereview.chromium.org/2108007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=44371
Review URL: http://codereview.chromium.org/2066008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Ensure that the About Chrome dialog has proper accessibility role.
BUG=none
Review URL: http://codereview.chromium.org/1838002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We already don't compile the code to load the library for 64-bit, this makes it so we also don't try to build anything into it.
BUG=None
TEST=Eventually we should be able to compile for 64-bit on the Mac.
Review URL: http://codereview.chromium.org/2090007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When Window Manager sends us a NOTIFY_SYSKEY_CLICKED message,
we adjust the volume accordingly. Currently just calling
amixer as WM was doing before. There will be a different
change submitted for WM to send this message instead of
calling amixer itself.
Patch by davej@chromium.org:
http://codereview.chromium.org/2102001/show
BUG=cros/525
TEST=none
Related to issue 2107001.
Review URL: http://codereview.chromium.org/2107010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
timeticks.
Also use a prettier display for the DNS cache and "bad proxy" cache.
BUG=37421
Review URL: http://codereview.chromium.org/2120002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This time around i've tested it on the mac with a full build. Fixed string16 issues.
Review URL: http://codereview.chromium.org/2133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=HistoryTest::MostVisitedURLs
Original review: http://codereview.chromium.org/2099004
Checked in for Nik Sckrob
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For WebGL the shader translation is off. For Pepper
and other processes it is on. This will
be removed and the tranlator will always be on
at some point in the future
TEST=More conformance tests pass, manually ran WebGL demos in Chrome.
BUG=none
Review URL: http://codereview.chromium.org/2127001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44379 gtk_chrome_shrinkable_hbox may redraw children with incorrect size allocation.
TEST=see bug report.
Review URL: http://codereview.chromium.org/2120005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WriteHyperlink to take string16 anchor text.
BUG=42624
TEST=none
Review URL: http://codereview.chromium.org/2036013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2083007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
delegate to avoid stale weak references.
BUG=44225
TEST=see bug
Review URL: http://codereview.chromium.org/2122008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed in r43790 (my fault, as I reviewed it). There used to be a test that covered this functionality, but the test was removed in r37819.
BUG=44107
TEST=none.
Review URL: http://codereview.chromium.org/2109004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DISABLED test that times out on Mac. (Original patch reviewed at http://codereview.chromium.org/2067003 )
Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken".
Make the "display" state only affect the current tab (not the entire host).
Fix an SSL browser test by supplying the appropriate SiteInstance*.
Move a test from "disabled" to "flaky" since it at least passes for me.
Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner.
BUG=15072, 18626, 40932, 42758
TEST=Covered by browser tests
Review URL: http://codereview.chromium.org/2063008
Review URL: http://codereview.chromium.org/2126005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, made the info-bubble HWND on Windows owned by its border widget so that it shows on top. That way we don't have to create a hole in the border widget to make it visible.
BUG=None
TEST=Make sure other info-bubble (bookmark bubble, extension bubbles...) work as expected. Test that when tarting Chrome with --app-panel, creating a new tab shows the apps launcher with an animation.
Review URL: http://codereview.chromium.org/2096004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AutoFill keyboard shortcut to "Edit -> AutoFill Form" removed for security reasons. Nib changes: Removed menu separator and "AutoFill Form" menu item from MainMenu.xib.
BUG=42264
TEST=Manual test: Launch Chrome, look under Edit menu, expect no AutoFill Form item.
Review URL: http://codereview.chromium.org/2125006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I've seen this fail on my local machine as well as on the try server. Looks like there's a race condition.
BUG=none
TEST=none
TBR=dmazonni@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3061
TEST=Verify options dialog is closed when "Get Theme" link is clicked per chromium-os:3061.
Review URL: http://codereview.chromium.org/2090003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=44371,44371
Review URL: http://codereview.chromium.org/2132004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since WebKit r59457, this test is rebaselined and can be enabled again.
Landing http://codereview.chromium.org/2078009/show
BUG=42740
TEST=ui_tests --gtest_filter=DOMStorageTest.RootLayoutTests
TEST=run_webkit_tests.sh --debug storage/domstorage/quota.html
Review URL: http://codereview.chromium.org/2066006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now this extra text is not localized.
Added max width for info bubble, text will be wrapped.
BUG=crosbug.com/3274
TEST=On Chrome OS login type wrong password.
Review URL: http://codereview.chromium.org/2084006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It needs to be after calling navigator.geolocation.getCurrentPosition()/watchPosition() rather than just accessing navigator.geolocation.
Depends on https://bugs.webkit.org/show_bug.cgi?id=38323.
BUG=42789
TEST=GeolocationBrowserTest.NoInfoBarBeforeStart
Review URL: http://codereview.chromium.org/1950001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the layout so the input method configure button will be shown right
next to the input method name (the layout was bad as the row was sharing the
same columnset with the huge the "Display Google Chrome in this language"
button).
Also widen the width of the dialog from 96 to 106, so the "Display Google
Chrome in this language" button does not get truncated. To do this, define
separate dialog size settings for this dialog.
BUG=chromium-os:3235
TEST=manually
Review URL: http://codereview.chromium.org/2106008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
value checks.
Relands. It's irrelative.
http://buildbot.jail.google.com/buildbot/waterfall/builders/Mac10.5%20Tests%20(dbg)(2)/builds/16790
TBR=sky
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2098007
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/2076004
TBR=tyoshino@chromium.org
Review URL: http://codereview.chromium.org/2073009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks that this change caused lots of test failures. Reverts for now and wait and see.
http://buildbot.jail.google.com/buildbot/waterfall/builders/Mac10.5%20Tests%20(dbg)(2)/builds/16790
TBR=sky
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2098007
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/2076004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
prefixed with '+'.
TBR=willchan
Review URL: http://codereview.chromium.org/2098008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2124003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Display it on the about:net-internals page
- Collect it in the histogram Net.OSErrorsForGetAddrinfo.
Review URL: http://codereview.chromium.org/2134004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the merge issue this time. Also fixes a TODO in another change that was blocked on this one.
Support SpdySession as a new NetLog source type. Start logging some more SPDY control frames.
Original code review: http://codereview.chromium.org/2102003/show
BUG=43237
Review URL: http://codereview.chromium.org/2114003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=44253,44254
TEST=media_unittests succeeds when run in valgrind
TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/2103002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
closed the tab by way of mouse.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2106006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=out/Debug/unit_tests
Review URL: http://codereview.chromium.org/1741012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2098007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test hangs in cases when the server fails to start.
The tests will still fail in that case, obviously,
but will no longer hang (or crash), which is an
improvement.
TEST=browser_tests
BUG=none
Review URL: http://codereview.chromium.org/2095004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppressing memcheck:cond error.
Following CL seems to be culprit.
http://src.chromium.org/viewvc/chrome?view=rev&revision=47333
BUG=44253,44254
TEST=linux/chromeos valgrind should cycle green
TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/2076003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/2067003 )
Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken".
Make the "display" state only affect the current tab (not the entire host).
Fix an SSL browser test by supplying the appropriate SiteInstance*.
Move a test from "disabled" to "flaky" since it at least passes for me.
Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner.
Falied TestGoodFrameNavigation on Mac 10.5 browser tests
among other things:
/b/slave/chromium-rel-mac-builder/build/src/chrome/browser/ssl/ssl_browser_tests.cc:43: Failure
Value of: entry->ssl().displayed_mixed_content()
Actual: false
Expected: displayed_mixed_content
Which is: true
BUG=15072, 18626, 40932, 42758
TEST=Covered by browser tests
Review URL: http://codereview.chromium.org/2063008
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2095006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=44220
TEST=none
TBR=huanr
Review URL: http://codereview.chromium.org/2131004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Updated analytics tutorial with new tracking code as well as more information about debugging requests.
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/1880001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and modified communication with chat engine for increased reliability.
Patch by seh@chromium.org:
http://codereview.chromium.org/2065004/show
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2094007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42894,42345
TEST=chrome --diagnostics
Review URL: http://codereview.chromium.org/2115001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken".
Make the "display" state only affect the current tab (not the entire host).
Fix an SSL browser test by supplying the appropriate SiteInstance*.
Move a test from "disabled" to "flaky" since it at least passes for me.
Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner.
BUG=15072, 18626, 40932, 42758
TEST=Covered by browser tests
Review URL: http://codereview.chromium.org/2063008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2079005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47345 0039d316-1c4b-4281-b951-d872f2087c98
|