| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes submenus which broke on all platforms during a recent refactor of
the RenderViewContextMenu class, and adds support for more than one level of
child menus.
BUG=39504
TEST=Create a test extension using the chrome.experimental.contextMenu API and
add multiple levels of child menu items.
Review URL: http://codereview.chromium.org/2443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a conditional mistake introduced with the new drawing model.
Skips unnecessary work when a NPDrawingModelInvalidatingCoreAnimation plugin calls invalidate.
Removes some obsolete comments (the renaming in question already happened)
BUG=None
TEST=Core Animation plugins still work
Review URL: http://codereview.chromium.org/2578004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41280
Review URL: http://codereview.chromium.org/2618002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2555003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41280
Review URL: http://codereview.chromium.org/2469004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38152
TEST=Inject css file with BOM using an extension. It should be injected without BOM.
Review URL: http://codereview.chromium.org/2453005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This issue has been here for forever (or at least as long as far back as the
bisect script will let me check).
BUG=44502
TEST=See bug.
Review URL: http://codereview.chromium.org/2616001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Note: this was a TODO.
BUG=None
TEST=compiles
Review URL: http://codereview.chromium.org/2410002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2548003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove FLAKY annotation from test for other platforms -- annotation is likely stale.
BUG=25039,5314
TEST=AutomationProxyTest.AppModalDialogTest
Review URL: http://codereview.chromium.org/2576002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
non-gallery installs, use the download URL as origin.
BUG=40848
Review URL: http://codereview.chromium.org/2517001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38982
TEST=None (no plugins use it yet)
Review URL: http://codereview.chromium.org/2561005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3761
TEST=Verify fix for chromium-os:3761
Review URL: http://codereview.chromium.org/2600001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds bug annotation to the tests that still needs porting work.
BUG=45766,45753,45770,45771
TEST=Compling ui_tests still works
Review URL: http://codereview.chromium.org/2605001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40473
TEST=Run browser_tests and see if failed FAILS_ or FLAKY_ tests are recorded in its XML output. Also make sure that failures of FAILS/FLAKY tests don't make the browser_tests exit with non-zero return value.
Review URL: http://codereview.chromium.org/2431003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
selected is false.
BUG=42531
Review URL: http://codereview.chromium.org/2483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44847
TEST=see bug
Review URL: http://codereview.chromium.org/2557001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Is causing Perf(2) redness.
TBR=pink,avi
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2588002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=willchan
Review URL: http://codereview.chromium.org/2113017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45581,26349,45581
TEST=it runs, succeeds on bots
Review URL: http://codereview.chromium.org/2520002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40617
TEST=none
Review URL: http://codereview.chromium.org/2521001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enabling the zombie code in release causes Perf(2) to regress.
Reviewing |ZombieDealloc()|, I notice that object_setClass() is
implemented with a memory barrier. The objc runtime doesn't use it in
deallocation, so move to direct access.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2605004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=45792
TEST=tree goes green
TBR=thakis
Review URL: http://codereview.chromium.org/2612001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As current implementation BWSI mode = "Incognito session" so only incognito windows should be open.
BUG= http://crosbug.com/3473
TEST=Open BWSI mode from "New user" screen. Ctrl+N/Shift+Ctrl+N should open only Incognito windows.
Review URL: http://codereview.chromium.org/2580001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Directory was causing an InvalidHandle exception, and causing FF import to fail.
BUG=45730
TEST= FF import should work.
Review URL: http://codereview.chromium.org/2581002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
1. Countries ComboBox - need countries list.
2. Correct icons size.
TEST=in the mocks.
BUG=37816,39238,41232,41793,36601
Review URL: http://codereview.chromium.org/2500002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Now it happens before the command buffer is initialized, which fixes an occasional race condition in Pepper 3D plugins that are not animated.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/2461003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Refreshing of networks will keep the scroll location.
BUG=chromium-os:3086
TEST=manually test to make sure scroll appears when the network list is long. and network changes keeps the same scroll location.
Review URL: http://codereview.chromium.org/2578002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recently closed items.
Now, the menu will show Window entries that have a submenu of all the tabs. Currently, only
the complete window can be restored, not submenu items (representing individual tabs) as
this requires changing the TabRestoreService. That will come in a future CL.
This CL also significantly refactors the internals of the history menu.
XIB changes:
Re-assign tag values in the History menu to those used in HistoryMenuBridge::Tags enum.
BUG=43787
TEST=Open a window and navigate two tabs. Close window. In the History menu, there should be a "2 Tabs" item in the Recently Closed section. Select that to restore.
TEST=Open a window and navigate two tabs. Close one tab. In the History menu, there should be that individual tab entry. Select to restore.
Review URL: http://codereview.chromium.org/2481001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reasons.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2444005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the ExtensionFunctionDispatcher/RenderViewHost that launched the popup. This is a problem, for example, when Chrome is closed while a popup is still displayed.
I also removed the code that delayed sending the onClosed popup notification. I modified the ExtensionPopup::Obeserver interface to add methods for about-to-close, and fully-closed notifications.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/2092020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where the user
chooses to sync, but the window is already open and obscured by another window. For now
this only works on Mac due to how browser dialogs are handled on different platforms.
BUG=30649
TEST=Choose to 'Sync' when the sync window is already open behind a browser window.
Review URL: http://codereview.chromium.org/2121017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Attempt to flush out more use-after-free cases in the wild. Right now messages to freed ObjC objects are binned by the object's address, with this change they should aggregate into a bigger bin. Additionally, the treadmill should slightly increase the number of cases caught.
BUG=35590,24987,45676
TEST=none
Review URL: http://codereview.chromium.org/2478004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=34644
TEST=Try moving the preferences window and confirm it works.
Patch from Mingmin Xie <melvinxie@gmail.com>
Review URL: http://codereview.chromium.org/2592001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use the page title as the print job title for cloud printing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2438004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
language/site'.
BUG=39222
TEST=see bug
Review URL: http://codereview.chromium.org/2400001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dpolukhin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2564003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new user screen). If user takes snapshot and hits OK on image screen, the
snapshot becomes user image. If user presses Cancel, his image is downloaded
via Contacts API.
BUG=cros:3175
TEST=Login via new user login window. Verify that both use cases work if you logout after the browser is shown.
Review URL: http://codereview.chromium.org/2578001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/3757
TEST=none
Review URL: http://codereview.chromium.org/2575001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38575
TBR=glider
Review URL: http://codereview.chromium.org/2573001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This adds IDBIndex support. The majority of this CL was boilerplate type code in indexed_db_dispatcher_host so I did my best to factor it into template functions and split things into multiple sub-dispatcher hosts.
Review URL: http://codereview.chromium.org/2449005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2558001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Chrome Sync works
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48798
Review URL: http://codereview.chromium.org/2255007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change just pulls the hunspell dictionaries moved by my r48011.
TBR=estade
BUG=44543
TEST=none
Review URL: http://codereview.chromium.org/2074023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2624
TEST=Open the IME settings window. Add Traditional Chinese. Open the options dialog, and check that the integer prefs are there
Review URL: http://codereview.chromium.org/2457001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
UTF16ToUTF8 conversions.
BUG=41862
TEST=trybots
Review URL: http://codereview.chromium.org/2481003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Chrome Sync works
Review URL: http://codereview.chromium.org/2255007
TBR=sergeyu@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Chrome Sync works
Review URL: http://codereview.chromium.org/2255007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, make it work better when using backup jobs / late binding (the display was very confused before because of how these asynchronous events would nest).
Also changed the paradigm for how PassiveLogCollector preserves these async associations -- this fixes how it replays the events to net-internals. (Before we would collapse the event streams into the SOURCE_URL_REQUEST which lost some hiearchy.. now I keep the separate streams).
Some of the particular changes to the event streams:
* ConnectJobs now create their own source stream internally.
* Sockets are now bounded by +SOCKET_ALIVE / -SOCKET_ALIVE events (removed the one-off SOCKET_DONE event).
* The socket log streams contains +SOCKET_IN_USE / -SOCKET_IN_USE event blocks to show which URLRequest was controlling it at various points in time (this makes it much easier to understand which read/writes belonged to a particular network transaction when a socket gets re-used).
* ConnectJobs are bounded by +SOCKET_POOL_CONNECT_JOB / - SOCKET_POOL_CONNECT_JOB events.
* ConnectJobs log the net error they failed with.
* Removed the SOCKET_BACKUP_TIMER_EXTENDED event.
Review URL: http://codereview.chromium.org/2363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48797 0039d316-1c4b-4281-b951-d872f2087c98
|