summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fix issue where the width of the sections was not updated correctly.arv@google.com2009-07-281-1/+1
| | | | | | | | | | | | BUG=17751 TEST=Make the window small so that the small layout is triggered. Then resize the window to trigger normal mode. The right border of the tips section should be visible. Review URL: http://codereview.chromium.org/159466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21781 0039d316-1c4b-4281-b951-d872f2087c98
* Change text on theme preview infobar.aa@chromium.org2009-07-281-2/+2
| | | | | | Review URL: http://codereview.chromium.org/160227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21772 0039d316-1c4b-4281-b951-d872f2087c98
* Pull a SandboxedExtensionUnpacker out of ExtensionsService.aa@chromium.org2009-07-288-403/+478
| | | | | | Review URL: http://codereview.chromium.org/160145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21770 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: DnD extravaganzaestade@chromium.org2009-07-2812-143/+196
| | | | | | | | | | | | | - Correctly update drag status for drags over renderer. This makes things look quite a bit better. - Rework the dnd utils so that we specify the drag targets in the order we prefer them (for destinations) - Refactor code in bookmark bar so folder and toolbar drags share more code - Allow bookmark bar to accept URI lists and plain text drags (for plain text we require the text to be a valid url) BUG=17431 Review URL: http://codereview.chromium.org/159419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21767 0039d316-1c4b-4281-b951-d872f2087c98
* First stab at download item overflow. Also add the image to the left of ↵thakis@chromium.org2009-07-286-20/+232
| | | | | | | | | | | "Show all downloads" to the shelf. BUG=14672,14665 TEST=Download several items. They should now no longer overlap the "Open all downloads" link. Review URL: http://codereview.chromium.org/159384 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21759 0039d316-1c4b-4281-b951-d872f2087c98
* Add the shadow above the toolbar (below the tabstrip).tc@google.com2009-07-281-6/+24
| | | | | | | | | | | | We put this in the browser window expose handler so the tabs in the tab strip will draw over it. BUG=15505 Review URL: http://codereview.chromium.org/160201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21758 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Make the window tooltip behave more like a real tooltip byarv@google.com2009-07-284-43/+46
| | | | | | | | | | | | | | | | | | | adding a hide delay and making sure we show the tooltip where the mouse pointer is at the time of showing. Also fix an issue where the theme css incorrectly made the tab and window items look different than the download items. BUG=16539 TEST=Download a file, close a tab, close a window and go to the new tab page. There should be three links in the recent activities and they should all have the same color and underline color. Hower over the closed window entry and it should show a rich tooltip. Review URL: http://codereview.chromium.org/159417 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21750 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a warning: 'this' in initializer list.dumi@chromium.org2009-07-271-2/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/159450 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21741 0039d316-1c4b-4281-b951-d872f2087c98
* Adding HTML5 DB support to Chromium: Chromium changesdumi@chromium.org2009-07-2716-1/+717
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/74001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21736 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Use the requested window bounds when determining the location of the ↵jhawkins@chromium.org2009-07-273-7/+20
| | | | | | | | | | source tab. This is necessary because we move the hidden source tab during a drag, and gtk does not update the allocation of hidden widgets. BUG=16918,17712 TEST=Extensive tab dragging. Review URL: http://codereview.chromium.org/159436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21729 0039d316-1c4b-4281-b951-d872f2087c98
* Fix LogTCPConnectedMetrics. Add FieldTrials for late binding (enable for ↵willchan@chromium.org2009-07-271-0/+9
| | | | | | | | 50% of dev channel). Review URL: http://codereview.chromium.org/159038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21727 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create an ExtensionDOMUI for urls with invalid extension IDs.mpcomplete@chromium.org2009-07-273-4/+28
| | | | | | | | | | | | This fixes a crash bug. BUG=17546 TEST=Navigate to chrome-extension://baaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/ with no extensions installed. Chrome should not crash. Review URL: http://codereview.chromium.org/160199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21721 0039d316-1c4b-4281-b951-d872f2087c98
* Make possible reloading extensions from the chrome://extensions/ page.phajdan.jr@chromium.org2009-07-275-4/+41
| | | | | | | | http://crbug.com/16459 Review URL: http://codereview.chromium.org/159323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21719 0039d316-1c4b-4281-b951-d872f2087c98
* Set window icon on manage search engines dialog.estade@chromium.org2009-07-272-1/+3
| | | | | | | | | | Same for hung renderer dialog. BUG=13000 Review URL: http://codereview.chromium.org/160147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21718 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Make the info bubble (and bookmark bubble and first run bubble) bidi.estade@chromium.org2009-07-273-36/+94
| | | | | | | | BUG=17631 Review URL: http://codereview.chromium.org/160131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21717 0039d316-1c4b-4281-b951-d872f2087c98
* Make the theme preview infobar default to installation, and aa@chromium.org2009-07-273-23/+4
| | | | | | | only have a single button for undo. Review URL: http://codereview.chromium.org/160200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21713 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix the positioning of the tabstrip drop arrow for RTL locales.jhawkins@chromium.org2009-07-273-7/+35
| | | | | | | | BUG=17695 TEST=Open the browser in a RTL locale. Drag a link from the tab contents into the tabstrip. The drop arrow should be positioned correctly. Review URL: http://codereview.chromium.org/159394 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21711 0039d316-1c4b-4281-b951-d872f2087c98
* Fix lineendings on the Hunspell patch file.brettw@chromium.org2009-07-271-42/+42
| | | | | | Review URL: http://codereview.chromium.org/160198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21708 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gradient drawing on the Mac. (Base coordinate system != window base ↵avi@chromium.org2009-07-272-7/+8
| | | | | | | | | | | coordinate system.) BUG=http://crbug.com/17716 TEST=as in bug Review URL: http://codereview.chromium.org/160194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21707 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: A gtkrc file can now override our choice of frame color byerg@google.com2009-07-271-11/+53
| | | | | | | | | | | | | | | | | specifying "frame_color" and "inactive_frame_color" in the gtk_color_scheme. Also attempts to do a better job matching the frame color. Most window managers (defined as metacity default theme and xfwm's default theme) take bg[SELECTED] tint it by 80%. We hand code that behaviour in, as it will be wrong a smaller percentage of the time then our current behaviour. http://crbug.com/16271 (dark theme bug) http://crbug.com/13967 (theme color metabug) Review URL: http://codereview.chromium.org/160188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21704 0039d316-1c4b-4281-b951-d872f2087c98
* Pull out synchronous extension apis to extensions_api.json, add custom ↵rafaelw@chromium.org2009-07-278-73/+229
| | | | | | | | | | handling for calls R=aa Review URL: http://codereview.chromium.org/160129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21703 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings by reference.jhawkins@chromium.org2009-07-271-1/+3
| | | | | | | | | CID=5146 BUG=none TEST=none Review URL: http://codereview.chromium.org/160154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21700 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings by reference.jhawkins@chromium.org2009-07-271-4/+4
| | | | | | | | | CID=4139 BUG=none TEST=none Review URL: http://codereview.chromium.org/159352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21699 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build issues while doing a shared build of the test suiteevan@chromium.org2009-07-271-0/+7
| | | | | | | | | | BUG=17800 TEST=none Review URL: http://codereview.chromium.org/159414 Patch from Fabien Tassin <fta@sofaraway.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21697 0039d316-1c4b-4281-b951-d872f2087c98
* Removing unused forward declaration of StarredURLDatabase from bookmark_model.h.phajdan.jr@chromium.org2009-07-271-4/+0
| | | | | | | | | | | Patch by Thiago Farina. Original review: http://codereview.chromium.org/160151 BUG=None TEST=None Review URL: http://codereview.chromium.org/160185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21691 0039d316-1c4b-4281-b951-d872f2087c98
* Pretties up the FindBar on Mac.rohitrao@chromium.org2009-07-275-23/+94
| | | | | | | | | | BUG=http://crbug.com/14903 BUG=http://crbug.com/14904 BUG=http://crbug.com/14905 TEST=Findbar should function normally, as before. Review URL: http://codereview.chromium.org/160144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21686 0039d316-1c4b-4281-b951-d872f2087c98
* Re-landing r21673 without re-enabling the BrowserTest, which apparently isbrettw@chromium.org2009-07-278-38/+62
| | | | | | | | | | | | | | | | | | | | | | | | | still failing. Make downloads not prevent tabs from closing. If a download creates a cross-site transition (for example, if you click a link in Gmail that results in a download in a new tab), that tab will be stuck and you can't close it or the browser. This is the opposite problem with a similar cause as bug 16246. In both cases we were using some secondary signal to tell us if we're closing for a cross site transition or closing the tab, and that signal was wrong. In this case, we were running the onunload handler, but because there was a pending RenderViewHost, the RenderManager would think that the close was a cross-site one, and not forward the close message to actually close the tab. This patch adds a flag to the on unload handlers that indicates whether it's for a tab closure or a cross-site transition, so we can do the right thing unambiguously when the message returns. In this case I keep this information in the RenderView in case we send multiple close requests, we'll close the tab if any of them were for the entire tab, even if that particular one was dropped because we don't want to have more than one in flight at once. BUG=17560 TEST=none. Review URL: http://codereview.chromium.org/160122 Review URL: http://codereview.chromium.org/159426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21685 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of r21673 - which caused browser_test failure in ChromeURLAfterDownload.robertshield@chromium.org2009-07-279-63/+40
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/160187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21683 0039d316-1c4b-4281-b951-d872f2087c98
* Fix partial plugin invalidate repainting on Mac.stuartmorgan@google.com2009-07-272-2/+16
| | | | | | | | | | | The transport canvas and the backing store canvas are upside down relative to eachother, so the rects need some massaging. BUG=none TEST=YouTube videos should play without sections drawing in the wrong place, and plugins scrolled partially offscreen should draw the right section. Review URL: http://codereview.chromium.org/159423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21681 0039d316-1c4b-4281-b951-d872f2087c98
* posix: restore IPC loggingevan@chromium.org2009-07-271-0/+10
| | | | | | | | | | In the recent refactoring of IPC, it appears logging on POSIX was lost. The file modified here later checks an #ifdef that is set by the now-included ipc_message.h to set up POSIX logging. Review URL: http://codereview.chromium.org/159418 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21679 0039d316-1c4b-4281-b951-d872f2087c98
* Fix port disconnect so that it's refcounted. This fixes a bug where a channelmpcomplete@chromium.org2009-07-275-6/+122
| | | | | | | | | | | would close if any one listener on the channel called "disconnect()". BUG=16644 TEST=no Review URL: http://codereview.chromium.org/155476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21678 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid calls to gtk_widget_get_pointer during mouse move iftc@google.com2009-07-271-7/+15
| | | | | | | | | | | | | not necessary. This is to work around janky scrolling behavior that brad was seeing. I can't repro, so he'll have to tell me if this works for him BUG=16786 Review URL: http://codereview.chromium.org/160179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21675 0039d316-1c4b-4281-b951-d872f2087c98
* Make downloads not prevent tabs from closing.brettw@chromium.org2009-07-279-40/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If a download creates a cross-site transition (for example, if you click a link in Gmail that results in a download in a new tab), that tab will be stuck and you can't close it or the browser. This is the opposite problem with a similar cause as bug 16246. In both cases we were using some secondary signal to tell us if we're closing for a cross site transition or closing the tab, and that signal was wrong. In this case, we were running the onunload handler, but because there was a pending RenderViewHost, the RenderManager would think that the close was a cross-site one, and not forward the close message to actually close the tab. This patch adds a flag to the on unload handlers that indicates whether it's for a tab closure or a cross-site transition, so we can do the right thing unambiguously when the message returns. In this case I keep this information in the RenderView in case we send multiple close requests, we'll close the tab if any of them were for the entire tab, even if that particular one was dropped because we don't want to have more than one in flight at once. BUG=17560 TEST=none. Review URL: http://codereview.chromium.org/160122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21673 0039d316-1c4b-4281-b951-d872f2087c98
* Make AutomationProxyTest.NavigateToURLWithTimeout* tests not-flaky.phajdan.jr@chromium.org2009-07-277-18/+148
| | | | | | | | | | | I used a mock url request job which is guaranteed to finish after the timeout the test uses. TEST=none http://crbug.com/16462 Review URL: http://codereview.chromium.org/155941 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21668 0039d316-1c4b-4281-b951-d872f2087c98
* Implement delete key for the Remove action in the bookmark manager.estade@chromium.org2009-07-272-9/+36
| | | | | | | | | | | | Although we will also need to implement certain other hotkeys such as Ctrl+C and so forth, I see no point in adding an accelerator group as we do not want the accelerators to work when the tree views don't have focus. Also we don't want the menu to show the accelerators. Also, fix a bug where the organize menu could be stale. mdm pointed out that ctrl+clicking the selection could lead to an empty selection. BUG=17393 Review URL: http://codereview.chromium.org/160137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21664 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: gtk_window_present when an already-showing browser window is showing ↵estade@chromium.org2009-07-271-1/+2
| | | | | | | | | | | | and we want to show it again. I think this will be very WM-specific on whether it works. It seems that a lot of WMs don't want to allow windows from groups that don't have focus to do this. For example: http://blogs.gnome.org/metacity/2007/12/24/stacking/ BUG=17767 Review URL: http://codereview.chromium.org/160149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21657 0039d316-1c4b-4281-b951-d872f2087c98
* Give crashed tabs the crashed tab icon on the Mac.avi@chromium.org2009-07-279-124/+266
| | | | | | | | | BUG=none TEST=crash a page and see if the icon shows up (animated) Review URL: http://codereview.chromium.org/160113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21648 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at Mac history menu.rohitrao@chromium.org2009-07-2712-9/+842
| | | | | | | | | | | | | | | | * The menu has two sections: most visited and recently closed. * Creates a HistoryMenuBridge that observes different data sources and stores results for use in the menu. * Creates a HistoryMenuController to respond to Cocoa IBActions from the menu. BUG=14933 TEST=History menu in mac should populate with most visited and recently closed sites. RELEASE_NOTES=Add initial implementation of the Mac history menu. Patch by Robert Sesek. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21639 0039d316-1c4b-4281-b951-d872f2087c98
* reenable a disabled part of a unit testerikkay@chromium.org2009-07-272-6/+4
| | | | | | | | | BUG=15363 TEST=ExtensionsService.LoadAllExtensionsFromDirectorySuccess Review URL: http://codereview.chromium.org/159388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21638 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: split console evaluation into two steps: actual evaluation and resultyurys@google.com2009-07-271-0/+5
| | | | | | | | | | | wrapping. When second step is executed debugger_agent_manager will autocontinue on break. We assume that second step doesn't call user scripts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21635 Review URL: http://codereview.chromium.org/159395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21637 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 21635.yurys@google.com2009-07-271-5/+0
| | | | | | Review URL: http://codereview.chromium.org/159399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21636 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: split console evaluation into two steps: actual evaluation and resultyurys@google.com2009-07-271-0/+5
| | | | | | | | | wrapping. When second step is executed debugger_agent_manager will autocontinue on break. We assume that second step doesn't call user scripts. Review URL: http://codereview.chromium.org/159395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21635 0039d316-1c4b-4281-b951-d872f2087c98
* Fix location bar display.thakis@chromium.org2009-07-271-1/+1
| | | | | | | | | BUG=17667 TEST=see bug Review URL: http://codereview.chromium.org/160142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21634 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Change the lower right section to say "What will we put here?"arv@google.com2009-07-272-5/+4
| | | | | | | | | | | | TBR=glen@chromium.org BUG=None Test=None Review URL: http://codereview.chromium.org/159393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21633 0039d316-1c4b-4281-b951-d872f2087c98
* add test to verify mole data being readerikkay@chromium.org2009-07-261-0/+3
| | | | | | | | TBR=mpcomplete Review URL: http://codereview.chromium.org/160148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21632 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the concept of threading from ProxyService, and move it into the ↵ericroman@google.com2009-07-261-9/+29
| | | | | | | | | | | | | | | | | | | | | | | | ProxyResolver dependency. ProxyResolver may now complete requests asynchronously, and is defined to handle multiple requests. The code from ProxyService that queued requests onto the single PAC thread has moved into SingleThreadedProxyResolver. This refactor lays the groundwork for: (1) http://crbug.com/11746 -- Run PAC proxy resolving out of process. (Can inject an IPC bridge implementation of ProxyResolver) (2) http://crbug.com/11079 -- Run PAC proxy resolving on multiple threads. (Can implement a MultithreadedProxyResolver type class; still complications around v8 threadsafety though). BUG=http://crbug.com/11746, http://crbug.com/11079 TEST=existing unit-tests. Review URL: http://codereview.chromium.org/149525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21631 0039d316-1c4b-4281-b951-d872f2087c98
* Fix exception in DownloadManager if the download has no extension.aa@chromium.org2009-07-261-1/+2
| | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/159392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21628 0039d316-1c4b-4281-b951-d872f2087c98
* Modify detection of Chrome extensions in download manager. Itaa@chromium.org2009-07-261-3/+17
| | | | | | | | | | | | | | turns out many servers send the no-sniff option, including the one we use for our sample extensions. So we can't rely on mime types to detect Chrome extensions, at least until we have some place to put our samples that doesn't have this problem. TBR=erikkay Review URL: http://codereview.chromium.org/159391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21627 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to commit r21622: Add infobar preview for themes,aa@chromium.org2009-07-269-40/+174
| | | | | | | | remove --enable-extension requirement. Review URL: http://codereview.chromium.org/159390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21626 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revisions 21622-21624.aa@chromium.org2009-07-269-186/+48
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21625 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-03 20:31:42 +0000