summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Adds support for phantom tabs. A pinned tab becomes a phantom tab whensky@chromium.org2010-01-2225-97/+405
| | | | | | | | | | | | | | | | | it is closed, and effectively unloads the renderer and replaces it with a new TabContents that loads when selected. A phantom tab is currently rendered without a border. Phantom tabs do not prevent a window from closing. Long term only pinned app tabs will have the ability to be made phantom, but this allows us to test the feature until app support is all wired in. BUG=32845 TEST=none yet Review URL: http://codereview.chromium.org/553008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36815 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: don't get stuck in render view drag.estade@chromium.org2010-01-211-5/+16
| | | | | | | | | | | Everyone once in a while gtk_drag_begin() returns NULL meaning the drag failed to start. Inform webkit of this. BUG=30580 TEST=see bug Review URL: http://codereview.chromium.org/548108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36812 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where needs_reload_ was not getting set to false in somesky@chromium.org2010-01-214-1/+31
| | | | | | | | | | | situations, leading to a stuck throbber. BUG=31462 TEST=see bug Review URL: http://codereview.chromium.org/554025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36811 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a comment long-obsolete.avi@chromium.org2010-01-211-3/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/545160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36810 0039d316-1c4b-4281-b951-d872f2087c98
* PyAuto: Python Interface to Chromium's Automation Proxy.nirnimesh@chromium.org2010-01-217-97/+479
| | | | | | | | | | | | | | | | | | | | | PyAuto is a python interface to chromium's automation framework. It exposes some of the Automation Proxy functions in Python. This can be used to play around with chromium, or automate functional tests. SWIG is used to bridge Automation Proxy's C++ to Python. This CL addresses Mac-only to begin with. I'll be adding win/linux shortly. Also, this CL breaks down UITest class into parts that does not use gtest (UITestBase) and parts that does (UITest). UITestBase is used by pyauto. BUG=32283 TEST=None Review URL: http://codereview.chromium.org/555022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36808 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser crash in extensions due to painting badges on PageActions.finnur@chromium.org2010-01-211-15/+2
| | | | | | | | | | | It is possible this will move the crash location elsewhere, but since we don't even support showing badges on PageActions, we have no reason to attempt it. BUG=http://crbug.com/31080 TEST=Monitor the crash rate and see if the crash is fixed. Badges should still work on BrowserActions. Review URL: http://codereview.chromium.org/551105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36807 0039d316-1c4b-4281-b951-d872f2087c98
* More bookmarks string1t work.munjal@chromium.org2010-01-217-62/+62
| | | | | | | | | TEST=exists BUG=32013 Review URL: http://codereview.chromium.org/546094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36805 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented Esc/Command-. shortcuts for HTML dialogs.akalin@chromium.org2010-01-211-0/+20
| | | | | | | | | BUG=32216 TEST=manually Review URL: http://codereview.chromium.org/548051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36800 0039d316-1c4b-4281-b951-d872f2087c98
* Removed #ifdef in IncrementErrorCount() now that it's platform-independent.akalin@chromium.org2010-01-211-3/+0
| | | | | | | | | BUG=30728 TEST=trybots Review URL: http://codereview.chromium.org/548062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36799 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2: Disable the test (I accidentally modified the file before checking ↵finnur@chromium.org2010-01-211-57/+8
| | | | | | | | | | | | in in my last checkin and added things I was working on but didn't want checked in yet). :/ TBR=oshima BUG=http://crbug.com/28629, http://crbug.com/16447 TEST=None Review URL: http://codereview.chromium.org/554041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36797 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix a crash in the cookies manager that was caused by an invalid ↵rsesek@chromium.org2010-01-214-29/+105
| | | | | | | | | | | | | | | | selection. XIB change: Change the "Remove" button's |enabled| binding from just looking at the count of the selection to FilesOwner.removeButtonEnabled. BUG=32627 TEST=Covered by unit tests. TEST=Open cookies manager. Select one item, make sure "Remove" is enabled. TEST=Open cookies manager. Try to select two items. You shouldn't be able to. Review URL: http://codereview.chromium.org/546102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36796 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a test on Linux Views. It was marked as flaky, but it is failing all ↵finnur@chromium.org2010-01-211-5/+54
| | | | | | | | | | | | | | the time. See http://crbug.com/28629 for details. TBR=pkasting BUG=http://crbug.com/28629, http://crbug.com/16447 TEST=None Review URL: http://codereview.chromium.org/552086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36795 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] relayout the import data and clear browser data buttons in the prefs ↵thomasvl@chromium.org2010-01-212-39/+19
| | | | | | | | | | for the string changes that already landed. more work will be needed to make the window match the new wants, but this gets the tests passing again. BUG=32719 TEST=unittests green up Review URL: http://codereview.chromium.org/551103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36793 0039d316-1c4b-4281-b951-d872f2087c98
* Simplifying appmenu impl.oshima@chromium.org2010-01-212-17/+8
| | | | | | | | | | | Using command id instead of index. BUG=none TEST=none Review URL: http://codereview.chromium.org/554038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36791 0039d316-1c4b-4281-b951-d872f2087c98
* Insert diagnostics in an attempt to track down a crash in popup menuspam@chromium.org2010-01-212-0/+15
| | | | | | | | | | in RenderWidgetHostViewMac::ShowPopupWithItems(). BUG=31716 TEST=should have no user-visible effect; see crash reports Review URL: http://codereview.chromium.org/545159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36790 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Hide browser action buttons when they would otherwise overflow with ↵andybons@chromium.org2010-01-215-7/+101
| | | | | | | | | | the omnibar. TEST=none BUG=29838 Review URL: http://codereview.chromium.org/553038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36789 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an observed shutdown crash after downgrading to an older Chrome release.nick@chromium.org2010-01-211-2/+4
| | | | | | Review URL: http://codereview.chromium.org/548105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36784 0039d316-1c4b-4281-b951-d872f2087c98
* Update the kHasSyncSetupCompleted preference when the bootstrapedalbertb@google.com2010-01-213-22/+32
| | | | | | | | | | | | | authentication is succesful in Chrome OS. BUG=1220 TEST=The menu option in the wrench menu should indicate that bookmarks are synced on startup, and it should be possible to disable sync through the options dialog. Review URL: http://codereview.chromium.org/551053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36783 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix flaky test (FindMovesIfObscuring). I've run this through the try ↵finnur@chromium.org2010-01-212-40/+29
| | | | | | | | | | | bots three times and they seemed to like the patch. BUG=16447 TEST=The change is to a test. Review URL: http://codereview.chromium.org/553042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36781 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Wallpaper fix for crasher when an alert is called from an extension ↵andybons@chromium.org2010-01-211-0/+5
| | | | | | | | | | popup window. BUG=29355 TEST=none Review URL: http://codereview.chromium.org/552084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36780 0039d316-1c4b-4281-b951-d872f2087c98
* Notify the AutoFillManager when the user clicks "Apply" or "OK". Adds an ↵jhawkins@chromium.org2010-01-218-51/+233
| | | | | | | | | | AutoFillDialogObserver interface that is used to send the profile information back to clients. BUG=none TEST=none Review URL: http://codereview.chromium.org/555023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36779 0039d316-1c4b-4281-b951-d872f2087c98
* Move two generic string split functions from sync API to their own API in ↵timsteele@google.com2010-01-211-61/+4
| | | | | | | | | | | | | | base/string_split. BUG=None TEST=base_unittests Original patch by Thiago Farina Original Review: http://codereview.chromium.org/464075 Review URL: http://codereview.chromium.org/502074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36774 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark mgr: Fix crash after closing incognito window.snej@chromium.org2010-01-211-1/+5
| | | | | | | | BUG=32594 TEST=none (see steps to reproduce) Review URL: http://codereview.chromium.org/554034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36772 0039d316-1c4b-4281-b951-d872f2087c98
* String resources for privacy settings.zelidrag@chromium.org2010-01-211-5/+171
| | | | | | | | | BUG=32719 TEST=none Review URL: http://codereview.chromium.org/546091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36770 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in tab's close button.feldstein@chromium.org2010-01-211-0/+6
| | | | | | | | | | | If you click and hold on a close button that is being animated closed, it will crash if you release it after the tab is completely closed. The button is being freed when the |super mouseDown| call is in it's tracking loop, so we need to hold on to it with a scoped_nsobject until we're done with it. The checkImageState call is called unnecessarily, but it shouldn't hurt anything. BUG=28220 TEST=Click and hold on the close button of a tab that is animating closed. Release it a couple of seconds after the tab is fully hidden. To help test, you can change the kAnimationDuration in tab_strip_controller.mm to a higher value. Review URL: http://codereview.chromium.org/555018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36769 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: restore ctr+shift+i for devtools (was accidentally changed to ctrl+i).estade@chromium.org2010-01-211-1/+2
| | | | | | | | | | BUG=32803 TEST=use it TBR=thestig Review URL: http://codereview.chromium.org/553046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36767 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Localize the cookie manager. Also rolls GTM r259:280.rsesek@chromium.org2010-01-213-507/+1452
| | | | | | | | | BUG=32338 TEST=Preferences-->Under the Hood-->Show cookies... should now be localized. Review URL: http://codereview.chromium.org/543128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36766 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a failing test on chrome os.estade@chromium.org2010-01-211-1/+9
| | | | | | | | | | | | This test was disabled except on linux until I enabled it in r36676. It passes on normal linux, but not chromeos. Further investigation is warranted, but it is not actually a regression. BUG=32799 TEST=none TBR=pkasting Review URL: http://codereview.chromium.org/552083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36763 0039d316-1c4b-4281-b951-d872f2087c98
* Position the the inactive toast to the left in RTL machines.cpu@chromium.org2010-01-211-4/+8
| | | | | | | | | BUG=32474 TEST=see bug for details Review URL: http://codereview.chromium.org/545144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36762 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36757 - Add reserved messages to ExtensionMessageBundle dictionary. ↵cira@chromium.org2010-01-215-344/+158
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They are of the form @@somename, i.e. @@ui_locale. Trying to reland. It's the same as http://codereview.chromium.org/546040. It makes easier for developers to detect current UI locale (also available though window.navigator.language), or text direction. I'll use them for static message replacement later on too. Before this change developers would have to manualy add locale and text_dir messages and translate for all supported locales. Added 5 reserved messages: @@ui_locale @@bidi_dir @@bidi_reversed_dir @@bidi_start_edge @@bidi_end_edge See http://code.google.com/apis/gadgets/docs/i18n.html#BIDI on why are they usefull. Extended allowed charset for variable names with @. Added unittest for variable names. TBR=jshin@chromium.org Review URL: http://codereview.chromium.org/555021 TBR=cira@chromium.org Review URL: http://codereview.chromium.org/546108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36761 0039d316-1c4b-4281-b951-d872f2087c98
* Add reserved messages to ExtensionMessageBundle dictionary. They are of the ↵cira@chromium.org2010-01-215-158/+344
| | | | | | | | | | | | | | | | | | | | | | | | | | | | form @@somename, i.e. @@ui_locale. Trying to re-land. It's the same as http://codereview.chromium.org/546040. It makes easier for developers to detect current UI locale (also available though window.navigator.language), or text direction. I'll use them for static message replacement later on too. Before this change developers would have to manualy add locale and text_dir messages and translate for all supported locales. Added 5 reserved messages: @@ui_locale @@bidi_dir @@bidi_reversed_dir @@bidi_start_edge @@bidi_end_edge See http://code.google.com/apis/gadgets/docs/i18n.html#BIDI on why are they usefull. Extended allowed charset for variable names with @. Added unittest for variable names. TBR=jshin@chromium.org Review URL: http://codereview.chromium.org/555021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36757 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Beep when unable to find any matches.rohitrao@chromium.org2010-01-211-1/+2
| | | | | | | | BUG=32790 TEST=Search for something that doesn't exist. Hear beep. Review URL: http://codereview.chromium.org/545154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36756 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure method to set up cmd-w/cmd-shift-w runs on the main thread, add a ↵pinkerton@google.com2010-01-211-5/+6
| | | | | | | | | | DCHECK to try to catch instances where it is called away from the main thread. BUG=32786 TEST=cmd-w/cmd-shift-w should always be correct. Review URL: http://codereview.chromium.org/546106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36755 0039d316-1c4b-4281-b951-d872f2087c98
* Send Cocoa NPAPI plugins an initial window activation eventstuartmorgan@chromium.org2010-01-214-4/+10
| | | | | | | | | | | | | Until we have real window activation status, just send a window focus event so that Cocoa plugins always think their window is active (as is currently the case with Carbon plugins). Also wire up the Carbon interposing on window activation checks to talk to the delegate, so once the delegate has correct information Carbon will Just Work. BUG=31847 TEST=Flash 10.1 should track the mouse when the plugin is loaded, without having to click in it first. Review URL: http://codereview.chromium.org/552067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36754 0039d316-1c4b-4281-b951-d872f2087c98
* Fix FullTabModeIE_ChromeFrameDeleteCookieTest. The problem was that a ↵tommi@chromium.org2010-01-212-18/+46
| | | | | | | | | | | | | | | domain cookie was being set twice although only set once by the server. The test itself needed fixing as well as an extra check for domain cookies set by a different url than the current url. There's one other problem remaining however which was initially reported in bug 30786 and I'll get on that next (bug reopened). TEST=Run the FullTabModeIE_ChromeFrameDeleteCookieTest test. BUG=32546, 30786 Review URL: http://codereview.chromium.org/546104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36749 0039d316-1c4b-4281-b951-d872f2087c98
* Whitespace change to clobber botsjochen@chromium.org2010-01-211-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=thomasvl Review URL: http://codereview.chromium.org/545152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36748 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 303.0 to 304.0chrome-release@google.com2010-01-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36744 0039d316-1c4b-4281-b951-d872f2087c98
* Removed restriction for {} so that javascript blocks can be used in the url.avayvod@chromium.org2010-01-213-15/+104
| | | | | | | | | | | Added unittests for TemplateURLRef::ParseParameter and TemplateURLRef::ParseURL methods. BUG=2238 TEST=Try adding urls with different combinations of {}, they all should work. Review URL: http://codereview.chromium.org/555012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36743 0039d316-1c4b-4281-b951-d872f2087c98
* Don't accidentally add downloads with db_handle = kUninitializedHandle, ↵thestig@chromium.org2010-01-212-13/+32
| | | | | | | | | | which can happen if the sqlite history db is corrupt / offline. BUG=25492 TEST=none Review URL: http://codereview.chromium.org/492017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36736 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark manager: Prevents the Recents group from losing its custom icon.snej@chromium.org2010-01-211-1/+2
| | | | | | | | BUG=32740 TEST=Click Recents in bookmark manager, verify it still has a star icon. Review URL: http://codereview.chromium.org/554029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36735 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36098 because the UI team has decided on a different long-term ↵jorlow@chromium.org2010-01-2115-168/+12
| | | | | | | | | | | | direction for the clear browsing data dialog. TEST=none BUG=none Review URL: http://codereview.chromium.org/542126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36733 0039d316-1c4b-4281-b951-d872f2087c98
* Support for playing back media from the appcache.michaeln@chromium.org2010-01-211-2/+6
| | | | | | | | | | | | * add the appcache_host_id to resource requests * support for byte-range requests TEST=manual BUG=none Review URL: http://codereview.chromium.org/550040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36727 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Text Input" section to the Chromium OS tab.satorux@chromium.org2010-01-212-0/+102
| | | | | | | | | | | | | | The section is used to activate and deactivate input languages. See the design doc for details about the text input support. http://sites.google.com/a/chromium.org/dev/chromium-os/chromiumos-design-docs/text-input TEST=manually BUG=none Review URL: http://codereview.chromium.org/549082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36726 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/543134 for ernestd(at)google.comcira@chromium.org2010-01-218-10/+150
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36710 0039d316-1c4b-4281-b951-d872f2087c98
* One more attempt at landing this CL.jcampan@chromium.org2010-01-2116-84/+160
| | | | | | | | | | | | | | | | There are now memory errors in the CLD library that cause memory crashers in reliability tests. I will add reliability failures to the know_crashes.txt file while the memory errors are being fixed. Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unit-tests. TBR=brettw Review URL: http://codereview.chromium.org/555014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36707 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit r36640 "Choose right installer strings based on branding."kuchhal@chromium.org2010-01-213-7/+27
| | | | | | Review URL: http://codereview.chromium.org/553037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36706 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.finnur@chromium.org2010-01-211-0/+0
| | | | | | | | | | TBR=dpranke TEST=None BUG=None Review URL: http://codereview.chromium.org/555019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36703 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36693 - breaking mac for some reason - Add reserved messages to ↵cira@chromium.org2010-01-205-344/+158
| | | | | | | | | | | | | | | | | | | | | | | | | | | ExtensionMessageBundle dictionary. They are of the form @@somename, i.e. @@ui_locale. It makes easier for developers to detect current UI locale (also available though window.navigator.language), or text direction. I'll use them for static message replacement later on too. Before this change developers would have to manualy add locale and text_dir messages and translate for all supported locales. Added 5 reserved messages: @@ui_locale @@bidi_dir @@bidi_reversed_dir @@bidi_start_edge @@bidi_end_edge See http://code.google.com/apis/gadgets/docs/i18n.html#BIDI on why are they usefull. Extended allowed charset for variable names with @. Added unittest for variable names. Review URL: http://codereview.chromium.org/546040 TBR=cira@chromium.org Review URL: http://codereview.chromium.org/552078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36702 0039d316-1c4b-4281-b951-d872f2087c98
* Adding image for resize gripper in the hopes that the try bots don't fail to ↵finnur@chromium.org2010-01-201-0/+0
| | | | | | | | | | | try my patch. BUG=None TEST=None Review URL: http://codereview.chromium.org/555017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36699 0039d316-1c4b-4281-b951-d872f2087c98
* Disable UninstallDisabled and UpdatePermissions temporarily.kkania@chromium.org2010-01-201-2/+2
| | | | | | | | | BUG=none TEST=none TBR=asargent Review URL: http://codereview.chromium.org/552077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36697 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 13:01:06 +0000