| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
code that runs it.
Review URL: http://codereview.chromium.org/19666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
more sense anyway) so I'll be able to use it in custom_frame_window.cc.
Also eliminate an unnecessarily-repeated set of resource IDs from the opaque nonclient view, and move a comment to match what I ended up doing (but haven't yet sent up for review) in other places. Seems I couldn't make up my mind on that one.
Review URL: http://codereview.chromium.org/19458
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Disconnect the "browser controlled printing" and always delegate the control flow to the renderer.
Simplify the tests by not using a message loop anymore.
Followup changes will remove more parts that are not needed anymore.
Review URL: http://codereview.chromium.org/19460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
avoid possible crash.
Review URL: http://codereview.chromium.org/19451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=7191
Review URL: http://codereview.chromium.org/19665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
UI by plumbing through a delegate notification. This will also fix metrics for
the "focus the URL bar" command.
This also includes some OCD URL-formatting changes to the DOM UI that I noticed.
Review URL: http://codereview.chromium.org/19455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
studio projects for creating snapshots.
Apply change http://codereview.chromium.org/19635 to chrome and webkit solution files.
Review URL: http://codereview.chromium.org/19659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Collected in setup.exe passed to chrome via return code
- Depends on an updated oem.html and JS code by Glen
BUG=1468838
Review URL: http://codereview.chromium.org/19649
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=aa
Review URL: http://codereview.chromium.org/19654
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
also cleans up the internal plugin handling some more.
Review URL: http://codereview.chromium.org/19443
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
web page to the desktop.
We receive information about the image from WebKit in the
render which includes the image URL, MIME type and a guess
as to what the file name is. If the filename is empty, we
synthesize a file name based on the URL. In all cases, we
set the file extension to the MIME type that was detected
by WebKit.
This change is the Chromium portion of image dragging. The
WebKit portion has been committed as:
http://trac.webkit.org/changeset/40294
BUG=6481 (http://crbug.com/6481)
Review URL: http://codereview.chromium.org/19417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr
Review URL: http://codereview.chromium.org/19652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
message if we don't have any scripts.
Review URL: http://codereview.chromium.org/19441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=7144
Review URL: http://codereview.chromium.org/19642
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
constants, oops.
Also some tiny reorderings and similar nonfunctional changes in order to make this class closer to its sibling NonClientView subclasses, so I can eventually refactor them all more easily.
Review URL: http://codereview.chromium.org/19447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This will re-land http://codereview.chromium.org/18390
BUG=5325
Review URL: http://codereview.chromium.org/19004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19449
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18835
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
checked to accept the EULA.
Review URL: http://codereview.chromium.org/19436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Almost every method of the IPC channel must be invoked
from a single thread. This adds the corresponding
DCHECKS, and should confirm bug 6489 as a cause of
flakiness on the UI tests.
BUG: 6489.
Review URL: http://codereview.chromium.org/19617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
To get it to build, the source files had to have a few minor modifications:
- resolved compiler warnings
- fixed include path to avoid picking up system version of header
Review URL: http://codereview.chromium.org/19645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
build_config already.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19640
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19453
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ported and added to the xcode build.
Not much here, seems the earlier porting stuff just works.
Review URL: http://codereview.chromium.org/19637
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19623
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on shutdown. This came up in running in process ui tests through
purify.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
l10n_util::GetString(IDS_TASK_MANAGER) is returning "". Tony, myself
and Rahul don't think this should be possible, yet we have crashes
indicating otherwise. If IDS_TASK_MANAGER returns an emtpy string then
menu derefs NULL and we crash.
BUG=6206
TEST=no way to directly test this, instead just make sure menus still
work.
Review URL: http://codereview.chromium.org/19434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Improving automation interface to offer better control over
window creation of external tabs. The changes allow us
to specify a parent window, initial size and window style.
Review URL: http://codereview.chromium.org/19048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
because of the unresponsive tab logic. If we are short-cutting a slow
beforeunload handler, we now avoid a redundant call to SetNavigationsSuspended.
Also clarified a few comments, removed what appeared to be an unnecessary call
to DidNavigateMainFrame, and re-enabled tests that were likely disabled due
to this issue.
BUG=6950
BUG=6698
TEST=SSLUITest.TestHTTPSExpiredCertAndDontProceed --single-process
TEST=SSLUITest.TestHTTPWithBrokenHTTPSResource
TEST=SSLUITest.TestOKHTTPS
TEST=SSLUITest.TestHTTPSExpiredCertAndProceed
Review URL: http://codereview.chromium.org/19006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
for the about IPC dialog next.
Review URL: http://codereview.chromium.org/19433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
flow to the renderer.
Followup changes will remove more parts that are not needed anymore.
Review URL: http://codereview.chromium.org/18860
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
regressed with the introduction
of the Plugin wrapper window which parents the actual plugin window in the plugin process. We need to set focus to the actual plugin window when we receive a WM_MOUSEACTIVATE in the browser caused by a click on the plugin window.
This fixes http://code.google.com/p/chromium/issues/detail?id=7143
Bug=7143
Review URL: http://codereview.chromium.org/19626
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19632
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
since it prints a confusing message on first run.
Review URL: http://codereview.chromium.org/19429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fix of Linux by using ARRAYSIZE_UNSAFE instead of arraysize.
Issue=Issue=6329
Review URL: http://codereview.chromium.org/18567
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the Search menu item. Original patch by Brian Duff (see http://codereview.chromium.org/16510 ), r=me.
BUG=1925
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19627
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19423
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
switch. It's better to check this at one chokepoint
(initialization) and let the rest of the code work
the same, but end up as no-ops.
Review URL: http://codereview.chromium.org/18401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Follow up to issue 19041/r8767. Building with SHARED=1 --mode=opt got errors with missing sqlite. Move sqlite append from chrome/SConscript to build/SConscript.main.
Review URL: http://codereview.chromium.org/19615
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* wstring -> FilePath
* create versions of WriteFile/ReadFile with FilePath signatures
Review URL: http://codereview.chromium.org/19610
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shutdown. Normally it's true, but I'm going to set it to false for in
process ui tests. I can't delete the ResourceBundle for these tests as
many classes cache SkBitmaps from the resource bundle in statics.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19609
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
switch. It's better to check this at one chokepoint
(initialization) and let the rest of the code work
the same, but end up as no-ops.
This seems to break ui_tests.
Review URL: http://codereview.chromium.org/19418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8794 0039d316-1c4b-4281-b951-d872f2087c98
|