summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Remove svn:executable property from a bunch of files that don't need it.thestig@chromium.org2010-04-27131-456/+456
| | | | | | Review URL: http://codereview.chromium.org/1732014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45657 0039d316-1c4b-4281-b951-d872f2087c98
* Move a disabled test from sync_unit_test to unit_test.thestig@chromium.org2010-04-272-2/+3
| | | | | | | | | BUG=37839 TEST=Tsan goes green. TBR=sanjeevr Review URL: http://codereview.chromium.org/1783004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45656 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the code to use separate ids namspacesgman@chromium.org2010-04-271-2/+2
| | | | | | | | | | | | for buffers, textures, programs, etc.. This is needed to pass GLES2 conformance tests. TEST=old unit tests BUG=none Review URL: http://codereview.chromium.org/1747013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45654 0039d316-1c4b-4281-b951-d872f2087c98
* This test is no longer flaky now that it is run as an interactive UI test. ↵johnnyg@chromium.org2010-04-271-1/+1
| | | | | | | | | | | Changing the name to match. BUG=32807 TEST=none Review URL: http://codereview.chromium.org/1727008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45651 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill crash in CreditCard::SetInfo().dhollowa@chromium.org2010-04-276-153/+270
| | | | | | | | | | | | | Fix for crash seen in the field. The AutoFillType class was not thread-safe. These changes make it so. Also adds unit tests that cover mappings from type to group and subgroup, and out of range conditions. BUG=42341 TEST=AutoFillTypeTest Review URL: http://codereview.chromium.org/1789001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45650 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the "cancel leaked host resolver requests shutdown hack" gets run ↵eroman@chromium.org2010-04-273-5/+22
| | | | | | | | | | before the message loop is destroyed. BUG=41966 Review URL: http://codereview.chromium.org/1798001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45644 0039d316-1c4b-4281-b951-d872f2087c98
* Ground work for making appcaches work in workers.michaeln@chromium.org2010-04-261-0/+2
| | | | | | | | | | | | Add ResourceRequest target types for worker and shared worker resources. This is the first patch of a two-sided change that involves WebKit API changes which haven't been made yet. BUG=39368 TEST=none Review URL: http://codereview.chromium.org/1666002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45643 0039d316-1c4b-4281-b951-d872f2087c98
* Ground work for making appcache work in workers.michaeln@chromium.org2010-04-261-0/+8
| | | | | | | | | | | Put in place a noop impl of createApplicationCacheHost() on all WebCommonWorkerClient subclasses. That factory method is soon to be added to the WebKit::WebCommonWorkerClient class as a pure virtual. Adding these methods in advance so it builds when that pure virtual shows up later. BUG=39368 TEST=none Review URL: http://codereview.chromium.org/1729015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45642 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Disable the "Import" button on Import Bookmarks dialog if there is no ↵evan@chromium.org2010-04-262-17/+57
| | | | | | | | | | | | | checkbox checked. BUG=30401 TEST=open Import Bookmarks dialog, uncheck all checkboxes, see if the "Import" button is disabled. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1604025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45641 0039d316-1c4b-4281-b951-d872f2087c98
* Send out notifications when logins are changed through PasswordStoreMacalbertb@chromium.org2010-04-263-35/+114
| | | | | | | | | | | so that the sync backend can register as an observer. BUG=35038 TEST=none Review URL: http://codereview.chromium.org/1752007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45640 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the toolkit_views gyp variable define mania.evan@chromium.org2010-04-261-1/+4
| | | | | | | | | | | | | | | | This makes it so toolkit_views==1 is always true for views builds, either on Windows or ChromeOS. Three levels of nesting are needed for this chained conditional: 1) Set the default value of ChromeOS. 2) Depending on ChromeOS value, set the default value of toolkit_views. 3) Depending on toolkit_views value, set the rest of the build variables. This should have no affect on the build, but will allow subsequent cleanup. Review URL: http://codereview.chromium.org/1799002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45639 0039d316-1c4b-4281-b951-d872f2087c98
* Archive lib.target/_pyautolib.so on Linux.nirnimesh@chromium.org2010-04-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1789003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45637 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Order the methods in WebDataService. Rename a method to match ↵jhawkins@chromium.org2010-04-264-353/+354
| | | | | | | | | | | current style. BUG=none TEST=none Review URL: http://codereview.chromium.org/1701012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45636 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 388.0 to 389.0chrome-release@google.com2010-04-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45633 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor parts of the NTP to split things into more managable chunks.arv@chromium.org2010-04-2614-580/+680
| | | | | | | | | BUG=None TEST=Manual Review URL: http://codereview.chromium.org/1759007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45631 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flaky AppApiTest.AppProcess.mpcomplete@chromium.org2010-04-261-6/+7
| | | | | | | | BUG=42497 Review URL: http://codereview.chromium.org/1745016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45630 0039d316-1c4b-4281-b951-d872f2087c98
* Honor the select_all argument to AutocompleteEditViewMac::FocusLocation.mark@chromium.org2010-04-261-3/+5
| | | | | | | | | | | | | | | | | | | | | | | Calling -[NSWindow makeFirstResponder:] to give focus to the AutocompleteTextField will select the entire contents of the field. If the field is already focused and "select all" is not desired, avoid making this call. If "select all" is desired, or if the field is not focused (regardless of the value of select_all), the field will be focused and its entire contents selected. BUG=40322, 40682 TEST=With a profile primed so that "google.com" is the first suggestion when typing "g" in the location bar, and no windows open, quickly press command-N and begin typing "google" while the tab is being created. Expect all of the entered characters to make it to the location bar. When the bug occurs, the location bar in its entirety will be selected at some point during or immediately following tab creation, which will cause previously-typed text to be lost or the first autocomplete suggestion to be chosen, and something like "ogle" or "google.com/ogle" to appear in the location bar. Review URL: http://codereview.chromium.org/1709010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45628 0039d316-1c4b-4281-b951-d872f2087c98
* Move event_sys.h, event_sys-inl.h and event_sys_unittest.cc to chrome/common ↵sanjeevr@chromium.org2010-04-2633-42/+42
| | | | | | | | | | | in preparation of moving TalkMediator and GaiaAuthenticator to chrome/common. No functional change, only file locations have changed. BUG=None TEST=Test Bookmakrs Sync Review URL: http://codereview.chromium.org/1739004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45626 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: partial fix position of context menu for trees.arv@chromium.org2010-04-261-1/+1
| | | | | | | | | | | When the user presses the context menu key we ask the tree for the rect where the context menu should be placed at. We incorrectly returned the rec for whole tree item, including its children. With this change we only return the rect for the row of the tree item. BUG=None TEST=None Review URL: http://codereview.chromium.org/1758009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45625 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Make sure we do not collapse whitespace in bookmark names.arv@chromium.org2010-04-263-12/+14
| | | | | | | | | | BUG=41911 TEST=Create a bookmark and a bookmark folder with the name " ". The item should still be shown in both the tree and the list. Review URL: http://codereview.chromium.org/1793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45624 0039d316-1c4b-4281-b951-d872f2087c98
* Put an "(empty)" into the submenus of empty folders in the bookmark menu, to ↵avi@chromium.org2010-04-261-3/+10
| | | | | | | | | | | match the same in the non-menubar menus. BUG=http://crbug.com/41768 TEST=as in bug Review URL: http://codereview.chromium.org/1718016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45615 0039d316-1c4b-4281-b951-d872f2087c98
* Add the "history" permission.kathyw@chromium.org2010-04-264-65/+114
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/1662007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45613 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/GTK: delete native bookmark manager code.viettrungluu@chromium.org2010-04-2612-1966/+33
| | | | | | | | | | | Views code still to be deleted; some cleanup will take place then. BUG=38908 TEST=everything keeps working as before Review URL: http://codereview.chromium.org/1753009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45612 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Ignore rapp events when the browser is shutting down.rohitrao@chromium.org2010-04-261-0/+6
| | | | | | | | BUG=42430 TEST=Suspected test case is to click on the dock icon immediately after quitting, but before the quit has finished. This is very timing-dependent, and I have never actually been able to reproduce the crash. Review URL: http://codereview.chromium.org/1796001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45609 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Support themes in the devtools window in GTK mode too.erg@chromium.org2010-04-265-2/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1762009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45606 0039d316-1c4b-4281-b951-d872f2087c98
* Correction, and simplification of the javascript code to capture the ↵twiz@chromium.org2010-04-261-20/+11
| | | | | | | | | | | | | screen-space position of the DOM element on which the experimental popup API is anchored. The old code was taking into consideration the scroll offset within the element to which the popup was attached. This was incorrect: All scrolling within the parent hierarchy of the given node should be considered, but not scrolling within the node itself. BUG=None TEST=None Review URL: http://codereview.chromium.org/1734009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45604 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash in BoundsAnimator. This patch largely justsky@chromium.org2010-04-262-8/+15
| | | | | | | | | | | | cleans things up and fixes some possible usage problems by TabStrip. I'm not confident this fixes the crash, but we'll see. BUG=41538 TEST=none Review URL: http://codereview.chromium.org/1710003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45602 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't display bookmark right click menu when bookmark bar is hidden.erg@chromium.org2010-04-261-1/+1
| | | | | | | | | | | | | | Because the event box is still visible when the bookmark bar is hidden and the event box is connected to the button-press-event, if you right click under the location bar or the browser action icons, you'll show the bookmark menu even if you have it hidden. BUG=none TEST=none Review URL: http://codereview.chromium.org/1704010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45601 0039d316-1c4b-4281-b951-d872f2087c98
* Fix save complete web page crasherestade@chromium.org2010-04-264-18/+28
| | | | | | | | | | | | | Repeatedly saving a page may cause a crash. See the bug for a full discussion. This fixes that by making sure the curretn SavePackage is the same one that called into SaveFileManager::RenameAllFiles. One more hack on the giant, teetering pile of hacks that is the SavePackage system. Can't hurt, right? BUG=42454 TEST=see bug Review URL: http://codereview.chromium.org/1729016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45599 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for history.nirnimesh@chromium.org2010-04-264-2/+134
| | | | | | | | | | | | | | | Tests various scenarios with chromium history. testHistoryPersists, testInvalidURLNoHistory -- by Srikanth. testNewTabNoHistory, testIncognitoNoHistory, testStarredBookmarkInHistory, testHistorySearchSnippet -- by Ismail. testNavigateMultiTimes, testMultiTabsWindowsHistory -- by Rohit. TEST=python chrome/test/functional/history.py Review URL: http://codereview.chromium.org/1745012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45597 0039d316-1c4b-4281-b951-d872f2087c98
* Search Engine experiment will crash if the user is importing to a non-empty ↵mirandac@chromium.org2010-04-261-0/+8
| | | | | | | | | | | | | profile, and has fewer than 3 default search engines *combined* in the non-empty chrome profile and the browser from which they are importing. BUG= 42554 TEST= Run with the search engine experiment enabled, importing from a browser with only 1 search engine in the list. Make sure the user data dir you are running from is non-empty, *and* that it has a profile with only 1 search engine in its list. Chrome should not crash (experiment will also not appear). Review URL: http://codereview.chromium.org/1736015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45595 0039d316-1c4b-4281-b951-d872f2087c98
* Add geolocation permission to extensions/apps.erikkay@chromium.org2010-04-2614-22/+99
| | | | | | | | | BUG=41278 TEST=None Review URL: http://codereview.chromium.org/1695013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45590 0039d316-1c4b-4281-b951-d872f2087c98
* Declare TranslateInfobarController as implementing NSMenuDelegate, requiredmark@chromium.org2010-04-261-2/+3
| | | | | | | | | | for the 10.6 SDK build after r45553. BUG=none TEST=none Review URL: http://codereview.chromium.org/1733018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45587 0039d316-1c4b-4281-b951-d872f2087c98
* Added more keyboard shortcuts for other wizard screens.avayvod@google.com2010-04-261-7/+28
| | | | | | | | | BUG=37068 TEST=Boot so that any wizard is shown. Verify that Ctrl-Alt-{n, u, l, a} switch to network, update, login and account screens correspondingly. Review URL: http://codereview.chromium.org/1696011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45584 0039d316-1c4b-4281-b951-d872f2087c98
* RenderView::UpdateTargetURL should not look at GURL::spec().dglazkov@chromium.org2010-04-264-2/+10
| | | | | | | | | | | | | Doing so causes a DCHECK to fail if GURL does not consider it a valid URL. Contributed by Hans Wennborg <hans@chromium.org>. BUG=41562 TEST=unit_tests --gtest_filter=RenderViewTest.UpdateTargetURLWithInvalidURL Review URL: http://codereview.chromium.org/1718013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45582 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the tab menu to use pin and unpin instead of a check. The macsky@chromium.org2010-04-267-58/+34
| | | | | | | | | | | changes to use the right thing (pinned vs mini) will be done separately. BUG=none TEST=none Review URL: http://codereview.chromium.org/1725006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45581 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Kill off google_update_settings_mac.mm. It's functions are empty and ↵thomasvl@chromium.org2010-04-262-38/+0
| | | | | | | | | | nothing actually calls it. If we ever support rlz, we might need to add something back, but rlz.cc is pretty Windows heavy, so there doesn't seem to be a reason to have this empty shell in the mean time. BUG=39131 TEST=none Review URL: http://codereview.chromium.org/1729013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45580 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: support themes.pfeldman@chromium.org2010-04-262-3/+38
| | | | | | Review URL: http://codereview.chromium.org/1584016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45578 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ExternalTabUITest.HostNetworkStack failed as flaky.bulach@chromium.org2010-04-261-1/+2
| | | | | | | | | TBR=stoyan@chromium.org BUG=42545 Review URL: http://codereview.chromium.org/1733017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45576 0039d316-1c4b-4281-b951-d872f2087c98
* Remove empty nodes when deleting cookies.jochen@chromium.org2010-04-263-105/+51
| | | | | | | | | BUG=39389 TEST=none Review URL: http://codereview.chromium.org/1751013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45575 0039d316-1c4b-4281-b951-d872f2087c98
* Clear non-wildcard content settings before setting from bubble or prompt.jochen@chromium.org2010-04-264-0/+26
| | | | | | | | | BUG=42359 TEST=manual Review URL: http://codereview.chromium.org/1707011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45571 0039d316-1c4b-4281-b951-d872f2087c98
* Allow user to choose what kind of container to launchaa@chromium.org2010-04-266-10/+89
| | | | | | | | applications in. Review URL: http://codereview.chromium.org/1784001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45570 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of more calls to FromWStringHack.tony@chromium.org2010-04-268-61/+43
| | | | | | | | | | | BUG=24672 TEST=compiles Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1750013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45568 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r45520. This adds a new browser type: EXTENSION_APP thataa@chromium.org2010-04-2618-52/+268
| | | | | | | | | has a larger titlebar and a big icon, along with a tabstrip, but no titlebar. Review URL: http://codereview.chromium.org/1774003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45566 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another instance of python_24 being used on Windows.tony@chromium.org2010-04-261-13/+1
| | | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/1762006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45565 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use the checked in python for UI tests on Windows.tony@chromium.org2010-04-261-13/+2
| | | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/1788001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45564 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix use-after-free in translate infobar options menu.jeremy@chromium.org2010-04-251-6/+14
| | | | | | | | | | | | | | | The "About Translate" command opens a new tab which closes the infobar, we where trying to update the options menu which acccessed an already released object. The fix is to match Windows behavior and only rebuild the options menu when clicked. Thanks to Rohit for diagnosing the problem! BUG=42030 TEST=repro in bug description. Review URL: http://codereview.chromium.org/1756006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45553 0039d316-1c4b-4281-b951-d872f2087c98
* mark AppApiTest.AppProcess as flakynsylvain@chromium.org2010-04-251-1/+2
| | | | | | | | | TBR:mpcomplete BUG:42497 Review URL: http://codereview.chromium.org/1752015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45546 0039d316-1c4b-4281-b951-d872f2087c98
* Mac cleanup: get rid of probably-stale TODOs.viettrungluu@chromium.org2010-04-251-4/+0
| | | | | | | | | | | | See comments at <http://codereview.chromium.org/1737013>. TBR=jrg@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/1726007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45545 0039d316-1c4b-4281-b951-d872f2087c98
* Mac cleanup: remove a TODO and add ToolbarControllerTest.NoLocationBar ↵viettrungluu@chromium.org2010-04-242-4/+18
| | | | | | | | | | | (another TODO). BUG=none TEST=ToolbarControllerTest.NoLocationBar passes Review URL: http://codereview.chromium.org/1737013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45543 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 13:01:53 +0000