| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No one more uses this function after we removed the platform-specific code and
switched to WebUI.
(Note: This was a TODO for kmadhusu).
BUG=None
TEST=None
R=thestig@chromium.org,kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/6894015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These failures only happen if tests are called in the right (wrong?) order.
ExtensionSourcePriorityTest::SetUp() failied to call SetUp on it's parent class. If a previous test caused an error, it would fail with that error.
ExtensionServiceTestSimple.Enabledness should initialize ExtensionErrorReporter. If it was run before other tests had done so, it would CHECK().
BUG=79755
TEST=ExtensionSourcePriorityTest.*, ExtensionServiceTestSimple.*
Review URL: http://codereview.chromium.org/6877072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:14305
TEST=
Review URL: http://codereview.chromium.org/6882069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bundle identifier is needed on the Mac. This means that everything will use
up using org.chromium.Chromium, com.google.Chrome, or
com.google.Chrome.canary when it's important to get the base bundle
identifier. .helper and .framework will not be appended. Note, however, that
things that run inside the helper and use CFPreferences or NSUserDefaults
will continue to write their defaults as org.chromium.Chromium.helper or
com.google.Chrome.helper. Mostly this just affects the Flash plug-in's
settings for the NSNav open dialog. There is no
com.google.Chrome.canary.helper, but that's not expected to be a problem.
This change ensures that Chromes, canaries, and Chromiums don't get in each
other's way.
BUG=79814
TEST=none
Review URL: http://codereview.chromium.org/6896003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Exclude <script> and <option> tags from the "Infer" traversals. 2. Exclude <!-- comment --> elements from the "Infer" traversals. 3. Change IDS_AUTOFILL_ZIP_CODE_RE to be ... |^cap$ ... to strengthen the match.
BUG=64818
TEST=1. Go to gmail.com and click on the "Create an account" button. 2. Double click first name field and try to trigger Autofill. 3. Choose an item from the Autofill window. 4. Make sure the fields are correctly filled.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82448
Review URL: http://codereview.chromium.org/6873030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=79814
TEST=none
Review URL: http://codereview.chromium.org/6900013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the GTK-side of:
http://codereview.chromium.org/6806013/
Which implements this feature on Windows and Mac. (This CL depends on that CL, which I've not landed yet.)
BUG=19071
TEST=1. Select some text and drag it over an inactive tab. In 0.5 seconds,
the tab selection should switch to that tab. You should now be able to
drag the text into the content area of that tab (e.g. into a text box).
2. Select some text and drag it over an inactive tab. Without waiting
over 0.5 seconds, move the mouse away from that tab. No tab switch
should take place.
Review URL: http://codereview.chromium.org/6869012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80196, 80150
TEST=unit_tests.exe
Review URL: http://codereview.chromium.org/6899007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82578
Review URL: http://codereview.chromium.org/6873147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unhardcoded dimentions;
Added a testcase that uses WEBKIT_lose_context extension.
BUG=
TEST=it is failing before WebGLLayerChromium fix is applied
Review URL: http://codereview.chromium.org/6879050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=79961
TEST=none
Review URL: http://codereview.chromium.org/6879093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=80091
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6899013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
URL: http://codereview.chromium.org/6873147
TBR=lipalani@chromium.org
Review URL: http://codereview.chromium.org/6880129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a refactoring of r82400. We're going to need the title
direction in a bunch of different places; it's better to package
it up as one object.
BUG=27094
Review URL: http://codereview.chromium.org/6878089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
XFCE.
BUG=20587
TEST=Check xprop on the main window.
Review URL: http://codereview.chromium.org/6879127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
making the lined pointer.
BUG=79568
TEST=
Review URL: http://codereview.chromium.org/6880021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6873147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Switch webkitRequestFileSystem/webkitResolveLocalFileSystemURL.
* Stop sharing selection models between grid/table, it doesn't work.
* Remove readAsDataURL in favor of toURL
* Fix case where chrome sets defaultPath to the downloads folder.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6899003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6897007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename InfoBubbleGtk to BubbleGtk.
Rename InfoBubbleGtkDelegate to BubbleDelegateGtk.
Rename InfoBubbleAcceleratorsGtk To BubbleAcceleratorsGtk.
This is a follow up to Ben's patch in http://codereview.chromium.org/6840026.
BUG=72040
TEST=None
R=estade@chromium.org
Review URL: http://codereview.chromium.org/6865048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=carnitas
TEST=visual
Review URL: http://codereview.chromium.org/6883095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
use base.dll from chrome.
BUG=76996
TEST=none
Review URL: http://codereview.chromium.org/6877053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=79523
TEST=Enable print preview flag. Preview a webpage. Close the initiator tab. Observe the disabled controls in preview tab.
Review URL: http://codereview.chromium.org/6881096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Per post-commit comments by maf@ on: http://codereview.chromium.org/6883121/
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6883131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new name is chosen because it goes along with new_new_tab.html/js/css
The reason it has to change is there's a filename conflict with resources/ntp4/new_tab_theme.css (Grit rc generation failure?)
BUG=80044
TEST=manual
Review URL: http://codereview.chromium.org/6879126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:14328
TEST=NONE
Review URL: http://codereview.chromium.org/6880113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=apavlov@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6882131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
VS2005 gets confused when a class inherits from Foo::Delegate
and also defines an inner class with the name Delegate.
The fix is to move the inner class out.
R=mirandac
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6891006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Strings "Invalid page range" and "Invalid number of copies" where used before
as a tooltip text, but now they are used as regular messages not as tooltips.
BUG=NONE
TEST=Print preview messages "Invalid page range" and "Invalid number of copies" should still
be displayed correctly.
Review URL: http://codereview.chromium.org/6879110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If this is called before OnBackendInitialized, the DTM won't exist. We fake a call to OnPassphraseAccepted from OnPassphraseRequired if no encrypted types are enabled to clean up errors and passphrase prompts, but we don't need to call in to DTM. Especially if it doesn't exist.
BUG=80208
TEST=Restart sync-enabled browser that doesn't have password sync enabled. No crash.
Review URL: http://codereview.chromium.org/6880117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79814
TEST=There should be only one checkbox in the first run dialog (after the
search engine selection), it should be for stats reporting, and it should
default to on.
Review URL: http://codereview.chromium.org/6881115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fails.
BUG=80212
TEST=
R=apatrick@chromium.org
Review URL: http://codereview.chromium.org/6877131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=80098
TEST=official debug build shouldn't hit DCHECK. pingback content verified with tcpdump.
Review URL: http://codereview.chromium.org/6889001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72363
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6882126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:13825
TEST=Go to wrench > About Chrome OS. Verify there is a line that says "Chrome OS is made possible by additional open source software", not "Google Chrome OS...".
Review URL: http://codereview.chromium.org/6877103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This hooks up a new TabController state (called 'active') to indicate what
'selected' used to: key/focused state. The selected state can now be applied to
multiple TabControllers.
Currently only commands available through the context menu are usable for a
multi-tab selection. Support for dragging will come in a future CL.
The other notable chane is that tab activation now happens on |-mouseUp:|
rather than |-mouseDown:|, which is in preparation for multi-tab dragging.
BUG=78816
TEST=Shift click, Cmd click, and Cmd+Shift click to select tabs in different ways.
Review URL: http://codereview.chromium.org/6821003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=70658
TEST=Start chrome; chrome should detect gnome-keyring/kwallet and use it.
Review URL: http://codereview.chromium.org/6880110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a part of r82185 that was reverted. The change was reverted because it caused a performance regression.
I'm checking in just the reorganization code to narrow down exactly which part of the change caused the regression.
The only code change here is some header includes. If this change passes the perf bot then my next change will be to load the new resource pak.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6883110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests passed as-is when I ran them. They all passed when executed
with "--repeat=20".
BUG=chromium-os:12653
TEST=None
Review URL: http://codereview.chromium.org/6877127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=chromium-os:14328
TEST=NONE
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=80190
TESTS=autofill.AutofillTest.testDistinguishMiddleInitialWithinName, autofill.AutofillTest.testFormFillableOnReset, autofill.AutofillTest.testMultipleEmailFilledByOneUserGesture
Review URL: http://codereview.chromium.org/6879124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the correct RVH.
BUG=79748
TEST=ExtensionApiTest.CaptureVisibleTabRace
R=skerner@chromium.org
Review URL: http://codereview.chromium.org/6873140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The network menu > Other Wi-Fi network... dialog now contains an "Advanced" button that opens a larger dialog with EAP connection type, certificates, etc.
Removed unused browser_mode state in NetworkConfigView, fixed some method naming style issues, removed some unused parameters from test code.
BUG=chromium-os:13476
TEST=Test connections to various Wi-Fi network types: normal public wifi, password protected wifi, hidden wifi with password, PEAP wifi, hidden PEAP wifi.
Review URL: http://codereview.chromium.org/6877087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=14256
TEST=
Review URL: http://codereview.chromium.org/6884002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory.
Updated path in autofill.py
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6873149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6883108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch created by arthurhsu@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6880092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Checks |isKeyWindow| before performing the poof animation. Re-ordered the
call to [oldButton removeFromSuperview] so that the view will actually have
a window at the time of the check. Also, moved initialization of |poofPoint|
inside the block to avoid doing the work when it's not needed.
BUG=80046
TEST=See bug.
Review URL: http://codereview.chromium.org/6883121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6883098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82519 0039d316-1c4b-4281-b951-d872f2087c98
|