summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Increase timeout for ui_test.paulg@google.com2008-12-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/15061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7266 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a DCHECK in the IFrameTest.InEmptyFrame by removing it. The behavior isbrettw@google.com2008-12-182-6/+3
| | | | | | | | | correct, and the condition can be hit differently than assumed by the DCHECK. BUG=3035 Review URL: http://codereview.chromium.org/15050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7262 0039d316-1c4b-4281-b951-d872f2087c98
* Make the tab restore ui_tests Purify friendly.paulg@google.com2008-12-181-1/+2
| | | | | | Review URL: http://codereview.chromium.org/15053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7258 0039d316-1c4b-4281-b951-d872f2087c98
* Bridge out media player from MediaPlayerPrivate.hclam@chromium.org2008-12-188-1/+224
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove MediaPlayerPrivateChromium.cpp and move it to webkit/glue/media_player_private_impl.cc - Added the following classes: WebMediaPlayer WebMediaPlayerImpl WebMediaPlayerDelegate WebMediaPlayerDelegateImpl TestWebMediaPlayerDelegate VideoStackMediaPlayer (Just a forward declaration) - One include fix for webkit/glue/webframe.h - Overview of what each class is doing: WebMediaPlayer and WebMediaPlayerImpl Wrapper over the MediaPlayerPrivate, it provides methods like Repaint(), NotifyNetworkStateChange(), etc to VideoStackMediaPlayer. It also creates the ResourceHandle for VideoStackMediaPlayer for resource loading, or maybe VideoStackMediaPlayer can simply use webkit_glue::ResourceDispatcher? WebMediaPlayerDelegate, WebMediaPlayerDelegateImpl Delegate calls from webkit to the internal media player. MediaPlayerPrivate Forward calls to WebMidiaPlayerDelegate, creates WebMediaPlayerDelegate and WebMediaPlayer in the constructor. Expose some public methods to WebMediaPlayer so we can actually do repaint and notification of changes. Review URL: http://codereview.chromium.org/13762 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7256 0039d316-1c4b-4281-b951-d872f2087c98
* Make some more ui_test Purify friendly.paulg@google.com2008-12-182-4/+4
| | | | | | Review URL: http://codereview.chromium.org/15027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7242 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the Home button to the MSAA focus order, if enabled. Also removes an ↵klink@chromium.org2008-12-183-5/+2
| | | | | | | | unnecessary check from ViewAccessibility. Review URL: http://codereview.chromium.org/15026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7239 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes browser crash that could occur if the user closed a tab with ansky@google.com2008-12-182-12/+52
| | | | | | | | | | | | unload handler, then right clicked on the tab. The fix is to close the menu if the tab closes. BUG=4846 TEST=see bug Review URL: http://codereview.chromium.org/14843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7235 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes a crash while trying to duplicate an application window.erg@google.com2008-12-181-1/+4
| | | | | | Review URL: http://codereview.chromium.org/14823 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7228 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for running the ui_tests under Purify on thepaulg@google.com2008-12-1812-36/+90
| | | | | | | | | | | | | | | | | | buildbots. With these changes, I've been able to get 106 of about 185 ui_tests running under Purify on my machine (I haven't gotten to the remaining tests yet) with minimal changes. The changes here are timeout related, allowing us to specify longer timeouts in chrome_tests.py rather than hard coding them in the tests themselves. We'll likely have to experiment on the buildbots with different timeout values, depending on how fast the bots are. Review URL: http://codereview.chromium.org/14184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7226 0039d316-1c4b-4281-b951-d872f2087c98
* Don't handle in-page navigations if it's for a subframe. Previously we wouldbrettw@google.com2008-12-182-3/+39
| | | | | | | | | | compare the URL with the main frame to see if it was in page. In very rare cases, these can actually be the same, which will confuse us. http://crbug.com/5585 Review URL: http://codereview.chromium.org/14824 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7220 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in browser/debugger/phajdan.jr@chromium.org2008-12-183-7/+16
| | | | | | Review URL: http://codereview.chromium.org/14841 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7218 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in renderer/phajdan.jr@chromium.org2008-12-186-11/+34
| | | | | | Review URL: http://codereview.chromium.org/15601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7217 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak Windows scons build caused by my importer porting.phajdan.jr@chromium.org2008-12-181-2/+6
| | | | | | Review URL: http://codereview.chromium.org/14840 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7216 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7214.phajdan.jr@chromium.org2008-12-181-8/+4
| | | | | | Review URL: http://codereview.chromium.org/15403 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7215 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak Windows scons build caused by my importer porting.phajdan.jr@chromium.org2008-12-181-4/+8
| | | | | | Review URL: http://codereview.chromium.org/14840 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7214 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7206.ojan@google.com2008-12-181-1/+3
| | | | | | | Sigh. Apparently these fail only on the buildbots. Review URL: http://codereview.chromium.org/14829 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7207 0039d316-1c4b-4281-b951-d872f2087c98
* This test seems to have started passing again.ojan@google.com2008-12-181-3/+1
| | | | | | Review URL: http://codereview.chromium.org/14828 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7206 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 4224: Window Management controls don't work with ↵xji@chromium.org2008-12-181-1/+2
| | | | | | | | | | | | | | | | | | | maximized RTL Chrome windows. When checking whether a point is within a window management button view's boundary, need to apply mirroring transformation on the view's boundary to work for RTL chrome. http://crbug.com/4224 TEST: 1. Launch Chrome with any RTL (Eg: he, ar) 2. Maximize the browser window. 3. Hover over window management controls (min,restore,close), they all work correctly in the sense that the buttons got highlighted and react to user events. (without this fix, when hover over window management controls, the buttons won't get highlighted at all and they won't react to user events) Review URL: http://codereview.chromium.org/14129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7205 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the text field is focused when doing a JavaScript prompt (which ↵jcampan@chromium.org2008-12-182-0/+7
| | | | | | | | | | shows an alert box with a text field in it). BUG=5333 TEST=Load a page that does a prompt("Hello", "World"). It should open an alert box with a text field with the contents 'World'. The text should be selected and the text field should have focus. Make sure alert() and confirm() still have the OK button focused when used. Review URL: http://codereview.chromium.org/15023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7201 0039d316-1c4b-4281-b951-d872f2087c98
* Switch Extension over to UTF8 strings.scherkus@chromium.org2008-12-183-17/+17
| | | | | | | | | | Value now stores everything internally as UTF8 strings, so I'm going around switching code over from wstring to string. Feel free to reject the change if you need wstring! Review URL: http://codereview.chromium.org/15020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7199 0039d316-1c4b-4281-b951-d872f2087c98
* Duplicate popup window should have same size and scroll erg@google.com2008-12-181-0/+6
| | | | | | | | | | position as original popup. BUG=5632 (http://crbug.com/5632) Patch by Mohamed Mansour. Review URL: http://codereview.chromium.org/14812 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7195 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the tab restore service contain any windows that were open atsky@google.com2008-12-187-37/+366
| | | | | | | | | | | | | the time of a crash. BUG=5465 TEST=Bring up chrome, go to google.com. Wait a minute. Kill chrome via the task manager. Launch chrome again. Make sure the new tab page shows an entry named 'Window (g)' where g is Google's favicon. Review URL: http://codereview.chromium.org/14172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7188 0039d316-1c4b-4281-b951-d872f2087c98
* Switched MetricsService over to using UTF8 string values.scherkus@chromium.org2008-12-182-10/+10
| | | | | | | | This is part of my ongoing wide string vanquishing. Review URL: http://codereview.chromium.org/15013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7187 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed mixed EOLs and set svn EOL prop for interstitial_page.[h,cc]jcampan@chromium.org2008-12-182-8/+8
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/14819 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7186 0039d316-1c4b-4281-b951-d872f2087c98
* Move the "platform" wrappers in skia/ext to the skia namespace.brettw@google.com2008-12-1713-26/+26
| | | | | | Review URL: http://codereview.chromium.org/14110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7182 0039d316-1c4b-4281-b951-d872f2087c98
* Changes menu's Dispatcher to translate/dispatch message beforesky@google.com2008-12-172-6/+25
| | | | | | | | | | | | | returning false. This way we don't screw up the message pump. I also needed to slightly tweak the bookmark bar test that was hitting this code path. BUG=none TEST=none Review URL: http://codereview.chromium.org/15008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7177 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs resulting in bad window resize behavior:sky@google.com2008-12-171-5/+8
| | | | | | | | | | | | | | | | | . Dragging a tab out was forcing the bounds to fit on the monitor. This was a regression introduced during some refactoring. The fix is not to call Window::SetBounds, but instead SetWindowPos (which is roughly what the old code did). . When the bounds of the window change always layout. We need this for the situation where the normal bounds and maximized bounds are the same because we layout differently in the two. BUG=5540 5118 TEST=see description in 5118 Review URL: http://codereview.chromium.org/14511 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7169 0039d316-1c4b-4281-b951-d872f2087c98
* Increase UMA upload interval, and upload usage stats more oftenjar@google.com2008-12-173-27/+81
| | | | | | | r=evanm Review URL: http://codereview.chromium.org/14186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7165 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in download tab view that resulted from attempting tosky@google.com2008-12-171-1/+4
| | | | | | | | | | | | | | | paint a download at downloads_.size(). This happened if the last download is visible, in which case row_stop == downloads_.size() and because the loop iterates to row_stop we try accessing downloads_[downloads_.size()]. BUG=5520 TEST=Bring up the downloads view and make sure you can scroll to the end of your downloads without crashing. Review URL: http://codereview.chromium.org/14806 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7161 0039d316-1c4b-4281-b951-d872f2087c98
* Cleans up the code style of the Accessibility Test suite.klink@chromium.org2008-12-1712-893/+848
| | | | | | | | BUG=2236 Review URL: http://codereview.chromium.org/13333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7160 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7149.jcampan@chromium.org2008-12-1736-1108/+1607
| | | | | | Review URL: http://codereview.chromium.org/15004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7153 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux release build.evanm@google.com2008-12-171-5/+6
| | | | | | | Review URL: http://codereview.chromium.org/15401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7151 0039d316-1c4b-4281-b951-d872f2087c98
* Revamp of the interstitial pages.jcampan@chromium.org2008-12-1736-1607/+1108
| | | | | | | | | | | | | | The interstitial is now a RVH that is displayed on top of the WebContents with no interaction with the WebContents' RenderViewHostManager. This simplifies the states that the RenderViewHostManager has. The interstitial is responsible for hiding and deleting itself when told to proceed/not proceed or when a navigation occurs or the tab is closed. The interstitial now uses a data URL (instead of loading some alternate HTML), which allowed me to remove some interstitial flags from NavigationController::LoadCommittedDetails and ProvisionalLoadDetails. Also changed tab_utils::GetTabContentsByID to return a WebContents since only WebContents have a RVH associated with them. TEST=Run all ui tests and unit tests. Review URL: http://codereview.chromium.org/13764 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7149 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak unit_test failure on Windows.phajdan.jr@chromium.org2008-12-171-17/+18
| | | | | | Review URL: http://codereview.chromium.org/15002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7146 0039d316-1c4b-4281-b951-d872f2087c98
* * Add resource file to criteria checker test application to get CompanyName.kuchhal@chromium.org2008-12-173-56/+275
| | | | | | Review URL: http://codereview.chromium.org/15001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7145 0039d316-1c4b-4281-b951-d872f2087c98
* * Remove re-offer check from criteria checker.kuchhal@chromium.org2008-12-171-154/+0
| | | | | | | | | BUG=1380504 TBR=gwilson Review URL: http://codereview.chromium.org/14197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7143 0039d316-1c4b-4281-b951-d872f2087c98
* Platform cleanup in browser/ and porting of few files.phajdan.jr@chromium.org2008-12-1710-47/+50
| | | | | | Review URL: http://codereview.chromium.org/14466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7142 0039d316-1c4b-4281-b951-d872f2087c98
* Mostly cleanup.pkasting@chromium.org2008-12-173-136/+107
| | | | | | | | | | | * Use temporary variables when we're going to call AsWebContents() repeatedly * Remove some NOTREACHED()s that don't really help debugging (and none of the surrounding code checks) * Try and simplify or make clearer some bits of code Also enables/disables some commands more selectively: IDC_GO is now enabled only when the go button is visible (i.e. when we're not loading), and several commands whose UI is only available in normal windows are now only enabled in normal windows. This last change fixes a number of weird effects where you could hit different shortcuts in web app and popup windows and trigger commands with little or no UI feedback. Review URL: http://codereview.chromium.org/14182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7141 0039d316-1c4b-4281-b951-d872f2087c98
* Handle HTTP 200 responses received in response to byte range requests issued ↵ananta@chromium.org2008-12-173-2/+20
| | | | | | | | by the plugin. This means that the server does not support byte range requests. Firefox handles this by destroying the current plugin instance and creating a new instance to handle the response. The stream which is created to pass the data off to the plugin is not seekable.Fix is to emulate Firefox behavior. Will work on unit testing the NPN_RequestRead related code in a separate CB. This fixes http://code.google.com/p/chromium/issues/detail?id=5403Bug=5403 Review URL: http://codereview.chromium.org/14122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7139 0039d316-1c4b-4281-b951-d872f2087c98
* DatabaseLoadComplete now needs to be run after OnIOInitialize, so change the ↵jam@chromium.org2008-12-171-3/+3
| | | | | | | | | order of the PostTask. BUG=5587 Review URL: http://codereview.chromium.org/14499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7129 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a helper class used to mark/define critical section in a class and then ↵maruel@chromium.org2008-12-172-0/+4
| | | | | | | | | | | | install controls to check that those critical sections are not violated. This CL is due the thread posted on chromium-dev: http://groups.google.com/group/chromium-dev/browse_frm/thread/30af0b63b6adb245. From Gaetano Mendola <mendola bigfoot com> Review URL: http://codereview.chromium.org/8621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7127 0039d316-1c4b-4281-b951-d872f2087c98
* Replace some CRects with gfx::Rectagl@chromium.org2008-12-1714-49/+45
| | | | | | | Review URL: http://codereview.chromium.org/14173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7126 0039d316-1c4b-4281-b951-d872f2087c98
* Add some initial before unload tests. We still need testsojan@google.com2008-12-173-11/+125
| | | | | | | for multiple tabs with beforeunload/unload handlers. Review URL: http://codereview.chromium.org/14085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7122 0039d316-1c4b-4281-b951-d872f2087c98
* Make stop work again (I broke it). Rather than revert to the previous ↵pkasting@chromium.org2008-12-171-11/+10
| | | | | | | | | working-but-lame code, this cleans up the code a little further by actually enabling/disabling the stop command at the right times. BUG=5542 Review URL: http://codereview.chromium.org/14498 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7119 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test for fts2 prefix searching.mpcomplete@google.com2008-12-171-0/+15
| | | | | | Review URL: http://codereview.chromium.org/14177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7116 0039d316-1c4b-4281-b951-d872f2087c98
* fix buildestade@chromium.org2008-12-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7112 0039d316-1c4b-4281-b951-d872f2087c98
* Port the spell checker to posix.estade@chromium.org2008-12-166-51/+52
| | | | | | | | It all builds but does not link yet. Review URL: http://codereview.chromium.org/14408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7109 0039d316-1c4b-4281-b951-d872f2087c98
* * Fix for one end of FIFO not being set as non-blocking. This fixes the IPC ↵jeremy@chromium.org2008-12-162-4/+4
| | | | | | | | | | fuzzing tests on Linux. * Enable fuzzing tests on Linux. Review URL: http://codereview.chromium.org/14484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7100 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for crbug.com/5471 (browser crash regression).tim@chromium.org2008-12-162-21/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | The "pending_save_manager_" used to only be non-null between the time the user hits 'Submit' on a form and we either 1) show an infobar, or 2) update an existing login. Now, instead, the member only gets reset on InfoBarClosed(), and so this ordering of events was causing a crash: --ExpireInfoBar, removes delegate from infobar_delegates_ --WebContents::DidStopLoading, causes PasswordManager to call AddInfoBar because it has a pending_save_manager_ (and AddInfoBar succeeds because there is no "equal" delegate already in the set) --Animation terminates, which calls InfoBarClosed(), and resets the pending_save_manager_ --Now we have an infobar and a null pending_save_manager_, so clicking Accept/Cancel will deref 0. Renamed |pending_save_manager_| to |provisional_save_manager_| to be more consistent, and added |pending_decision_manager_| to take responsibility of the PasswordFormManager in |provisional_save_manager_| when the infobar comes in to play, so that we have the same ownership model as before the new infobar changes. Review URL: http://codereview.chromium.org/14464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7094 0039d316-1c4b-4281-b951-d872f2087c98
* Switch back svn:eol-style=native for .sln, .vcproj and .vsprops files.maruel@chromium.org2008-12-1697-27397/+27397
| | | | | | | Patch fails otherwise on non-Windows platforms. Review URL: http://codereview.chromium.org/14478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7093 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-20 01:23:45 +0000