summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Convert some stuff to string16 so the toolkit_views build can build againben@chromium.org2009-07-109-35/+37
| | | | | | Review URL: http://codereview.chromium.org/155334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20342 0039d316-1c4b-4281-b951-d872f2087c98
* linux: move gtk_init to the right threadpiman@google.com2009-07-102-16/+21
| | | | | | | | | In the plugin process, gtk_init needs to be called from the UI thread (PluginThread) not the main thread (PluginMain) which is an IO thread. Review URL: http://codereview.chromium.org/149424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20340 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window.close() not working for modal dialogs.jam@chromium.org2009-07-103-1/+10
| | | | | | | | BUG=16374 TEST=added regression test Review URL: http://codereview.chromium.org/149412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20339 0039d316-1c4b-4281-b951-d872f2087c98
* Made MediaFilter::host_ and MediaFilter::message_loop_ private.scherkus@chromium.org2009-07-092-9/+9
| | | | | | | | | | | More cleanup relating to pipeline cleanup. BUG=16008 TEST=no real code chage, nothing should change Review URL: http://codereview.chromium.org/155230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20338 0039d316-1c4b-4281-b951-d872f2087c98
* linux/mac: Fix return status of OpenChannelToPlugin message in case of failurepiman@google.com2009-07-091-0/+7
| | | | | | | | | | | Currently on linux if the plugin process dies, the PluginProcessHost is not destroyed. A side effect of that is that if a renderer tries to create a new plugin, the OpenChannelToPlugin message returns success with an empty handle, which is interpreted as the host channel, to which the renderer tries to connect to a second time, causing DCHECKs and havok in the browser process. This CL fixes that particular problem, returning failure if the browser can't connect to the plugin process. Review URL: http://codereview.chromium.org/155313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20337 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Made MediaFilter::host_ and MediaFilter::message_loop_ private."scherkus@chromium.org2009-07-092-9/+9
| | | | | | | | | | TEST=none BUG=none TBR=evmar Review URL: http://codereview.chromium.org/155333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20336 0039d316-1c4b-4281-b951-d872f2087c98
* Made MediaFilter::host_ and MediaFilter::message_loop_ private.scherkus@chromium.org2009-07-092-9/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20335 0039d316-1c4b-4281-b951-d872f2087c98
* Improve performance of dragged tab renderering.estade@chromium.org2009-07-094-91/+117
| | | | | | | | | | | | | | | Do as much as possible server side. I suspect the main factors that made our previous implementation slow were blitting from client to server, several unnecessary copies of the entire image, and doing an in-memory rgba->bgra swap. Now, even in debug mode with a 30" chrome window, the performance is very fast. BUG=16257,15869 TEST=drag a tab out of the tabstrip, with and without compositing Review URL: http://codereview.chromium.org/155321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20333 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporate new Linux common files after deb packaging refactoring.thestig@chromium.org2009-07-091-5/+8
| | | | | | Review URL: http://codereview.chromium.org/149422 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20329 0039d316-1c4b-4281-b951-d872f2087c98
* Always let other handlers run for render area mouse clicks.estade@chromium.org2009-07-091-1/+3
| | | | | | | | | BUG=none TEST=context menu shows when you right click (and doesn't immediately disappear) Review URL: http://codereview.chromium.org/149417 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20326 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more interfaces on RenderViewHostDelegate to separate classes. Thebrettw@chromium.org2009-07-0918-236/+276
| | | | | | | | ones in the patch are those that are implemented by other classes, avoiding TabContents pass-throughs. Review URL: http://codereview.chromium.org/149373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20324 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead code in RWHV Gtk.estade@chromium.org2009-07-091-10/+0
| | | | | | | | | | | The code was introduced in r13044 and should have been removed in r13396 (when the majority of r13044 was undone). BUG=16195 TEST=selection clipboard still works in render view, memory leak is gone Review URL: http://codereview.chromium.org/149358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20321 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: "Other bookmarks" button should use correct borders.erg@google.com2009-07-091-0/+3
| | | | | | Review URL: http://codereview.chromium.org/155322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20320 0039d316-1c4b-4281-b951-d872f2087c98
* Adds code to position the tab overview button during animations. Itsky@chromium.org2009-07-092-2/+16
| | | | | | | | | | | | appears that some times Layout isn't invoked on initial size, so that positioning the tab overview button only during Layout isn't enough. BUG=none TEST=none Review URL: http://codereview.chromium.org/155306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20318 0039d316-1c4b-4281-b951-d872f2087c98
* Add a rudamentary feed preview to the RSS extension. Itfinnur@chromium.org2009-07-0920-23/+482
| | | | | | | | | | | | | | | | | | | | | doesn't handle inline HTML in the item description (it just dumps it as text) and the feed needs to be valid XML for it to show any preview, but it is better than nothing. We can easily change it to display the HTML but we want to (at some point) try to use a separate origin so that we can render the HTML code from untrusted sources safely. Also fix a bug in the image tracker. It should not try to communicate with the view if the view has gone away (which was the whole point of the image tracker...) BUG=None TEST=Install the extension, browse to a page with a feed and click onthe rss icon in the Omnibox. An interstitial page should appear with a preview of the feed. Review URL: http://codereview.chromium.org/155180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20316 0039d316-1c4b-4281-b951-d872f2087c98
* Use the calculated dragged tab bounds when rendering the screenshot into the ↵jhawkins@chromium.org2009-07-091-3/+2
| | | | | | | | | | canvas. BUG=15869 TEST=Drag a tab out of the Linux tab strip. There should be a light-blue border around the dragged tab contents. Review URL: http://codereview.chromium.org/155317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20314 0039d316-1c4b-4281-b951-d872f2087c98
* Change the window background color to the inactive color when thetc@google.com2009-07-096-22/+172
| | | | | | | | | | | | | | | | | | | | window manager says the window isn't active. ActiveWindowWatcher listens for X events and notifies the browser windows when the active window changes. We can't just use focus events because popup menus cause browser windows to lose focus, but it's still the "active" window. Some window managers don't track active window, in which case we don't get the x event and we just say that all windows are active (our current behavior). BUG=14649 Review URL: http://codereview.chromium.org/155303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20313 0039d316-1c4b-4281-b951-d872f2087c98
* If the init returns nil (don't throw) don't try to store that into the dict.thomasvl@chromium.org2009-07-091-2/+3
| | | | | | | Fix typo. Review URL: http://codereview.chromium.org/155318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20312 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Theme: Localize "GTK Theme" button.erg@google.com2009-07-092-1/+5
| | | | | | Review URL: http://codereview.chromium.org/149411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20311 0039d316-1c4b-4281-b951-d872f2087c98
* Make the filename in the downloads page wrap.arv@google.com2009-07-091-3/+4
| | | | | | | | | | BUG=15148 TEST=Download a large file with a very long file name. The file name should wrap. Review URL: http://codereview.chromium.org/149349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20310 0039d316-1c4b-4281-b951-d872f2087c98
* Added an helper namespace that provides fetches images from the app bundle ↵thomasvl@chromium.org2009-07-0911-23/+169
| | | | | | | | | | | | | and caches them, line NSImage imageNamed: but lets us control the bundle that's checked. Unittest for the helper. Updated the current places that use +[NSImage imageNamed:] to use our cache helper. BUG=none TEST=All the ui images still load. Review URL: http://codereview.chromium.org/149393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20309 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Prevent colors from "leaking through" by using an event box.erg@google.com2009-07-092-3/+12
| | | | | | | | | | Some engines (clearlooks) query the bg color of a widget directly, so wrap the toolbar in an event box so that the bg value set in browser_window_gtk.cc doesn't leak through. http://crbug.com/13967 Review URL: http://codereview.chromium.org/155310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20308 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux tab strip zone calculation when using the skyline. We are ↵jhawkins@chromium.org2009-07-092-3/+5
| | | | | | | | | | looking for the top-left origin of the tab strip in screen coordinates, but we sent in the coordinates of this point relative to the entire window to gtk_util::ConvertWidgetPointToScreen. BUG=15867 TEST=Open enough tabs so that they must be resized. Repeatedly press the mouse over a close button so that many tabs are closed. The tabs should not resize until the mouse leaves the tab strip. Review URL: http://codereview.chromium.org/155308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20306 0039d316-1c4b-4281-b951-d872f2087c98
* Fix toolkit views bustage... bad conversion from string16 to std::wstringben@chromium.org2009-07-091-1/+1
| | | | | | | | | | TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/155307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20304 0039d316-1c4b-4281-b951-d872f2087c98
* Bring over most of the old TabRenderer into Tab2. No real logic changes ↵ben@chromium.org2009-07-096-33/+814
| | | | | | | | | | here. Split out a few large functions into sub functions (Layout -> LayoutIcon, LayoutTitle, etc; Paint -> PaintIcon, PaintTitle etc). BUG=none TEST=none Review URL: http://codereview.chromium.org/149380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20301 0039d316-1c4b-4281-b951-d872f2087c98
* Scroll-wheeling, whilst over the tab-strip, now switches tabs on GTK/Linux.jhawkins@chromium.org2009-07-092-5/+32
| | | | | | | | TEST=none BUG=1316 Review URL: http://codereview.chromium.org/155053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20297 0039d316-1c4b-4281-b951-d872f2087c98
* Make the API to open a message channel symmetric, so it works the same ↵mpcomplete@chromium.org2009-07-0925-293/+457
| | | | | | | | | | | | | | | whether opening from a tab or extension. Also, move the callback handling back to extension_process_bindings, since I didn't need it in event_bindings to implement this, and it didn't make sense there anyway. BUG=12461 TEST=no Review URL: http://codereview.chromium.org/149237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20296 0039d316-1c4b-4281-b951-d872f2087c98
* Start Chrome button on First Run customize view should launch Chrome.kuchhal@chromium.org2009-07-092-1/+1
| | | | | | | | BUG=16358 Review URL: http://codereview.chromium.org/149398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20295 0039d316-1c4b-4281-b951-d872f2087c98
* Remove reference counting from WebWidgetDelegate.darin@chromium.org2009-07-092-14/+1
| | | | | | | | | | | | | | | | | This was added as a speculative crash fix by eseidel back in June of 2008. See http://b/1211911 for details. It didn't appear to resolve the crash then (as another patch was required to fix the bug), and it doesn't seem to be necessary since the RenderView, which is the delegate and owns the WebView, is the one in charge of allocating the WebView and destroying the WebView. So, it is not possible for the WebView to outlive the RenderView. BUG=16234 TEST=none R=brettw Review URL: http://codereview.chromium.org/155292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20294 0039d316-1c4b-4281-b951-d872f2087c98
* Set the save file type index properly if there was only one file type.paul@chromium.org2009-07-091-0/+2
| | | | | | | | | | | | | | The save file indexes are 1 based, and if there is only one file type that the page can be saved as (such as a page like foo.com/notes.txt), the index is set to 0 which will cause a crash. BUG=15555 (http://crbug.com/15555) TEST=Go to a web page that is a text file and try to save it. Chrome should not crash. Review URL: http://codereview.chromium.org/155264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20293 0039d316-1c4b-4281-b951-d872f2087c98
* Perf bots are "happy enough", enable the throbber for real.pinkerton@chromium.org2009-07-091-22/+10
| | | | | | | | BUG=12699 TEST=throbber animations in tabs while page loading. Review URL: http://codereview.chromium.org/149400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20292 0039d316-1c4b-4281-b951-d872f2087c98
* Converts linux2 in grd file to chromeos.sky@chromium.org2009-07-091-1/+1
| | | | | | | | | | TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/155300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20289 0039d316-1c4b-4281-b951-d872f2087c98
* Try a new set of buttons (which should also work much better with themes).glen@chromium.org2009-07-0916-0/+0
| | | | | | | | | TBR=mirandac BUG=13821 TEST=Verify that our toolbar buttons have the same visual style in normal, hover and pressed states git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20288 0039d316-1c4b-4281-b951-d872f2087c98
* This CL prevents the first run UI from showing in the browser tests, as it ↵jcampan@chromium.org2009-07-091-0/+3
| | | | | | | | | | | | would be unexpected and cause the test to hang waiting for user interaction. BUG=None TEST=Run the browser tests. Review URL: http://codereview.chromium.org/155293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20283 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 193.0 to 194.0laforge@chromium.org2009-07-091-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20282 0039d316-1c4b-4281-b951-d872f2087c98
* Disable media ui test again because it doesn't run without audio devicehclam@chromium.org2009-07-091-1/+1
| | | | | | Review URL: http://codereview.chromium.org/155296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20280 0039d316-1c4b-4281-b951-d872f2087c98
* Add additional render histogramsjar@chromium.org2009-07-091-2/+30
| | | | | | | | | | Trying to debuge distinction in between several start times (request vs start, vs begin). r=davemoore Review URL: http://codereview.chromium.org/149396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20279 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: add LOG(FATAL) to try and catch an error."agl@chromium.org2009-07-091-8/+0
| | | | | | | | This reverts commit r20271. The FATAL log triggered on the build bots, which is a very useful data point! git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20278 0039d316-1c4b-4281-b951-d872f2087c98
* Convert most flakiness-prone Browser UI tests to browser_tests framework.phajdan.jr@chromium.org2009-07-093-76/+86
| | | | | | | | | TEST=none BUG=http://crbug.com/16062 Review URL: http://codereview.chromium.org/149365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20276 0039d316-1c4b-4281-b951-d872f2087c98
* Enable UI test MediaTest.VideoBearH264hclam@chromium.org2009-07-091-1/+1
| | | | | | Review URL: http://codereview.chromium.org/155294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20275 0039d316-1c4b-4281-b951-d872f2087c98
* Testing perfbots with throbber enabledpinkerton@chromium.org2009-07-091-1/+1
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20273 0039d316-1c4b-4281-b951-d872f2087c98
* Change ThumbnailStore to use sqlite instead of individual files try 2. ↵meelapshah@chromium.org2009-07-097-279/+226
| | | | | | | | Previous try failed interactive_ui_tests. Review URL: http://codereview.chromium.org/149361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20272 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add LOG(FATAL) to try and catch an error.agl@chromium.org2009-07-091-0/+8
| | | | | | | | | | | | | | | Crash reports like: http://crash/reportview?product=Chrome_Linux&version=3.0.192.0&date=&signature=WebCore::TextRunWalker::nextScriptRun()-3F2080B are popping up and I don't know why. I suspect that we might we returning an empty family string from fontconfig, so I'm adding a LOG(FATAL) to catch this. We'll see in the crash reports from next week if it's getting hit. R=evan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20271 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that SDCH is initialized at all times.jar@chromium.org2009-07-091-11/+8
| | | | | | | | | | | | There is an active A/B experiment to test the impact of SDCH support. This change correctly toggles support by simulating the command line flag, rather than incorrectly avoiding initialization of the module. BUG=16274 r=huanr Review URL: http://codereview.chromium.org/155277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20270 0039d316-1c4b-4281-b951-d872f2087c98
* Make the toolbar theme align with the left edge of the browser and the top ↵glen@chromium.org2009-07-094-7/+10
| | | | | | | | | | | edge of the tab strip. BUG=none TEST=install a theme with lines across the toolbar and frame, and verify that the lines line up across the frame,toolbar,bookmarks bar and find bar. Review URL: http://codereview.chromium.org/155124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20269 0039d316-1c4b-4281-b951-d872f2087c98
* A prototype of resource loading through automationamit@chromium.org2009-07-0922-98/+881
| | | | | | | | | | | | | | | | In a test scenario where we need to load resources over automation, we intercept the URL reqeusts and serve them using automation IPCs. This resource loading can be enabled per tab created by automation. BUG=none TEST=none Review URL: http://codereview.chromium.org/145024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20267 0039d316-1c4b-4281-b951-d872f2087c98
* mac workaround.evan@chromium.org2009-07-091-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20266 0039d316-1c4b-4281-b951-d872f2087c98
* Copy parsed URL into CF_UNICODETEXT when user select entire of Omnibox.hamaji@chromium.org2009-07-091-12/+15
| | | | | | | | | | | | | | | | | | | | BUG=2820 BUG=8162 TEST=Visit http://www.google.com/search?ie=UTF-8&q=荳雁慍 and select entire text in Omnibox, then copy the text. Paste the copied text into other applications such as notepad and check if the pasted text contains %E4%B8%8A%E5%9C%B0, not 荳雁慍. Paste the copied text into Firefox's URL bar and type return. Check if you are navigated to the same website. Paste the copied text into textareas in Chrome and check if the pasted text contains %E4%B8%8A%E5%9C%B0. Paste the copied text into Gmail's rich text editing mode and check if the pasted text contains 荳雁慍. Right click the link you pasted in Gmail and check if you see "Go to: http://www.google.com/...%E4%B8%8A%E5%9C%B0". Paste the copied text into URL-aware softwares such as MS-word and check if the pasted text contains 荳雁慍. Check if the link in MS-word is pointing to encoded URL (http://www.google.com/...%E4%B8%8A%E5%9C%B0). TEST=Visit http://www.google.com/search?ie=UTF-8&q=荳雁慍 again and select "q=荳雁慍" in Omnibox, then copy the text. Paste it into somewhere and check if you see "q=荳雁慍". TEST=Copy "荳雁慍" from somewhere and paste it into Omnibox. Copy from Omnibox and paste it into notepad. Then check if the pasted text is NOT encoded. Review URL: http://codereview.chromium.org/119352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20265 0039d316-1c4b-4281-b951-d872f2087c98
* linux: implement the sad pluginevan@chromium.org2009-07-095-15/+20
| | | | | | | | | | | | | | This required moving the sad plugin resource out of the Windows-specific code. Note that it doesn't display right yet, since the place to display is covered by the GtkSocket that used to host the plugin. But that is a separate issue. (I had it draw to the side to verify the image was correctly getting loaded.) BUG=16158 Review URL: http://codereview.chromium.org/155262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20264 0039d316-1c4b-4281-b951-d872f2087c98
* I've seen recently a race condition while debugging printing. The pages are ↵sverrir@google.com2009-07-091-1/+5
| | | | | | | | | | | | | not sent from the renderer quickly enough which causes the print thread to hang (no new page notifications are sent any more). This change simply adds a poll every half a second for a new page. BUG=none TEST=none Review URL: http://codereview.chromium.org/149390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20261 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 18:51:43 +0000